Re: [PATCH v1 3/3] scsi: ufs-qcom: update configuration option of SCSI_UFS_QCOM component

2015-05-20 Thread Paul Bolle
On Tue, 2015-05-19 at 16:47 +0300, Yaniv Gardi wrote: > This change is required in order to be able to build the component > as a module. > > Signed-off-by: Yaniv Gardi > --- a/drivers/scsi/ufs/Kconfig > +++ b/drivers/scsi/ufs/Kconfig > config SCSI_UFS_QCOM > - bool "QCOM specific hooks t

Re: [PATCH v1 1/3] phy: qcom-ufs: fix build error when the driver is built as a module

2015-05-20 Thread Paul Bolle
On Tue, 2015-05-19 at 16:47 +0300, Yaniv Gardi wrote: > Export the following functions in order to avoid build errors > when the driver is compiled as a module: Where "the driver" actually means something like ufs-qcom.c, or SCSI_UFS_QCOM, or "QCOM specific hooks to UFS controller platform driver"

[PATCH] iscsi: Fix iscsi endpoints leak

2015-05-20 Thread Sagi Grimberg
When creating a new endpoint, we look for a free id for the new endpoint. We baisically loop on possible ids and use the first id that class_find_device() returns NULL. However, we are missing a reference put when class_find_device() does find an existing device for a given id. Reported-by: Alex L

Re: [PATCH kernel] commit 4fbdf9cb ("lpfc: Fix for lun discovery issue with saturn adapter.")

2015-05-20 Thread James Smart
Not sure - I'll go look. -- james On 5/19/2015 11:55 PM, Alexey Kardashevskiy wrote: On 05/06/2015 07:46 AM, Sebastian Herbszt wrote: James Smart wrote: Reviewed-By: James Smart Alexey, Sebastian, Yes - this section needs to be reverted. This patch is good. -- james s Reviewed-by: S

drivers/scsi/be2iscsi/be_main.c:3168: possible bad expression ?

2015-05-20 Thread David Binderman
Hello there, drivers/scsi/be2iscsi/be_main.c:3168:18: warning: logical not is only applied to the left hand side of comparison [-Wlogical-not-parentheses]   WARN_ON(!length> 0);   ^ Maybe better code   WARN_ON(length == 0); Regards David Binderman   ^

Re: [RFC PATCH 0/4] Make iSCSI network namespace aware

2015-05-20 Thread Andy Grover
On 05/13/2015 03:12 PM, Chris Leech wrote: This is only about the structures and functionality involved in maintaining the iSCSI session, the SCSI host along with it's discovered targets and devices has no association with network namespaces. These patches are functional, but not complete. Ther

Re: [PATCH kernel] commit 4fbdf9cb ("lpfc: Fix for lun discovery issue with saturn adapter.")

2015-05-20 Thread James Smart
Alexey, Can you send me boot messages so I can see everything the lpfc driver may have done ? And you're using 10.5.0.0 verbatim ? -- james On 5/20/2015 9:11 AM, James Smart wrote: Not sure - I'll go look. -- james On 5/19/2015 11:55 PM, Alexey Kardashevskiy wrote: On 05/06/2015 07:46 A

Re: [PATCH] scsi: debug: fix type mismatch warning for sg_pcopy_from_buffer

2015-05-20 Thread Andrew Morton
On Tue, 19 May 2015 23:22:39 +0200 Arnd Bergmann wrote: > The recent change to mark the input argument of sg_pcopy_from_buffer > had the unfortunate side-effect to cause a new warning in the > scsi_debug code: > > drivers/scsi/scsi_debug.c: In function 'do_device_access': > drivers/scsi/scsi_deb

Re: [PATCH] scsi: debug: fix type mismatch warning for sg_pcopy_from_buffer

2015-05-20 Thread Arnd Bergmann
On Wednesday 20 May 2015 12:53:29 Andrew Morton wrote: > On Tue, 19 May 2015 23:22:39 +0200 Arnd Bergmann wrote: > > > > I can't decide if this is actually a good idea, or if we should rather drop > > the sg_pcopy_from_buffer() patch. Maybe someone else sees a better solution. > > Could make do_

[PATCH] libsas: fix "sysfs group not found" warnings at port teardown time

2015-05-20 Thread Dan Williams
Praveen reports: --- After some debugging this is what I have found sas_phye_loss_of_signal gets triggered on phy_event from mvsas sas_phye_loss_of_signal calls sas_deform_port sas_deform_port posts a DISCE_DESTRUCT event (sas_unregister_domain_devices-> sas_unregis

Re: [PATCH] libsas: fix "sysfs group not found" warnings at port teardown time

2015-05-20 Thread Luis Henriques
On Wed, May 20, 2015 at 06:09:09PM -0400, Dan Williams wrote: > Praveen reports: > > --- > Just a minor comment, not related with the patch itself but with the commit message: the line above will cause major pain to anyone applying this patch using 'git am'. This is because git-mailinfo, when s

[PATCH v2] libsas: fix "sysfs group not found" warnings at port teardown time

2015-05-20 Thread Dan Williams
Praveen reports: After some debugging this is what I have found sas_phye_loss_of_signal gets triggered on phy_event from mvsas sas_phye_loss_of_signal calls sas_deform_port sas_deform_port posts a DISCE_DESTRUCT event (sas_unregister_domain_devices-> sas_unregister_d

Proposal for annotating _unstable_ pages

2015-05-20 Thread Kent Overstreet
On Tue, May 19, 2015 at 01:10:55PM -0700, Darrick J. Wong wrote: > On Tue, May 19, 2015 at 08:42:00AM -0700, Kent Overstreet wrote: > > Also, stable pages - what's been going on there? Last I heard you were > > talking > > about using the page migration code to do COW, did anything come of that? I