[PATCH v7 5/9] snic:add SCSI handling, AEN, and fwreset handling

2015-05-29 Thread Narsimhulu Musini
snic_scsi.c contains scsi handling, includes queuing io, abort, lun reset, and host reset. Also it handles asynchronous event notifications from FW. Signed-off-by: Narsimhulu Musini nmus...@cisco.com Signed-off-by: Sesidhar Baddela sebad...@cisco.com --- * v7 - Removed SNIC_DEBUG macro. * v6 -

[PATCH v7 0/9] snic:initial submission of snic driver for Cisco SCSI HBA

2015-05-29 Thread Narsimhulu Musini
The following patch series adds snic driver for Cisco SCSI HBA Cisco has developed a new PCI HBA interface called sNIC, which stands for SCSI NIC. This is a new storage feature supported on specialized network adapter. The new PCI function provides a uniform host interface and abstracts backend

[PATCH v7 8/9] snic:Add event tracing to capture IO events.

2015-05-29 Thread Narsimhulu Musini
snic_trc.h contains global trace structure definitions for snic driver snic_trc.c adds tracing functionality to capture various IO events. It maintains global trace buffer to maintain recent history of IO events. It helps to understand the sequence of events prior to particular IO event, or hung,

[PATCH v7 7/9] snic:Add sysfs entries to list stats and trace data

2015-05-29 Thread Narsimhulu Musini
snic_stats.h contains stats structre definitions for various events in snic driver. snic_debugfs.c contains setup and cleanup of sysfs entries for listing stats, resetting stats, enabling/disabling trace, and listing trace data. Signed-off-by: Narsimhulu Musini nmus...@cisco.com Signed-off-by:

[PATCH v7 1/9] snic: snic module infrastructure

2015-05-29 Thread Narsimhulu Musini
snic_main.c contains module load and unload, global driver context, PCI Registration, PCI probe and remove, SCSI ML registration functionality. snic.h contains snic structure definition, snic global context, and prototypes. snic_attrs.c contains device attributes to list snic state, link state,

[PATCH v7 3/9] snic:Add meta request, handling of meta requests.

2015-05-29 Thread Narsimhulu Musini
snic_io.h contains meta request structure definition meta request contains high level information about firmware requests. such as request information, size, SGLs. snic_io.c contains interfaces to handle meta request, firmware acknowledgment, and high level generic queueing interface.

[PATCH v7 6/9] snic:Add low level queuing interfaces

2015-05-29 Thread Narsimhulu Musini
These files contain low level queueing interfaces includes hardware queues, and management of hardware features. Signed-off-by: Narsimhulu Musini nmus...@cisco.com Signed-off-by: Sesidhar Baddela sebad...@cisco.com --- * v6 - Fixed bit width and endianness. * v5 - removed macro definitions that

[PATCH v7 4/9] snic:Add snic target discovery

2015-05-29 Thread Narsimhulu Musini
snic_disc.h contains snic target structure definition. snic_disc.c contains target discovery, setup, lookup, and cleanup snic_ctl.c contains retrieval of snic capabilities includes max ios, size, SGs per request, and max concurrent requests. Signed-off-by: Narsimhulu Musini nmus...@cisco.com

[PATCH v7 2/9] snic:Add interrupt, resource firmware interfaces

2015-05-29 Thread Narsimhulu Musini
snic_fwint.h contains firmware interface structures. snic_res.h contains firmware request initialization snic_res.c contains retrieval of resource configuration, and allocation, and initialization of HW Queues. snic_isr.c contains interrupt request, release, and handling Signed-off-by:

[PATCH v7 9/9] snic:Add Makefile, patch Kconfig, MAINTAINERS

2015-05-29 Thread Narsimhulu Musini
Kconfig for kbuild Makefile to build snic module Updated MAINTAINERS file Signed-off-by: Narsimhulu Musini nmus...@cisco.com Signed-off-by: Sesidhar Baddela sebad...@cisco.com --- * v3 - Added additional config section (CONFIG_SNIC_DEBUG_FS) for enabling debugging functionality. * v2 - Added

[RFC][PATCH] x86: remove vmalloc.h from asm/io.h

2015-05-29 Thread Stephen Rothwell
Nothing in asm/io.h uses anything from vmalloc.h, so remove the include and fix up the build problems in an allmodconfig (64 bit and 32 bit) build. This may be the place where x86 builds get vmalloc.h implicitly included and that tends to hide places where vmalloc() et al are added to files but

Re: [PATCH] megaraid_sas : Modify return value of megasas_issue_blocked_cmd() and wait_and_poll() to consider command status returned by firmware

2015-05-29 Thread Sumit Saxena
James, Gentle reminder. Can we consider this patch. Thanks, Sumit On Fri, May 15, 2015 at 3:26 PM, Tomas Henzl the...@redhat.com wrote: On 05/06/2015 03:31 PM, sumit.sax...@avagotech.com wrote: This patch is rebased on top of recently sent 18 patches(submitted by me) for megaraid_sas

Re: [RFC][PATCH] x86: remove vmalloc.h from asm/io.h

2015-05-29 Thread Ingo Molnar
* Stephen Rothwell s...@canb.auug.org.au wrote: Nothing in asm/io.h uses anything from vmalloc.h, so remove the include and fix up the build problems in an allmodconfig (64 bit and 32 bit) build. This may be the place where x86 builds get vmalloc.h implicitly included and that tends to

Re: [RFC][PATCH] x86: remove vmalloc.h from asm/io.h

2015-05-29 Thread Stephen Rothwell
Hi Ingo, On Fri, 29 May 2015 11:21:05 +0200 Ingo Molnar mi...@kernel.org wrote: Good idea. Acked-by: Ingo Molnar mi...@kernel.org Thanks. Please also test x86 allnoconfig and defconfig 32/64, that tends to unearth the remaining places. People doing randconfig testing will find the

[PATCH] lpfc: in sli3 use configured sg_seg_cnt for sg_tablesize

2015-05-29 Thread bstroesser
Hi James, We had some performance problems with RAID systems connected to LPe12k. AFAICS, the reason is a small bug in lpfc.ko, causing the IO-size to be smaller than expected. The patch below fixes it for us. Please CC me, I'm not on the list. Best regards Bodo

Re: [RFC][PATCH] x86: remove vmalloc.h from asm/io.h

2015-05-29 Thread Takashi Iwai
At Fri, 29 May 2015 19:18:47 +1000, Stephen Rothwell wrote: Nothing in asm/io.h uses anything from vmalloc.h, so remove the include and fix up the build problems in an allmodconfig (64 bit and 32 bit) build. This may be the place where x86 builds get vmalloc.h implicitly included and that

Re: [PATCH v7 1/9] snic: snic module infrastructure

2015-05-29 Thread Hannes Reinecke
On 05/29/2015 10:04 AM, Narsimhulu Musini wrote: snic_main.c contains module load and unload, global driver context, PCI Registration, PCI probe and remove, SCSI ML registration functionality. snic.h contains snic structure definition, snic global context, and prototypes. snic_attrs.c

Re: [PATCH v7 2/9] snic:Add interrupt, resource firmware interfaces

2015-05-29 Thread Hannes Reinecke
On 05/29/2015 10:04 AM, Narsimhulu Musini wrote: snic_fwint.h contains firmware interface structures. snic_res.h contains firmware request initialization snic_res.c contains retrieval of resource configuration, and allocation, and initialization of HW Queues. snic_isr.c contains

Re: [PATCH v7 3/9] snic:Add meta request, handling of meta requests.

2015-05-29 Thread Hannes Reinecke
On 05/29/2015 10:04 AM, Narsimhulu Musini wrote: snic_io.h contains meta request structure definition meta request contains high level information about firmware requests. such as request information, size, SGLs. snic_io.c contains interfaces to handle meta request, firmware acknowledgment,

Re: [PATCH v7 8/9] snic:Add event tracing to capture IO events.

2015-05-29 Thread Hannes Reinecke
On 05/29/2015 10:04 AM, Narsimhulu Musini wrote: snic_trc.h contains global trace structure definitions for snic driver snic_trc.c adds tracing functionality to capture various IO events. It maintains global trace buffer to maintain recent history of IO events. It helps to understand the

Re: [PATCH v7 7/9] snic:Add sysfs entries to list stats and trace data

2015-05-29 Thread Hannes Reinecke
On 05/29/2015 10:04 AM, Narsimhulu Musini wrote: snic_stats.h contains stats structre definitions for various events in snic driver. snic_debugfs.c contains setup and cleanup of sysfs entries for listing stats, resetting stats, enabling/disabling trace, and listing trace data.

Re: [PATCH v2 12/15] lpfc: Fix rport leak.

2015-05-29 Thread James Smart
That's good to know. We have a fair amount of existing strings that are split, so I don't want to retrofit those. But, on future submits, we'll keep the string on a single line. Thanks -- james On 5/27/2015 5:32 PM, Sebastian Herbszt wrote: James Smart wrote: Sebastian, Re: more than 1

Re: [PATCH v7 4/9] snic:Add snic target discovery

2015-05-29 Thread Hannes Reinecke
On 05/29/2015 10:04 AM, Narsimhulu Musini wrote: snic_disc.h contains snic target structure definition. snic_disc.c contains target discovery, setup, lookup, and cleanup snic_ctl.c contains retrieval of snic capabilities includes max ios, size, SGs per request, and max concurrent requests.

Re: [PATCH v7 5/9] snic:add SCSI handling, AEN, and fwreset handling

2015-05-29 Thread Hannes Reinecke
On 05/29/2015 10:04 AM, Narsimhulu Musini wrote: snic_scsi.c contains scsi handling, includes queuing io, abort, lun reset, and host reset. Also it handles asynchronous event notifications from FW. Signed-off-by: Narsimhulu Musini nmus...@cisco.com Signed-off-by: Sesidhar Baddela

Re: [PATCH v7 6/9] snic:Add low level queuing interfaces

2015-05-29 Thread Hannes Reinecke
On 05/29/2015 10:04 AM, Narsimhulu Musini wrote: These files contain low level queueing interfaces includes hardware queues, and management of hardware features. Signed-off-by: Narsimhulu Musini nmus...@cisco.com Signed-off-by: Sesidhar Baddela sebad...@cisco.com --- Reviewed-by: Hannes

Re: [PATCH] lpfc: in sli3 use configured sg_seg_cnt for sg_tablesize

2015-05-29 Thread James Smart
Bodo, This is a valid fix. Thank you. I assume you were changing the driver module parameter to up the SG count ? without the fix we would have been capped at 64 sges. -- james Reviewed-By: James Smart james.sm...@avagotech.com On 5/29/2015 8:22 AM, bstroes...@ts.fujitsu.com wrote: Hi

Re: [RFC][PATCH] x86: remove vmalloc.h from asm/io.h

2015-05-29 Thread Stephen Rothwell
Hi Takashi, On Fri, 29 May 2015 14:43:14 +0200 Takashi Iwai ti...@suse.de wrote: For the sound bits, Acked-by: Takashi Iwai ti...@suse.de Thanks, noted. -- Cheers, Stephen Rothwells...@canb.auug.org.au pgptJlepfEy8S.pgp Description: OpenPGP digital signature

[PATCH v7 9/9] snic:Add Makefile, patch Kconfig, MAINTAINERS

2015-05-29 Thread Narsimhulu Musini
Kconfig for kbuild Makefile to build snic module Updated MAINTAINERS file Signed-off-by: Narsimhulu Musini nmus...@cisco.com Signed-off-by: Sesidhar Baddela sebad...@cisco.com --- * v7 - Removed SNIC_DEBUG_FS macro, and replaced it with CONFIG_SCSI_SNIC_DEBUG_FS * v3 - Added additional config

[PATCH 2/6] scsi: storvsc: Use a single value to track protocol versions

2015-05-29 Thread K. Y. Srinivasan
From: keith.ma...@microsoft.com keith.ma...@microsoft.com Use a single value to track protocol versions to simplify comparisons and to be consistent with vmbus version tracking. Tested-by: Alex Ng ale...@microsoft.com Signed-off-by: Keith Mange keith.ma...@microsoft.com Signed-off-by: K. Y.

[PATCH 4/6] scsi: storvsc: use correct defaults for values determined by protocol negotiation

2015-05-29 Thread K. Y. Srinivasan
From: keith.ma...@microsoft.com keith.ma...@microsoft.com Use correct defaults for values determined by protocol negotiation, instead of resetting them with every scsi controller. Tested-by: Alex Ng ale...@microsoft.com Signed-off-by: Keith Mange keith.ma...@microsoft.com Signed-off-by: K. Y.

[PATCH 5/6] scsi: storvsc: use storage protocol version to determine storage capabilities

2015-05-29 Thread K. Y. Srinivasan
From: keith.ma...@microsoft.com keith.ma...@microsoft.com Use storage protocol version instead of vmbus protocol version when determining storage capabilities. Tested-by: Alex Ng ale...@microsoft.com Signed-off-by: Keith Mange keith.ma...@microsoft.com Signed-off-by: K. Y. Srinivasan

[PATCH 3/6] hv:scsi:Untangle the storage protocol negotiation from the vmbus protocol negotiation.

2015-05-29 Thread K. Y. Srinivasan
From: keith.ma...@microsoft.com keith.ma...@microsoft.com Currently we are making decisions based on vmbus protocol versions that have been negotiated; use storage potocol versions instead. Tested-by: Alex Ng ale...@microsoft.com Signed-off-by: Keith Mange keith.ma...@microsoft.com

[PATCH 1/6] scsi: storvsc: Rather than look for sets of specific protocol versions, make decisions based on ranges.

2015-05-29 Thread K. Y. Srinivasan
From: keith.ma...@microsoft.com keith.ma...@microsoft.com Rather than look for sets of specific protocol versions, make decisions based on ranges. This will be safer and require fewer changes going forward as we add more storage protocol versions. Tested-by: Alex Ng ale...@microsoft.com

RE: [PATCH 1/6] scsi: storvsc: Rather than look for sets of specific protocol versions, make decisions based on ranges.

2015-05-29 Thread Long Li
-Original Message- From: devel [mailto:driverdev-devel-boun...@linuxdriverproject.org] On Behalf Of K. Y. Srinivasan Sent: Friday, May 29, 2015 1:29 PM To: gre...@linuxfoundation.org; linux-ker...@vger.kernel.org; de...@linuxdriverproject.org; oher...@suse.com;

RE: [PATCH 2/6] scsi: storvsc: Use a single value to track protocol versions

2015-05-29 Thread Long Li
-Original Message- From: devel [mailto:driverdev-devel-boun...@linuxdriverproject.org] On Behalf Of K. Y. Srinivasan Sent: Friday, May 29, 2015 1:29 PM To: gre...@linuxfoundation.org; linux-ker...@vger.kernel.org; de...@linuxdriverproject.org; oher...@suse.com;

Re: [PATCH v2] cxlflash: Base support for IBM CXL Flash Adapter

2015-05-29 Thread Brian King
Hi Matt, Comments below... -Brian On 05/22/2015 05:14 PM, Matthew R. Ochs wrote: +++ b/drivers/scsi/cxlflash/common.h @@ -0,0 +1,180 @@ +/* + * CXL Flash Device Driver + * + * Written by: Manoj N. Kumar ma...@linux.vnet.ibm.com, IBM Corporation + * Matthew R. Ochs

Re: [PATCH v3] fusion: remove dead MTRR code

2015-05-29 Thread Luis R. Rodriguez
On Wed, Apr 29, 2015 at 12:50 PM, Luis R. Rodriguez mcg...@suse.com wrote: On Tue, Apr 21, 2015 at 1:46 PM, Luis R. Rodriguez mcg...@do-not-panic.com wrote: From: Luis R. Rodriguez mcg...@suse.com If and when this gets enabled the driver could should split up IO memory space properly and

RE: [PATCH 5/6] scsi: storvsc: use storage protocol version to determine storage capabilities

2015-05-29 Thread Long Li
-Original Message- From: devel [mailto:driverdev-devel-boun...@linuxdriverproject.org] On Behalf Of K. Y. Srinivasan Sent: Friday, May 29, 2015 1:29 PM To: gre...@linuxfoundation.org; linux-ker...@vger.kernel.org; de...@linuxdriverproject.org; oher...@suse.com;

RE: [PATCH 4/6] scsi: storvsc: use correct defaults for values determined by protocol negotiation

2015-05-29 Thread Long Li
-Original Message- From: devel [mailto:driverdev-devel-boun...@linuxdriverproject.org] On Behalf Of K. Y. Srinivasan Sent: Friday, May 29, 2015 1:29 PM To: gre...@linuxfoundation.org; linux-ker...@vger.kernel.org; de...@linuxdriverproject.org; oher...@suse.com;

[PATCH 0/6] scsi: storvsc: Some miscellaneous cleanup

2015-05-29 Thread K. Y. Srinivasan
Cleanup version handling as well as base feature detection on storage version as opposed to host version. keith.ma...@microsoft.com (6): scsi: storvsc: Rather than look for sets of specific protocol versions, make decisions based on ranges. scsi: storvsc: Use a single value to track

RE: [PATCH] lpfc: in sli3 use configured sg_seg_cnt for sg_tablesize

2015-05-29 Thread Strösser , Bodo
Yes, we normally use 128, as this is the value best suited for our RAID systems. After upgrading the software we saw a clear performance reduction that was caused by the bug. With the fix everything works fine again. Thank you, Bodo -Original Message- From: James Smart

[PATCH 6/6] scsi: storvsc: Allow write_same when host is windows 10

2015-05-29 Thread K. Y. Srinivasan
From: keith.ma...@microsoft.com keith.ma...@microsoft.com Allow WRITE_SAME for Windows10 and above hosts. Tested-by: Alex Ng ale...@microsoft.com Signed-off-by: Keith Mange keith.ma...@microsoft.com Signed-off-by: K. Y. Srinivasan k...@microsoft.com --- drivers/scsi/storvsc_drv.c |6 +-

RE: [PATCH 3/6] hv:scsi:Untangle the storage protocol negotiation from the vmbus protocol negotiation.

2015-05-29 Thread Long Li
-Original Message- From: devel [mailto:driverdev-devel-boun...@linuxdriverproject.org] On Behalf Of K. Y. Srinivasan Sent: Friday, May 29, 2015 1:29 PM To: gre...@linuxfoundation.org; linux-ker...@vger.kernel.org; de...@linuxdriverproject.org; oher...@suse.com;

RE: [PATCH 6/6] scsi: storvsc: Allow write_same when host is windows 10

2015-05-29 Thread Long Li
-Original Message- From: devel [mailto:driverdev-devel-boun...@linuxdriverproject.org] On Behalf Of K. Y. Srinivasan Sent: Friday, May 29, 2015 1:29 PM To: gre...@linuxfoundation.org; linux-ker...@vger.kernel.org; de...@linuxdriverproject.org; oher...@suse.com;