Re: [PATCH 3/4] scsi: storvsc: Refactor the code in storvsc_channel_init()

On Thu, Dec 10, 2015 at 04:14:19PM -0800, K. Y. Srinivasan wrote: > @@ -753,27 +740,62 @@ static int storvsc_channel_init(struct hv_device > *device, bool is_fc) > VM_PKT_DATA_INBAND, > VMBUS_DATA_PACKET_FLAG_COMPLETION_REQUESTED); >

[PATCH v2] hisi_sas: use platform_get_irq()

It is preferred that drivers use platform_get_irq() instead of irq_of_parse_and_map(), so replace. Signed-off-by: John Garry Acked-by: Rob Herring diff --git a/drivers/scsi/hisi_sas/hisi_sas.h b/drivers/scsi/hisi_sas/hisi_sas.h index 30a9ab9..5af2e41

Re: [PATCH 2/4] scsi: storvsc: Properly support Fibre Channel devices

On Thu, Dec 10, 2015 at 04:14:18PM -0800, K. Y. Srinivasan wrote: > + ret = vmbus_sendpacket(device->channel, vstor_packet, > +(sizeof(struct vstor_packet) - > +vmscsi_size_delta), > +(unsigned long)request, >

kernel BUG at block/bio.c:1787! while initializing scsi_debug on ppc64 host

Hi, I saw this kernel BUG_ON on 4.4-rc4 kernel, and this can be reproduced easily on ppc64 host by: modprobe scsi_debug sector_size=512 physblk_exp=3 dev_size_mb=256 And I bisected to this commit commit ca369d51b3e1649be4a72addd6d6a168cfb3f537 Author: Martin K. Petersen

Re: [PATCH v2] hisi_sas: use platform_get_irq()

On Fri, Dec 11, 2015 at 08:03:21PM +0800, John Garry wrote: > It is preferred that drivers use platform_get_irq() > instead of irq_of_parse_and_map(), so replace. > > Signed-off-by: John Garry > Acked-by: Rob Herring > > diff --git

Re: [PATCH] hisi_sas: use platform_get_irq()

On 10/12/2015 20:08, Rob Herring wrote: On Thu, Dec 10, 2015 at 9:02 AM, John Garry wrote: It is preferred that drivers use platform_get_irq() instead of irq_of_parse_and_map(), so replace. You may be able to stop including of_irq.h with this change. Otherwise,

Re: [PATCH 10/13] IB/srp: use the new CQ API

Hi Bart, thanks for all the reviews. I've updated the git branch with your suggestions and reviewed-by tags. I'm going to wait a little bit longer for other reviews to come in before reposting the series. -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a

Re: [PATCH 2/6] cxlflash: Fix to avoid virtual LUN failover failure

On 12/10/2015 4:53 PM, Uma Krishnan wrote: From: "Matthew R. Ochs" To remedy this scenario, provide feedback back to the application on virtual LUN creation as to which ports the LUN may be accessed. LUN's spanning both ports are candidates for a retry in a presence

Re: [PATCH 07/13] IB: add a proper completion queue abstraction

On Thu, Dec 10, 2015 at 10:42:22AM -0800, Bart Van Assche wrote: >> +struct ib_cq *ib_alloc_cq(struct ib_device *dev, void *private, >> +int nr_cqe, int comp_vector, enum ib_poll_context poll_ctx) >> +{ > > [ ... ] >> +cq->wc = kmalloc_array(IB_POLL_BATCH, sizeof(*cq->wc),

Re: [PATCHv4 1/1] SCSI: hosts: update to use ida_simple for host_no management

On Thu, 2015-12-10 at 13:48 -0800, Lee Duncan wrote: > On 11/17/2015 03:20 PM, Martin K. Petersen wrote: > >> "Lee" == Lee Duncan writes: > > > > Lee> Martin: I will be glad to update the patch, creating a modprobe > > Lee> parameter as suggested, if you find this

RE: [PATCH 1/4] scsi: storvsc: Fix a bug in the layout of the hv_fc_wwn_packet

> -Original Message- > From: Johannes Thumshirn [mailto:jthumsh...@suse.de] > Sent: Friday, December 11, 2015 12:48 AM > To: KY Srinivasan > Cc: gre...@linuxfoundation.org; linux-ker...@vger.kernel.org; > de...@linuxdriverproject.org; oher...@suse.com; >

[PATCH] scsi_dh_alua: fix build warning

We were getting build warning about unused variables "vpd_pg83" and "d" Fixes: 83ea0e5e3501 ("scsi_dh_alua: use scsi_vpd_tpg_id()") Cc: Hannes Reinecke <h...@suse.de> Signed-off-by: Sudip Mukherjee <su...@vectorindia.org> --- build warning with next-20

Re: [PATCH] scsi_dh_alua: fix build warning

u...@vectorindia.org> --- build warning with next-20151211 and build log is at: https://travis-ci.org/sudipm-mukherjee/parport/jobs/96209206 --- drivers/scsi/device_handler/scsi_dh_alua.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/scsi/device_handler/scsi_dh_alua.c b/drivers/scsi/d

Re: [PATCH 1/4] scsi: storvsc: Fix a bug in the layout of the hv_fc_wwn_packet

On Thu, Dec 10, 2015 at 04:14:17PM -0800, K. Y. Srinivasan wrote: > The hv_fc_wwn_packet is exchanged over vmbus. Make the definition in Linux > match > the Window's definition. > > Signed-off-by: K. Y. Srinivasan > Reviewed-by: Long Li > Tested-by:

Re: [PATCH 2/4] scsi: storvsc: Properly support Fibre Channel devices

On Thu, Dec 10, 2015 at 04:14:18PM -0800, K. Y. Srinivasan wrote: > For FC devices managed by this driver, atttach the appropriate transport > template. This will allow us to create the appropriate sysfs files for > these devices. With this we can publish the wwn for both the port and the > node.

Re: [PATCH 4/4] scsi: storvsc: Tighten up the interrupt path

On Thu, Dec 10, 2015 at 04:14:20PM -0800, K. Y. Srinivasan wrote: > On the interrupt path, we repeatedly establish the pointer to the > storvsc_device. Fix this. > > Signed-off-by: K. Y. Srinivasan > Reviewed-by: Long Li > Tested-by: Alex Ng

Re: [dm-devel] [PATCH 0/15] copy offload patches

On Thu, Dec 10, 2015 at 11:06:04PM -0600, Mike Christie wrote: > > 2. Start REQ_OP_READ off at non-zero to try and shake out code that was > not converted. > > There are a several places where we assume reads are zero and writes are > 1 for things like indexing in arrays (like blktrace's

[PATCH] ses: fix additional element traversal bug

KASAN found that our additional element processing scripts drop off the end of the VPD page into unallocated space. The reason is that not every element has additional information but our traversal routines think they do, leading to them expecting far more additional information than is present.

Re: [PATCH 10/13] IB/srp: use the new CQ API

On 12/11/2015 09:22 AM, Christoph Hellwig wrote: > Hi Bart, > > thanks for all the reviews. I've updated the git branch with your > suggestions and reviewed-by tags. I'm going to wait a little bit > longer for other reviews to come in before reposting the series. Indeed, thanks for all the

[Bug 108771] scsi: ses: kasan: ses_enclosure_data_process use after free on boot SAS2X28

https://bugzilla.kernel.org/show_bug.cgi?id=108771 --- Comment #3 from Pavel Tikhomirov --- On 12/10/2015 03:43 AM, James Bottomley wrote: > On Wed, 2015-12-09 at 15:35 +0300, Pavel Tikhomirov wrote: >> >> On 12/08/2015 07:16 PM, James Bottomley wrote: >>> On Mon,

Re: [Bug 108771] scsi: ses: kasan: ses_enclosure_data_process use after free on boot SAS2X28

On 12/10/2015 03:43 AM, James Bottomley wrote: On Wed, 2015-12-09 at 15:35 +0300, Pavel Tikhomirov wrote: On 12/08/2015 07:16 PM, James Bottomley wrote: On Mon, 2015-12-07 at 14:01 +, bugzilla-dae...@bugzilla.kernel.org wrote: https://bugzilla.kernel.org/show_bug.cgi?id=108771 ---

Re: [PATCH 3/4] scsi: storvsc: Refactor the code in storvsc_channel_init()

On Thu, Dec 10, 2015 at 04:14:19PM -0800, K. Y. Srinivasan wrote: > The function storvsc_channel_init() repeatedly interacts with the host to > extract various channel properties. Refactor this code to eliminate code > repetition. > > Signed-off-by: K. Y. Srinivasan >

RE: [PATCH 3/4] scsi: storvsc: Refactor the code in storvsc_channel_init()

> -Original Message- > From: Dan Carpenter [mailto:dan.carpen...@oracle.com] > Sent: Friday, December 11, 2015 2:41 AM > To: KY Srinivasan > Cc: gre...@linuxfoundation.org; linux-ker...@vger.kernel.org; > de...@linuxdriverproject.org; oher...@suse.com; >

RE: [PATCH 2/4] scsi: storvsc: Properly support Fibre Channel devices

> -Original Message- > From: Dan Carpenter [mailto:dan.carpen...@oracle.com] > Sent: Friday, December 11, 2015 2:25 AM > To: KY Srinivasan > Cc: gre...@linuxfoundation.org; linux-ker...@vger.kernel.org; > de...@linuxdriverproject.org; oher...@suse.com; >