Re: Device or HBA QD throttling creates holes in Sequential work load

2016-10-20 Thread Kashyap Desai
Reply to see if email reached to linux-scsi@vger.kernel.org. On Thu, Oct 20, 2016 at 12:07 PM, Kashyap Desai wrote: > Hi, > > I am doing some performance tuning in MR driver to understand how sdev queue > depth and hba queue depth play role in IO submission from

Re: [RFC 1/6] qed: Add support for hardware offloaded iSCSI.

2016-10-20 Thread Johannes Thumshirn
Hi Arun, On Wed, Oct 19, 2016 at 05:14:59PM -0700, Arun Easi wrote: > Thanks Johannes for the review, please see my response below. > [...] > > > > Why not introduce a small helper like: > > static inline bool qed_is_iscsi_personality() > > { > > return IS_ENABLED(CONFIG_QEDI) &&

Re: `rmmod mpt3sas` leads to backtraces 'fs/sysfs/group.c:237 sysfs_remove_group+0xa0/0xb0'

2016-10-20 Thread ojab //
Hi, ses module was not built/loaded in my tests (ENCLOSURE_SERVICES was not set in the kernel config), so it's not the case. Also Oracle bug is private, so I can't tell if it's really related. //wbr ojab On Thu, Oct 20, 2016 at 10:08 AM, Chaitra Basappa wrote: >

Re: [PATCH v2 6/7] megaraid_sas: Do not set MPI2_TYPE_CUDA for JBOD FP path for FW which does not support JBOD sequence map

2016-10-20 Thread James Bottomley
On Thu, 2016-10-20 at 11:15 +0200, Greg KH wrote: > On Thu, Oct 20, 2016 at 02:05:04AM -0700, Sumit Saxena wrote: > > CC: sta...@vger.kernel.org > > Signed-off-by: Sumit Saxena > > Reviewed-by: Hannes Reinecke > > Reviewed-by: Tomas Henzl

Device or HBA level QD throttling creates randomness in sequetial workload

2016-10-20 Thread Kashyap Desai
[ Apologize, if you find more than one instance of my email. Web based email client has some issue, so now trying git send mail.] Hi, I am doing some performance tuning in MR driver to understand how sdev queue depth and hba queue depth play role in IO submission from above layer. I have 24

[PATCH] ata: xgene: Enable NCQ support for APM X-Gene SATA controller hardware v1.1

2016-10-20 Thread Rameshwar Prasad Sahu
This patch enables NCQ support for APM X-Gene SATA controller hardware v1.1 that was broken with hardware v1.0. Signed-off-by: Rameshwar Prasad Sahu --- drivers/ata/ahci_xgene.c | 14 -- 1 files changed, 8 insertions(+), 6 deletions(-) diff --git

Device or HBA level QD throttling creates randomness in sequetial workload

2016-10-20 Thread Kashyap Desai
[ Apologize, if you find more than one instance of my email. Web based email client has some issue, so now trying git send mail.] Hi, I am doing some performance tuning in MR driver to understand how sdev queue depth and hba queue depth play role in IO submission from above layer. I have 24

Re: [RFC 3/6] qedi: Add QLogic FastLinQ offload iSCSI driver framework.

2016-10-20 Thread Rangankar, Manish
Thanks Johannes for the review, please see comments below, On 19/10/16 3:32 PM, "Johannes Thumshirn" wrote: >On Wed, Oct 19, 2016 at 01:01:10AM -0400, manish.rangan...@cavium.com >wrote: >> From: Manish Rangankar >> >> The QLogic FastLinQ

Re: [PATCH 2/2] scsi: smartpqi: Replace semaphore lun_reset_sem with mutex

2016-10-20 Thread Arnd Bergmann
On Thursday, October 20, 2016 2:24:02 PM CEST Binoy Jayan wrote: > Semaphores are going away in the future, so replace the semaphore > lun_reset_sem with the a mutex lock. > > Signed-off-by: Binoy Jayan > Reviewed-by: Arnd Bergmann -- To unsubscribe from

Re: [PATCH v2 6/7] megaraid_sas: Do not set MPI2_TYPE_CUDA for JBOD FP path for FW which does not support JBOD sequence map

2016-10-20 Thread Greg KH
On Thu, Oct 20, 2016 at 02:05:04AM -0700, Sumit Saxena wrote: > CC: sta...@vger.kernel.org > Signed-off-by: Sumit Saxena > Reviewed-by: Hannes Reinecke > Reviewed-by: Tomas Henzl > --- > drivers/scsi/megaraid/megaraid_sas_fusion.c |

[PATCH 2/2] scsi: smartpqi: Replace semaphore lun_reset_sem with mutex

2016-10-20 Thread Binoy Jayan
Semaphores are going away in the future, so replace the semaphore lun_reset_sem with the a mutex lock. Signed-off-by: Binoy Jayan --- drivers/scsi/smartpqi/smartpqi.h | 2 +- drivers/scsi/smartpqi/smartpqi_init.c | 6 +++--- 2 files changed, 4 insertions(+), 4

[PATCH 1/2] scsi: smartpqi: Replace semaphore sync_request_sem with mutex

2016-10-20 Thread Binoy Jayan
Semaphores are going away in the future, so replace the semaphore sync_request_sem with the a mutex lock. timeout_msecs is not used for the lock sync_request_sem, so remove the timed locking too. Signed-off-by: Binoy Jayan --- drivers/scsi/smartpqi/smartpqi.h | 4

Re: [RFC 5/6] qedi: Add support for iSCSI session management.

2016-10-20 Thread Rangankar, Manish
On 19/10/16 6:58 PM, "Johannes Thumshirn" wrote: >On Wed, Oct 19, 2016 at 01:01:12AM -0400, manish.rangan...@cavium.com >wrote: >> From: Manish Rangankar >> >> This patch adds support for iscsi_transport LLD Login, >> Logout, NOP-IN/NOP-OUT,

Device or HBA QD throttling creates holes in Sequential work load

2016-10-20 Thread Kashyap Desai
[ Apologize, if this thread is reached to you multiple time ] Hi, I am doing some performance tuning in MR driver to understand how sdev queue depth and hba queue depth play role in IO submission from above layer. I have 24 JBOD connected to MR 12GB controller and I can see performance for 4K

RE: [PATCH] Fix: scsi: megaraid: reduce the scope of pending-list lock to avoid double lock

2016-10-20 Thread Kashyap Desai
> -Original Message- > From: i...@itu.dk [mailto:i...@itu.dk] > Sent: Monday, October 17, 2016 1:00 PM > To: Jiri Kosina > Cc: Kashyap Desai; Sumit Saxena; Uday Lingala; James E.J. Bottomley; Martin K. > Petersen; megaraidlinux@avagotech.com; linux-scsi@vger.kernel.org; Iago > Abal >

[PATCH v2 2/7] megaraid_sas: Send correct PhysArm to FW for R1 VD downgrade

2016-10-20 Thread Sumit Saxena
This patch fixes the issue of wrong PhysArm was sent to firmware for R1 VD downgrade. Signed-off-by: Kiran Kumar Kasturi Signed-off-by: Sumit Saxena Reviewed-by: Hannes Reinecke Reviewed-by: Tomas Henzl

[PATCH v2 3/7] megaraid_sas: Do not fire DCMDs during PCI shutdown/detach

2016-10-20 Thread Sumit Saxena
This patch addresses the issue of driver firing DCMDs in PCI shutdown/detach path irrespective of firmware state. Driver will check for whether firmware is operational state or not before firing DCMDs. If firmware is in unrecoverbale state or does not become operational within specfied time,

[PATCH v2 5/7] MAINTAINERS: Update megaraid maintainers list

2016-10-20 Thread Sumit Saxena
Update MEGARAID drivers maintainers list. Signed-off-by: Sumit Saxena Reviewed-by: Hannes Reinecke --- MAINTAINERS | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 4c1f3f9..05c0624 100644

[PATCH v2 4/7] megaraid_sas: Send SYNCHRONIZE_CACHE command to firmware

2016-10-20 Thread Sumit Saxena
>From previous patch we have below changes in v2 - 1. Updated change log. Provided more detail in change log. 2. Agreed to remove module parameter. If we remove module parameter, we can ask customer to disable WCE on drive to get similar impact. 3. Always Send SYNCHRONIZE_CACHE for JBOD

[PATCH v2 7/7] megaraid_sas: driver version upgrade

2016-10-20 Thread Sumit Saxena
Signed-off-by: Sumit Saxena --- drivers/scsi/megaraid/megaraid_sas.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/megaraid/megaraid_sas.h b/drivers/scsi/megaraid/megaraid_sas.h index 43fd14f..1d4de90 100644 ---

[PATCH v2 0/7] megaraid_sas: Updates for scsi-next

2016-10-20 Thread Sumit Saxena
Changes in v2: 1. Removed unconditional msleep and moved calls to atomic_read into megasas_wait_for_adapter_operational 2. Updated change log for patch #4. Provided more detail in change log. 3. Agreed to remove module parameter. If we remove module parameter, we can ask customer to

[PATCH v2 6/7] megaraid_sas: Do not set MPI2_TYPE_CUDA for JBOD FP path for FW which does not support JBOD sequence map

2016-10-20 Thread Sumit Saxena
CC: sta...@vger.kernel.org Signed-off-by: Sumit Saxena Reviewed-by: Hannes Reinecke Reviewed-by: Tomas Henzl --- drivers/scsi/megaraid/megaraid_sas_fusion.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git

[PATCH v2 1/7] megaraid_sas: For SRIOV enabled firmware, ensure VF driver waits for 30secs before reset

2016-10-20 Thread Sumit Saxena
For SRIOV enabled firmware, if there is a OCR(online controller reset) possibility driver set the convert flag to 1, which is not happening if there are outstanding commands even after 180 seconds. As driver does not set convert flag to 1 and still making the OCR to run, VF(Virtual function)

Re: [RFC 6/6] qedi: Add support for data path.

2016-10-20 Thread Rangankar, Manish
On 19/10/16 3:54 PM, "Hannes Reinecke" wrote: >On 10/19/2016 07:01 AM, manish.rangan...@cavium.com wrote: >> From: Manish Rangankar >> >> This patch adds support for data path and TMF handling. >> >> Signed-off-by: Nilesh Javali

Re: [PATCH 1/2] scsi: smartpqi: Replace semaphore sync_request_sem with mutex

2016-10-20 Thread Arnd Bergmann
On Thursday, October 20, 2016 2:24:01 PM CEST Binoy Jayan wrote: > Semaphores are going away in the future, so replace the semaphore > sync_request_sem with the a mutex lock. timeout_msecs is not used > for the lock sync_request_sem, so remove the timed locking too. > > Signed-off-by: Binoy Jayan

[PATCH 0/2] smartpqi: Remove semaphores

2016-10-20 Thread Binoy Jayan
Hi, The following are a set of patches which removes semaphores from scsi/smartpqi. These are part of a bigger effort to eliminate all semaphores from the linux kernel. Thanks, Binoy Binoy Jayan (2): scsi: smartpqi: Replace semaphore sync_request_sem with mutex scsi: smartpqi: Replace

Re: [RFC 3/6] qedi: Add QLogic FastLinQ offload iSCSI driver framework.

2016-10-20 Thread Rangankar, Manish
Thanks Hannes for the review, please see my comments below, On 19/10/16 1:15 PM, "Hannes Reinecke" wrote: >On 10/19/2016 07:01 AM, manish.rangan...@cavium.com wrote: >> From: Manish Rangankar >> >> The QLogic FastLinQ Driver for iSCSI (qedi) is the

Re: [PATCH 1/2] scsi: smartpqi: Replace semaphore sync_request_sem with mutex

2016-10-20 Thread Arnd Bergmann
On Thursday, October 20, 2016 2:24:01 PM CEST Binoy Jayan wrote: > - sema_init(_info->sync_request_sem, > - PQI_RESERVED_IO_SLOTS_SYNCHRONOUS_REQUESTS); > + mutex_init(_info->sync_request_mutex); > Looking at this again, I see that

Re: [RFC 5/6] qedi: Add support for iSCSI session management.

2016-10-20 Thread Rangankar, Manish
On 19/10/16 1:33 PM, "Hannes Reinecke" wrote: >On 10/19/2016 07:01 AM, manish.rangan...@cavium.com wrote: >> From: Manish Rangankar >> >> This patch adds support for iscsi_transport LLD Login, >> Logout, NOP-IN/NOP-OUT, Async, Reject PDU processing

Re: [PATCH 00/10] mm: adjust get_user_pages* functions to explicitly pass FOLL_* flags

2016-10-20 Thread Michal Hocko
On Wed 19-10-16 10:23:55, Dave Hansen wrote: > On 10/19/2016 10:01 AM, Michal Hocko wrote: > > The question I had earlier was whether this has to be an explicit FOLL > > flag used by g-u-p users or we can just use it internally when mm != > > current->mm > > The reason I chose not to do that was

Re: [PATCH v2 1/2] scsi: Handle Unit Attention when issuing SCSI command

2016-10-20 Thread James Bottomley
On Mon, 2016-10-17 at 14:17 -0200, Gabriel Krisman Bertazi wrote: > James Bottomley writes: > > > On Thu, 2016-10-13 at 15:47 -0300, Gabriel Krisman Bertazi wrote: > > > @@ -210,6 +219,13 @@ int scsi_execute(struct scsi_device *sdev, > > > const > > > unsigned char *cmd,

Ahoj....

2016-10-20 Thread Ko M. Leung
Ahoj. Dobry vecer a jak se mas? Jen rychly jedno, je tu oficialni prilezitosti bych chtel diskutovat s vami soukrome. Ocenil bych vasi rychlou reakci tady na mem osobnim soukromeho e-mailu nize pro dalsi komunikaci. S pratelskym pozdravem, PanĂ­ Ko May Leung email: kmyln...@gmail.com

[Bug 179341] mpt3sas: LSISAS3008 don't see Intel 540s SSD

2016-10-20 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=179341 --- Comment #1 from Badalyan Vyacheslav --- I was change product and component -- You are receiving this mail because: You are watching someone on the CC list of the bug. -- To unsubscribe from this list: send the line

[Bug 179341] mpt3sas: LSISAS3008 don't see Intel 540s SSD

2016-10-20 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=179341 --- Comment #2 from Badalyan Vyacheslav --- Adapter Selected is a Avago SAS: SAS3008(C0) Num CtlrFW VerNVDATAx86-BIOS PCI Addr

[PATCH 00/10] mpt3sas driver Enhancements and

2016-10-20 Thread Suganath Prabu S
Here is the change list: Posting 10 patches for mpt3sas driver enhancements and few fixes. * Added Device ID's for SAS35 devices and updated MPI Header. * Support "EEDP Escape flag" for SAS35 devices. * fixed improper printk statement. * Regardless of whether RDPQ disabled card is

[PATCH 10/10] mpt3sas: Fix for Endianness issue.

2016-10-20 Thread Suganath Prabu S
Use le16_to_cpu only for accessing two byte data provided by controller. Signed-off-by: Chaitra P B Signed-off-by: Sathya Prakash Signed-off-by: Suganath Prabu S ---

[PATCH 09/10] mpt3sas: Use the new MPI 2.6 32-bit Atomic Request Descriptors for SAS35 devices.

2016-10-20 Thread Suganath Prabu S
Support Atomic Request Descriptors for Ventura/SAS35 devices. Signed-off-by: Chaitra P B Signed-off-by: Sathya Prakash Signed-off-by: Suganath Prabu S --- drivers/scsi/mpt3sas/mpt3sas_base.c

[PATCH 06/10] mpt3sas: Added Device ID's for SAS35 devices and updated MPI header.

2016-10-20 Thread Suganath Prabu S
Added Device ID's for SAS35 devices (Ventura, Crusader, Harpoon & Tomcat) and updated mpi header file for the same. Also added "is_gen35_ioc" to MPT3SAS_ADAPTER structure for identifying SAS35 adapters. Signed-off-by: Chaitra P B Signed-off-by: Sathya Prakash

[PATCH 05/10] mpt3sas: Bump driver version as "14.100.00.00"

2016-10-20 Thread Suganath Prabu S
Signed-off-by: Chaitra P B Signed-off-by: Sathya Prakash Signed-off-by: Suganath Prabu S --- drivers/scsi/mpt3sas/mpt3sas_base.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff

[PATCH 07/10] mpt3sas: Increased/Additional MSIX support for SAS35 devices.

2016-10-20 Thread Suganath Prabu S
For SAS35 devices MSIX vectors are inceased to 128 from 96. To support this Reply post host index register count is increased to 16. Also variable msix96_vector is replaced with combined_reply_queue and variable combined_reply_index_count is added to set different values for SAS3 and SAS35

RE: [RFC 2/6] qed: Add iSCSI out of order packet handling.

2016-10-20 Thread Mintz, Yuval
> > This patch adds out of order packet handling for hardware offloaded > > iSCSI. Out of order packet handling requires driver buffer allocation > > and assistance. > > > > Signed-off-by: Arun Easi > > Signed-off-by: Yuval Mintz > > > Hmm. The

[PATCH 08/10] mpt3sas: set EEDP-escape-flags for SAS35 devices.

2016-10-20 Thread Suganath Prabu S
An UNMAP command on a PI formatted device will leave the Logical Block Application Tag and Logical Block Reference Tag as all F's (for those LBAs that are unmapped). To avoid IO errors if those LBAs are subsequently read before they are written with valid tag fields, the MPI SCSI IO requests need

[PATCH 01/10] mpt3sas: Fix for improper info displayed in var log, while blocking or unblocking the device.

2016-10-20 Thread Suganath Prabu S
Return value and Device_handle Arguments passed in correct order to match with its format string. Signed-off-by: Chaitra P B Signed-off-by: Sathya Prakash Signed-off-by: Suganath Prabu S ---

[PATCH 02/10] mpt3sas: Fix for incorrect numbers for MSIX vectors enabled when non RDPQ card is enumerated first.

2016-10-20 Thread Suganath Prabu S
No. of MSIX vectors supported = min (Total no. of CPU cores, MSIX vectors supported by card) when RDPQ is disabled "max_msix_vectors" module parameter which was declared as global was set to '8' and hence if there are more than one card in system among which if RDPQ disabled card is enumerated

[PATCH 04/10] mpt3sas: Removing unused macro "MPT_DEVICE_TLR_ON"

2016-10-20 Thread Suganath Prabu S
Removing macro "MPT_DEVICE_TLR_ON" defined in header file as its unused Signed-off-by: Chaitra P B Signed-off-by: Sathya Prakash Signed-off-by: Suganath Prabu S ---

Re: [PATCH v3 0/11] Fix race conditions related to stopping block layer queues

2016-10-20 Thread Keith Busch
On Wed, Oct 19, 2016 at 04:51:18PM -0700, Bart Van Assche wrote: > > I assume that line 498 in blk-mq.c corresponds to BUG_ON(blk_queued_rq(rq))? > Anyway, it seems to me like this is a bug in the NVMe code and also that > this bug is completely unrelated to my patch series. In nvme_complete_rq()