Re: Crash in TCM-LIO

2016-10-24 Thread Nicholas A. Bellinger
Hello Anil & Co, On Mon, 2016-10-24 at 06:36 +, Anil Gurumurthy wrote: > Hello Nicholas, > > I was trying to get DIF working on TCM-LIO with a QLogic FC adapter > on kernel version 4.7. I noticed a crash when there was an abort > received by the target with the following stack trace: > >

Maxtor USB disk – "UNKNOWN(0x2003) Result" messages logged

2016-10-24 Thread Mantas Mikulėnas
Apologies if I'm posting to the wrong place; this is where I was pointed to the last time I had USB storage questions. I have a Maxtor (Seagate) "D3 Station" USB 3.0 SATA disk (0bc2:6125). While it appears to work completely fine, every now and then the following are logged in dmesg: [Oct20

Re: Kernel 4.8.4: INFO: task kworker/u16:8:289 blocked for more than 120 seconds.

2016-10-24 Thread Nicholas A. Bellinger
Hi TomK, Thanks for reporting this bug. Comments inline below. On Mon, 2016-10-24 at 00:45 -0400, TomK wrote: > On 10/24/2016 12:32 AM, TomK wrote: > > On 10/23/2016 10:03 PM, TomK wrote: > >> Hey, > >> > >> Has anyone seen this and could have a workaround? Seems like it is more > >> Kernel

Re: [patch] zfcp: spin_lock_irqsave() is not nestable

2016-10-24 Thread Christian Borntraeger
On 10/14/2016 10:21 PM, Martin K. Petersen wrote: >> "Steffen" == Steffen Maier writes: > > Steffen> could you please queue this as fix for one of my patches that > Steffen> went into the 4.9 merge window, so for 4.9-rc I guess? > > Applied to 4.9/scsi-fixes. >

RE: Crash in TCM-LIO

2016-10-24 Thread Gurumurthy, Anil
-Original Message- From: Nicholas A. Bellinger [mailto:n...@linux-iscsi.org] Sent: 24 October 2016 12:30 To: Anil Gurumurthy Cc: linux-scsi ; Malavali, Giridhar ; Tran, Quinn ;

Re: [PATCH] lpfc: Revise MAINTAINERS to reflect Broadcom

2016-10-24 Thread Martin K. Petersen
> "James" == James Smart writes: James> Avago is now known as Broadcom. Revise the emails and website James> for lpfc accordingly Applied to 4.10/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line

[Bug 176951] boot fails unless acpi=off Acer Travelmate X-349

2016-10-24 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=176951 Len Brown changed: What|Removed |Added Component|Config-Tables |Other

Re: [PATCH v3 4/8] megaraid_sas: Send SYNCHRONIZE_CACHE for non-raid to firmware

2016-10-24 Thread Martin K. Petersen
> "Kashyap" == Kashyap Desai writes: Kashyap> Commit- " 02b01e0 [SCSI] megaraid_sas: return sync cache call Kashyap> with success" added the code in driver to return Kashyap> SYNCHRONIZE_CACHE without sending it to firmware back in Kashyap> 2007. Earlier MR was

Re: [PATCH v2 00/10] ufs-qcom: phy/hcd: Clean up qcom-ufs phy and ufs-qcom hcd

2016-10-24 Thread Martin K. Petersen
> "Vivek" == Vivek Gautam writes: Vivek, Vivek> These patches cleanup the ufs phy driver to an extent. Vivek> Subsequent patches will target to clean the phy_init() of these Vivek> qcom-ufs phy drivers in order to get rid of a number of exported Vivek> APIs that

Re: [PATCH 00/20] libfc callback cleanup

2016-10-24 Thread Martin K. Petersen
> "Hannes" == Hannes Reinecke writes: Hannes> Hi all, it has been bugging me for a while that libfc has tons Hannes> of callbacks in an attempt to abstract things away. But as it Hannes> turned out no-one ever used those, rendering them quite Hannes> pointless. As I got some

Re: [PATCH 00/10] mpt3sas driver Enhancements and

2016-10-24 Thread Martin K. Petersen
> "Suganath" == Suganath Prabu S > writes: Suganath, Suganath> Here is the change list: Posting 10 patches for mpt3sas driver Suganath> enhancements and few fixes. Suganath> * Added Device ID's for SAS35 devices and updated MPI Suganath>

Re: [PATCH v3 0/7] megaraid_sas: Updates for scsi-next

2016-10-24 Thread Martin K. Petersen
> "Kashyap" == Kashyap Desai writes: Kashyap, Kashyap> Changes in v3 Kashyap> two logical patches created for "Send SYNCHRONIZE_CACHE Kashyap> command to firmware" Kashyap>- Send SYNCHRONIZE_CACHE for JBOD to firmware Kashyap>- Send

Re: [PATCH] advansys: fix build warning for PCI=n

2016-10-24 Thread Hannes Reinecke
On 10/24/2016 05:51 PM, Arnd Bergmann wrote: > The advansys probe function tries to handle both ISA and PCI cases, > each hidden in an #ifdef when unused. This leads to a warning > indicating that when PCI is disabled we could be using uninitialized > data: > > drivers/scsi/advansys.c: In

Re: [PATCH v3 0/6] scsi: collection of clean ups

2016-10-24 Thread Martin K. Petersen
> "Andy" == Andy Shevchenko writes: Andy> Just collection of clean ups against SCSI drivers. Some of them Andy> were Acked quite long ago, but didn't make upstream yet. Applied to 4.10/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering -- To

Re: [PATCH 4/7] megaraid_sas: Send SYNCHRONIZE_CACHE command to firmware

2016-10-24 Thread Martin K. Petersen
> "Tomas" == Tomas Henzl writes: >> SCSI command checking in queuecommand function of arcmsr can be >> removed safely. Now driver can pass all scsi command to controller >> firmware. Tomas> Is this (passing the SYNCHRONIZE_CACHE command to firmware) safe Tomas> for all

Re: Kernel 4.8.4: INFO: task kworker/u16:8:289 blocked for more than 120 seconds.

2016-10-24 Thread TomK
On 10/24/2016 2:36 AM, Nicholas A. Bellinger wrote: Hi TomK, Thanks for reporting this bug. Comments inline below. On Mon, 2016-10-24 at 00:45 -0400, TomK wrote: On 10/24/2016 12:32 AM, TomK wrote: On 10/23/2016 10:03 PM, TomK wrote: Hey, Has anyone seen this and could have a workaround?

Re: [PATCH v3 2/6] fusion: print lan address via %pMR

2016-10-24 Thread Ewan D. Milne
On Sat, 2016-10-22 at 20:32 +0300, Andy Shevchenko wrote: > LAN MAC addresses can be printed directly using %pMR specifier. > > Cc: Sathya Prakash > Cc: Chaitra P B > Cc: Suganath Prabu Subramani

Re: [PATCH v3 4/6] [SCSI] ips: don't use custom hex_asc_upper[] table

2016-10-24 Thread Ewan D. Milne
On Sat, 2016-10-22 at 20:32 +0300, Andy Shevchenko wrote: > From: Andy Shevchenko > > We have table of the HEX characters in the kernel. Replace custom by a generic > one. > > Cc: Adaptec OEM Raid Solutions > Signed-off-by: Andy Shevchenko

Re: [PATCH v3 5/6] scsi: replace custom approach to hexdump small buffers

2016-10-24 Thread Ewan D. Milne
On Sat, 2016-10-22 at 20:32 +0300, Andy Shevchenko wrote: > In kernel we have defined specifier (%*ph[C]) to dump small buffers in a hex > format. Replace custom approach by a generic one. > > Cc: Jon Mason > Signed-off-by: Andy Shevchenko

Re: [PATCH 1/2] scsi: smartpqi: Replace semaphore sync_request_sem with mutex

2016-10-24 Thread Arnd Bergmann
On Monday, October 24, 2016 3:34:27 PM CEST Binoy Jayan wrote: > Hi Arnd > > On 20 October 2016 at 14:36, Arnd Bergmann wrote: > > On Thursday, October 20, 2016 2:24:01 PM CEST Binoy Jayan wrote: > >> Semaphores are going away in the future, so replace the semaphore > >>

Re: [PATCH v3 1/6] scsi: fnic: use kernel's '%pM' format option to print MAC

2016-10-24 Thread Ewan D. Milne
On Sat, 2016-10-22 at 20:32 +0300, Andy Shevchenko wrote: > Instead of supplying each byte through stack let's use %pM specifier. > > Cc: Hiral Patel > Cc: Suma Ramars > Acked-by: Tom Tucker > Signed-off-by: Andy Shevchenko

Re: [PATCH 1/2] scsi: smartpqi: Replace semaphore sync_request_sem with mutex

2016-10-24 Thread Binoy Jayan
On 20 October 2016 at 14:40, Arnd Bergmann wrote: > On Thursday, October 20, 2016 2:24:01 PM CEST Binoy Jayan wrote: >> - sema_init(_info->sync_request_sem, >> - PQI_RESERVED_IO_SLOTS_SYNCHRONOUS_REQUESTS); >> + mutex_init(_info->sync_request_mutex); >> >

RE: Device or HBA level QD throttling creates randomness in sequetial workload

2016-10-24 Thread Kashyap Desai
> > On Fri, Oct 21, 2016 at 05:43:35PM +0530, Kashyap Desai wrote: > > Hi - > > > > I found below conversation and it is on the same line as I wanted some > > input from mailing list. > > > > http://marc.info/?l=linux-kernel=147569860526197=2 > > > > I can do testing on any WIP item as Omar

Re: [PATCH v3 8/8] megaraid_sas: driver version upgrade

2016-10-24 Thread Hannes Reinecke
On 10/21/2016 03:33 PM, Kashyap Desai wrote: Signed-off-by: Sumit Saxena --- drivers/scsi/megaraid/megaraid_sas.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/megaraid/megaraid_sas.h b/drivers/scsi/megaraid/megaraid_sas.h

Re: [PATCH 01/10] mpt3sas: Fix for improper info displayed in var log, while blocking or unblocking the device.

2016-10-24 Thread Hannes Reinecke
On 10/20/2016 02:20 PM, Suganath Prabu S wrote: Return value and Device_handle Arguments passed in correct order to match with its format string. Signed-off-by: Chaitra P B Signed-off-by: Sathya Prakash Signed-off-by: Suganath Prabu

Re: [PATCH 06/10] mpt3sas: Added Device ID's for SAS35 devices and updated MPI header.

2016-10-24 Thread Hannes Reinecke
On 10/20/2016 02:20 PM, Suganath Prabu S wrote: Added Device ID's for SAS35 devices (Ventura, Crusader, Harpoon & Tomcat) and updated mpi header file for the same. Also added "is_gen35_ioc" to MPT3SAS_ADAPTER structure for identifying SAS35 adapters. Signed-off-by: Chaitra P B

Re: [PATCH 08/10] mpt3sas: set EEDP-escape-flags for SAS35 devices.

2016-10-24 Thread Hannes Reinecke
On 10/20/2016 02:20 PM, Suganath Prabu S wrote: An UNMAP command on a PI formatted device will leave the Logical Block Application Tag and Logical Block Reference Tag as all F's (for those LBAs that are unmapped). To avoid IO errors if those LBAs are subsequently read before they are written

Re: [PATCH 07/10] mpt3sas: Increased/Additional MSIX support for SAS35 devices.

2016-10-24 Thread Hannes Reinecke
On 10/20/2016 02:20 PM, Suganath Prabu S wrote: For SAS35 devices MSIX vectors are inceased to 128 from 96. To support this Reply post host index register count is increased to 16. Also variable msix96_vector is replaced with combined_reply_queue and variable combined_reply_index_count is added

Re: [PATCH 09/10] mpt3sas: Use the new MPI 2.6 32-bit Atomic Request Descriptors for SAS35 devices.

2016-10-24 Thread Hannes Reinecke
On 10/20/2016 02:20 PM, Suganath Prabu S wrote: Support Atomic Request Descriptors for Ventura/SAS35 devices. Signed-off-by: Chaitra P B Signed-off-by: Sathya Prakash Signed-off-by: Suganath Prabu S

Re: [PATCH 05/10] mpt3sas: Bump driver version as "14.100.00.00"

2016-10-24 Thread Hannes Reinecke
On 10/20/2016 02:20 PM, Suganath Prabu S wrote: Signed-off-by: Chaitra P B Signed-off-by: Sathya Prakash Signed-off-by: Suganath Prabu S --- drivers/scsi/mpt3sas/mpt3sas_base.h | 4 ++-- 1 file

Re: [PATCH 1/1] libfc: don't have fc_exch_find log errors on a new exchange

2016-10-24 Thread Ewan D. Milne
On Fri, 2016-10-21 at 14:10 -0700, Chris Leech wrote: > With the error message I added in "libfc: sanity check cpu number > extracted from xid" I didn't account for the fact that fc_exch_find is > called with FC_XID_UNKNOWN at the start of a new exchange if we are the > responder. > > It doesn't

[PATCH] block: Fix kernel panic occurs while creating second raid disk

2016-10-24 Thread Sreekanth Reddy
Observing below kernel panic while creating second raid disk on LSI SAS3008 HBA card. [ +0.55] [ cut here ] [ +0.07] WARNING: CPU: 2 PID: 281 at fs/sysfs/dir.c:31 sysfs_warn_dup+0x62/0x80 [ +0.02] sysfs: cannot create duplicate filename

Re: [PATCH v3 5/8] megaraid_sas: Send SYNCHRONIZE_CACHE for VD to firmware

2016-10-24 Thread Hannes Reinecke
On 10/21/2016 03:33 PM, Kashyap Desai wrote: From previous patch we have below changes in v2 (only for Virtual Disk)- 1. Updated change log. Provided more detail in change log. 2. Agreed to remove module parameter. If we remove module parameter, we can ask customer to disable WCE on drive

Re: [PATCH 1/1] libfc: don't have fc_exch_find log errors on a new exchange

2016-10-24 Thread Hannes Reinecke
On 10/21/2016 11:10 PM, Chris Leech wrote: With the error message I added in "libfc: sanity check cpu number extracted from xid" I didn't account for the fact that fc_exch_find is called with FC_XID_UNKNOWN at the start of a new exchange if we are the responder. It doesn't come up with the

Re: [PATCH] sd: fix uninitialized variable access in error handling

2016-10-24 Thread Hannes Reinecke
On 10/21/2016 05:32 PM, Arnd Bergmann wrote: If sd_zbc_report_zones fails, the check for 'zone_blocks == 0' later in the function accesses uninitialized data: drivers/scsi/sd_zbc.c: In function ‘sd_zbc_read_zones’: drivers/scsi/sd_zbc.c:520:7: error: ‘zone_blocks’ may be used uninitialized in

Re: [PATCH 04/10] mpt3sas: Removing unused macro "MPT_DEVICE_TLR_ON"

2016-10-24 Thread Hannes Reinecke
On 10/20/2016 02:20 PM, Suganath Prabu S wrote: Removing macro "MPT_DEVICE_TLR_ON" defined in header file as its unused Signed-off-by: Chaitra P B Signed-off-by: Sathya Prakash Signed-off-by: Suganath Prabu S

Re: [PATCH 03/10] mpt3sas: Implement device_remove_in_progress check in IOCTL path

2016-10-24 Thread Hannes Reinecke
On 10/20/2016 02:20 PM, Suganath Prabu S wrote: When device missing event arrives, device_remove_in_progress bit will be set and hence driver has to stop sending IOCTL commands.Now the check has been added in IOCTL path to test device_remove_in_progress bit is set, if so then IOCTL will be

Re: [PATCH 10/10] mpt3sas: Fix for Endianness issue.

2016-10-24 Thread Hannes Reinecke
On 10/20/2016 02:20 PM, Suganath Prabu S wrote: Use le16_to_cpu only for accessing two byte data provided by controller. Signed-off-by: Chaitra P B Signed-off-by: Sathya Prakash Signed-off-by: Suganath Prabu S

Re: [PATCH v3 3/8] megaraid_sas: Do not fire DCMDs during PCI shutdown/detach

2016-10-24 Thread Hannes Reinecke
On 10/21/2016 03:33 PM, Kashyap Desai wrote: This patch addresses the issue of driver firing DCMDs in PCI shutdown/detach path irrespective of firmware state. Driver will check for whether firmware is operational state or not before firing DCMDs. If firmware is in unrecoverbale state or does not

Re: [PATCH v3 4/8] megaraid_sas: Send SYNCHRONIZE_CACHE for non-raid to firmware

2016-10-24 Thread Hannes Reinecke
On 10/21/2016 03:33 PM, Kashyap Desai wrote: Commit- " 02b01e0 [SCSI] megaraid_sas: return sync cache call with success" added the code in driver to return SYNCHRONIZE_CACHE without sending it to firmware back in 2007. Earlier MR was mainly for Virtual Disk, so same code continue for JBOD as

Re: [PATCH 02/10] mpt3sas: Fix for incorrect numbers for MSIX vectors enabled when non RDPQ card is enumerated first.

2016-10-24 Thread Hannes Reinecke
On 10/20/2016 02:20 PM, Suganath Prabu S wrote: No. of MSIX vectors supported = min (Total no. of CPU cores, MSIX vectors supported by card) when RDPQ is disabled "max_msix_vectors" module parameter which was declared as global was set to '8' and hence if there are more than one card in system

Re: [PATCH v3 4/8] megaraid_sas: Send SYNCHRONIZE_CACHE for non-raid to firmware

2016-10-24 Thread Ewan D. Milne
On Fri, 2016-10-21 at 06:33 -0700, Kashyap Desai wrote: > Commit- " 02b01e0 [SCSI] megaraid_sas: return sync cache call with success" > added the code in driver to return SYNCHRONIZE_CACHE without sending it to > firmware back in 2007. Earlier MR was mainly for Virtual Disk, > so same code

Re: [PATCH v3 5/8] megaraid_sas: Send SYNCHRONIZE_CACHE for VD to firmware

2016-10-24 Thread Ewan D. Milne
On Fri, 2016-10-21 at 06:33 -0700, Kashyap Desai wrote: > From previous patch we have below changes in v2 (only for Virtual Disk)- > 1. Updated change log. Provided more detail in change log. > 2. Agreed to remove module parameter. If we remove module parameter, we > can ask customer to

Re: Device or HBA level QD throttling creates randomness in sequetial workload

2016-10-24 Thread Omar Sandoval
On Mon, Oct 24, 2016 at 06:35:01PM +0530, Kashyap Desai wrote: > > > > On Fri, Oct 21, 2016 at 05:43:35PM +0530, Kashyap Desai wrote: > > > Hi - > > > > > > I found below conversation and it is on the same line as I wanted some > > > input from mailing list. > > > > > >

[PATCH] lpfc: Revise MAINTAINERS to reflect Broadcom

2016-10-24 Thread James Smart
Avago is now known as Broadcom. Revise the emails and website for lpfc accordingly Signed-off-by: James Smart --- MAINTAINERS | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 072fe36..96e0ec6 100644 ---

[PATCH] advansys: fix build warning for PCI=n

2016-10-24 Thread Arnd Bergmann
The advansys probe function tries to handle both ISA and PCI cases, each hidden in an #ifdef when unused. This leads to a warning indicating that when PCI is disabled we could be using uninitialized data: drivers/scsi/advansys.c: In function ‘advansys_board_found’:

RE: Device or HBA level QD throttling creates randomness in sequetial workload

2016-10-24 Thread Kashyap Desai
> -Original Message- > From: Omar Sandoval [mailto:osan...@osandov.com] > Sent: Monday, October 24, 2016 9:11 PM > To: Kashyap Desai > Cc: linux-scsi@vger.kernel.org; linux-ker...@vger.kernel.org; linux- > bl...@vger.kernel.org; ax...@kernel.dk; Christoph Hellwig; >

RE: Crash in TCM-LIO

2016-10-24 Thread Gurumurthy, Anil
-Original Message- From: Nicholas A. Bellinger [mailto:n...@linux-iscsi.org] Sent: 24 October 2016 12:30 To: Anil Gurumurthy Cc: linux-scsi ; Malavali, Giridhar ; Tran, Quinn ;

Re: [PATCH 1/2] scsi: smartpqi: Replace semaphore sync_request_sem with mutex

2016-10-24 Thread Binoy Jayan
Hi Arnd On 20 October 2016 at 14:36, Arnd Bergmann wrote: > On Thursday, October 20, 2016 2:24:01 PM CEST Binoy Jayan wrote: >> Semaphores are going away in the future, so replace the semaphore >> sync_request_sem with the a mutex lock. timeout_msecs is not used >> for the lock

Re: [PATCH v3 3/6] scsi: qla4xxx: print MAC and SID via %p[mM][R]

2016-10-24 Thread Ewan D. Milne
On Sat, 2016-10-22 at 20:32 +0300, Andy Shevchenko wrote: > From: Oleksandr Khoshaba > > In the kernel we have nice specifier to print MAC by given pointer to the > address in a binary form. > > Signed-off-by: Oleksandr Khoshaba >