Re: [PATCH 05/12] blk-mq: Introduce blk_mq_quiesce_queue()

On 10/26/16 18:30, Ming Lei wrote: On Thu, Oct 27, 2016 at 6:53 AM, Bart Van Assche wrote: blk_mq_quiesce_queue() waits until ongoing .queue_rq() invocations have finished. This function does *not* wait until all outstanding requests have finished (this means

Re: [PATCH 04/12] blk-mq: Move more code into blk_mq_direct_issue_request()

On 10/27/2016 12:52 AM, Bart Van Assche wrote: > Move the "hctx stopped" test and the insert request calls into > blk_mq_direct_issue_request(). Rename that function into > blk_mq_try_issue_directly() to reflect its new semantics. Pass > the hctx pointer to that function instead of looking it up a

Re: [PATCH 03/12] blk-mq: Introduce blk_mq_queue_stopped()

On 10/27/2016 12:52 AM, Bart Van Assche wrote: > The function blk_queue_stopped() allows to test whether or not a > traditional request queue has been stopped. Introduce a helper > function that allows block drivers to query easily whether or not > one or more hardware contexts of a blk-mq queue

Re: [PATCH 05/12] blk-mq: Introduce blk_mq_quiesce_queue()

On 10/26/16 19:31, Ming Lei wrote: On Thu, Oct 27, 2016 at 10:04 AM, Bart Van Assche wrote: On 10/26/16 18:30, Ming Lei wrote: On Thu, Oct 27, 2016 at 6:53 AM, Bart Van Assche wrote: blk_mq_quiesce_queue() waits until ongoing .queue_rq()

Re: [PATCH 01/12] blk-mq: Do not invoke .queue_rq() for a stopped queue

On 10/27/2016 12:50 AM, Bart Van Assche wrote: > The meaning of the BLK_MQ_S_STOPPED flag is "do not call > .queue_rq()". Hence modify blk_mq_make_request() such that requests > are queued instead of issued if a queue has been stopped. > > Reported-by: Ming Lei >

Re: [PATCH 05/12] blk-mq: Introduce blk_mq_quiesce_queue()

On 10/27/2016 12:53 AM, Bart Van Assche wrote: > blk_mq_quiesce_queue() waits until ongoing .queue_rq() invocations > have finished. This function does *not* wait until all outstanding > requests have finished (this means invocation of request.end_io()). > The algorithm used by

Re: [PATCH v3 1/2] scsi: Handle Unit Attention when issuing SCSI command

On Wed, 2016-10-26 at 08:42 -0700, Bart Van Assche wrote: > On 10/25/2016 04:50 PM, James Bottomley wrote: > > On Tue, 2016-10-25 at 23:18 +, Bart Van Assche wrote: > > > Anyway, currently the following functions interpret the SCSI > > > sense buffer: > > > * scsi_io_completion() in

Re: [PATCH v3 1/2] scsi: Handle Unit Attention when issuing SCSI command

On 10/25/2016 04:50 PM, James Bottomley wrote: On Tue, 2016-10-25 at 23:18 +, Bart Van Assche wrote: Anyway, currently the following functions interpret the SCSI sense buffer: * scsi_io_completion() in scsi_lib.c. * scsi_mode_sense() in scsi_lib.c. * scsi_test_unit_ready_flags() in

Re: [PATCH v3 1/2] scsi: Handle Unit Attention when issuing SCSI command

On Wed, 2016-10-26 at 08:52 -0700, James Bottomley wrote: > On Wed, 2016-10-26 at 08:42 -0700, Bart Van Assche wrote: > > Can you elaborate on this? Since the sense buffer is available in  > > scsi_io_completion() and since that function already calls  > > scsi_command_normalize_sense() this

[PATCH] scsi_debug: Fix memory leak if LBP enabled and module is unloaded

From: "Ewan D. Milne" map_storep was not being vfree()'d in the module_exit call. Signed-off-by: Ewan D. Milne --- drivers/scsi/scsi_debug.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/scsi/scsi_debug.c b/drivers/scsi/scsi_debug.c index

[PATCH 03/12] blk-mq: Introduce blk_mq_queue_stopped()

The function blk_queue_stopped() allows to test whether or not a traditional request queue has been stopped. Introduce a helper function that allows block drivers to query easily whether or not one or more hardware contexts of a blk-mq queue have been stopped. Signed-off-by: Bart Van Assche

[PATCH 04/12] blk-mq: Move more code into blk_mq_direct_issue_request()

Move the "hctx stopped" test and the insert request calls into blk_mq_direct_issue_request(). Rename that function into blk_mq_try_issue_directly() to reflect its new semantics. Pass the hctx pointer to that function instead of looking it up a second time. These changes avoid that code has to be

Re: [RFC] libata-scsi: introducing SANITIZE translation

On 16-07-11 02:35 AM, Tom Yan wrote: I don't suppose there would be any problem doing it in userspace / with ATA PASS-THROUGH anyway. .. On 8 July 2016 at 17:29, James Bottomley wrote: .. Not really. The point is that you've proposed something as an

[PATCH 08/12] dm: Fix a race condition related to stopping and starting queues

Ensure that all ongoing dm_mq_queue_rq() and dm_mq_requeue_request() calls have stopped before setting the "queue stopped" flag. This allows to remove the "queue stopped" test from dm_mq_queue_rq() and dm_mq_requeue_request(). This patch fixes a race condition because dm_mq_queue_rq() is called

[PATCH 05/12] blk-mq: Introduce blk_mq_quiesce_queue()

blk_mq_quiesce_queue() waits until ongoing .queue_rq() invocations have finished. This function does *not* wait until all outstanding requests have finished (this means invocation of request.end_io()). The algorithm used by blk_mq_quiesce_queue() is as follows: * Hold either an RCU read lock or an

[PATCH 07/12] dm: Use BLK_MQ_S_STOPPED instead of QUEUE_FLAG_STOPPED in blk-mq code

Instead of manipulating both QUEUE_FLAG_STOPPED and BLK_MQ_S_STOPPED in the dm start and stop queue functions, only manipulate the latter flag. Change blk_queue_stopped() tests into blk_mq_queue_stopped(). Signed-off-by: Bart Van Assche Reviewed-by: Christoph Hellwig

Re: [PATCH 05/12] blk-mq: Introduce blk_mq_quiesce_queue()

On Thu, Oct 27, 2016 at 10:40 AM, Bart Van Assche wrote: > On 10/26/16 19:31, Ming Lei wrote: >> >> On Thu, Oct 27, 2016 at 10:04 AM, Bart Van Assche >> wrote: >>> >>> On 10/26/16 18:30, Ming Lei wrote: On Thu, Oct 27, 2016 at 6:53 AM, Bart

[PATCH 10/12] SRP transport, scsi-mq: Wait for .queue_rq() if necessary

Ensure that if scsi-mq is enabled that scsi_wait_for_queuecommand() waits until ongoing shost->hostt->queuecommand() calls have finished. Signed-off-by: Bart Van Assche Reviewed-by: Christoph Hellwig Cc: James Bottomley Cc:

Re: [PATCH 2/2] be2iscsi: Replace _bh with _irqsave/irqrestore

On 10/12/2016 11:38 PM, Jitendra Bhivare wrote: > [ 3843.132217] WARNING: CPU: 20 PID: 1227 at kernel/softirq.c:150 > __local_bh_enable_ip+0x6b/0x90 > [ 3843.142815] Modules linked in: > ... > [ 3843.294328] CPU: 20 PID: 1227 Comm: kworker/20:1H Tainted: GE > 4.8.0-rc1+ #3 > [

Re: [PATCH 1/2] libiscsi: Fix locking in __iscsi_conn_send_pdu

On 10/12/2016 11:38 PM, Jitendra Bhivare wrote: > The code at free_task label in __iscsi_conn_send_pdu can get executed > from blk_timeout_work which takes queue_lock using spin_lock_irq. > back_lock taken with spin_unlock_bh will cause WARN_ON_ONCE. > The code gets executed either with bottom

[PATCH 02/12] blk-mq: Introduce blk_mq_hctx_stopped()

Multiple functions test the BLK_MQ_S_STOPPED bit so introduce a helper function that performs this test. Signed-off-by: Bart Van Assche Cc: Christoph Hellwig Cc: Hannes Reinecke Cc: Sagi Grimberg Cc: Johannes Thumshirn

Re: [PATCH v4 0/12] Fix race conditions related to stopping block layer queues

On 10/26/2016 04:49 PM, Bart Van Assche wrote: Hello Jens, Multiple block drivers need the functionality to stop a request queue and to wait until all ongoing request_fn() / queue_rq() calls have finished without waiting until all outstanding requests have finished. Hence this patch series that

[PATCH 06/12] blk-mq: Add a kick_requeue_list argument to blk_mq_requeue_request()

Most blk_mq_requeue_request() and blk_mq_add_to_requeue_list() calls are followed by kicking the requeue list. Hence add an argument to these two functions that allows to kick the requeue list. This was proposed by Christoph Hellwig. Signed-off-by: Bart Van Assche Cc:

Re: [PATCH 02/12] blk-mq: Introduce blk_mq_hctx_stopped()

On Thu, Oct 27, 2016 at 6:51 AM, Bart Van Assche wrote: > Multiple functions test the BLK_MQ_S_STOPPED bit so introduce > a helper function that performs this test. > > Signed-off-by: Bart Van Assche > Cc: Christoph Hellwig >

Re: [PATCH 05/12] blk-mq: Introduce blk_mq_quiesce_queue()

On 10/26/16 19:48, Ming Lei wrote: On Thu, Oct 27, 2016 at 10:40 AM, Bart Van Assche wrote: If you have a look at the later patches in this series then you will see that the dm core and the NVMe driver have been modified such that blk_mq_stop_hw_queues(q) is called

[PATCH 01/12] blk-mq: Do not invoke .queue_rq() for a stopped queue

The meaning of the BLK_MQ_S_STOPPED flag is "do not call .queue_rq()". Hence modify blk_mq_make_request() such that requests are queued instead of issued if a queue has been stopped. Reported-by: Ming Lei Signed-off-by: Bart Van Assche

[PATCH 11/12] nvme: Use BLK_MQ_S_STOPPED instead of QUEUE_FLAG_STOPPED in blk-mq code

Make nvme_requeue_req() check BLK_MQ_S_STOPPED instead of QUEUE_FLAG_STOPPED. Remove the QUEUE_FLAG_STOPPED manipulations that became superfluous because of this change. Change blk_queue_stopped() tests into blk_mq_queue_stopped(). This patch fixes a race condition: using

[PATCH 09/12] SRP transport: Move queuecommand() wait code to SCSI core

Additionally, rename srp_wait_for_queuecommand() into scsi_wait_for_queuecommand() and add a comment about the queuecommand() call from scsi_send_eh_cmnd(). Signed-off-by: Bart Van Assche Reviewed-by: Christoph Hellwig Cc: James Bottomley

[PATCH v4 0/12] Fix race conditions related to stopping block layer queues

Hello Jens, Multiple block drivers need the functionality to stop a request queue and to wait until all ongoing request_fn() / queue_rq() calls have finished without waiting until all outstanding requests have finished. Hence this patch series that introduces the blk_mq_quiesce_queue()

[PATCH 12/12] nvme: Fix a race condition related to stopping queues

Avoid that nvme_queue_rq() is still running when nvme_stop_queues() returns. Signed-off-by: Bart Van Assche Reviewed-by: Sagi Grimberg Reviewed-by: Christoph Hellwig Cc: Keith Busch --- drivers/nvme/host/core.c

Re: [PATCH 4/7] megaraid_sas: Send SYNCHRONIZE_CACHE command to firmware

> "ching" == 黃清隆 writes: ching, ching> Yes. Passing SYNCHRONIZE_CACHE command to firmware is safe for ching> all Areca Raid controllers, even the oldest. I applied your patch to 4.9/scsi-fixes. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe

Re: [PATCH 1/1] libfc: don't have fc_exch_find log errors on a new exchange

> "Chris" == Chris Leech writes: Chris> With the error message I added in "libfc: sanity check cpu number Chris> extracted from xid" I didn't account for the fact that Chris> fc_exch_find is called with FC_XID_UNKNOWN at the start of a new Chris> exchange if we are the

Re: [PATCH] advansys: fix build warning for PCI=n

> "Arnd" == Arnd Bergmann writes: Arnd> The advansys probe function tries to handle both ISA and PCI Arnd> cases, each hidden in an #ifdef when unused. This leads to a Arnd> warning indicating that when PCI is disabled we could be using Arnd> uninitialized data: Arnd>

Re: [PATCH 05/12] blk-mq: Introduce blk_mq_quiesce_queue()

On Thu, Oct 27, 2016 at 6:53 AM, Bart Van Assche wrote: > blk_mq_quiesce_queue() waits until ongoing .queue_rq() invocations > have finished. This function does *not* wait until all outstanding > requests have finished (this means invocation of request.end_io()). > The

Re: [PATCH v2 00/11] mpt3sas driver Enhancements and

> "Suganath" == Suganath Prabu S > writes: Suganath> Here is the change list: Posting 11 patches for mpt3sas driver Suganath> enhancements and few fixes. Suganath> * Added Device ID's for SAS35 devices and updated MPI Suganath> Header.

Re: [PATCH] scsi_debug: Fix memory leak if LBP enabled and module is unloaded

> "Ewan" == Ewan D Milne writes: Ewan> map_storep was not being vfree()'d in the module_exit call. Applied to 4.9/scsi-fixes. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a

Re: [PATCH 05/12] blk-mq: Introduce blk_mq_quiesce_queue()

On Thu, Oct 27, 2016 at 10:04 AM, Bart Van Assche wrote: > On 10/26/16 18:30, Ming Lei wrote: >> >> On Thu, Oct 27, 2016 at 6:53 AM, Bart Van Assche >> wrote: >>> >>> blk_mq_quiesce_queue() waits until ongoing .queue_rq() invocations >>> have

Re: Crash in TCM-LIO

Hello Anil & Co, On Tue, 2016-10-25 at 05:33 +, Gurumurthy, Anil wrote: > On Mon, 2016-10-24 at 06:36 +, Anil Gurumurthy wrote: > > > > [71884.588748] BUG: unable to handle kernel NULL pointer dereference > > at 00e0 > > > > [71884.51] IP: []

Re: [PATCH 2/2] scsi: ufs: Use the resource-managed function to add devfreq device

On 2016-10-26 00:38, Chanwoo Choi wrote: This patch uses the resource-managed to add the devfreq device. This function will make it easy to handle the devfreq device. - struct devfreq *devm_devfreq_add_device(struct device *dev, struct devfreq_dev_profile

[PATCH] Avoid that SCSI device removal through sysfs triggers a deadlock

The solution I prefer is to modify the SCSI scanning code such that the scan_mutex is only held while performing the actual LUN scanning and while ensuring that no SCSI device has been created yet for a certain LUN number but not while the Linux device and its sysfs attributes are created. Since

Re: [PATCH] scsi_debug: Fix memory leak if LBP enabled and module is unloaded

- Original Message - > From: "Ewan D. Milne" > To: linux-scsi@vger.kernel.org > Sent: Wednesday, October 26, 2016 11:22:53 AM > Subject: [PATCH] scsi_debug: Fix memory leak if LBP enabled and module is > unloaded > > From: "Ewan D. Milne" > >

Re: [PATCH v2 04/10] phy: qcom-ufs-qmp-xx: Discard remove callback for drivers.

On Tuesday 18 October 2016 07:58 PM, Vivek Gautam wrote: > remove() callback does a phy_exit() only and nothing else now. remove callback calls a phy_power_off() ;-) -Kishon > The phy_exit() over the generic phy is called from the phy > consumer, and phy provider driver should not explicitly

[PATCH v2 01/11] mpt3sas: Fix for improper info displayed in var log, while blocking or unblocking the device.

Return value and Device_handle Arguments passed in correct order to match with its format string. Signed-off-by: Chaitra P B Signed-off-by: Sathya Prakash Signed-off-by: Suganath Prabu S

[PATCH v2 09/11] mpt3sas: Use the new MPI 2.6 32-bit Atomic Request Descriptors for SAS35 devices.

Support Atomic Request Descriptors for Ventura/SAS35 devices. Signed-off-by: Chaitra P B Signed-off-by: Sathya Prakash Signed-off-by: Suganath Prabu S Reviewed-by: Hannes Reinecke

[PATCH v2 11/11] mpt3sas: Bump driver version as "14.101.00.00"

Signed-off-by: Chaitra P B Signed-off-by: Sathya Prakash Signed-off-by: Suganath Prabu S --- drivers/scsi/mpt3sas/mpt3sas_base.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff

[PATCH v2 06/11] mpt3sas: Added Device ID's for SAS35 devices and updated MPI header.

Added Device ID's for SAS35 devices (Ventura, Crusader, Harpoon & Tomcat) and updated mpi header file for the same. Also added "is_gen35_ioc" to MPT3SAS_ADAPTER structure for identifying SAS35 adapters. Signed-off-by: Chaitra P B Signed-off-by: Sathya Prakash

[PATCH v2 08/11] mpt3sas: set EEDP-escape-flags for SAS35 devices.

An UNMAP command on a PI formatted device will leave the Logical Block Application Tag and Logical Block Reference Tag as all F's (for those LBAs that are unmapped). To avoid IO errors if those LBAs are subsequently read before they are written with valid tag fields, the MPI SCSI IO requests need

[PATCH v2 07/11] mpt3sas: Increased/Additional MSIX support for SAS35 devices.

For SAS35 devices MSIX vectors are inceased to 128 from 96. To support this Reply post host index register count is increased to 16. Also variable msix96_vector is replaced with combined_reply_queue and variable combined_reply_index_count is added to set different values for SAS3 and SAS35

[PATCH v2 00/11] mpt3sas driver Enhancements and

Here is the change list: Posting 11 patches for mpt3sas driver enhancements and few fixes. * Added Device ID's for SAS35 devices and updated MPI Header. * Support "EEDP Escape flag" for SAS35 devices. * fixed improper printk statement. * Regardless of whether RDPQ disabled card is

[PATCH v2 10/11] mpt3sas: Fix for Endianness issue.

Use le16_to_cpu only for accessing two byte data provided by controller. Signed-off-by: Chaitra P B Signed-off-by: Sathya Prakash Signed-off-by: Suganath Prabu S Reviewed-by: Hannes Reinecke

[PATCH v2 02/11] mpt3sas: Fix for incorrect numbers for MSIX vectors enabled when non RDPQ card is enumerated first.

No. of MSIX vectors supported = min (Total no. of CPU cores, MSIX vectors supported by card) when RDPQ is disabled "max_msix_vectors" module parameter which was declared as global was set to '8' and hence if there are more than one card in system among which if RDPQ disabled card is enumerated

RE: Crash in TCM-LIO

Hello Nicholas, -Original Message- From: Nicholas A. Bellinger [mailto:n...@linux-iscsi.org] Sent: 26 October 2016 11:49 To: Gurumurthy, Anil Cc: Anil Gurumurthy ; linux-scsi ; Malavali, Giridhar

[PATCH 2/2] scsi: ufs: Use the resource-managed function to add devfreq device

This patch uses the resource-managed to add the devfreq device. This function will make it easy to handle the devfreq device. - struct devfreq *devm_devfreq_add_device(struct device *dev, struct devfreq_dev_profile *profile,

[PATCH v2 04/11] mpt3sas: Removing unused macro "MPT_DEVICE_TLR_ON"

Removing macro "MPT_DEVICE_TLR_ON" defined in header file as its unused Signed-off-by: Chaitra P B Signed-off-by: Sathya Prakash Signed-off-by: Suganath Prabu S Reviewed-by: Hannes Reinecke

Re: Kernel 4.8.4: INFO: task kworker/u16:8:289 blocked for more than 120 seconds.

Hello TomK & Co, Comments below. On Tue, 2016-10-25 at 22:05 -0400, TomK wrote: > On 10/25/2016 1:28 AM, TomK wrote: > > On 10/24/2016 2:36 AM, Nicholas A. Bellinger wrote: > >> Hi TomK, > >> > >> Thanks for reporting this bug. Comments inline below. > >> > >> On Mon, 2016-10-24 at 00:45 -0400,

[PATCH v2 03/11] mpt3sas: Implement device_remove_in_progress check in IOCTL path

When device missing event arrives, device_remove_in_progress bit will be set and hence driver has to stop sending IOCTL commands.Now the check has been added in IOCTL path to test device_remove_in_progress bit is set, if so then IOCTL will be failed printing failure message. Signed-off-by:

[PATCH v2 05/11] mpt3sas: Bump driver version as "14.100.00.00"

Signed-off-by: Chaitra P B Signed-off-by: Sathya Prakash Signed-off-by: Suganath Prabu S --- drivers/scsi/mpt3sas/mpt3sas_base.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff

[PATCH 2/2] scsi: ufs: Use the resource-managed function to add devfreq device

This patch uses the resource-managed to add the devfreq device. This function will make it easy to handle the devfreq device. - struct devfreq *devm_devfreq_add_device(struct device *dev, struct devfreq_dev_profile *profile,

[Bug 121531] Adaptec 7805H SAS HBA (pm80xx): hangs when writing >80MB at once

https://bugzilla.kernel.org/show_bug.cgi?id=121531 Chloé Desoutter changed: What|Removed |Added Attachment #242701|0 |1 is

[Bug 121531] Adaptec 7805H SAS HBA (pm80xx): hangs when writing >80MB at once

https://bugzilla.kernel.org/show_bug.cgi?id=121531 --- Comment #20 from Chloé Desoutter --- Currently testing w/ PM8001_MPI_QUEUE = 256. Prospective patch attached. -- You are receiving this mail because: You are the assignee for the bug.-- To unsubscribe from this

Re: Kernel 4.8.4: INFO: task kworker/u16:8:289 blocked for more than 120 seconds.

On 10/26/2016 3:20 AM, Nicholas A. Bellinger wrote: Hello TomK & Co, Comments below. On Tue, 2016-10-25 at 22:05 -0400, TomK wrote: On 10/25/2016 1:28 AM, TomK wrote: On 10/24/2016 2:36 AM, Nicholas A. Bellinger wrote: Hi TomK, Thanks for reporting this bug. Comments inline below. On

[PATCH 4/4] hpsa: bump driver version

Reviewed-by: Scott Benesh Reviewed-by: Scott Teel Signed-off-by: Don Brace --- drivers/scsi/hpsa.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c

[PATCH 2/4] hpsa: add generate controller NMI on lockup

Tell the controller to NMI when the controller deadlocks. Reviewed-by: Scott Benesh Reviewed-by: Scott Teel Reviewed-by: Kevin Barnett Signed-off-by: Don Brace --- drivers/scsi/hpsa.c

[PATCH 3/4] hpsa: remove coalescing settings for ioaccel2

- Setting coalescing has a significant negative impact on low queue-depth performance. - Does not help high queue-depth performance. Reviewed-by: Scott Benesh Reviewed-by: Scott Teel Reviewed-by: Kevin Barnett

[PATCH 0/4] hpsa updates

These patches are based on Linus's tree The changes are: - do not call pci_disable_device on an already disabled device. - add a new lockup condition to lockup handler. - remove coalescing settings for ioaccel2 - update driver version. --- Don Brace (4): hpsa: correct lockup

[PATCH 1/4] hpsa: correct lockup detector pci_disable_device

need to check if the device is already disabled first Reviewed-by: Scott Benesh Reviewed-by: Scott Teel Signed-off-by: Don Brace --- drivers/scsi/hpsa.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)

Re: Device or HBA level QD throttling creates randomness in sequetial workload

On Tue, Oct 25, 2016 at 12:24:24AM +0530, Kashyap Desai wrote: > > -Original Message- > > From: Omar Sandoval [mailto:osan...@osandov.com] > > Sent: Monday, October 24, 2016 9:11 PM > > To: Kashyap Desai > > Cc: linux-scsi@vger.kernel.org; linux-ker...@vger.kernel.org; linux- > >

Re: [PATCH v3 1/2] scsi: Handle Unit Attention when issuing SCSI command

On 10/26/2016 11:15 AM, Bart Van Assche wrote: > On Wed, 2016-10-26 at 08:52 -0700, James Bottomley wrote: >> On Wed, 2016-10-26 at 08:42 -0700, Bart Van Assche wrote: >>> Can you elaborate on this? Since the sense buffer is available in >>> scsi_io_completion() and since that function already