[PATCH v5 3/6] g_NCR5380: Cleanup comments and whitespace

Signed-off-by: Finn Thain --- drivers/scsi/g_NCR5380.c | 61 ++-- 1 file changed, 28 insertions(+), 33 deletions(-) diff --git a/drivers/scsi/g_NCR5380.c b/drivers/scsi/g_NCR5380.c index 911a4300ea51..dedaed2d16e4 100644

[PATCH v5 5/6] g_NCR5380: Re-work PDMA loops

From: Ondrej Zary The polling loops in pread() and pwrite() can easily become infinite loops and hang the machine. On DTC chips, IRQ can arrive late and we miss it because we only check once. Merge the IRQ check into host buffer wait and add polling limit. Also

Re: [PATCH 3/3] cxlflash: Update debug prints in reset handlers

On 06/28/2017 07:14 PM, Matthew R. Ochs wrote: > The device and host reset handler contain debug prints to help > identify the entities being reset. Today these reset handlers > are based on a SCSI EH design that uses a SCSI command reference > as a means of identifying the target entity. As such,

Re: [PATCH 2/3] cxlflash: Update send_tmf() parameters

On 06/28/2017 07:14 PM, Matthew R. Ochs wrote: > The current send_tmf() implementation is based on the caller providing > a SCSI command reference. In reality all that is needed is a SCSI device > reference as the routine uses a private command. > > Refactor send_tmf() to pass the private adapter

Re: [PATCH 1/3] cxlflash: Avoid double free of character device

On 06/28/2017 07:14 PM, Matthew R. Ochs wrote: > The device_unregister() service used when cleaning up the character > device is already responsible for the internal state associated with > the device upon successful creation. As the cxlflash driver does not > obtain a second reference to the

Re: [PATCH 13/47] megaraid: pass in NULL scb for host reset

On 06/28/2017 07:40 PM, Kashyap Desai wrote: >> -Original Message- >> From: linux-scsi-ow...@vger.kernel.org [mailto:linux-scsi- >> ow...@vger.kernel.org] On Behalf Of Hannes Reinecke >> Sent: Wednesday, June 28, 2017 9:00 PM >> To: Sumit Saxena; Christoph Hellwig >> Cc: Martin K.

[PATCH] aic7xxx: fix firmware build with O=path

Building firmware with O=path was apparently broken in aic7 for ever. Message of the previous commit to the Makefile (from 2008) mentions this unfortunate state of affairs already. Fix this, mostly to make randconfig builds more reliable. Signed-off-by: Jakub Kicinski

Re: [PATCH v4 0/5] g_NCR5380: PDMA fixes and cleanup

On Wed, 28 Jun 2017, Ondrej Zary wrote: > > Now read seems to work on non-DTC chips. Writes continue in PDMA after > disconnect but there's a corruption - one 128 B block missing on > disconnect. > > On DTC, the log is spammed with errors like this: > sd 2:0:1:0: [sdb] tag#0

Re: [PATCH 0/5] target: Zoned block device support and bug fixes

On 6/28/17 23:34, Bryant G. Ly wrote: > >> This series introduce zoned block device support for the pscsi backstore and >> also fixes several problems with sense data handling for failed requests. >> >> The first patch is only a cleanup, so not really necessary but nice to have I >> think. >>

Re: [PATCH] scsi: ufs: check link active or not after switch to HS mode

On Wed, Jun 28, 2017 at 04:48:21PM -0700, Subhash Jadavani wrote: > On 2017-06-24 04:44, Zang Leigang wrote: > >Some device can successfully link and switch to HS mode. But failed > >to do more. ufshcd_verify_dev_init can help to find this earlier. > > > >Signed-off-by: Zang Leigang

Re: [PATCH] scsi: ufs: set host_byte to DID_REQUEUE when ocs = OCS_ABORTED

On Wed, Jun 28, 2017 at 04:42:36PM -0700, Subhash Jadavani wrote: > On 2017-06-24 03:27, Zang Leigang wrote: > >Host set ocs to OCS_ABORTED when clear a doorbell in err handler. > > OCS field is valid after host controller has cleared the > corresponding doorbell (UTRLDBR) bit to zero. And here

Re: [PATCH 4/5] target: user: Fix sense data handling

On 6/29/17 02:44, Mike Christie wrote: > On 06/28/2017 12:58 AM, Damien Le Moal wrote: >> If the user request handler completed the request with a CHECK CONDITION >> status, tcmu_handle_completion() copies the command entry sense data >> into the session request structure sense data. However, the

[PATCH v5 1/6] g_NCR5380: Fix PDMA transfer size

From: Ondrej Zary generic_NCR5380_dma_xfer_len() incorrectly uses cmd->transfersize which causes rescan-scsi-bus and CD-ROM access to hang the system. Use cmd->SCp.this_residual instead, like other NCR5380 drivers. Signed-off-by: Ondrej Zary

[PATCH v5 2/6] g_NCR5380: End PDMA transfer correctly on target disconnection

From: Ondrej Zary When an IRQ arrives during PDMA transfer, pread() and pwrite() return without waiting for the 53C80 registers to be ready and this ends up messing up the chip state. This was observed with SONY CDU-55S which is slow enough to disconnect during

[PATCH v5 0/6] g_NCR5380: PDMA fixes and cleanup

Ondrej, would you please test this new series? Changed since v1: - PDMA transfer residual is calculated earlier. - End of DMA flag check is now polled (if there is any residual). Changed since v2: - Bail out of transfer loops when Gated IRQ gets asserted. - Make udelay conditional on board type.

[PATCH v5 4/6] g_NCR5380: Limit PDMA send to 512 B to avoid data corruption on DTC3181E

From: Ondrej Zary The corruption is always the same: one byte missing at the beginning of a 128 B block. It happens only with slow Quantum LPS 240 drive, not with faster IBM DORS-32160. It's not clear what causes this. Documentation for the DTC436 chip has not been

[PATCH v5 6/6] g_NCR5380: Use unambiguous terminology for PDMA send and receive

The word "read" may be used to mean "DMA read operation" or "SCSI READ command", though a READ command implies writing to memory. Signed-off-by: Finn Thain --- drivers/scsi/g_NCR5380.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git

Re: [PATCH v2 1/6] qla2xxx: Add FC-NVMe port discovery and PRLI handling

On Wed, 2017-06-21 at 13:48 -0700, Madhani, Himanshu wrote: > From: Duane Grigsby > > Added logic to change the login process into an optional PRIL > step for FC-NVMe ports as a separate operation, such that we can > change type to 0x28 (NVMe). > > Currently, the

Re: [PATCH 13/47] megaraid: pass in NULL scb for host reset

On Wed, Jun 28, 2017 at 11:38:22AM -0700, adam radford wrote: > LSI/Broadcom isn't the maintainer of the 3ware drivers. See 'MAINTAINERS'. > Your attempts > to remove them may get a NACK from the Maintainer since I believe there are > still users of these controllers. Same for the legacy

Re: [PATCH] sd: add support for TCG OPAL self encrypting disks

On Mon, Jun 19, 2017 at 02:26:46PM +0200, Christoph Hellwig wrote: > Just wire up the generic TCG OPAL infrastructure to the SCSI disk driver > and the Security In/Out commands. > > Note that I don't know of any actual SCSI disks that do support TCG OPAL, > but this is required to support ATA

RE: [PATCH 04/47] aacraid: use aac_tmf_callback for reset fib

> > > When sending a reset fib we shouldn't rely on the scsi command, but rather set > the TMF status in the map_info->reset_state variable. > That allows us to send a TMF independent on a scsi command. > > Signed-off-by: Hannes Reinecke > --- > /* > * aac_eh_dev_reset

[PATCH] qla2xxx: Fix compile warning

Fixes following warning drivers/scsi/qla2xxx/qla_nvme.c: In function 'qla2x00_start_nvme_mq': include/uapi/linux/byteorder/big_endian.h:32:26: warning: large integer implicitly truncated to unsigned type [-Woverflow] #define __cpu_to_le32(x) ((__force __le32)__swab32((x))) Signed-off-by:

Re: [PATCH] qla2xxx: Fix compile warning

On Wed, 2017-06-28 at 15:00 -0700, Himanshu Madhani wrote: > Fixes following warning > > drivers/scsi/qla2xxx/qla_nvme.c: In function 'qla2x00_start_nvme_mq': > include/uapi/linux/byteorder/big_endian.h:32:26: warning: large > integer > implicitly truncated to unsigned type [-Woverflow] >  

Re: [PATCH] scsi: ufs: flush eh_work when eh_work scheduled.

On 2017-06-24 04:14, Zang Leigang wrote: Forget a condition: eh_work scheduled but do not start to work. Signed-off-by: Zang Leigang diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c index e050dcea1bea..a2dff12713fc 100644 ---

Re: [PATCH] scsi: ufs: check link active or not after switch to HS mode

On 2017-06-24 04:44, Zang Leigang wrote: Some device can successfully link and switch to HS mode. But failed to do more. ufshcd_verify_dev_init can help to find this earlier. Signed-off-by: Zang Leigang diff --git a/drivers/scsi/ufs/ufshcd.c

Re: [PATCH v2 1/6] qla2xxx: Add FC-NVMe port discovery and PRLI handling

Hi James, > On Jun 28, 2017, at 2:15 PM, James Bottomley > wrote: > > On Wed, 2017-06-21 at 13:48 -0700, Madhani, Himanshu wrote: >> From: Duane Grigsby >> >> Added logic to change the login process into an optional PRIL >>

Re: [PATCH v4 0/5] g_NCR5380: PDMA fixes and cleanup

On Wednesday 28 June 2017 06:04:36 Finn Thain wrote: > Ondrej, would you please test this new series? > > Changed since v1: > - PDMA transfer residual is calculated earlier. > - End of DMA flag check is now polled (if there is any residual). > > Changed since v2: > - Bail out of transfer loops

Re: [PATCH] qla2xxx: Fix compile warning

> On Jun 28, 2017, at 3:12 PM, James Bottomley > wrote: > > On Wed, 2017-06-28 at 15:00 -0700, Himanshu Madhani wrote: >> Fixes following warning >> >> drivers/scsi/qla2xxx/qla_nvme.c: In function 'qla2x00_start_nvme_mq': >>

Re: [PATCH] scsi: ufs: set host_byte to DID_REQUEUE when ocs = OCS_ABORTED

On 2017-06-24 03:27, Zang Leigang wrote: Host set ocs to OCS_ABORTED when clear a doorbell in err handler. OCS field is valid after host controller has cleared the corresponding doorbell (UTRLDBR) bit to zero. And here HW would be clearing the doorbell bit, not the SW. So I am not sure what

Re: [PATCH 03/47] aacraid: split off device, target, and bus reset

Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB

Re: [PATCH 05/47] aacraid: enable sending of TMFs from aac_hba_send()

Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB

Re: [PATCH 06/47] aacraid: add fib flag to mark scsi command callback

Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB

Re: [PATCH 08/47] sym53c8xx_2: split off bus reset from host reset

Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB

Re: [PATCH 11/47] snic: reserve tag for TMF

Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB

Re: [PATCH 07/47] aacraid: complete all commands during bus reset

Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB

Re: [PATCH 08/47] sym53c8xx_2: split off bus reset from host reset

Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB

Re: [PATCH 10/47] ips: Do not try to abort command from host reset

Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB

Re: [PATCH 12/47] qla1280: separate out host reset function from qla1280_error_action()

Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB

Re: [PATCH 13/47] megaraid: pass in NULL scb for host reset

Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB

Re: [PATCH 0/5] v3 block subsystem refcounter conversions

On 06/28/2017 05:58 AM, Reshetova, Elena wrote: > >> Subject: Re: [PATCH 0/5] v3 block subsystem refcounter conversions >> >> On Tue, Jun 27, 2017 at 6:26 AM, Jens Axboe wrote: >>> On 06/27/2017 05:39 AM, Elena Reshetova wrote: Changes in v3: No changes in patches

RE: [PATCH 0/5] v3 block subsystem refcounter conversions

> Subject: Re: [PATCH 0/5] v3 block subsystem refcounter conversions > > On Tue, Jun 27, 2017 at 6:26 AM, Jens Axboe wrote: > > On 06/27/2017 05:39 AM, Elena Reshetova wrote: > >> Changes in v3: > >> No changes in patches apart from trivial rebases, but now by > >> default

Re: [PATCH] scsi: hisi_sas: optimise DMA slot memory

On Wed, Jun 28, 2017 at 5:25 PM, John Garry wrote: > From: Xiaofei Tan > > Currently we allocate 3 sets of DMA memories from separate > pools for each slot. This is inefficient in terms of memory usage > (buffers are less than 1 page in size, so we

Re: [PATCH 19/28] qedf: drop bus reset handler

On Wed, 28 Jun 2017, 10:37am, Christoph Hellwig wrote: > > sg_reset / SG_SCSI_RESET are designed to escalatae to to the bigger > hammers if the method isn't implemented or doesn't succeed. > > Use the -N / --no-esc option to disable that. I wish that behavior had > been the default from the

[PATCH] scsi: hisi_sas: optimise DMA slot memory

From: Xiaofei Tan Currently we allocate 3 sets of DMA memories from separate pools for each slot. This is inefficient in terms of memory usage (buffers are less than 1 page in size, so we lose due to alignment), and also time spend in doing 3 allocations + de-allocations

Re: [PATCH 11/28] scsi: drop bus reset for wd33c93-compatible boards

On Wed, Jun 28, 2017 at 10:24:59AM +0200, Hannes Reinecke wrote: > The bus reset function is just a wrapper calling host reset > under the host lock. So move taking of the host lock into > the host reset function and drop bus reset. The changelog could be expanded a bit, especially about the

Re: [PATCH 20/28] nsp32: drop bus reset

On Wed, Jun 28, 2017 at 10:25:08AM +0200, Hannes Reinecke wrote: > From: Hannes Reinecke > > bus reset is essentially identical to host reset, and will always > return SUCCESS, thus disabling the use of host reset. > So drop bus reset in favour of host reset. > > Signed-off-by:

Re: [PATCH 24/28] megaraid_mbox: drop duplicate bus reset and device reset function

Looks good, Reviewed-by: Christoph Hellwig

Re: [PATCH 27/28] eata: remove 'arg_done' from eata2x_eh_host_reset()

Looks fine, Reviewed-by: Christoph Hellwig

Re: [PATCH RESEND] scsi: Add STARGET_CREATED_REMOVE state to scsi_target_state

[ removed cc: stable from discussion ] On Wed, 2017-06-28 at 09:38 +0200, Johannes Thumshirn wrote: > > Looks good, > Reviewed-by: Johannes Thumshirn > > Although we've been tampering with the target removal code for quite some > time now, so I really have the gut feeling

Re: [PATCH 18/28] ppa: drop duplicate bus_reset handler

On Wed, Jun 28, 2017 at 10:25:06AM +0200, Hannes Reinecke wrote: > bus_reset and host_reset are the same functions, so drop bus_reset. > > Signed-off-by: Hannes Reinecke Looks good, Reviewed-by: Christoph Hellwig

Re: [PATCH 17/28] imm: drop duplicate bus_reset handler

On Wed, Jun 28, 2017 at 10:25:05AM +0200, Hannes Reinecke wrote: > host_reset and bus_reset is the same function, so drop bus reset. > > Signed-off-by: Hannes Reinecke Looks good, Reviewed-by: Christoph Hellwig

Re: [PATCH 15/28] NCR5380: Move bus reset to host reset

Looks good, Reviewed-by: Christoph Hellwig

Re: [PATCH 21/28] aha152x: drop bus reset

On Wed, Jun 28, 2017 at 10:25:09AM +0200, Hannes Reinecke wrote: > From: Hannes Reinecke > > The bus reset function is a subset of host reset, but will always > return SUCCESS. But as the host reset also invokes a reset for > all ports there is a possibility that the bus reset

Re: [PATCH 00/47] SCSI EH argument reshuffle part II

On Wed, Jun 28, 2017 at 10:32:26AM +0200, Hannes Reinecke wrote: > Hi all, > finally here's the patchset to revamp the SCSI EH callback arguments > which I promised to do (some years ago ...). Still looks like a way to big series to review. Once we got the first part 1 it might make sense to

RE: [PATCH 13/47] megaraid: pass in NULL scb for host reset

>-Original Message- >From: linux-scsi-ow...@vger.kernel.org [mailto:linux-scsi- >ow...@vger.kernel.org] On Behalf Of Hannes Reinecke >Sent: Wednesday, June 28, 2017 2:03 PM >To: Christoph Hellwig >Cc: Martin K. Petersen; James Bottomley; linux-scsi@vger.kernel.org; Hannes >Reinecke; Hannes

Re: [PATCH 10/28] fdomain: move bus reset to host reset

Looks fine, Reviewed-by: Christoph Hellwig

Re: [PATCH 01/28] scsi: fix comment in scsi_device_set_state()

Looks fine, Reviewed-by: Christoph Hellwig On Wed, Jun 28, 2017 at 10:24:49AM +0200, Hannes Reinecke wrote: > The function returns '0' if successful; with the original comment > the function doesn't have a way to indicate success ... > > Signed-off-by: Hannes Reinecke

Re: [PATCH 19/28] qedf: drop bus reset handler

On Wed, Jun 28, 2017 at 10:25:07AM +0200, Hannes Reinecke wrote: > qedf has a host reset handler, but as the bus reset handler is > a stub always returning SUCCESS the host reset is never invoked. > So drop the bus reset handler. Given that comment this needs a lot more explanation, as the

Re: [PATCH 22/28] 53c700: move bus reset to host reset

On Wed, Jun 28, 2017 at 10:25:10AM +0200, Hannes Reinecke wrote: > bus reset always returns SUCCESS, meaning host reset was never > tested. At the same time the only difference to the HBA is a > missing call to NCR_700_chip_reset(). > So add the missing call to bus reset, drop host reset, and move

Re: [PATCH 19/28] qedf: drop bus reset handler

On Wed, 28 Jun 2017, 9:58am, Christoph Hellwig wrote: > On Wed, Jun 28, 2017 at 10:25:07AM +0200, Hannes Reinecke wrote: > > qedf has a host reset handler, but as the bus reset handler is > > a stub always returning SUCCESS the host reset is never invoked. > > So drop the bus reset handler. > >

Re: [PATCH 0/5] target: Zoned block device support and bug fixes

This series introduce zoned block device support for the pscsi backstore and also fixes several problems with sense data handling for failed requests. The first patch is only a cleanup, so not really necessary but nice to have I think. Patch 2 and 3 introduce support for host managed zoned

Re: [PATCH 19/28] qedf: drop bus reset handler

On Wed, Jun 28, 2017 at 10:07:50AM -0400, Chad Dupuis wrote: > The test case this was meant to fix as using the sg_reset utility with the > -b option which forces a bus reset with NPIV ports attached. What we were > finding is that some of the devices attached to the vport were being > brought

[PATCH 0/3] cxlflash: Minor fix and EH refactoring

This small series fixes a recently injected double free and also includes two patches to refactor the host and reset handlers to ease the burden of making this driver compatible with an updated SCSI EH framework. This series is intended for 4.13 and is bisectable. Matthew R. Ochs (3):

[PATCH 3/3] cxlflash: Update debug prints in reset handlers

The device and host reset handler contain debug prints to help identify the entities being reset. Today these reset handlers are based on a SCSI EH design that uses a SCSI command reference as a means of identifying the target entity. As such, the debug trace includes the SCSI command pointer and

[PATCH 2/3] cxlflash: Update send_tmf() parameters

The current send_tmf() implementation is based on the caller providing a SCSI command reference. In reality all that is needed is a SCSI device reference as the routine uses a private command. Refactor send_tmf() to pass the private adapter configuration reference and a SCSI device reference. As

[PATCH 1/3] cxlflash: Avoid double free of character device

The device_unregister() service used when cleaning up the character device is already responsible for the internal state associated with the device upon successful creation. As the cxlflash driver does not obtain a second reference to the character device, the explicit call to put_device() is not

Re: [PATCH 33/47] cxlflash: use dedicated reset command in send_tmf()

Hi Hannes, We actually just reworked these paths in a series that was pulled in on Monday. While testing, I came across a bug in that series and was planning on sending out a fix for it. I'll include some patches that will ease the burden of incorporating your EH updates for cxlflash. Many

Re: [PATCH v2] qla2xxx: Protect access to qpair members with qpair->qp_lock

> On Jun 23, 2017, at 12:10 AM, Johannes Thumshirn wrote: > > In qla2xx_start_scsi_mq() and qla2xx_dif_start_scsi_mq() we grab the > qpair->qp_lock but do access members of the qpair before having the lock. > Re-order the locking sequence to have all read and write access to

Re: [PATCH 13/47] megaraid: pass in NULL scb for host reset

On 06/28/2017 03:41 PM, Sumit Saxena wrote: >> -Original Message- >> From: linux-scsi-ow...@vger.kernel.org [mailto:linux-scsi- >> ow...@vger.kernel.org] On Behalf Of Hannes Reinecke >> Sent: Wednesday, June 28, 2017 2:03 PM >> To: Christoph Hellwig >> Cc: Martin K. Petersen; James

RE: [PATCH 13/47] megaraid: pass in NULL scb for host reset

> -Original Message- > From: linux-scsi-ow...@vger.kernel.org [mailto:linux-scsi- > ow...@vger.kernel.org] On Behalf Of Hannes Reinecke > Sent: Wednesday, June 28, 2017 9:00 PM > To: Sumit Saxena; Christoph Hellwig > Cc: Martin K. Petersen; James Bottomley; linux-scsi@vger.kernel.org; >

Re: [PATCH 4/5] target: user: Fix sense data handling

On 06/28/2017 12:58 AM, Damien Le Moal wrote: > If the user request handler completed the request with a CHECK CONDITION > status, tcmu_handle_completion() copies the command entry sense data > into the session request structure sense data. However, the sense data > length indicated by the field

Re: [PATCH 5/5] target: core: Fix failed command sense data handling

On 06/28/2017 12:59 AM, Damien Le Moal wrote: > For a target device without a transport->transport_complete method > defined (e.g. target_core_user), target_complete_cmd() will always > result in a failed command completion being processed through target > failure completion work even when the

Re: [PATCH 03/28] ibmvfc: Do not call fc_block_scsi_eh() on host reset

Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB

Re: [PATCH 02/28] mptfc: Do not call fc_block_scsi_eh() on host reset

Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB

Re: [PATCH 01/28] scsi: fix comment in scsi_device_set_state()

Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB

Re: [PATCH 08/28] bfa: move bus reset to target reset

Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB

Re: [PATCH 13/28] qlogicpti: move bus reset to host reset

Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB

Re: [PATCH 14/28] acornscsi: move bus reset to host reset

Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB

Re: [PATCH 20/28] nsp32: drop bus reset

Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB

Re: [PATCH 27/28] eata: remove 'arg_done' from eata2x_eh_host_reset()

Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB

Re: [PATCH 28/28] NCR5380: Clear all unissued commands on host reset

Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB

Re: [PATCH 01/47] aacraid: split off functions to generate reset FIB

Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB

[PATCH 05/28] fnic: do not call host reset from command abort

command abort already returns FAILED, which will then be escalated to a host reset. So no need to call host_reset directly. Signed-off-by: Hannes Reinecke Reviewed-by: Christoph Hellwig --- drivers/scsi/fnic/fnic_scsi.c | 4 1 file changed, 4 deletions(-) diff

[PATCH 17/28] imm: drop duplicate bus_reset handler

host_reset and bus_reset is the same function, so drop bus reset. Signed-off-by: Hannes Reinecke --- drivers/scsi/imm.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/scsi/imm.c b/drivers/scsi/imm.c index 9164ce12..87c9419 100644 --- a/drivers/scsi/imm.c +++

[PATCH 12/28] rtsx: drop bus reset function

Function is a stub, so can as well be dropped. Signed-off-by: Hannes Reinecke Reviewed-by: Christoph Hellwig --- drivers/staging/rts5208/rtsx.c | 11 --- 1 file changed, 11 deletions(-) diff --git a/drivers/staging/rts5208/rtsx.c

[PATCH 06/28] uas: move eh_bus_reset_handler to eh_device_reset_handler

The bus_reset handler is really a device reset, so move it to eh_device_reset_handler(). Signed-off-by: Hannes Reinecke Reviewed-by: Christoph Hellwig --- drivers/usb/storage/uas.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH 03/28] ibmvfc: Do not call fc_block_scsi_eh() on host reset

When we're resetting the host any remote port states will be reset anyway, so it's pointless to wait for dev_loss_tmo during host reset. Signed-off-by: Hannes Reinecke Reviewed-by: Christoph Hellwig --- drivers/scsi/ibmvscsi/ibmvfc.c | 6 +- 1 file changed, 1

[PATCH 16/28] qlogicfas: move bus_reset to host_reset

From: Hannes Reinecke The bus reset handler is really a host reset. Signed-off-by: Hannes Reinecke Reviewed-by: Christoph Hellwig --- drivers/scsi/pcmcia/qlogic_stub.c | 4 ++-- drivers/scsi/qlogicfas.c | 2 +- drivers/scsi/qlogicfas408.c

[PATCH 10/28] fdomain: move bus reset to host reset

The bus reset function really is a host reset, so move it to eh_host_reset_handler(). Signed-off-by: Hannes Reinecke --- drivers/scsi/fdomain.c | 6 +++--- drivers/scsi/fdomain.h | 2 +- drivers/scsi/pcmcia/fdomain_stub.c | 2 +- 3 files changed, 5

[PATCH 21/28] aha152x: drop bus reset

From: Hannes Reinecke The bus reset function is a subset of host reset, but will always return SUCCESS. But as the host reset also invokes a reset for all ports there is a possibility that the bus reset will not be able to fully reset the HBA, leading to a blocked system. So drop

[PATCH 08/28] bfa: move bus reset to target reset

The bus reset handler is just calling target reset on all targets, which is exactly what SCSI EH will be doing anyway. So move the bus reset function to target reset and drop the loop. Signed-off-by: Hannes Reinecke Reviewed-by: Christoph Hellwig ---

[PATCH 07/28] libsas: move bus_reset_handler() to target_reset_handler()

The bus reset handler is calling I_T Nexus reset, which logically is a target reset as it need to specify both the initiator and the target. So move it to target reset. Signed-off-by: Hannes Reinecke Reviewed-by: Christoph Hellwig ---

[PATCH 22/28] 53c700: move bus reset to host reset

bus reset always returns SUCCESS, meaning host reset was never tested. At the same time the only difference to the HBA is a missing call to NCR_700_chip_reset(). So add the missing call to bus reset, drop host reset, and move bus reset to host reset. Signed-off-by: Hannes Reinecke

[PATCH 15/28] NCR5380: Move bus reset to host reset

The bus reset handler really is a host reset, so move it to eh_bus_reset_handler. Signed-off-by: Hannes Reinecke Acked-by: Finn Thain --- drivers/scsi/NCR5380.c | 4 ++-- drivers/scsi/arm/cumana_1.c | 2 +- drivers/scsi/arm/oak.c | 2 +-

[PATCH 09/28] hptiop: Simplify reset handling

The Highpoint driver only has one reset function, and that is a host reset. So stop pretending we're doing anything else. Signed-off-by: Hannes Reinecke Reviewed-by: Christoph Hellwig --- drivers/scsi/hptiop.c | 11 --- 1 file changed, 4 insertions(+), 7

[PATCH 43/47] fas216: Rework device reset to not rely on SCSI command pointer

The device reset code should not rely on the SCSI command pointer; it will be going away with the device reset handler rework. Signed-off-by: Hannes Reinecke --- drivers/scsi/arm/fas216.c | 51 +++ 1 file changed, 25 insertions(+), 26

[PATCH 46/47] scsi: Move eh_device_reset_handler() to use scsi_device as argument

When resetting a device we shouldn't depend on an existing SCSI device, so use 'struct scsi_device' as argument for eh_device_reset_handler(). Signed-off-by: Hannes Reinecke --- Documentation/scsi/scsi_eh.txt | 2 +- Documentation/scsi/scsi_mid_low_api.txt

[PATCH 44/47] csiostor: use separate TMF command

Set one command aside as a TMF command, and use this command to send the TMF. This avoids having to rely on the passed-in scsi command when resetting the device. Signed-off-by: Hannes Reinecke --- drivers/scsi/csiostor/csio_hw.h | 2 ++ drivers/scsi/csiostor/csio_init.c | 2

[PATCH 42/47] xen-scsifront: call scsifront_action_handler() with a NULL command argument

For device reset we shouldn't rely on the scsi command, so allow scsifront_action_handler() to be called with a NULL command argument. Signed-off-by: Hannes Reinecke --- drivers/scsi/xen-scsifront.c | 20 +--- 1 file changed, 13 insertions(+), 7 deletions(-) diff

[PATCH 45/47] snic: use dedicated device reset command

Use a dedicated command to send a device reset instead of relying on using the command which triggered the device failure. Signed-off-by: Hannes Reinecke --- drivers/scsi/snic/snic_scsi.c | 52 --- 1 file changed, 24 insertions(+), 28

  1   2   >