Re: [PATCH 03/14] blk-mq: introduce blk_mq_dispatch_rq_from_ctxs()

On Mon, Jul 31, 2017 at 11:09:38PM +, Bart Van Assche wrote: > On Tue, 2017-08-01 at 00:51 +0800, Ming Lei wrote: > > @@ -810,7 +810,11 @@ static void blk_mq_timeout_work(struct work_struct > > *work) > > > > struct ctx_iter_data { > > struct blk_mq_hw_ctx *hctx; > > - struct

[PATCH 1/2] block: Zoned block device single-threaded submission

From: Hannes Reinecke The scsi_request_fn() dispatch function internally unlocks the request queue before submitting a request to the underlying LLD. This can potentially lead to write request reordering if the context executing scsi_request_fn() is preempted before the request is

[PATCH 2/2] sd_zbc: Disable zone locking with scsi-mq enabled

Unlike the legacy blk-sq infrastructure, blk-mq cannot provide any sort of guarantees to well behaved users regarding write command ordering for zoned block devices. This is due to the lockless manipulation of the dispatch queue as well as the use of different work queues for requeuing requests

[PATCH 0/2] Zoned block device support fixes

This small series addresses a couple of problems detected with 4.13-rc. The first patch ensures that a well behaved host managed zoned block device user (an application doing direct disk accesses, f2fs or dm-zoned) will not see unaligned write errors due to reordering of write commands at

Re: [PATCH] tcmu: Oops in unmap_thread_fn()

On 2017年08月02日 04:09, Dan Carpenter wrote: Calling list_del() on the iterator pointer in list_for_each_entry() will cause an oops. We need to user the _safe() version for that. Fixes: c73d02f63c16 ("tcmu: Add fifo type waiter list support to avoid starvation") Signed-off-by: Dan Carpenter

[Bug 196543] Adaptec 6405H can not understand Queue full message from Disks.

https://bugzilla.kernel.org/show_bug.cgi?id=196543 --- Comment #2 from Kazufumi Watanabe (kiyomi.kakitsub...@gmail.com) --- Dear James Thank you for your message. I want give you result of sas bus trace, but company do not give me grant permission of take data outside. I think sorry to you not

Re: [PATCH 05/14] blk-mq-sched: don't dequeue request until all in ->dispatch are flushed

On Tue, Aug 01, 2017 at 04:14:07PM +, Bart Van Assche wrote: > On Tue, 2017-08-01 at 18:44 +0800, Ming Lei wrote: > > On Mon, Jul 31, 2017 at 11:42:21PM +, Bart Van Assche wrote: > > > Since setting, clearing and testing of BLK_MQ_S_BUSY can happen > > > concurrently > > > and since

Re: [PATCH 04/14] blk-mq-sched: improve dispatching from sw queue

On Tue, Aug 01, 2017 at 03:11:42PM +, Bart Van Assche wrote: > On Tue, 2017-08-01 at 18:50 +0800, Ming Lei wrote: > > On Tue, Aug 01, 2017 at 06:17:18PM +0800, Ming Lei wrote: > > > How can we get the accurate 'number of requests in progress' efficiently? > > Hello Ming, > > How about

[no subject]

внимания; Ваши сообщения превысил лимит памяти, который составляет 5 Гб, определенных администратором, который в настоящее время работает на 10.9GB, Вы не сможете отправить или получить новую почту, пока вы повторно не проверить ваш почтовый ящик почты. Чтобы восстановить работоспособность

[PATCH] tcmu: Oops in unmap_thread_fn()

Calling list_del() on the iterator pointer in list_for_each_entry() will cause an oops. We need to user the _safe() version for that. Fixes: c73d02f63c16 ("tcmu: Add fifo type waiter list support to avoid starvation") Signed-off-by: Dan Carpenter diff --git

Re: [PATCH] st: fix blk_get_queue usage

> On 1 Aug 2017, at 15.42, Hannes Reinecke wrote: > > From: Bodo Stroesser > > If blk_queue_get() in st_probe fails, disk->queue must not > be set to SDp->request_queue, as that would result in > put_disk() dropping a not taken reference. > > Thus,

[PATCH 0/2] nvmet_fc: work around overalloc of queue elements

At queue creation, the transport allocates a local job struct (struct nvmet_fc_fcp_iod) for each possible element of the queue. When a new CMD is received from the wire, a jobs struct is allocated from the queue and then used for the duration of the command. The job struct contains buffer space

[PATCH 1/2] nvmet_fc: add defer_req callback for deferment of cmd buffer return

At queue creation, the transport allocates a local job struct (struct nvmet_fc_fcp_iod) for each possible element of the queue. When a new CMD is received from the wire, a jobs struct is allocated from the queue and then used for the duration of the command. The job struct contains buffer space

[PATCH 2/2] lpfc: support nvmet_fc defer_rcv callback

Currently, calls to nvmet_fc_rcv_fcp_req() always copied the FC-NVME cmd iu to a temporary buffer before returning, allowing the driver to immediately repost the buffer to the hardware. To address timing conditions on queue element structures vs async command reception, the nvmet_fc transport

Re: [PATCH 04/14] blk-mq-sched: improve dispatching from sw queue

On Mon, Jul 31, 2017 at 11:34:35PM +, Bart Van Assche wrote: > On Tue, 2017-08-01 at 00:51 +0800, Ming Lei wrote: > > SCSI devices use host-wide tagset, and the shared > > driver tag space is often quite big. Meantime > > there is also queue depth for each lun(.cmd_per_lun), > > which is often

Re: [PATCH 04/14] blk-mq-sched: improve dispatching from sw queue

On Tue, 2017-08-01 at 18:50 +0800, Ming Lei wrote: > On Tue, Aug 01, 2017 at 06:17:18PM +0800, Ming Lei wrote: > > How can we get the accurate 'number of requests in progress' efficiently? Hello Ming, How about counting the number of bits that have been set in the tag set? I am aware that these

[PATCH] ipr: Fix scsi-mq lockdep issue

Fixes the following lockdep warning that can occur when scsi-mq is enabled with ipr due to ipr calling scsi_unblock_requests from irq context. The fix is to move the call to scsi_unblock_requests to ipr's existing workqueue. stack backtrace: CPU: 28 PID: 0 Comm: swapper/28 Not tainted

RE: [PATCH v2 11/15] megaraid_sas: Set device queue_depth same as HBA can_queue value in scsi-mq mode

> -Original Message- > From: Shivasharan Srikanteshwara > [mailto:shivasharan.srikanteshw...@broadcom.com] > Sent: Monday, July 24, 2017 4:59 PM > To: 'Christoph Hellwig' > Cc: 'linux-scsi@vger.kernel.org'; 'martin.peter...@oracle.com'; > 'the...@redhat.com'; 'j...@linux.vnet.ibm.com';

[PATCH] arcmsr: add const to bin_attribute structures

Add const to bin_attribute structures as they are only passed to the functions system_{remove/create}_bin_file. The arguments passed are of type const, so declare the structures to be const. Done using Coccinelle. Signed-off-by: Bhumika Goyal ---

Re: [PATCH 2/2] sd_zbc: Disable zone locking with scsi-mq enabled

On Tue, 2017-08-01 at 18:39 +0900, Damien Le Moal wrote: > diff --git a/drivers/scsi/sd_zbc.c b/drivers/scsi/sd_zbc.c > index 96855df9f49d..78fb51a37e86 100644 > --- a/drivers/scsi/sd_zbc.c > +++ b/drivers/scsi/sd_zbc.c > @@ -528,15 +528,20 @@ static int sd_zbc_check_zone_size(struct scsi_disk >

Re: [PATCH 04/14] blk-mq-sched: improve dispatching from sw queue

On Tue, Aug 01, 2017 at 06:17:18PM +0800, Ming Lei wrote: > On Mon, Jul 31, 2017 at 11:34:35PM +, Bart Van Assche wrote: > > On Tue, 2017-08-01 at 00:51 +0800, Ming Lei wrote: > > > SCSI devices use host-wide tagset, and the shared > > > driver tag space is often quite big. Meantime > > >

Re: [PATCH 05/14] blk-mq-sched: don't dequeue request until all in ->dispatch are flushed

On Mon, Jul 31, 2017 at 11:42:21PM +, Bart Van Assche wrote: > On Tue, 2017-08-01 at 00:51 +0800, Ming Lei wrote: > > During dispatch, we moved all requests from hctx->dispatch to > > one temporary list, then dispatch them one by one from this list. > > Unfortunately duirng this period, run

[PATCH] st: fix blk_get_queue usage

From: Bodo Stroesser If blk_queue_get() in st_probe fails, disk->queue must not be set to SDp->request_queue, as that would result in put_disk() dropping a not taken reference. Thus, disk->queue should be set only after a successful blk_queue_get(). Signed-off-by:

Re: [PATCH] st: fix blk_get_queue usage

On Tue, 2017-08-01 at 14:42 +0200, Hannes Reinecke wrote: > From: Bodo Stroesser > > If blk_queue_get() in st_probe fails, disk->queue must not > be set to SDp->request_queue, as that would result in > put_disk() dropping a not taken reference. > > Thus, disk->queue

Re: [RFC 2/9] zfcp: decouple TMF response handler from scsi_cmnd

Just for the records, in case anyone wants to resurrect this later on: This patch is buggy. On 07/25/2017 04:14 PM, Steffen Maier wrote: Do not get scsi_device via req->data any more, but pass an optional(!) scsi_device to zfcp_fsf_fcp_handler_common(). The latter must now guard any access to

Re: [PATCH 05/14] blk-mq-sched: don't dequeue request until all in ->dispatch are flushed

On Tue, 2017-08-01 at 18:44 +0800, Ming Lei wrote: > On Mon, Jul 31, 2017 at 11:42:21PM +, Bart Van Assche wrote: > > Since setting, clearing and testing of BLK_MQ_S_BUSY can happen concurrently > > and since clearing and testing happens without any locks held I'm afraid > > this > > patch

[PATCH] ses: Fix wrong page error

If a SES device returns an error on a requested diagnostic page, we are currently printing an error indicating the wrong page was received. Fix this up to simply return a failure and only check the returned page when the diagnostic page buffer was populated by the device. Signed-off-by: Brian