Re: Seagate External SMR drive USB resets (was: Re: [PATCH] uas: Add US_FL_NO_ATA_1X quirk for one more Seagate device)

2017-11-15 Thread Alan Stern
On Wed, 15 Nov 2017, Jérôme Carretero wrote: > (Adding Tejun Heo who was assigned on still-open bugzilla #93581 which > is about SATA but seems terribly related.) > > On Wed, 15 Nov 2017 16:43:14 -0500 > Jérôme Carretero wrote: > > > Hi Hans, > > > > > > Tests are

Re: Seagate External SMR drive USB resets (was: Re: [PATCH] uas: Add US_FL_NO_ATA_1X quirk for one more Seagate device)

2017-11-15 Thread James Bottomley
On Wed, 2017-11-15 at 17:02 -0500, Alan Stern wrote: > On Wed, 15 Nov 2017, Jérôme Carretero wrote: > > >   Because with several of these drives / lots of activity / > occasional > > >   issues, it looks like it will be hard to catch (yes I can use > > > usbmon). > > >  > > > - It looks like there

Seagate External SMR drive USB resets (was: Re: [PATCH] uas: Add US_FL_NO_ATA_1X quirk for one more Seagate device)

2017-11-15 Thread Jérôme Carretero
Hi Hans, Tests are currently undergoing with drives operating in plain USB mass storage class. In a first time, I'm filling drives with data (uncontrolled corpus, just TBs that I have on hand). It looks like the drives with most usage history are the ones that drop most often. kernel: usb

Re: Seagate External SMR drive USB resets (was: Re: [PATCH] uas: Add US_FL_NO_ATA_1X quirk for one more Seagate device)

2017-11-15 Thread Jérôme Carretero
Hi, On Thu, 16 Nov 2017 07:40:08 +0900 James Bottomley wrote: > On Wed, 2017-11-15 at 17:02 -0500, Alan Stern wrote: > > On Wed, 15 Nov 2017, Jérôme Carretero wrote: > > > >   Because with several of these drives / lots of activity / > > occasional

Re: Seagate External SMR drive USB resets (was: Re: [PATCH] uas: Add US_FL_NO_ATA_1X quirk for one more Seagate device)

2017-11-15 Thread Jérôme Carretero
(Adding Tejun Heo who was assigned on still-open bugzilla #93581 which is about SATA but seems terribly related.) On Wed, 15 Nov 2017 16:43:14 -0500 Jérôme Carretero wrote: > Hi Hans, > > > Tests are currently undergoing with drives operating in plain USB mass > storage

Re: [PATCH] uas: Add US_FL_NO_ATA_1X quirk for one more Seagate device

2017-11-15 Thread Hans de Goede
Hi, On 15-11-17 10:06, Oliver Neukum wrote: Am Dienstag, den 14.11.2017, 18:44 +0100 schrieb Hans de Goede: Greg, please do no merge the 2 recent uas seagate quirks I send then. I will submit a patch with the new approach right away. Hi, I am afraid in that case we will need a way to

Re: [PATCH] uas: Add US_FL_NO_ATA_1X quirk for one more Seagate device

2017-11-15 Thread Oliver Neukum
Am Dienstag, den 14.11.2017, 18:44 +0100 schrieb Hans de Goede: > > Greg, please do no merge the 2 recent uas seagate quirks I send > then. I will submit a patch with the new approach right away. Hi, I am afraid in that case we will need a way to override a quirk in the other direction, that

Re: [GIT PULL] first round of SCSI updates for the 4.14+ merge window

2017-11-15 Thread James Bottomley
On Tue, 2017-11-14 at 16:33 -0800, Linus Torvalds wrote: > On Tue, Nov 14, 2017 at 8:36 AM, James Bottomley > wrote: > > > > > > Hannes Reinecke (14): > >   scsi: scsi_devinfo: Reformat blacklist flags > > Ugh, that's just really ugly, but it's also

mvsas sata drives with high ioerr_cnt and long stalls

2017-11-15 Thread Larkin Lowrey
Hello, I'm looking for some help to diagnose write stalls for sata drives connected to Highpoint controllers running the mvsas driver. I'm seeing writes stall for several seconds at a time for md raid arrays using Highpoint 2740 and 2720sgl controllers running in JBOD mode (mvsas driver). I'm

[bug report] A race between device_resume and removing disk

2017-11-15 Thread chenxiang (M)
Hi all, When debugging suspend and resume of hisi_sas, I find a issue: use commands (echo freeze > /sys/power/state) to suspend, after 5s system will be resumed as i enable TEST_DEVICES. But if I plug one disks during suspend, system will be blocked all the time and it seems that there is a

Re: Seagate External SMR drive USB resets... why? / USB storage debugging

2017-11-15 Thread Bart Van Assche
On Wed, 2017-11-15 at 18:27 -0500, Jérôme Carretero wrote: > OK but I find that a "reset" message without any reason is not > as helpful as it could have been. At the minimum I'll try to scratch my > own itch and see if I can go at the bottom of my issue. If you want more information about SCSI

Re: [PATCH 3/3] Introduce a type for device information flags, namely bflags_t

2017-11-15 Thread Martin K. Petersen
Bart, > +typedef __u32 __bitwise bflags_t; Since we're already out of flags, let's not perpetuate the u32 limitation. -- Martin K. Petersen Oracle Linux Engineering

Re: Seagate External SMR drive USB resets (XHCI transfer error, not timeout)

2017-11-15 Thread Jérôme Carretero
Hi, On Wed, 15 Nov 2017 18:17:08 -0500 Jérôme Carretero wrote: > Hi, > > > On Thu, 16 Nov 2017 07:40:08 +0900 > James Bottomley wrote: > > > On Wed, 2017-11-15 at 17:02 -0500, Alan Stern wrote: > > > On Wed, 15 Nov 2017, Jérôme

[PATCH] scsi_debug: add cdb_len parameter

2017-11-15 Thread Douglas Gilbert
While testing "sd: Micro-optimize READ / WRITE CDB encoding" patches it was helpful to check various code paths associated with READ/WRITE 6, 10 and 16 byte cdb variants. There seems to be no user space "knobs" to twiddle use_10_for_rw and friends in the scsi_device structure. So add a parameter

Re: [PATCH 1/3] device information: Do not interpret error codes as flags

2017-11-15 Thread Martin K. Petersen
Hi Bart, > This patch also avoids that error codes returned by > scsi_get_device_flags_keyed() are interpret as device flags. Nobody expects this and scsi_get_device_flags() to ever return an error. So I'd rather have the != -ENOENT case fixed up to return 0. -- Martin K. Petersen Oracle

Re: [PATCH] scsi: Use 'blist_flags_t' for scsi_devinfo flags

2017-11-15 Thread Martin K. Petersen
Hi Hannes, > As per recommendation from Linus we should be using a distinct > type for blacklist flags. > -#define BLIST_MAX_1024 ((__force __u32 __bitwise)(1 << 30)) > +#define BLIST_MAX_1024 ((__force blist_flags_t)(1 << 30)) You are missing: /* Use UNMAP limit

[PATCH] scsi: Use 'blist_flags_t' for scsi_devinfo flags

2017-11-15 Thread Hannes Reinecke
As per recommendation from Linus we should be using a distinct type for blacklist flags. Signed-off-by: Hannes Reinecke --- drivers/scsi/scsi_devinfo.c | 18 - drivers/scsi/scsi_priv.h| 15 +++--- drivers/scsi/scsi_scan.c| 2 +-

Hello Dear...

2017-11-15 Thread M,Shakour Rosarita
Hello Dear... I know that this message will come to you as a surprise. I hoped that you will not expose or betray this trust and confident that I am about to repose on you, my name is M, Shakour Rosarita. I am 19 years old Girl, female, from Tartu Syria, (never married) 61 kg, white in

Re: [PATCH V4] scsi_debugfs: fix crash in scsi_show_rq()

2017-11-15 Thread James Bottomley
On Wed, 2017-11-15 at 18:09 +0800, Ming Lei wrote: > On Tue, Nov 14, 2017 at 10:14:52AM -0800, James Bottomley wrote: > > > > On Tue, 2017-11-14 at 08:55 +0800, Ming Lei wrote: > > > > > > Hi James, > > > > > > On Mon, Nov 13, 2017 at 10:55:52AM -0800, James Bottomley wrote: > > > > > > > > >

Re: [PATCH V4] scsi_debugfs: fix crash in scsi_show_rq()

2017-11-15 Thread Ming Lei
On Tue, Nov 14, 2017 at 10:14:52AM -0800, James Bottomley wrote: > On Tue, 2017-11-14 at 08:55 +0800, Ming Lei wrote: > > Hi James, > > > > On Mon, Nov 13, 2017 at 10:55:52AM -0800, James Bottomley wrote: > > > > > > On Sat, 2017-11-11 at 10:43 +0800, Ming Lei wrote: > > > > > > > > So from

[Bug 197877] arcmsr fails to initialize Areca ARC-1110/ARC-1120 on some systems

2017-11-15 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=197877 --- Comment #3 from k...@sognnes.no --- Created attachment 260681 --> https://bugzilla.kernel.org/attachment.cgi?id=260681=edit Output from lspci -vvv -- You are receiving this mail because: You are watching the assignee of the bug.

[Bug 197877] arcmsr fails to initialize Areca ARC-1110/ARC-1120 on some systems

2017-11-15 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=197877 --- Comment #2 from k...@sognnes.no --- Created attachment 260679 --> https://bugzilla.kernel.org/attachment.cgi?id=260679=edit Full dmesg log (kernel 4.14) -- You are receiving this mail because: You are watching the assignee of the bug.

[Bug 197877] arcmsr fails to initialize Areca ARC-1110/ARC-1120 on some systems

2017-11-15 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=197877 --- Comment #1 from k...@sognnes.no --- Created attachment 260677 --> https://bugzilla.kernel.org/attachment.cgi?id=260677=edit .config for 4.14 -- You are receiving this mail because: You are watching the assignee of the bug.

[PATCH] bnx2fc: Fix hung task messages when a cleanup response is not received during abort.

2017-11-15 Thread Chad Dupuis
If a cleanup task is not responded to while we are in bnx2fc_abts_cleanup, it will hang the SCSI error handler since we use wait_for_completion instead of wait_for_completion_timeout. So, use wait_for_completion_timeout so that we don't hang the SCSI error handler thread forever. Fixes the call

Re: [PATCH] bnx2fc: Fix hung task messages when a cleanup response is not received during abort.

2017-11-15 Thread Laurence Oberman
On Wed, 2017-11-15 at 07:06 -0800, Chad Dupuis wrote: > If a cleanup task is not responded to while we are in > bnx2fc_abts_cleanup, it > will hang the SCSI error handler since we use wait_for_completion > instead of > wait_for_completion_timeout.  So, use wait_for_completion_timeout so > that we

Re: [PATCH] scsi: Use 'blist_flags_t' for scsi_devinfo flags

2017-11-15 Thread Bart Van Assche
On Wed, 2017-11-15 at 12:07 +0100, Hannes Reinecke wrote: > As per recommendation from Linus we should be using a distinct > type for blacklist flags. Hello Hannes, Have you noticed that this patch is a subset of the patch series I posted yesterday

[PATCH] scsi: aacraid: remove unused variable managed_request_id

2017-11-15 Thread Colin King
From: Colin Ian King Variable managed_request_id is being assigned but it is never read, hence it is redundant and can be removed. Cleans up clang warning: drivers/scsi/aacraid/linit.c:706:5: warning: Value stored to 'managed_request_id' is never read Signed-off-by:

[PATCH] bfa: remove unused pointer 'port'

2017-11-15 Thread Colin King
From: Colin Ian King The pointer 'port' is being assigned but it is never read, hence it is redundant and can be removed. Cleans up clang warning: drivers/scsi/bfa/bfad_attr.c:505:2: warning: Value stored to 'port' is never read Signed-off-by: Colin Ian King