Re: [PATCH for sg3_utils 0/4] Simplify the sg3_utils configure script

On 2018-01-03 04:37 AM, Bean Huo (beanhuo) wrote: Hi, Bart and Dong Do you think we need to submit all changed diff including some generated files by automake? Such as config.h.in, Makefile.in..., in fact, we only manually did a few modificaiton on Some files such as configura.ac,makefile.am.

[PATCH] aacraid driver oops with dead battery

The battery in my HP NetRAID-4M died of old age, and the aacraid driver started oopsing with NULL pointer dereference on startup after that. Fix it by reordering the init sequence to fill in function pointers before ioremapping memory, or dev->a_ops.adapter_ioremap pointer will be NULL. Other

RE: [PATCH for sg3_utils 1/4] configure.ac: Suppress an autoconf warning

>a/configure.ac b/configure.ac index 1cce0b25f583..129c2f9d4d4d 100644 >--- a/configure.ac >+++ b/configure.ac >@@ -7,13 +7,13 @@ AM_CONFIG_HEADER(config.h) AC_PROG_CC # >AC_PROG_CXX AC_PROG_INSTALL >- >-# Adding libtools to the build seems to bring in C++ environment - >AC_PROG_LIBTOOL > > #

RE: [PATCH for sg3_utils 0/4] Simplify the sg3_utils configure script

Hi, Bart and Dong Do you think we need to submit all changed diff including some generated files by automake? Such as config.h.in, Makefile.in..., in fact, we only manually did a few modificaiton on Some files such as configura.ac,makefile.am. > >Hello Doug, > >The four patches in this series

Re: [PATCH v2 22/30] scsi: aacraid: Merge adapter setup with resolve luns

Raghava Aditya Renukunta writes: > The device hotplug events are processed only after retrieving the updated > lun information from the fw. Does not make sense to keep them separate. > > Merge both the hotplug handling and safw adapter setup code into

RE: [PATCH v2 22/30] scsi: aacraid: Merge adapter setup with resolve luns

Hi Nikola, > -Original Message- > From: Nikola Pajkovsky [mailto:npajkov...@suse.cz] > Sent: Wednesday, January 3, 2018 2:02 AM > To: Raghava Aditya Renukunta > > Cc: j...@linux.vnet.ibm.com; martin.peter...@oracle.com; linux- >

Re: [-next PATCH 2/4] treewide: Use DEVICE_ATTR_RW

On Tuesday, December 19, 2017 10:15:07 AM Joe Perches wrote: > Convert DEVICE_ATTR uses to DEVICE_ATTR_RW where possible. > > Done with perl script: > > $ git grep -w --name-only DEVICE_ATTR | \ > xargs perl -i -e 'local $/; while (<>) { >

Re: [PATCH v17 0/4] Replace PCI pool by DMA pool API

On Tue, Jan 02, 2018 at 04:17:24PM -0600, Bjorn Helgaas wrote: > On Tue, Jan 02, 2018 at 06:53:52PM +0100, Romain Perier wrote: > > The current PCI pool API are simple macro functions direct expanded to > > the appropriate dma pool functions. The prototypes are almost the same > > and

[PATCH 6/6] cxlflash: Staging to support future accelerators

From: "Matthew R. Ochs" As staging to support future accelerator transports, add a shim layer such that the underlying services the cxlflash driver requires can be conditional upon the accelerator infrastructure. Signed-off-by: Matthew R. Ochs

[PATCH 2/6] cxlflash: Update cxl-specific arguments to generic cookie

Convert cxl-specific pointers to generic cookies to facilitate future enhancements. Signed-off-by: Uma Krishnan --- drivers/scsi/cxlflash/common.h| 4 ++-- drivers/scsi/cxlflash/main.c | 38 +++---

[PATCH 1/6] cxlflash: Reset command ioasc

In the event of a command failure, cxlflash returns the failure to the upper layers to process. After processing the error, when the command is queued again, the private command structure will not be zeroed and the ioasc could be stale. Per the SISLite specification, the AFU only sets the ioasc in

[PATCH 3/6] cxlflash: Explicitly cache number of interrupts per context

From: "Matthew R. Ochs" The number of interrupts a user requests during a context attach is presently stored within the CXL work ioctl structure that is nested alongside the per context metadata. Keeping this data in a structure that is tied to a particular hardware

[PATCH 4/6] cxlflash: Remove embedded CXL work structures

From: "Matthew R. Ochs" The CXL-specific work structure used to request the number of interrupts currently resides as a nested member of both the context information and hardware queue structures. It is used to cache values (specifically the number of interrupts)

[PATCH 5/6] cxlflash: Adapter context init can return error

Adapter context creation can return either NULL or an error pointer. Updating the check condition to reflect this. Signed-off-by: Uma Krishnan --- drivers/scsi/cxlflash/main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH v2.2] sd: Micro-optimize READ / WRITE CDB encoding

On 2017-10-26 02:31 AM, Martin K. Petersen wrote: Doug, The sd_setup_read_write_cmnd() function is on the "fast path" for block system access to SCSI devices (logical units). Rewrite this function to improve speed and readability. Please do any optimizations on top of my scsi-work branch

[PATCH 0/6] cxlflash: Miscellaneous patches

This patch series contains miscellaneous fixes. The first patch fixes a bug while the rest improve the code structure and prepare the code for future enhancements. This series is intended for 4.16 and is bisectable. Matthew R. Ochs (3): cxlflash: Explicitly cache number of interrupts per

[PATCH v2 4/4] scsi: pm8001: fix dma_unmap_sg() parameter

For function dma_unmap_sg(), the parameter should be number of elements in the scatterlist prior to the mapping, not after the mapping. Fix this usage. Cc: Jack Wang Cc: lindar_...@usish.com Fixes: dbf9bfe6("[SCSI]pm8001: add SAS/SATA/HBA driver") Signed-off-by: Xiang Chen

[PATCH v2 2/4] scsi: isci: fix dma_unmap_sg() parameter

For function dma_unmap_sg(), the parameter should be number of elements in the scatterlist prior to the mapping, not after the mapping. Fix this usage. Cc: Artur Paszkiewicz Cc: Dan Williams Fixes: d9dcb4ba7("isci: unify isci_host and

[PATCH v2 0/4] fix dma_unmap_sg() parameter in some scsi drivers

According to Documentation/DMA-API.txt, all the parameters of dma_unmap_sg() must be the same as those and passed in to the scatter/gather mapping API. But in scsi drivers such as ibmscsi_tgt/iscsi/mvsas/pm8001, the parameter of dma_unmap_sg() is number of elements after mapping. So fix them.

[PATCH v2 3/4] scsi: mvsas: fix dma_unmap_sg() parameter

For function dma_unmap_sg(), the parameter should be number of elements in the scatterlist prior to the mapping, not after the mapping. Fix this usage. Cc: Xiangliang Yu Cc: Jeff Garzik Fixes: 0b15fb1fd("[SCSI]mvsas: add support for Task collector mode

[PATCH v2 1/4] scsi: ibmvscsis: fix dma_unmap_sg() parameter

For function dma_unmap_sg(), the parameter should be number of elements in the scatterlist prior to the mapping, not after the mapping. Fix this usage. Cc: Bryant G. Ly Cc: Michael Cyr Fixes: 88a678bb("ibmscsis: Initial commit of IBM

Re: [PATCH v1] libsas: remove private hex2bin() implementation

Andy, > The function sas_parse_addr() could be easily substituted by hex2bin() > which is in kernel library code. Applied to 4.16/scsi-queue. Thank you! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] scsi: sd: Use warn for logs about no caching info

Hi Jeremy, > When no caching mode information can be found for a disk, use the > warning log level rather than error. It is common for this to occur > with cheap USB sticks. Just because something is common occurrence doesn't mean it's not an error. What's the rationale behind demoting this to

Re: [PATCH] mpt3sas: Proper handling of set/clear of "ATA command pending" flag.

Chaitra, > This patch fixes above two issues by setting of "ATA command pending" flag > after checking for whether device deleted, invalid device handle, device > busy with task management. And by setting "ATA command pending" flag to > false in all of the qcmd failure return paths after

Re: [PATCH 10/12] hpsa: drop unneeded newline

Julia, > hpsa_show_dev_msg prints other information and a newline after the > message string, so the message string does not need to include a > newline explicitly. Done using Coccinelle. Applied to 4.16/scsi-queue, thanks. -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] scsi: remove extra white space at the end of the line

Johannes, > All in all I'm so much in favour of this cleanup patch (and even would > apprechiate more of these, especailly getting rid of all those > camelCase foo we have in the scsi hba drivers). > > Let's see how Martin and James deceide about it. I am thoroughly annoyed by all the legacy

Re: [PATCH] scsi: libiscsi: Allow sd_shutdown on bad transport

Rafael, > If, for any reason, userland shuts down iscsi transport interfaces > before proper logouts - like when logging in to LUNs manually, without > logging out on server shutdown, or when automated scripts can't > umount/logout from logged LUNs - kernel will hang forever on its >

Re: [PATCH] scsi: scsi_transport_fc: fix typos on 64/128 GBit define names

James, > The define names specified 64Bit/128Bit, not 64GBIT/128GBIT. > Correct the names. Applied to 4.16/scsi-queue. Thanks! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] scsi: lpfc: fix a couple of minor indentation issues

Colin, > Several statements are indented too far, fix these Applied to 4.16/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] scsi: lpfc: don't dereference localport before it has been null checked

Colin, > localport is being dereferenced to assign lport and then immediately > afterwards localport is being sanity checked to see if it is null. > Fix this by only dereferencing localport until after it has been > null checked. Applied to 4.16/scsi-queue, thanks! -- Martin K. Petersen

Re: [PATCH 00/11] mpt3sas: Enable scsi MQ & lockless command submission

Suganath, > This patch set is initially posted by Hannes Reinecke to enable scsi > multiqueue for the mpt3sas driver. While the HBA only has a single > mailbox register for submitting commands, it does have individual > receive queues per MSI-X interrupt and as such does benefit from >

Re: [PATCH] scsi: fix iscsi-related kernel-doc warnings

Randy, > Fix kernel-doc warnings in drivers/scsi/ that are related to iscsi > support interfaces. > > Fixes these kernel-doc warnings: (tested by adding these files to a new > target.rst documentation file: WIP) Applied to 4.16/scsi-queue, thanks! > Cc: "Nicholas A. Bellinger"

Re: [PATCH 00/30] aacraid: Refactor for sas transport and bug fixes

Raghava, > This patchset primarily lays the foundation for adding sas transport > support to the aacraid driver. Being said these patches are mainly > code refactors, bug fixes and improvements. Applied to 4.16/scsi-queue. Thank you! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH v2 00/37] qla2xxx: driver updates

Hi Himanshu! > This series contains number of improvments in handling of switch > registration commands in the driver. Switch commands are now submitted > via IOCB patch asynchronously instead of mailbox interface. Applied to 4.16/scsi-queue. However, ... > 17 files changed, 2891

Re: [PATCH] scsi: fix iscsi-related kernel-doc warnings

On 01/03/2018 08:11 PM, Martin K. Petersen wrote: > > Randy, > >> Fix kernel-doc warnings in drivers/scsi/ that are related to iscsi >> support interfaces. >> >> Fixes these kernel-doc warnings: (tested by adding these files to a new >> target.rst documentation file: WIP) > > Applied to

Re: [PATCH v5 0/7] Enhance libsas hotplug feature

John, > At this point we feel that we have a decent solution to the > long-standing libsas hotplug issues. > > Hannes has kindly reviewed the series. > > Can you let us know what else you require for acceptance? More > independent review or testing? According to my notes, Hannes had some

Re: [PATCH] aacraid driver oops with dead battery

Meelis, > The battery in my HP NetRAID-4M died of old age, and the aacraid > driver started oopsing with NULL pointer dereference on startup after > that. > > Fix it by reordering the init sequence to fill in function pointers > before ioremapping memory, or dev->a_ops.adapter_ioremap pointer

Re: [PATCH 2/9] scsi: qla2xxx: Use zeroing allocator rather than allocator/memset

Himanshu, > Use dma_zalloc_coherent and vzalloc instead of dma_alloc_coherent and > vmalloc respectively, followed by memset 0. Applied to 4.16/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH 1/9] scsi: qla4xxx: Use zeroing allocator rather than allocator/memset

Himanshu, > Use dma_zalloc_coherent instead of dma_alloc_coherent followed by memset > 0. Applied to 4.16/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH 9/9] scsi: bnx2i: Use zeroing allocator rather than allocator/memset

Himanshu, > Use dma_zalloc_coherent instead of dma_alloc_coherent followed by > memset 0. Applied to 4.16/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH v2 00/37] qla2xxx: driver updates

Hi Martin, > On Jan 3, 2018, at 9:59 PM, Martin K. Petersen > wrote: > > > Hi Himanshu! > >> This series contains number of improvments in handling of switch >> registration commands in the driver. Switch commands are now submitted >> via IOCB patch

Re: [PATCH 8/9] scsi: bfa: Use zeroing allocator rather than allocator/memset

Himanshu, > Use vzalloc instead of vmalloc followed by memset 0. Applied to 4.16/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH 3/9] scsi: qedi: Use zeroing allocator instead of allocator/memset

Himanshu, > Use dma_zalloc_coherent instead of dma_alloc_coherent followed by memset > 0. Does not apply to 4.16/scsi-queue. Please resubmit. Thanks! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH 7/9] scsi: bnx2fc: Use zeroing allocator rather than allocator/memset

Himanshu, > Use dma_zalloc_coherent instead of dma_alloc_coherent followed by > memset 0. Does not apply to 4.16/scsi-queue. Please resubmit. Thanks! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH 1/6] cxlflash: Reset command ioasc

On 04/01/18 09:54, Uma Krishnan wrote: In the event of a command failure, cxlflash returns the failure to the upper layers to process. After processing the error, when the command is queued again, the private command structure will not be zeroed and the ioasc could be stale. Per the SISLite

Re: [PATCH 7/9] scsi: bnx2fc: Use zeroing allocator rather than allocator/memset

Hello Martin, On Thu, Jan 04, 2018 at 01:17:52AM -0500, Martin K. Petersen wrote: > > Himanshu, > > > Use dma_zalloc_coherent instead of dma_alloc_coherent followed by > > memset 0. > > Does not apply to 4.16/scsi-queue. Please resubmit. Thanks! No problem, I will resend the patch. scsi:

RE: [PATCH] aacraid driver oops with dead battery

> -Original Message- > From: mr...@math.ut.ee [mailto:mr...@math.ut.ee] On Behalf Of Meelis > Roos > Sent: Wednesday, January 3, 2018 1:11 AM > To: linux-scsi@vger.kernel.org; dl-esc-Aacraid Linux Driver > > Subject: [PATCH] aacraid driver oops with dead battery >

Re: 4.15-rcX 32-bit SCSI suspend2ram warning

On Wed, 2018-01-03 at 12:16 -0500, Woody Suwalski wrote: > Starting with a 32-bit 4.15-rcX I have observed a warning in dmesg, > happening when the system goes to suspend2ram. If it is just a warning > - could we have it quiet'et down? (+linux-scsi) Thank you for having reported this. The