Re: [PATCH] scsi_debug: Simplify request tag decoding

On 2018-01-26 11:52 AM, Bart Van Assche wrote: Since commit 64d513ac31bd ("scsi: use host wide tags by default") all SCSI requests have a tag, whether or not scsi-mq is enabled. Additionally, it is safe to use blk_mq_unique_tag() and blk_mq_unique_tag_to_hwq() for legacy SCSI queues. Since this

Re: [PATCH] scsi_debug: implement IMMED bit

On 01/29/18 21:54, Douglas Gilbert wrote: +static const struct opcode_info_t sync_cache_iarr[] = { + {0, 0x91, 0, F_LONG_DELAY | F_M_ACCESS, resp_sync_cache, NULL, + {16, 0x7, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, ^^^ Can you clarify the choice of

Re: [LSF/MM TOPIC] Patch Submission process and Handling Internal Conflict

On 1/24/18 5:43 PM, Darrick J. Wong wrote: > On Wed, Jan 24, 2018 at 01:36:00PM -0800, James Bottomley wrote: >> On Wed, 2018-01-24 at 11:20 -0800, Mike Kravetz wrote: >>> On 01/24/2018 11:05 AM, James Bottomley wrote: I've got two community style topics, which should probably be

[GIT PULL] first round of SCSI updates for the 4.14+ merge window

This is mostly updates of the usual driver suspects: arcmsr, scsi_debug, mpt3sas, lpfc, cxlflash, qla2xxx, aacraid, megaraid_sas, hisi_sas.  We also have a rework of the libsas hotplug handling to make it more robust, a slew of 32 bit time conversions and fixes, and a host of the usual minor

Re: [LSF/MM TOPIC] KPTI effect on IO performance

On 2018-01-31 01:23, Ming Lei wrote: Hi All, After KPTI is merged, there is extra load introduced to context switch between user space and kernel space. It is observed on my laptop that one syscall takes extra ~0.15us[1] compared with 'nopti'. IO performance is affected too, it is observed

Re: [PATCH resend 3/6] cdrom: wait for tray to close

On Mon, 29 Jan 2018 17:05:47 + Bart Van Assche wrote: > On Fri, 2018-01-26 at 17:58 +0100, Michal Suchanek wrote: > > +static int cdrom_tray_close(struct cdrom_device_info *cdi) > > +{ > > + int ret; > > + > > + ret = cdi->ops->tray_move(cdi, 0); > > + if (ret

Re: [PATCH] scsi: mpt3sas: fix oops in error handlers after shutdown/unload

Bart, Thanks for reviewing. On 01/31/2018 05:06 PM, Bart Van Assche wrote: Sorry but I think this patch introduces new race conditions. Have you Can you detail the race conditions? As far as I can see, the only race condition would be when an error handler is invoked very close in time to

Re: [GIT PULL] first round of SCSI updates for the 4.14+ merge window

On Wed, 2018-01-31 at 11:29 -0800, Linus Torvalds wrote: > On Wed, Jan 31, 2018 at 9:42 AM, James Bottomley > wrote: > > > > > > git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi.git scsi- > > misc > > Ok, now I did indeed get that > >   gpg: Can't

RE: [PATCH 1/1] scsi: storvsc: Increase cmd_per_lun for higher speed devices

> -Original Message- > From: Michael Kelley (EOSG) > Sent: Wednesday, January 24, 2018 2:50 PM > To: KY Srinivasan ; Stephen Hemminger > ; martin.peter...@oracle.com; Long Li > ; j...@linux.vnet.ibm.com; >

Sorry about all the patch dropped email noise

If you received it, just ignore it.  I didn't initialize my fixes tree correctly before pulling in Martin's branch, so it wrongly sent a patch dropped email for every patch in the misc tree (which has already been routed to Linus). James

[PATCH] scsi: mpt3sas: fix oops in error handlers after shutdown/unload

This patch adds checks for 'ioc->remove_host' in the SCSI error handlers, so not to access pointers/resources potentially freed in the PCI shutdown/module unload path. The error handlers may be invoked after shutdown/unload, depending on other components. This problem was observed with kexec on

Re: [GIT PULL] first round of SCSI updates for the 4.14+ merge window

On Wed, Jan 31, 2018 at 9:42 AM, James Bottomley wrote: > > git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi.git scsi-misc Ok, now I did indeed get that gpg: Can't check signature: unknown pubkey algorithm because of your fancy new key. But

RE: [PATCH 1/1] scsi: storvsc: Spread interrupts when picking a channel for I/O requests

> Subject: RE: [PATCH 1/1] scsi: storvsc: Spread interrupts when picking a > channel for I/O requests > > Updated/corrected two email addresses ... > > > -Original Message- > > From: Michael Kelley (EOSG) > > Sent: Wednesday, January 24, 2018 2:14 PM > > To: KY Srinivasan

Re: [PATCH] scsi: mpt3sas: fix oops in error handlers after shutdown/unload

On Wed, 2018-01-31 at 17:48 -0200, Mauricio Faria de Oliveira wrote: > On 01/31/2018 05:06 PM, Bart Van Assche wrote: > > Sorry but I think this patch introduces new race conditions. Have you > > Can you detail the race conditions? As far as I can see, the only race > condition would be when an

RE: [PATCH 1/1] scsi: storvsc: Spread interrupts when picking a channel for I/O requests

> From: Long Li > Sent: Wednesday, January 31, 2018 12:23 PM > To: Michael Kelley (EOSG) ; KY Srinivasan > ; Stephen Hemminger ; > martin.peter...@oracle.com; de...@linuxdriverproject.org; > linux-ker...@vger.kernel.org;

Re: [PATCH] scsi_debug: implement IMMED bit

On Wed, 2018-01-31 at 17:40 -0500, Douglas Gilbert wrote: > On 2018-01-31 05:05 PM, Bart Van Assche wrote: > > On Wed, 2018-01-31 at 15:26 -0500, Douglas Gilbert wrote: > > > On 2018-01-31 12:06 PM, Bart Van Assche wrote: > > > > On 01/29/18 21:54, Douglas Gilbert wrote: > > > > > +static const

Re: [PATCH] scsi_debug: implement IMMED bit

On Wed, 2018-01-31 at 15:26 -0500, Douglas Gilbert wrote: > On 2018-01-31 12:06 PM, Bart Van Assche wrote: > > On 01/29/18 21:54, Douglas Gilbert wrote: > > > +static const struct opcode_info_t sync_cache_iarr[] = { > > > +{0, 0x91, 0, F_LONG_DELAY | F_M_ACCESS, resp_sync_cache, NULL, > > > +

Re: [PATCH] test-case

On Wed, 2018-01-31 at 17:24 -0200, Mauricio Faria de Oliveira wrote: > diff --git a/drivers/scsi/mpt3sas/mpt3sas_scsih.c > b/drivers/scsi/mpt3sas/mpt3sas_scsih.c > index 3c4e47c..611cee33 100644 > --- a/drivers/scsi/mpt3sas/mpt3sas_scsih.c > +++ b/drivers/scsi/mpt3sas/mpt3sas_scsih.c > @@ -2997,6

Re: [PATCH] scsi_debug: implement IMMED bit

On 2018-01-31 12:06 PM, Bart Van Assche wrote: On 01/29/18 21:54, Douglas Gilbert wrote: +static const struct opcode_info_t sync_cache_iarr[] = { +    {0, 0x91, 0, F_LONG_DELAY | F_M_ACCESS, resp_sync_cache, NULL, +    {16,  0x7, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff, 0xff,

RE: [PATCH 1/1] scsi: storvsc: Spread interrupts when picking a channel for I/O requests

> Subject: RE: [PATCH 1/1] scsi: storvsc: Spread interrupts when picking a > channel for I/O requests > > > From: Long Li > > Sent: Wednesday, January 31, 2018 12:23 PM > > To: Michael Kelley (EOSG) ; KY > > Srinivasan ; Stephen Hemminger > >

Re: [PATCH] scsi_debug: implement IMMED bit

On 2018-01-31 05:05 PM, Bart Van Assche wrote: On Wed, 2018-01-31 at 15:26 -0500, Douglas Gilbert wrote: On 2018-01-31 12:06 PM, Bart Van Assche wrote: On 01/29/18 21:54, Douglas Gilbert wrote: +static const struct opcode_info_t sync_cache_iarr[] = { +{0, 0x91, 0, F_LONG_DELAY |

Re: scsi: sg: assorted memory corruptions

On Thu, Feb 1, 2018 at 7:03 AM, Douglas Gilbert wrote: > On 2018-01-30 07:22 AM, Dmitry Vyukov wrote: >> >> Uh, I've answered this a week ago, but did not notice that Doug >> dropped everybody from CC. Reporting to all. >> >> On Mon, Jan 22, 2018 at 8:16 PM, Douglas Gilbert

Re: scsi: sg: assorted memory corruptions

On 2018-01-30 07:22 AM, Dmitry Vyukov wrote: Uh, I've answered this a week ago, but did not notice that Doug dropped everybody from CC. Reporting to all. On Mon, Jan 22, 2018 at 8:16 PM, Douglas Gilbert wrote: On 2018-01-22 02:06 PM, Dmitry Vyukov wrote: On Mon, Jan

[PATCH] qedi: Fix truncation of name and secret

Adjust the NULL byte added by snprintf. Signed-off-by: Nilesh Javali --- drivers/scsi/qedi/qedi_main.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/scsi/qedi/qedi_main.c b/drivers/scsi/qedi/qedi_main.c index 34a..cf8badb

Re: [PATCH] scsi: mpt3sas: fix oops in error handlers after shutdown/unload

On Wed, 2018-01-31 at 17:00 -0200, Mauricio Faria de Oliveira wrote: > This problem was observed with kexec on a system with a mpt3sas > based adapter and an infiniband adapter which takes long enough > to shutdown. The mpt3sas driver finished shuttting down, which > disabled interruption

[PATCH] test-case

This patch can be verified with this simple test-case, which inserts a wait loop at the bottom of 'scsih_shutdown()' and forces SCSI commands to timeout (skip 'scmd->scsi_done()'). It abuses the 'ioc->logging_level' parameter do to that, with: - 0x1000: wait loop on scsih_shutdown() and skip

Re: [LSF/MM TOPIC] KPTI effect on IO performance

Hi Scotty, On Wed, Jan 31, 2018 at 11:43:33AM -0700, Scotty Bauer wrote: > On 2018-01-31 01:23, Ming Lei wrote: > > Hi All, > > > > After KPTI is merged, there is extra load introduced to context switch > > between user space and kernel space. It is observed on my laptop that > > one > > syscall

Re: [LSF/MM TOPIC] KPTI effect on IO performance

On Wed, Jan 31, 2018 at 11:43:33AM -0700, Scotty Bauer wrote: > On 2018-01-31 01:23, Ming Lei wrote: > > Hi All, > > > > After KPTI is merged, there is extra load introduced to context switch > > between user space and kernel space. It is observed on my laptop that > > one > > syscall takes extra

[LSF/MM TOPIC] KPTI effect on IO performance

Hi All, After KPTI is merged, there is extra load introduced to context switch between user space and kernel space. It is observed on my laptop that one syscall takes extra ~0.15us[1] compared with 'nopti'. IO performance is affected too, it is observed that IOPS drops by 32% in my test[2] on