Re: [PATCH] scsi: libsas: defer ata device eh commands to libata

2018-02-28 Thread John Garry
On 28/02/2018 04:14, Jason Yan wrote: On 2018/2/27 23:00, Jack Wang wrote: 2018-02-27 12:50 GMT+01:00 John Garry : On 27/02/2018 06:59, Jason Yan wrote: When ata device doing EH, some commands still attached with tasks are not passed to libata when abort failed or recover failed, so libata

Re: [PATCH] scsi: libsas: defer ata device eh commands to libata

2018-02-28 Thread Jason Yan
On 2018/2/28 16:09, John Garry wrote: On 28/02/2018 04:14, Jason Yan wrote: On 2018/2/27 23:00, Jack Wang wrote: 2018-02-27 12:50 GMT+01:00 John Garry : On 27/02/2018 06:59, Jason Yan wrote: When ata device doing EH, some commands still attached with tasks are not passed to libata when ab

[PATCH V2] scsi: core: use blk_mq_requeue_request in __scsi_queue_insert

2018-02-28 Thread Jianchao Wang
In scsi core, __scsi_queue_insert should just put request back on the queue and retry using the same command as before. However, for blk-mq, scsi_mq_requeue_cmd is employed here which will unprepare the request. To align with the semantics of __scsi_queue_insert, use blk_mq_requeue_request with kic

RE: [PATCH] mpt3sas: Do not mark fw_event workqueue as WQ_MEM_RECLAIM

2018-02-28 Thread Sreekanth Reddy
-Original Message- From: Hannes Reinecke [mailto:h...@suse.de] Sent: Monday, February 26, 2018 7:56 PM To: Martin K. Petersen Cc: Christoph Hellwig; James Bottomley; linux-scsi@vger.kernel.org; Hannes Reinecke; Sreekanth Reddy; Suganath Prabu Subramani; Hannes Reinecke Subject: [PATCH] mpt3

RE: [PATCH V3 8/8] scsi: megaraid: improve scsi_mq performance via .host_tagset

2018-02-28 Thread Kashyap Desai
Ming - Quick testing on my setup - Performance slightly degraded (4-5% drop)for megaraid_sas driver with this patch. (From 1610K IOPS it goes to 1544K) I confirm that after applying this patch, we have #queue = #numa node. ls -l /sys/devices/pci:80/:80:02.0/:83:00.0/host10/target10:2

Re: [PATCH V3 8/8] scsi: megaraid: improve scsi_mq performance via .host_tagset

2018-02-28 Thread Ming Lei
On Wed, Feb 28, 2018 at 08:28:48PM +0530, Kashyap Desai wrote: > Ming - > > Quick testing on my setup - Performance slightly degraded (4-5% drop)for > megaraid_sas driver with this patch. (From 1610K IOPS it goes to 1544K) > I confirm that after applying this patch, we have #queue = #numa node. >

Re: [PATCH V3 8/8] scsi: megaraid: improve scsi_mq performance via .host_tagset

2018-02-28 Thread Laurence Oberman
On Wed, 2018-02-28 at 23:21 +0800, Ming Lei wrote: > On Wed, Feb 28, 2018 at 08:28:48PM +0530, Kashyap Desai wrote: > > Ming - > > > > Quick testing on my setup -  Performance slightly degraded (4-5% > > drop)for > > megaraid_sas driver with this patch. (From 1610K IOPS it goes to > > 1544K) > > I

Re: [PATCH V2] scsi: core: use blk_mq_requeue_request in __scsi_queue_insert

2018-02-28 Thread Bart Van Assche
On Wed, 2018-02-28 at 16:55 +0800, Jianchao Wang wrote: > diff --git a/drivers/scsi/scsi_lib.c b/drivers/scsi/scsi_lib.c > index a86df9c..6fa7b0c 100644 > --- a/drivers/scsi/scsi_lib.c > +++ b/drivers/scsi/scsi_lib.c > @@ -191,7 +191,8 @@ static void __scsi_queue_insert(struct scsi_cmnd *cmd, > in

Re: [PATCH V2] scsi: core: use blk_mq_requeue_request in __scsi_queue_insert

2018-02-28 Thread jianchao.wang
Hi Bart Thanks for your precious time to review this and kindly detailed response. On 03/01/2018 01:52 AM, Bart Van Assche wrote: > On Wed, 2018-02-28 at 16:55 +0800, Jianchao Wang wrote: >> diff --git a/drivers/scsi/scsi_lib.c b/drivers/scsi/scsi_lib.c >> index a86df9c..6fa7b0c 100644 >> --- a/d

RE: [PATCH V3 8/8] scsi: megaraid: improve scsi_mq performance via .host_tagset

2018-02-28 Thread Kashyap Desai
> -Original Message- > From: Laurence Oberman [mailto:lober...@redhat.com] > Sent: Wednesday, February 28, 2018 9:52 PM > To: Ming Lei; Kashyap Desai > Cc: Jens Axboe; linux-bl...@vger.kernel.org; Christoph Hellwig; Mike > Snitzer; > linux-scsi@vger.kernel.org; Hannes Reinecke; Arun Easi; O

Re:[PATCH] scsi: lpfc: Switch memcpy_fromio() to __read32_copy()

2018-02-28 Thread 陈华才
Ping? -- Original -- From: "Huacai Chen"; Date: Fri, Jan 26, 2018 08:53 PM To: "James Smart"; "Dick Kennedy"; Cc: "James E . J . Bottomley"; "Martin K . Petersen"; "Fuxin Zhang"; "linux-scsi"; "Huacai Chen"; "stable"; Subject: [PATCH] scsi: lpfc: Switch me

Re: [PATCH V3 8/8] scsi: megaraid: improve scsi_mq performance via .host_tagset

2018-02-28 Thread Ming Lei
On Thu, Mar 01, 2018 at 10:54:17AM +0530, Kashyap Desai wrote: > > -Original Message- > > From: Laurence Oberman [mailto:lober...@redhat.com] > > Sent: Wednesday, February 28, 2018 9:52 PM > > To: Ming Lei; Kashyap Desai > > Cc: Jens Axboe; linux-bl...@vger.kernel.org; Christoph Hellwig; Mi