2018-03-04 0:54 GMT+01:00 Michael Schmitz :
> +static struct zorro_device_id zorro_esp_zorro_tbl[] = {
> + {
> + .id = ZORRO_PROD_PHASE5_BLIZZARD_1220_CYBERSTORM,
> + .driver_data = (unsigned long)&zorro_esp_driver_data[0],
> + },
> + {
> +
From: Markus Elfring
Date: Mon, 5 Mar 2018 09:14:32 +0100
A few update suggestions were taken into account
from static source code analysis.
Markus Elfring (4):
Use memdup_user() rather than duplicating its implementation
Less function calls in hpsa_big_passthru_ioctl() after error detection
From: Markus Elfring
Date: Sun, 4 Mar 2018 21:19:52 +0100
* Reuse existing functionality from memdup_user() instead of keeping
duplicate source code.
This issue was detected by using the Coccinelle software.
* Return directly after this function call failed at the beginning.
Signed-off-by:
From: Markus Elfring
Date: Sun, 4 Mar 2018 22:00:19 +0100
The function "kfree" was called in a few cases by
the hpsa_big_passthru_ioctl() function during error handling
even if the passed variable contained a null pointer.
* Adjust jump targets.
* Delete two initialisations and a check (for the
From: Markus Elfring
Date: Sun, 4 Mar 2018 22:02:10 +0100
The variable "status" will be set to an appropriate value a bit later.
Thus omit the explicit initialisation at the beginning.
Signed-off-by: Markus Elfring
---
drivers/scsi/hpsa.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
From: Markus Elfring
Date: Sun, 4 Mar 2018 22:16:05 +0100
Move an assignment for the local variable "sg_used" so that its setting
will only be performed after corresponding memory allocations succeeded
by this function.
Signed-off-by: Markus Elfring
---
drivers/scsi/hpsa.c | 3 ++-
1 file chan
Hi Michael,
On Sun, Mar 4, 2018 at 12:54 AM, Michael Schmitz wrote:
> From: Michael Schmitz
>
> New combined SCSI driver for all ESP based Zorro SCSI boards for
> m68k Amiga.
Thanks for your patch!
> --- /dev/null
> +++ b/drivers/scsi/zorro_esp.c
> @@ -0,0 +1,785 @@
> +static struct zorro_dri
On 19/02/18 08:35, Adrian Hunter wrote:
> On 18/02/18 11:45, Avri Altman wrote:
>>
>>
>>> -Original Message-
>>> From: linux-scsi-ow...@vger.kernel.org [mailto:linux-scsi-
>>> ow...@vger.kernel.org] On Behalf Of Adrian Hunter
>>> Sent: Friday, February 16, 2018 2:01 PM
>>> To: Vinayak Holik
On Fri, Mar 2, 2018 at 10:10 AM, John Garry wrote:
> On 02/03/2018 15:57, Rob Herring wrote:
>>
>> On Fri, Mar 2, 2018 at 9:06 AM, John Garry wrote:
>>>
>>> > From: Xiaofei Tan
>>> >
>>> > For some new boards with hip07 chipset we are required to
>>> > set PHY config registers differently. The h
> -Original Message-
> From: Kashyap Desai [mailto:kashyap.de...@broadcom.com]
> Sent: Monday, March 05, 2018 1:24 AM
> To: Laurence Oberman ; Don Brace
> ; Ming Lei
> Cc: Jens Axboe ; linux-bl...@vger.kernel.org; Christoph
> Hellwig ; Mike Snitzer ; linux-
> s...@vger.kernel.org; Hannes R
From: Xiaofei Tan
The current 110ms expiry time is not long enough for the internal
abort task.
The reason is that the internal abort task could be blocked in HW
if the HW is retrying to set up link. The internal abort task will
be executed only when the retry process finished.
The maximum time
From: Xiaofei Tan
The register SAS_PHY_CTRL is configured according to signal quality.
The signal quality is calculated by signal attenuation of hardware
physical link. It may be different for different PCB layout.
So, in order to give better support to new board, this patch add
support to readi
From: Xiang Chen
The patch does some code cleanup and fixes some small bugs:
- Correct return status of phy_up_v3_hw()
- Add static for function phy_get_max_linkrate_v3_hw()
- Change exception return status when no reset method
- Change magic value to ts->stat in slot_complete_vx_hw()
- Remove un
From: Xiaofei Tan
For some new boards with hip07 chipset we are required to
set PHY config registers differently. The hw property which
determines how to set these registers is in the PHY signal
attenuation readings.
This patch add an devicetree property, "hisilicon,signal-attenuation",
which is
From: Xiang Chen
The structure element hisi_sas_devices.running_req to count how
many commands are active is in effect only ever written in the
code, so remove it.
Signed-off-by: Xiang Chen
Signed-off-by: John Garry
---
drivers/scsi/hisi_sas/hisi_sas.h | 1 -
drivers/scsi/hisi_sas/hisi_
From: Xiaofei Tan
It is not right to set the register PROG_PHY_LINK_RATE while PHY
is still enabled. So if we want to change PHY linkrate, we need to
disable PHY before setting the register PROG_PHY_LINK_RATE, and then
start-up PHY. This patch is to fix this issue.
Signed-off-by: Xiaofei Tan
Si
This patchset primarily adds support for the Huawei x6000 board,
which includes hip07 chipset. Unfortunately, due to some board
layout differences with our development board, we need to set
a PHY-related register differently for optimal signal quality. As
such, a signal attenuation property is adde
From: Xiaofei Tan
In sysfs, there are two files about minimum linkrate, and also
two files for maximum linkrate. Take maximum linkrate example,
maximum_linkrate_hw is read-only and indicated by the register
HARD_PHY_LINKRATE, and maximum_linkrate is read-write and
corresponding to the register PR
From: Xiaofei Tan
It is an implicit regulation that error code that function returned
should be negative. But hisi_sas_task_prep() doesn't follow this.
This may cause problems in the upper layer code.
For example, in sas_expander.c of libsas, smp_execute_task_sg() may
return the number of bytes
From: Kevin Barnett
Reviewed-by: Scott Benesh
Signed-off-by: Kevin Barnett
Signed-off-by: Don Brace
---
drivers/scsi/smartpqi/smartpqi_init.c | 44 +
1 file changed, 44 insertions(+)
diff --git a/drivers/scsi/smartpqi/smartpqi_init.c
b/drivers/scsi/smartpqi
On Mon, Mar 05 2018 at 2:23am -0500,
Kashyap Desai wrote:
> > -Original Message-
> > From: Laurence Oberman [mailto:lober...@redhat.com]
> > Sent: Saturday, March 3, 2018 3:23 AM
> > To: Don Brace; Ming Lei
> > Cc: Jens Axboe; linux-bl...@vger.kernel.org; Christoph Hellwig; Mike
> > Snit
On 05.03.2018 03:11, Michael Schmitz wrote:
Hi Finn,
On Mon, Mar 5, 2018 at 2:01 PM, Finn Thain wrote:
On Mon, 5 Mar 2018, Michael Schmitz wrote:
+fail_unmap_dma_regs:
+ if (ioaddr > 0xff)
+ iounmap(esp->dma_regs);
I think you need to test for ZORRO_PROD_PHASE5_BLIZZARD_
On 3/4/2018 10:56 PM, 陈华才 wrote:
No one has the same problem? Or this patch need improve?
Huacai
-- Original --
From: "陈华才";
Date: Thu, Mar 1, 2018 01:59 PM
To: "James Smart"; "Dick
Kennedy";
Cc: "James E . J . Bottomley"; "Martin K . Petersen"; "Fuxin
This patch replaces:
https://www.spinics.net/lists/linux-scsi/msg117838.html
A prior lpfc patch:
scsi: lpfc: Add push-to-adapter support to sli4
commitid=1351e69fc6db30e186295f1c9495d03cef6a01a2
Fails compilation on some 32-bit systems as writeq() is not supported
on all architectures. Additional
Martin, James,
On 02/22/2018 01:07 AM, Martin K. Petersen wrote:
The first patch prevents the SCSI error handlers to run once the
shutdown/unload path starts. This avoids an oops at least in the host
reset handler, on kernels with a recent patch, and also in the abort
handler on kernels without
On Mon, 2018-03-05 at 09:03 -0800, James Smart wrote:
> This patch replaces:
> https://www.spinics.net/lists/linux-scsi/msg117838.html
>
> A prior lpfc patch:
> scsi: lpfc: Add push-to-adapter support to sli4
> commitid=1351e69fc6db30e186295f1c9495d03cef6a01a2
>
> Fails compilation on some 32-bit
This patch replaces:
https://www.spinics.net/lists/linux-scsi/msg117838.html
A prior lpfc patch:
scsi: lpfc: Add push-to-adapter support to sli4
commitid=1351e69fc6db30e186295f1c9495d03cef6a01a2
Fails compilation on some 32-bit systems as writeq() is not supported
on all architectures. Additional
On Mon, Mar 5, 2018 at 7:29 PM, James Smart wrote:
> This patch replaces:
> https://www.spinics.net/lists/linux-scsi/msg117838.html
>
> A prior lpfc patch:
> scsi: lpfc: Add push-to-adapter support to sli4
> commitid=1351e69fc6db30e186295f1c9495d03cef6a01a2
>
> Fails compilation on some 32-bit sys
From: Dongsheng Yang
Replace various -20/+19 hardcoded nice values with MIN_NICE/MAX_NICE.
Signed-off-by: Dongsheng Yang
Acked-by: Tejun Heo
Signed-off-by: Peter Zijlstra
Link:
http://lkml.kernel.org/r/ff13819fd09b7a5dba5ab5ae797f2e7019bdfa17.1394532288.git.yangds.f...@cn.fujitsu.com
Cc: de.
This patch contains lpfc bug fixes
The patches were cut against the Martin's 4.17/scsi-queue tree,
plus the following patch applied:
[PATCH v2] lpfc: use __raw_writeX on DPP copies
https://marc.info/?l=linux-scsi&m=152027455929958&w=2
James Smart (9):
lpfc: Fix NVME Initiator FirstBurst
To reduce latency when initializing WQE content, created
templates for the most common wqes. This reduces the number
of operations taken to set the content. It's not a lot of speed
up, but every bit helps.
This patch updates the NVME initiator path.
Signed-off-by: Dick Kennedy
Signed-off-by: Jam
When a port is configured for NVME and SCSI Initiator support and it probes
a target supporting both SCSI and NVME, NVME devices are discovered,
but SCSI devices are not.
The nlp_fc4_type for all NPorts should be cleared on Link Up or just
before GID_FTs get issued, as opposed to just during GID_F
To reduce latency when initializing WQE content, created
templates for the most common wqes. This reduces the number
of operations taken to set the content. It's not a lot of speed
up, but every bit helps.
This patch updates the NVME target path.
Signed-off-by: Dick Kennedy
Signed-off-by: James
First Burst support was not properly indicated in NVMe PRLI.
Correct the bit position and the logic to check and set
first burst support.
Signed-off-by: Dick Kennedy
Signed-off-by: James Smart
---
drivers/scsi/lpfc/lpfc_nportdisc.c | 15 ++-
drivers/scsi/lpfc/lpfc_nvme.h | 2
The driver is very sloppy about the WQE structure passed between
routines. The base struct type is a 64byte wqe. But in many routines
they typecast and access 128byte wqes. There were a couple of cases
in the past (corrected already) where the typecasts were incorrectly
done and the 64byte buffer w
POST_SGL_PAGES mailbox command failed with status (timeout).
wait_event_interruptible_timeout when called from mailbox wait
interface, gets interrupted, and will randomly fail. Behavior
seems very specific to 1 particular server type.
Fix by changing from wait_event_interruptible_timeout to
wait_
Updated Copyright in files updated as part of 12.0.0.1
Signed-off-by: Dick Kennedy
Signed-off-by: James Smart
---
drivers/scsi/lpfc/lpfc_nvme.h | 2 +-
drivers/scsi/lpfc/lpfc_scsi.h | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/scsi/lpfc/lpfc_nvme.h b/drivers/sc
Update the driver version to 12.0.0.1
Signed-off-by: Dick Kennedy
Signed-off-by: James Smart
---
drivers/scsi/lpfc/lpfc_version.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/lpfc/lpfc_version.h b/drivers/scsi/lpfc/lpfc_version.h
index b1ae62a44aae..e8b089abb
The driver fails to allocate command buffers in the routine
lpfc_new_scsi_buf_s4
There is an inconsistency between lpfc_mem_alloc(), where the
phba->lpfc_sg_dma_buf_pool is created, and lpfc_new_scsi_buf_s4(),
when we allocate a buffer from the pool and check the alignment.
The alignment should be
Hi Bill,
> On Mar 4, 2018, at 9:02 PM, Bill Kuzeja wrote:
>
> Because of the shifting around of code in qla2x00_probe_one recently,
> failures during adapter initialization can lead to problems, i.e. NULL
> pointer crashes and doubly freed data structures which cause eventual
> panics.
>
> Thi
On Tue, Feb 27, 2018 at 01:46:17PM +0800, Can Guo wrote:
> From: Gilad Broner
>
> Different platforms may have different number of lanes for the UFS Tx/Rx
> links. Add parameter to device tree specifying how many lanes should be
> configured for the UFS Tx/Rx links. And don't print err message fo
Hi Kars,
Index 1 should have been ZORRO_PROD_PHASE5_CYBERSTORM_MK_II, I've
corrected that in the meantime.
Fastlane / Blizzard 1230_II distinction is something I an not quite
sure about - does the probe function get called twice if the device
table contains the same ID twice but with different dr
Hi, James,
At least on MIPS (Loongson-3), we found that this patch is necessary.
Huacai
-- Original --
From: "James Smart";
Date: Mon, Mar 5, 2018 11:37 PM
To: "陈华才"; "Dick Kennedy";
Cc: "James E . J . Bottomley"; "Martin K .
Petersen"; "Fuxin Zhang";
"linu
Hi Geert,
thanks, will comment on a few points that were not already raised by Finn below.
On Tue, Mar 6, 2018 at 12:29 AM, Geert Uytterhoeven
wrote:
>> +static struct zorro_driver_data {
>> + const char *name;
>> + unsigned long offset;
>> + unsigned long dma_offset;
>> +
On Tue, 6 Mar 2018, Michael Schmitz wrote:
> >> +static void zorro_esp_send_pio_cmd(struct esp *esp, u32 addr, u32
> >> esp_count,
> >> +u32 dma_count, int write, u8 cmd)
> >> +{
> >> + struct zorro_esp_priv *zep = ZORRO_ESP_GET_PRIV(esp);
> >> + u8 __i
--
Good Day,
My wife and I have awarded you with a donation of $ 1,000,000.00 Dollars from
part of our Jackpot Lottery of 50 Million Dollars, respond with your details
for claims.
We await your earliest response and God Bless you.
Friedrich And Ann Mayrhofer.
Hi Finn,
Am 06.03.2018 um 16:04 schrieb Finn Thain:
> On Tue, 6 Mar 2018, Michael Schmitz wrote:
>
+static void zorro_esp_send_pio_cmd(struct esp *esp, u32 addr, u32
esp_count,
+u32 dma_count, int write, u8 cmd)
+{
+ struct zorro_esp
Hi Michael,
On Tue, Mar 6, 2018 at 2:11 AM, Michael Schmitz wrote:
> Index 1 should have been ZORRO_PROD_PHASE5_CYBERSTORM_MK_II, I've
> corrected that in the meantime.
>
> Fastlane / Blizzard 1230_II distinction is something I an not quite
> sure about - does the probe function get called twice
Hi Michael,
On Tue, Mar 6, 2018 at 2:33 AM, Michael Schmitz wrote:
> On Tue, Mar 6, 2018 at 12:29 AM, Geert Uytterhoeven
> wrote:
>>> +static unsigned char ctrl_data;/* Keep backup of the stuff written
>>> +* to ctrl_reg. Always write a copy
>>> +
49 matches
Mail list logo
