Re: [PATCH] scsi: mpt3sas: clarify mmio pointer types

2018-03-06 Thread Martin K. Petersen
Arnd, > The newly added code mixes up phys_addr_t/resource_size_t with dma_addr_t > and void pointers, as seen from these compiler warning: Applied to 4.17/scsi-queue. Thanks for fixing this up! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] scsi: libsas: defer ata device eh commands to libata

2018-03-06 Thread Dan Williams
On Tue, Mar 6, 2018 at 10:04 AM, Martin K. Petersen wrote: > >> When ata device doing EH, some commands still attached with tasks are not >> passed to libata when abort failed or recover failed, so libata did not >> handle these commands. After these commands done, sas

Re: [PATCH 2/2] m68k/amiga - Zorro ESP: new zorro_esp.c

2018-03-06 Thread Michael Schmitz
Hi Finn, I'll leave the unused !write branch in the original condition. I'd rather keep the address conversion inside the PIO code than duplicating it in each DMA setup routine though. You had asked what manual I had used a while ago: it's

Re: [PATCH V3 1/8] scsi: hpsa: fix selection of reply queue

2018-03-06 Thread Martin K. Petersen
Ming, > Given both Don and Laurence have verified that patch 1 and patch 2 > does fix IO hang, could you consider to merge the two first? Oh, and I would still need a formal Acked-by: from Don and Tested-by: from Laurence. Also, for 4.16/scsi-fixes I would prefer verification to be done with

Re: [PATCH v2 00/38] cxlflash: OCXL transport support

2018-03-06 Thread Martin K. Petersen
> This patch series adds OCXL support to the cxlflash driver. With this > support, new devices using the OCXL transport will be supported by the > cxlflash driver along with the existing CXL devices. An effort is made > to keep this transport specific function independent of the existing > core

Re: [PATCH V3 1/8] scsi: hpsa: fix selection of reply queue

2018-03-06 Thread Martin K. Petersen
Hi Ming, > Given both Don and Laurence have verified that patch 1 and patch 2 > does fix IO hang, could you consider to merge the two first? I'm not going to merge the MR patch until Kashyap acks it. -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] scsi: libsas: defer ata device eh commands to libata

2018-03-06 Thread Martin K. Petersen
> When ata device doing EH, some commands still attached with tasks are not > passed to libata when abort failed or recover failed, so libata did not > handle these commands. After these commands done, sas task is freed, but > ata qc is not freed. Somebody from the libsas camp, please review!

Re: [PATCH 2/2] m68k/amiga - Zorro ESP: new zorro_esp.c

2018-03-06 Thread Michael Schmitz
Hi Geert, On Tue, Mar 6, 2018 at 8:48 PM, Geert Uytterhoeven wrote: > BTW, please call the probe/remove functions zorro_esp_probe() resp. > zorro_esp_remove(). Fair enough. + if (!host) { + pr_err(PFX "No host detected; board configuration

Re: [PATCH] Improve ZBC/ZAC error handling

2018-03-06 Thread Martin K. Petersen
Tejun, > Except for the nit on the last patch, ata part looks good to me. > Martin, how do you wanna route the SCSI part? I want to route it to /dev/null on the grounds of being a BLATANT LAYERING VIOLATION (cue dramatic sound effect). scsi_error.c is SPC territory, we really shouldn't wedge

Re: [PATCH] scsi: ipr: Use dma_pool_zalloc()

2018-03-06 Thread Brian King
On 03/06/2018 02:52 PM, Souptick Joarder wrote: > Any comment for this patch. > > On Sat, Feb 17, 2018 at 9:56 PM, Souptick Joarder > wrote: >> Use dma_pool_zalloc() instead of dma_pool_alloc + memset >> >> Signed-off-by: Souptick Joarder >> --- >>

Re: [PATCH V3 1/8] scsi: hpsa: fix selection of reply queue

2018-03-06 Thread Ming Lei
On Tue, Mar 06, 2018 at 02:24:25PM -0500, Martin K. Petersen wrote: > > Ming, > > > Given both Don and Laurence have verified that patch 1 and patch 2 > > does fix IO hang, could you consider to merge the two first? > > Oh, and I would still need a formal Acked-by: from Don and Tested-by: >

Re: [PATCH V2] scsi: qla2xxx: Fix crashes in qla2x00_probe_one on probe failure

2018-03-06 Thread Martin K. Petersen
Bill, > Because of the shifting around of code in qla2x00_probe_one recently, > failures during adapter initialization can lead to problems, i.e. NULL > pointer crashes and doubly freed data structures which cause eventual > panics. > > This V2 version makes the relevant memory free routines

[GIT PULL] SCSI fixes for 4.16-rc4

2018-03-06 Thread James Bottomley
This patch is mostly fixes for driver specific issues (nine of them) and the storvsc performance improvement with interrupt handling which was dropped from the previous fixes pull request.  We also have two regressions: one is a double call_rcu() in ATA error handling and the other is a missed

Re: [PATCH 2/2] m68k/amiga - Zorro ESP: new zorro_esp.c

2018-03-06 Thread Finn Thain
On Wed, 7 Mar 2018, Michael Schmitz wrote: > The major obstacle now seems to be dynamic allocation of the driver > private data and storing a pointer to that in a way that it can be > retrieved using just the esp pointer. dev_set_drvdata(esp->dev, zep) > causes the module load to crash ...

Re: [PATCH] smartpqi: add in new supported controllers

2018-03-06 Thread Martin K. Petersen
Don, Applied to 4.17/scsi-queue. Thank you! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] scsi: aic94xx: Use dma_pool_zalloc()

2018-03-06 Thread Souptick Joarder
Any comment for this patch. On Thu, Feb 15, 2018 at 10:09 PM, Souptick Joarder wrote: > Use dma_pool_zalloc() instead of dma_pool_alloc + memset > > Signed-off-by: Souptick Joarder > --- > drivers/scsi/aic94xx/aic94xx_hwi.c | 3 +-- > 1 file changed,

Re: [PATCH v3 0/2] scsi: mpt3sas: prevent oops in the shutdown/unload path

2018-03-06 Thread Martin K. Petersen
Mauricio Faria, > Are you OK with / would ack this patchset for stable (v4.14+) ? > > I have the backports ready and can submit if you are OK with it. I am OK. Sreekanth? -- Martin K. Petersen Oracle Linux Engineering

[PATCH v2] scsi: sd: Keep disk read-only when re-reading partition

2018-03-06 Thread Jeremy Cline
If the read-only flag is true on a SCSI disk, re-reading the partition table sets the flag back to false. To observe this bug, you can run: 1. blockdev --setro /dev/sda 2. blockdev --rereadpt /dev/sda 3. blockdev --getro /dev/sda This commit reads the disk's old state and combines it with the

Re: [PATCH] scsi: ipr: Use dma_pool_zalloc()

2018-03-06 Thread Martin K. Petersen
Brian, > Thanks! > > Acked-by: Brian King Not sure where this patch was sent but it's not in my mailbox, nor the list archives. Souptick: Please resubmit to linux-scsi with Brian's Acked-by. -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH v2 0/2] scsi_io_completion cleanup and fix CONDITION MET handling

2018-03-06 Thread Martin K. Petersen
Doug, > Since this patchset seems to have frightened away reviewers, I'll try > again. Yeah, I tried and it was a bit too big to digest (for such a critical piece of code). > Now I'll send a single patch to do the fix for CONDITION MET. That > will be followed by a 5 part patchset cleaning up

Re: [PATCH] scsi: megaraid: Use dma_pool_zalloc()

2018-03-06 Thread Martin K. Petersen
Souptick, > Use dma_pool_zalloc() instead of dma_pool_alloc + memset Applied to 4.17/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering

[PATCH 3/5] scsi_io_completion: add _action helper function

2018-03-06 Thread Douglas Gilbert
ChangeLog: - move the bottom half of the code in scsi_io_completion that is based on a local enum called 'action' to a helper function with that suffix - replicate the ACTION_REPREP case code since the former 'goto requeue' would now need to jump into another function which is

[PATCH 4/5] scsi_io_completion: conditional hints on fastpath

2018-03-06 Thread Douglas Gilbert
ChangeLog: - add likely() and unlikely() hints to conditionals on or near the fastpath - fix a comment in scsi_io_completion_action() Signed-off-by: Douglas Gilbert --- drivers/scsi/scsi_lib.c | 26 -- 1 file changed, 12 insertions(+), 14

[PATCH 5/5] scsi_io_completion: convert BUGs to WARNs

2018-03-06 Thread Douglas Gilbert
ChangeLog: - replace BUG() and BUG_ON() with WARN variants. - try to send sensible reports (without flooding the log) and continuations that won't make things worse Signed-off-by: Douglas Gilbert --- drivers/scsi/scsi_lib.c | 14 +++--- 1 file changed, 11

Re: [PATCH v2 06/38] cxlflash: Read host function configuration

2018-03-06 Thread Andrew Donnellan
On 27/02/18 09:20, Uma Krishnan wrote: Per the OCXL specification, the underlying host can have multiple AFUs per function with each function supporting its own configuration. The host function configuration is read on the initialization path to evaluate the number of functions present and

Re: [PATCH V4] scsi: core: use blk_mq_requeue_request in __scsi_queue_insert

2018-03-06 Thread Martin K. Petersen
Jianchao, > In scsi core, __scsi_queue_insert should just put request back on > the queue and retry using the same command as before. However, for > blk-mq, scsi_mq_requeue_cmd is employed here which will unprepare > the request. To align with the semantics of __scsi_queue_insert, > use

RE: [PATCH v3 0/2] scsi: mpt3sas: prevent oops in the shutdown/unload path

2018-03-06 Thread Sreekanth Reddy
-Original Message- From: Martin K. Petersen [mailto:martin.peter...@oracle.com] Sent: Wednesday, March 7, 2018 6:48 AM To: Mauricio Faria de Oliveira Cc: Martin K. Petersen; j...@linux.vnet.ibm.com; linux-scsi@vger.kernel.org; bart.vanass...@wdc.com; sreekanth.re...@broadcom.com;

Re: [PATCH] Improve ZBC/ZAC error handling

2018-03-06 Thread Damien Le Moal
On 2018/03/07 3:49, Martin K. Petersen wrote: > > Tejun, > >> Except for the nit on the last patch, ata part looks good to me. >> Martin, how do you wanna route the SCSI part? > > I want to route it to /dev/null on the grounds of being a BLATANT > LAYERING VIOLATION (cue dramatic sound effect).

Re: [PATCH V3 8/8] scsi: megaraid: improve scsi_mq performance via .host_tagset

2018-03-06 Thread Ming Lei
On Wed, Feb 28, 2018 at 08:28:48PM +0530, Kashyap Desai wrote: > Ming - > > Quick testing on my setup - Performance slightly degraded (4-5% drop)for > megaraid_sas driver with this patch. (From 1610K IOPS it goes to 1544K) > I confirm that after applying this patch, we have #queue = #numa node.

[PATCH] scsi: jazz_esp, sun3x_esp: Pass struct device pointer in dma calls

2018-03-06 Thread Finn Thain
In jazz_esp and sun3x_esp, the esp_driver_ops methods pass esp->dev in dma api calls as if it was a pointer to a struct device. But it actually points to a struct platform_device. Fix this. Cc: Thomas Bogendoerfer Signed-off-by: Finn Thain

Re: [PATCH] scsi: libsas: defer ata device eh commands to libata

2018-03-06 Thread Jason Yan
On 2018/3/7 2:29, Dan Williams wrote: On Tue, Mar 6, 2018 at 10:04 AM, Martin K. Petersen wrote: When ata device doing EH, some commands still attached with tasks are not passed to libata when abort failed or recover failed, so libata did not handle these

Re: [PATCH v2] lpfc: use __raw_writeX on DPP copies

2018-03-06 Thread Martin K. Petersen
James, Minor patch formatting nits: > This patch replaces: > https://www.spinics.net/lists/linux-scsi/msg117838.html Patch revision commentary needs to go below the "---" delimiter so it doesn't end up in the commit description. > A prior lpfc patch: > scsi: lpfc: Add push-to-adapter support

Re: [PATCH v2 0/2] scsi_io_completion cleanup and fix CONDITION MET handling

2018-03-06 Thread Douglas Gilbert
Since this patchset seems to have frightened away reviewers, I'll try again. Now I'll send a single patch to do the fix for CONDITION MET. That will be followed by a 5 part patchset cleaning up the scsi_io_completion() function. Douglas Gilbert On 2018-02-28 01:23 AM, Douglas Gilbert wrote:

Re: [PATCH v2 05/38] cxlflash: Hardware AFU for OCXL

2018-03-06 Thread Andrew Donnellan
On 27/02/18 09:20, Uma Krishnan wrote: When an adapter is initialized, transport specific configuration and MMIO mapping details need to be saved. For CXL, this data is managed by the underlying kernel module. To maintain a separation between the cxlflash core and underlying transports,

Re: [PATCH v2] scsi: sd: Keep disk read-only when re-reading partition

2018-03-06 Thread Martin K. Petersen
Jeremy, > Sorry about this, but there's a bug in the first version of this patch. > I'm not sure what the protocol is for sending revised patches when the > earlier version got accepted, but I don't see the first version in > 4.16/scsi-fixes yet. It's your lucky day! I botched fixing up

Re: dmesg flooded with "Very big device. Trying to use READ CAPACITY(16)"

2018-03-06 Thread Martin K. Petersen
Menion, > Operating big capacity HDD such 8TB with complex filesystems like > BTRFS in RAID mode endup in dmesg get flooded by this log, due too > many capacity checks (opaque to the filesystem itself) What's your definition of flooded? How many do you see? Also, what kind of controller are

Re: [PATCH v2 04/38] cxlflash: Introduce OCXL backend

2018-03-06 Thread Andrew Donnellan
On 27/02/18 09:20, Uma Krishnan wrote: Add initial infrastructure to support a new cxlflash transport, OCXL. Claim a dependency on OCXL and add a new file, ocxl_hw.c, which will host the backend routines that are specific to OCXL. Signed-off-by: Uma Krishnan

[PATCH 0/5] scsi_io_completion cleanup

2018-03-06 Thread Douglas Gilbert
This patchset assumes the presence of "[PATCH v4] Make SCSI Status CONDITION MET equivalent to GOOD". While working on that patch the author had trouble following the logic in the scsi_io_completion() function found in scsi_lib.c . That led to a rework of the scsi_io_completion() which is now much

[PATCH 2/5] scsi_io_completion: add _nz_result helper

2018-03-06 Thread Douglas Gilbert
ChangeLog: - break out several interwined paths when cmd->result is non zero and place them in scsi_io_completion_nz_result helper function - after a review comment that proposed reducing the helper's former 2 return values to a single return value, use BLK_STS_NOTSUPP as a marker

[PATCH 1/5] scsi_io_completion: rename variables and comments

2018-03-06 Thread Douglas Gilbert
ChangeLog: - add comments to scsi_end_request() noting what its bool return value means - change some variable names in scsi_io_completion() - reword some inline comments; move some comments that seemed to be separated from the code they referred to Signed-off-by: Douglas Gilbert

[PATCH v4] Make SCSI Status CONDITION MET equivalent to GOOD

2018-03-06 Thread Douglas Gilbert
The SCSI PRE-FETCH (10 or 16) command is present both on hard disks and some SSDs. It is useful when the address of the next block(s) to be read is known but it is not following the LBA of the current READ (so read-ahead won't help). It returns two "good" SCSI Status values. If the requested

Re: [PATCH V3 1/8] scsi: hpsa: fix selection of reply queue

2018-03-06 Thread Martin K. Petersen
Ming, > Please consider 2/8 too since it is still a fix. I still need the driver maintainer to ack the change. -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH 2/2] m68k/amiga - Zorro ESP: new zorro_esp.c

2018-03-06 Thread Michael Schmitz
Hi Finn, Am 07.03.2018 um 13:54 schrieb Finn Thain: > On Wed, 7 Mar 2018, Michael Schmitz wrote: > >> The major obstacle now seems to be dynamic allocation of the driver >> private data and storing a pointer to that in a way that it can be >> retrieved using just the esp pointer.

Re: [PATCH 2/2] m68k/amiga - Zorro ESP: new zorro_esp.c

2018-03-06 Thread Michael Schmitz
Hi Geert, OK, in that case I'll need to work out something similar to the test for optional SCSI function on the Blizzard 1230/1260 to find out what board I have when dealing with the duplicate Fastlane/Blizzard1230II ID. Is the board base address as returned by zorro_resource_start() reliable

Re: [PATCH v3 5/8] scsi: hisi_sas: increase timer expire of internal abort task

2018-03-06 Thread Hannes Reinecke
On 03/05/2018 03:48 PM, John Garry wrote: > From: Xiaofei Tan > > The current 110ms expiry time is not long enough for the internal > abort task. > > The reason is that the internal abort task could be blocked in HW > if the HW is retrying to set up link. The internal

Re: [PATCH v3 8/8] scsi: hisi_sas: Code cleanup and minor bug fixes

2018-03-06 Thread Hannes Reinecke
On 03/05/2018 03:48 PM, John Garry wrote: > From: Xiang Chen > > The patch does some code cleanup and fixes some small bugs: > - Correct return status of phy_up_v3_hw() > - Add static for function phy_get_max_linkrate_v3_hw() > - Change exception return status when no

[PATCH] scsi: ufs: ufshcd_dump_regs to use memcpy_fromio

2018-03-06 Thread Tomas Winkler
ufshcd_dump_regs should use memcpy_fromio to read host registers instead of directly accessing using memcpy. The same function is utilized in ufs-qcom. Elminite compilation warning drivers/scsi/ufs/ufshcd.c:356:9: warning: incorrect type in argument 6 (different address spaces)

[PATCH v2] scsi: libsas: defer ata device eh commands to libata

2018-03-06 Thread Jason Yan
When ata device doing EH, some commands still attached with tasks are not passed to libata when abort failed or recover failed, so libata did not handle these commands. After these commands done, sas task is freed, but ata qc is not freed. This will cause ata qc leak and trigger a warning like

Re: [PATCH V4] scsi: core: use blk_mq_requeue_request in __scsi_queue_insert

2018-03-06 Thread jianchao.wang
Hi Martin Can you take your precious time to review this ? Thanks in advice. Jianchao On 03/03/2018 09:54 AM, Jianchao Wang wrote: > In scsi core, __scsi_queue_insert should just put request back on > the queue and retry using the same command as before. However, for > blk-mq,

dmesg flooded with "Very big device. Trying to use READ CAPACITY(16)"

2018-03-06 Thread Menion
Hi all Operating big capacity HDD such 8TB with complex filesystems like BTRFS in RAID mode endup in dmesg get flooded by this log, due too many capacity checks (opaque to the filesystem itself) The logs come from here: https://elixir.bootlin.com/linux/latest/source/drivers/scsi/sd.c#L2508 The

Re: [PATCH] scsi: pmcraid: Use dma_pool_zalloc()

2018-03-06 Thread Souptick Joarder
Any comment for this patch. On Thu, Feb 15, 2018 at 8:44 PM, Souptick Joarder wrote: > Use dma_pool_zalloc() instead of dma_pool_alloc + memset > > Signed-off-by: Souptick Joarder > --- > drivers/scsi/pmcraid.c | 4 +--- > 1 file changed, 1

Re: [PATCH] scsi: mvsas: Use dma_pool_zalloc()

2018-03-06 Thread Souptick Joarder
Any comment for this patch. On Thu, Feb 15, 2018 at 9:28 PM, Souptick Joarder wrote: > Use dma_pool_zalloc() instead of dma_pool_alloc + memset > > Signed-off-by: Souptick Joarder > --- > drivers/scsi/mvsas/mv_sas.c | 3 +-- > 1 file changed, 1

Re: [PATCH 2/2] m68k/amiga - Zorro ESP: new zorro_esp.c

2018-03-06 Thread Finn Thain
On Tue, 6 Mar 2018, Michael Schmitz wrote: > The whole !write branch will never be executed, and I could just omit it > entirely for now, or leave it as it was in the Mac driver. > We could make use of the !write branch in zorro_esp, even if it was only to figure out the SELAS/MSG OUT issue

RE: [PATCH] scsi: megaraid: Use dma_pool_zalloc()

2018-03-06 Thread Sumit Saxena
-Original Message- From: Souptick Joarder [mailto:jrdr.li...@gmail.com] Sent: Thursday, February 15, 2018 9:55 PM To: kashyap.de...@broadcom.com; sumit.sax...@broadcom.com; shivasharan.srikanteshw...@broadcom.com Cc: megaraidlinux@broadcom.com; linux-scsi@vger.kernel.org Subject:

Re: [PATCH v3 8/8] scsi: hisi_sas: Code cleanup and minor bug fixes

2018-03-06 Thread John Garry
Hi Hannes, Thanks for checking this. > + } > return -EINVAL? >return 0; > } [ ... ] > + } > >return 0; > } return -EINVAL? > @@ -2408,7 +2410,7 @@ static void slot_err_v2_hw(struct hisi_hba *hisi_hba, >spin_lock_irqsave(_hba->lock, flags); >

Re: [PATCH v3 5/8] scsi: hisi_sas: increase timer expire of internal abort task

2018-03-06 Thread John Garry
On 06/03/2018 11:23, Hannes Reinecke wrote: On 03/05/2018 03:48 PM, John Garry wrote: From: Xiaofei Tan The current 110ms expiry time is not long enough for the internal abort task. The reason is that the internal abort task could be blocked in HW if the HW is retrying

Re: [PATCH V2] scsi: qla2xxx: Fix crashes in qla2x00_probe_one on probe failure

2018-03-06 Thread Hannes Reinecke
On 03/05/2018 06:02 AM, Bill Kuzeja wrote: > Because of the shifting around of code in qla2x00_probe_one recently, > failures during adapter initialization can lead to problems, i.e. NULL > pointer crashes and doubly freed data structures which cause eventual > panics. > > This V2 version makes