Re: [PATCH v3] m68k/amiga - Amiga Zorro NCR53C9x boards: new zorro_esp.c

Hi Michael, On Mon, Mar 12, 2018 at 8:26 AM, Michael Schmitz wrote: > From: Michael Schmitz > > New combined SCSI driver for all ESP based Zorro SCSI boards for > m68k Amiga. > > Code largely based on board specific parts of the old drivers (blz1230.c,

Re: [PATCH v3] m68k/amiga - Amiga Zorro NCR53C9x boards: new zorro_esp.c

Hi Geert, thanks for the review - largely uncontroversial except for the volatile... Am 14.03.2018 um 20:49 schrieb Geert Uytterhoeven: >> +/* Blizzard 1230 DMA interface */ >> + >> +struct blz1230_dma_registers { >> + volatile unsigned char dma_addr;/* DMA address [0x]

Re: [PATCH v3] m68k/amiga - Amiga Zorro NCR53C9x boards: new zorro_esp.c

Hi Michael, On Wed, Mar 14, 2018 at 9:23 AM, Michael Schmitz wrote: > thanks for the review - largely uncontroversial except for the volatile... The presence of volatile in drivers is always considered controversial ;-) > Am 14.03.2018 um 20:49 schrieb Geert Uytterhoeven:

Re: [PATCH v3] m68k/amiga - Amiga Zorro NCR53C9x boards: new zorro_esp.c

> > I forgot to add your Reviewed-by tag - will do that for the next > version, OK? Sure. Geert's tag may be harder to bag though :-) --

Re: [PATCH] scsi: iscsi_tcp: set BDI_CAP_STABLE_WRITES when data digest enabled

Would anyone please take a review at this patch ? Thanks in advace Jianchao On 03/07/2018 08:29 PM, Jianchao Wang wrote: > iscsi tcp will first send out data, then calculate and send data > digest. If we don't have BDI_CAP_STABLE_WRITES, the page cache will > be written in spite of the on going

Re: [PATCH v3] m68k/amiga - Amiga Zorro NCR53C9x boards: new zorro_esp.c

Hi Tuomas, oddly enough, it does. How embarrassing... Hope I got the names of the boards right this time. Thanks for spotting this! Cheers, Michael Am 14.03.2018 um 20:13 schrieb Vainikka Tuomas: > The config description lists 53c700 devices, not ESP devices? > > -Tuomas >

Re: [PATCH] scsi: aic94xx: Use dma_pool_zalloc()

Hi Martin, Any comment for this patch ? On Wed, Mar 7, 2018 at 2:25 AM, Souptick Joarder wrote: > Any comment for this patch. > > On Thu, Feb 15, 2018 at 10:09 PM, Souptick Joarder > wrote: >> Use dma_pool_zalloc() instead of dma_pool_alloc + memset

Re: [PATCH] scsi: mvsas: Use dma_pool_zalloc()

Hi Martin, Any comment for this patch ? On Tue, Mar 6, 2018 at 1:31 PM, Souptick Joarder wrote: > Any comment for this patch. > > On Thu, Feb 15, 2018 at 9:28 PM, Souptick Joarder > wrote: >> Use dma_pool_zalloc() instead of dma_pool_alloc + memset

Re: [PATCH v3] m68k/amiga - Amiga Zorro NCR53C9x boards: new zorro_esp.c

The config description lists 53c700 devices, not ESP devices? -Tuomas From: linux-m68k-ow...@vger.kernel.org on behalf of Michael Schmitz Sent: 12 March 2018 09:26:40 To: linux-scsi@vger.kernel.org

Re: [PATCH] scsi: pmcraid: Use dma_pool_zalloc()

Hi Martin, Any comment for this patch ? On Tue, Mar 6, 2018 at 1:31 PM, Souptick Joarder wrote: > Any comment for this patch. > > On Thu, Feb 15, 2018 at 8:44 PM, Souptick Joarder > wrote: >> Use dma_pool_zalloc() instead of dma_pool_alloc + memset

Re: [PATCH v3] m68k/amiga - Amiga Zorro NCR53C9x boards: new zorro_esp.c

Hi Geert, Am 14.03.2018 um 21:30 schrieb Geert Uytterhoeven: > Hi Michael, > > On Wed, Mar 14, 2018 at 9:23 AM, Michael Schmitz wrote: >> thanks for the review - largely uncontroversial except for the volatile... > > The presence of volatile in drivers is always

Re: [PATCH 10/12] scsi: remove the mvme147 driver

Ah, bummer. I wanted to keep the MVME drivers but I never managed to get them ported to the new SCSI layer. Anyone out there who could help me with that? Adrian > On Mar 14, 2018, at 12:48 PM, Christoph Hellwig wrote: > > This driver hasn't seen any recent bug fixing and is one

Re: [PATCH 10/13] qla2xxx: Fix FC-NVMe IO abort during driver reset

On 03/12/2018 07:16 PM, Himanshu Madhani wrote: > From: Darren Trapp > > Signed-off-by: Darren Trapp > Signed-off-by: Himanshu Madhani > --- > drivers/scsi/qla2xxx/qla_nvme.c | 17 - >

Re: [PATCH V5 2/5] scsi: megaraid_sas: fix selection of reply queue

Same as for hpsa.. Reviewed-by: Christoph Hellwig

Re: [PATCH V5 1/5] scsi: hpsa: fix selection of reply queue

I still don't like the code duplication, but I guess I can fix this up in one of the next merge windows myself.. Reviewed-by: Christoph Hellwig

Re: Debugging SCSI 'UNMAP' ("Logical Block Provisioning") failure on an SSD

Am Dienstag, den 13.03.2018, 12:50 +0100 schrieb Kashyap Chamarthy: > Earlier, I didn't know which list to email, so I wrote to Martin K. > Petersen (who pointed me to the lists when I asked where I can post > publicly), and he made this observation on the above quoted text: > >     "Linux can

Re: [PATCH 01/13] qla2xxx: Remove unneeded message and minor cleanup for FC-NVMe

On 03/12/2018 07:16 PM, Himanshu Madhani wrote: > Signed-off-by: Himanshu Madhani > --- > drivers/scsi/qla2xxx/qla_nvme.c | 11 +++ > 1 file changed, 3 insertions(+), 8 deletions(-) > Reviewed-by: Hannes Reinecke Cheers, Hannes -- Dr.

Re: [PATCH 02/13] qla2xxx: Set IIDMA and fcport state before qla_nvme_register_remote()

On 03/12/2018 07:16 PM, Himanshu Madhani wrote: > From: Darren Trapp > > Signed-off-by: Darren Trapp > Signed-off-by: Himanshu Madhani > --- > drivers/scsi/qla2xxx/qla_init.c | 5 +++-- > 1 file changed, 3

Re: Debugging SCSI 'UNMAP' ("Logical Block Provisioning") failure on an SSD

Am Mittwoch, den 14.03.2018, 11:22 +0100 schrieb Kashyap Chamarthy: > I see.  So I ran `dmesg -w`, as I attached the disk & see the following: UAS and no quirk for your device. It looks like it indeed just does not support TRIM. Sorry Oliver

Re: [PATCH 08/13] qla2xxx: Remove nvme_done_list

On 03/12/2018 07:16 PM, Himanshu Madhani wrote: > From: Darren Trapp > > Signed-off-by: Darren Trapp > Signed-off-by: Himanshu Madhani > --- > drivers/scsi/qla2xxx/qla_def.h | 1 - >

Re: [PATCH 07/13] qla2xxx: Return busy if rport going away

On 03/12/2018 07:16 PM, Himanshu Madhani wrote: > From: Darren Trapp > > This patch adds mechanism to retur EBUSY if rport is going away > to prevent exhausting FC-NVMe layer's retry counter. > > Signed-off-by: Darren Trapp > Signed-off-by:

[PATCH 03/12] aha1740: stop using scsi_unregister

aha1740 doesn't use scsi_register, so it should not use scsi_unregister either. Signed-off-by: Christoph Hellwig --- drivers/scsi/aha1740.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/aha1740.c b/drivers/scsi/aha1740.c index

Re: Debugging SCSI 'UNMAP' ("Logical Block Provisioning") failure on an SSD

On Wed, Mar 14, 2018 at 10:52:36AM +0100, Oliver Neukum wrote: > Am Dienstag, den 13.03.2018, 12:50 +0100 schrieb Kashyap Chamarthy: > > Earlier, I didn't know which list to email, so I wrote to Martin K. > > Petersen (who pointed me to the lists when I asked where I can post > > publicly), and he

Re: [PATCH 05/13] qla2xxx: Add FC-NVMe abort processing

On 03/12/2018 07:16 PM, Himanshu Madhani wrote: > From: Darren Trapp > > Signed-off-by: Darren Trapp > Signed-off-by: Himanshu Madhani > --- > drivers/scsi/qla2xxx/qla_nvme.c | 36

Re: [PATCH 06/13] qla2xxx: Fix n2n_ae flag to prevent dev_loss on PDB change

On 03/12/2018 07:16 PM, Himanshu Madhani wrote: > From: Darren Trapp > Some more text would be nice; not everyone knows what n2n_ae or PDB is ... > Signed-off-by: Darren Trapp > Signed-off-by: Himanshu Madhani >

Re: [PATCH V5 4/5] scsi: virtio_scsi: fix IO hang caused by irq vector automatic affinity

Looks good, Reviewed-by: Christoph Hellwig

Re: [PATCH V5 5/5] scsi: virtio_scsi: unify scsi_host_template

Looks good, Reviewed-by: Christoph Hellwig

Re: [PATCH 03/13] qla2xxx: Add changes for devloss timeout in driver

On 03/12/2018 07:16 PM, Himanshu Madhani wrote: > From: Darren Trapp > > Add support for error recovery within devloss timeout, now that > FC-NVMe transport support devloss timeout. > > Signed-off-by: Darren Trapp > Signed-off-by: Himanshu

Re: [PATCH 11/13] qla2xxx: Cleanup code to improve FC-NVMe error handling

On 03/12/2018 07:16 PM, Himanshu Madhani wrote: > From: Darren Trapp > > Signed-off-by: Darren Trapp > Signed-off-by: Himanshu Madhani > --- > drivers/scsi/qla2xxx/qla_isr.c | 78 >

Re: [PATCH 09/13] qla2xxx: Fix retry for PRLI RJT with reason of BUSY

On 03/12/2018 07:16 PM, Himanshu Madhani wrote: > From: Darren Trapp > > Signed-off-by: Darren Trapp > Signed-off-by: Himanshu Madhani > --- > drivers/scsi/qla2xxx/qla_dbg.c | 2 +- >

[PATCH 07/12] scsi: remove the fdomain and fdomain_cs drivers

These drivers haven't seen any recent bug fixing and are two of the last drivers using the scsi_module.c infrastruture that has been deprecated 15 years ago. Signed-off-by: Christoph Hellwig --- MAINTAINERS|6 - arch/powerpc/configs/c2k_defconfig |1

[PATCH 05/12] scsi: remove the eata_pio driver

This driver hasn't seen any recent bug fixing and is one of the last drivers using the scsi_module.c infrastruture that has been deprecated 15 years ago. Signed-off-by: Christoph Hellwig --- drivers/scsi/Kconfig| 14 - drivers/scsi/Makefile | 1 -

[PATCH 08/12] scsi: remove the NCR53c406a driver

This driver hasn't seen any recent bug fixing and is one of the last drivers using the scsi_module.c infrastruture that has been deprecated 15 years ago. Signed-off-by: Christoph Hellwig --- drivers/scsi/Kconfig | 12 - drivers/scsi/Makefile |1 -

[PATCH 10/12] scsi: remove the mvme147 driver

This driver hasn't seen any recent bug fixing and is one of the last drivers using the scsi_module.c infrastruture that has been deprecated 15 years ago. Signed-off-by: Christoph Hellwig --- drivers/scsi/Kconfig | 8 --- drivers/scsi/Makefile | 1 - drivers/scsi/mvme147.c |

[PATCH 11/12] scsi: remove the old scsi_module.c initialization model

After more than 15 years all users of this legacy interface are finally gone. Rest in peace! Signed-off-by: Christoph Hellwig --- Documentation/driver-api/scsi.rst | 6 -- Documentation/scsi/scsi_mid_low_api.txt | 122 +--- drivers/scsi/hosts.c

[PATCH 04/12] esas2r: remove initialization / cleanup dead wood

esas2r has been converted to hotplug style initialization long ago, but kept various remant of the old-style scsi_module.c initialization around. Remove those. Signed-off-by: Christoph Hellwig --- drivers/scsi/esas2r/esas2r.h | 2 -- drivers/scsi/esas2r/esas2r_init.c | 21

[PATCH 06/12] scsi: remove the eata driver

This driver hasn't seen any recent bug fixing and is one of the last drivers using the scsi_module.c infrastruture that has been deprecated 15 years ago. Signed-off-by: Christoph Hellwig --- drivers/scsi/Kconfig | 48 - drivers/scsi/Makefile |1 - drivers/scsi/eata.c |

[PATCH 09/12] scsi: remove the sym53c416 driver

This driver hasn't seen any recent bug fixing and is one of the last drivers using the scsi_module.c infrastruture that has been deprecated 15 years ago. Signed-off-by: Christoph Hellwig --- Documentation/scsi/scsi-parameters.txt | 3 - drivers/scsi/Kconfig |

remove obsolete drivers and scsi_module.c

Hi all, this series removes the obsolete scsi_module.c infratructure that has been obsolete for 15 years, and the remaining drivers that depend on them.

[PATCH 02/12] ips: don't set .detect and .release in the host template

Since moving away from using scsi_module.c these were never called. The implementations are called directly, though so they remain. Signed-off-by: Christoph Hellwig --- drivers/scsi/ips.c | 4 1 file changed, 4 deletions(-) diff --git a/drivers/scsi/ips.c b/drivers/scsi/ips.c

[PATCH 01/12] dpt_i2o: stop using scsi_unregister

dpt_i2o doesn't use scsi_register, so it should not use scsi_unregister either. Also refactor the module exit path to make a little more sense. Signed-off-by: Christoph Hellwig --- drivers/scsi/dpt_i2o.c | 16 drivers/scsi/dpti.h| 1 - 2 files changed, 4

Re: [PATCH 4/5] scsi_io_completion: conditional hints on fastpath

On 2018-03-09 10:13 AM, Johannes Thumshirn wrote: On Tue, Mar 06, 2018 at 10:21:33PM -0500, Douglas Gilbert wrote: ChangeLog: - add likely() and unlikely() hints to conditionals on or near the fastpath - fix a comment in scsi_io_completion_action() Do you have any numbers what this

Re: [PATCH 12/13] qla2xxx: Fix Async GPN_FT for FCP and FC-NVMe scan

On 03/12/2018 07:16 PM, Himanshu Madhani wrote: > From: Quinn Tran > > This patch combines FCP and FC-NVMe scan into single scan when > driver detects FC-NVMe capability on same port. > > Signed-off-by: Quinn Tran > Signed-off-by: Himanshu Madhani

Re: [PATCH 04/13] qla2xxx: Restore ZIO threshold setting

On 03/12/2018 07:16 PM, Himanshu Madhani wrote: > From: Darren Trapp > > Signed-off-by: Darren Trapp > Signed-off-by: Himanshu Madhani > --- > drivers/scsi/qla2xxx/qla_nvme.c | 5 - > 1 file changed, 5

[PATCH 12/12] scsi: remove ChangeLog.1992-1997

This 20+ year old changelog has no useful information for kernel development or users, so remove it. Signed-off-by: Christoph Hellwig --- Documentation/scsi/ChangeLog.1992-1997 | 2023 1 file changed, 2023 deletions(-) delete mode 100644

[PATCH] scsi: eata: drop EATA and EATA-PIO drivers

Remove support for EATA and EATA-PIO SCSI host adapters. These devices are ancient and, apparently, nobody is still using them. https://lkml.kernel.org/r/20180313090540.GA4810%20()%20infradead%20!%20org Signed-off-by: Salvatore Mesoraca ---

Re: [PATCH 10/12] scsi: remove the mvme147 driver

Hi Christoph, On Wed, Mar 14, 2018 at 2:16 PM, Christoph Hellwig wrote: > On Wed, Mar 14, 2018 at 12:56:31PM +0100, John Paul Adrian Glaubitz wrote: >> Ah, bummer. I wanted to keep the MVME drivers but I never managed to get >> them ported to the new SCSI layer. >> >> Anyone out

Re: [PATCH] scsi: sd: Remember that READ CAPACITY(16) succeeded

On Wed, 2018-03-14 at 12:15 -0400, Martin K. Petersen wrote: > The USB storage glue sets the try_rc_10_first flag in an attempt to > avoid wedging poorly implemented legacy USB devices. > > If the device capacity is too large to be expressed in the provided > response buffer field of READ

Re: [PATCH] scsi: scsi_dh_alua: Correct comment for alua_alloc_pg()

On Wed, 2018-03-14 at 09:52 -0400, John Pittman wrote: > In the comment for function alua_alloc_pg() the argument '@h' is > mistakenly referred to.  Fix this by replacing it with the correct > argument reference, '@tpgs', and provide a short description. > > Signed-off-by: John Pittman

Re: [GIT PULL] SCSI fixes for 4.16-rc5

On Wed, Mar 14, 2018 at 4:28 PM, James Bottomley wrote: > - vfree(ha->optrom_buffer); > - kfree(ha->nvram); > - kfree(ha->npiv_info); > - kfree(ha->swl); > - kfree(ha->loop_id_map); > + > + if (ha->optrom_buffer) > +

[PATCH, resend] scsi: Avoid that .queuecommand() gets called for a quiesced SCSI device

Several SCSI transport and LLD drivers surround code that does not tolerate concurrent calls of .queuecommand() with scsi_target_block() / scsi_target_unblock(). These last two functions use blk_mq_quiesce_queue() / blk_mq_unquiesce_queue() for scsi-mq request queues to prevent concurrent

Re: [PATCH, resend] scsi: Avoid that .queuecommand() gets called for a quiesced SCSI device

On Wed, 2018-03-14 at 15:45 -0700, Bart Van Assche wrote: > Several SCSI transport and LLD drivers surround code that does not > tolerate concurrent calls of .queuecommand() with scsi_target_block() > / > scsi_target_unblock(). These last two functions use > blk_mq_quiesce_queue() /

[GIT PULL] SCSI fixes for 4.16-rc5

This is four patches, consisting of one regression from the merge window (qla2xxx) one lonstanding memory leak (sd_zbc) one event queue mislabelling which we want to eliminate to discourage the pattern (mpt3sas) and one behaviour change because re-reading the partition table shouldn't clear the ro

[PATCH v2 00/13] qla2xxx: Fixes for FC-NVMe

Hi Martin, This patch series addresses issue with FC-NVMe abort handling in the driver. Code has been cleaned up and devloss timeout support has been added in qla2xxx. Please apply this series to 4.17/scsi-queue at your earliest convenience. Hi Christoph, Sagi, Johannes, James, Please review

[PATCH v2 09/13] qla2xxx: Fix retry for PRLI RJT with reason of BUSY

From: Darren Trapp Signed-off-by: Darren Trapp Signed-off-by: Himanshu Madhani Reviewed-by: Hannes Reinecke --- drivers/scsi/qla2xxx/qla_dbg.c | 2 +- drivers/scsi/qla2xxx/qla_init.c | 13

[PATCH v2 01/13] qla2xxx: Remove unneeded message and minor cleanup for FC-NVMe

Signed-off-by: Himanshu Madhani Reviewed-by: Hannes Reinecke --- drivers/scsi/qla2xxx/qla_nvme.c | 11 +++ 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_nvme.c b/drivers/scsi/qla2xxx/qla_nvme.c index

[PATCH v2 06/13] qla2xxx: Fix n2n_ae flag to prevent dev_loss on PDB change

From: Darren Trapp On a port db changes, this patch will set n2n_ae flag for N2N connection when requesting for Report ID Acquition MBX, instead of Loop Initialization or point to point asynchronous events. Signed-off-by: Darren Trapp

[PATCH v2 03/13] qla2xxx: Add changes for devloss timeout in driver

From: Darren Trapp Add support for error recovery within devloss timeout, now that FC-NVMe transport support devloss timeout. Signed-off-by: Darren Trapp Signed-off-by: Himanshu Madhani Reviewed-by: Hannes Reinecke

[PATCH v2 02/13] qla2xxx: Set IIDMA and fcport state before qla_nvme_register_remote()

From: Darren Trapp Signed-off-by: Darren Trapp Signed-off-by: Himanshu Madhani Reviewed-by: Hannes Reinecke --- drivers/scsi/qla2xxx/qla_init.c | 5 +++-- 1 file changed, 3 insertions(+), 2

[PATCH v2 04/13] qla2xxx: Restore ZIO threshold setting

From: Darren Trapp Signed-off-by: Darren Trapp Signed-off-by: Himanshu Madhani Reviewed-by: Hannes Reinecke --- drivers/scsi/qla2xxx/qla_nvme.c | 5 - 1 file changed, 5 deletions(-) diff --git

[PATCH v2 07/13] qla2xxx: Return busy if rport going away

From: Darren Trapp This patch adds mechanism to return EBUSY if rport is going away to prevent exhausting FC-NVMe layer's retry counter. Signed-off-by: Darren Trapp Signed-off-by: Himanshu Madhani Reviewed-by:

[PATCH v2 08/13] qla2xxx: Remove nvme_done_list

From: Darren Trapp Signed-off-by: Darren Trapp Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_def.h | 1 - drivers/scsi/qla2xxx/qla_gbl.h | 2 -- drivers/scsi/qla2xxx/qla_init.c | 1 -

[PATCH v2 12/13] qla2xxx: Fix Async GPN_FT for FCP and FC-NVMe scan

From: Quinn Tran This patch combines FCP and FC-NVMe scan into single scan when driver detects FC-NVMe capability on same port. Signed-off-by: Quinn Tran Signed-off-by: Himanshu Madhani ---

[PATCH v2 10/13] qla2xxx: Fix FC-NVMe IO abort during driver reset

From: Darren Trapp Signed-off-by: Darren Trapp Signed-off-by: Himanshu Madhani Reviewed-by: Hannes Reinecke --- drivers/scsi/qla2xxx/qla_nvme.c | 17 -

[PATCH v2 11/13] qla2xxx: Cleanup code to improve FC-NVMe error handling

From: Darren Trapp This patch cleans up ABTS handling for FC-NVMe by - Removing allocation of sp, instead pass the sp pointer for abort IOCB - Fix error handling from Transport failure - set outstanding_cmds array to NULL for nvme completion Signed-off-by: Darren Trapp

[PATCH v2 13/13] qla2xxx: Update driver version to 10.00.00.06-k

Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_version.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/qla2xxx/qla_version.h b/drivers/scsi/qla2xxx/qla_version.h index 549bef9afddd..0c55d7057280 100644 ---

[PATCH v2 05/13] qla2xxx: Add FC-NVMe abort processing

From: Darren Trapp Signed-off-by: Darren Trapp Signed-off-by: Himanshu Madhani Reviewed-by: Hannes Reinecke --- drivers/scsi/qla2xxx/qla_nvme.c | 36 ++--

Re: [PATCH V5 0/5] SCSI: fix selection of reply(hw) queue

Ming, > The patches fixes reply queue(virt-queue on virtio-scsi) selection on > hpsa, megaraid_sa and virtio-scsi, and IO hang can be caused easily by > this issue. I clarified all the commit descriptions. There were also a bunch of duplicate review tags and other warnings. Please run

Re: [PATCH] scsi: scsi_transport_iscsi: use put_device() instead of kfree()

> Never directly free @dev after calling device_register(), even > if it returned an error! Always use put_device() to give up the > reference initialized. Lee, Chris: Please review! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] scsi: iscsi_tcp: set BDI_CAP_STABLE_WRITES when data digest enabled

> iscsi tcp will first send out data, then calculate and send data > digest. If we don't have BDI_CAP_STABLE_WRITES, the page cache will > be written in spite of the on going writeback. Consequently, wrong > digest will be got and sent to target. > > To fix this, set BDI_CAP_STABLE_WRITES when

Re: [PATCH 12/12] scsi: remove ChangeLog.1992-1997

Christoph, > This 20+ year old changelog has no useful information for kernel > development or users, so remove it. Applied to 4.17/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH 01/12] dpt_i2o: stop using scsi_unregister

Christoph, > dpt_i2o doesn't use scsi_register, so it should not use scsi_unregister > either. Also refactor the module exit path to make a little more sense. Applied to 4.17/scsi-queue. Thanks! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH 03/12] aha1740: stop using scsi_unregister

Christoph, > aha1740 doesn't use scsi_register, so it should not use scsi_unregister > either. Applied to 4.17/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH v2] aic7xxx/aic79xx: remove VLAs

Stephen, > In preparation to enabling -Wvla, remove VLAs and replace them with > fixed-length arrays instead. > > The arrays fixed here, using the number of constant sections, aren't > really VLAs, but they appear so to the compiler. Replace the array > sizes with a pre-processor-level constant

Re: [PATCH] scsi: aic94xx: Use dma_pool_zalloc()

Souptick, > Any comment for this patch ? -ENOREVIEWS Also, you have not provided potential reviewers with a compelling reason why dma_pool_zalloc() is superior to alloc+memset. -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] scsi: aic94xx: Use dma_pool_zalloc()

On Thu, Mar 15, 2018 at 10:20 AM, Martin K. Petersen wrote: > > Souptick, > >> Any comment for this patch ? > > -ENOREVIEWS > > Also, you have not provided potential reviewers with a compelling reason > why dma_pool_zalloc() is superior to alloc+memset. >

Re: [PATCH][next] scsi: lpfc: make several unions static, fix non-ANSI prototype

Colin, > There are several unions that are local to the source and do not need > to be in global scope, so make them static. Also add in a missing void > parameter to functions lpfc_nvme_cmd_template and > lpfc_nvmet_cmd_template to clean up non-ANSI warning. Applied to 4.17/scsi-queue. Thanks!

Re: [PATCH] scsi: csiostor: add support for 32 bit port capabilities

Varun, > 32 bit port capabilities are required to support new speeds which can > not be supported using 16 bit port capabilities. Applied to 4.17/scsi-queue. Thank you! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] ibmvfc: Avoid unnecessary port relogin

Brian, > Following an RSCN, ibmvfc will issue an ADISC to determine if the > underlying target has changed, comparing the SCSI ID, WWPN, and WWNN > to determine how to handle the rport in discovery. However, the > comparison of the WWPN and WWNN was performing a memcmp between a big > endian

Re: Debugging SCSI 'UNMAP' ("Logical Block Provisioning") failure on an SSD

Kashyap, > Sorry, I didn't give you complete information — with the previous > `dmesg` output, I actually attached the SSD (Samsung T5) via regular USB > "A Cable". > > Now, I re-attached the SSD via the "Thunderbolt" port on my other laptop > (Lenovo T470s), it _does_ show "UAS". Refer the

Re: [PATCH 02/12] ips: don't set .detect and .release in the host template

Christoph, > Since moving away from using scsi_module.c these were never called. > The implementations are called directly, though so they remain. Applied to 4.17/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] scsi: scsi_dh_alua: Correct comment for alua_alloc_pg()

John, > In the comment for function alua_alloc_pg() the argument '@h' is > mistakenly referred to. Fix this by replacing it with the correct > argument reference, '@tpgs', and provide a short description. Applied to 4.17/scsi-queue, thanks! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] bfa: remove VLA

Stephen, > bfad_bsg.c uses a variable-length array declaration to measure the > size of a putative array; this can be replaced by the product of the > size of an element and the number of elements, avoiding the VLA > altogether. > > - sizeof(wwn_t[iocmd->nports])) != BFA_STATUS_OK) {

Re: [GIT PULL] SCSI fixes for 4.16-rc5

Linus, > I've pulled it, but I don't see why (and how) this kind of garbage got > reviewed and acked by multiple people. My bad. I actually did notice the superfluous ifs and meant to nuke them when I committed the patch. However, I had a freak accident with my fixes branch that day that

Re: [PATCH 10/12] scsi: remove the mvme147 driver

Hi Martin, On Wed, Mar 14, 2018 at 4:58 PM, Martin K. Petersen wrote: IIRC, the Australian Navy may keep their MVME boxes running until close to Y2038. >>> But surely not updating them to 4.17 or later? >> >> I don't know. Perhaps to prolong life until

Re: [PATCH 10/12] scsi: remove the mvme147 driver

Hi Hannes, On Wed, Mar 14, 2018 at 4:26 PM, Hannes Reinecke wrote: > On 03/14/2018 02:25 PM, Geert Uytterhoeven wrote: >> On Wed, Mar 14, 2018 at 2:16 PM, Christoph Hellwig wrote: >>> On Wed, Mar 14, 2018 at 12:56:31PM +0100, John Paul Adrian Glaubitz wrote: Ah,

[PATCH] scsi: sd: Remember that READ CAPACITY(16) succeeded

The USB storage glue sets the try_rc_10_first flag in an attempt to avoid wedging poorly implemented legacy USB devices. If the device capacity is too large to be expressed in the provided response buffer field of READ CAPACITY(10), a well-behaved device will set the reported capacity to

Re: [PATCH 10/12] scsi: remove the mvme147 driver

On 03/14/2018 02:25 PM, Geert Uytterhoeven wrote: > Hi Christoph, > > On Wed, Mar 14, 2018 at 2:16 PM, Christoph Hellwig wrote: >> On Wed, Mar 14, 2018 at 12:56:31PM +0100, John Paul Adrian Glaubitz wrote: >>> Ah, bummer. I wanted to keep the MVME drivers but I never managed to get

Re: [PATCH V5 1/5] scsi: hpsa: fix selection of reply queue

On Tue, 2018-03-13 at 17:42 +0800, Ming Lei wrote: > From 84676c1f21 (genirq/affinity: assign vectors to all possible CPUs), > one msix vector can be created without any online CPU mapped, then one > command's completion may not be notified. > > This patch setups mapping between cpu and reply

[PATCH] scsi: scsi_dh_alua: Correct comment for alua_alloc_pg()

In the comment for function alua_alloc_pg() the argument '@h' is mistakenly referred to. Fix this by replacing it with the correct argument reference, '@tpgs', and provide a short description. Signed-off-by: John Pittman --- drivers/scsi/device_handler/scsi_dh_alua.c | 2

Re: [PATCH 4/5] scsi_io_completion: conditional hints on fastpath

On Wed, Mar 14, 2018 at 11:39:47AM +0100, Douglas Gilbert wrote: > So the difference measured on a Lenovo X270 (i5-7200U) amounts to > around 7 nanoseconds. > > Doug Gilbert Wow, thanks a lot. So it's actually buying us something measurable (not all too much though). Looks good, Reviewed-by:

Re: Debugging SCSI 'UNMAP' ("Logical Block Provisioning") failure on an SSD

On Wed, Mar 14, 2018 at 12:29:50PM +0100, Oliver Neukum wrote: > Am Mittwoch, den 14.03.2018, 11:22 +0100 schrieb Kashyap Chamarthy: > > I see.  So I ran `dmesg -w`, as I attached the disk & see the following: > > UAS and no quirk for your device. It looks like it indeed just does > not support

Re: [PATCH 10/12] scsi: remove the mvme147 driver

On Wed, Mar 14, 2018 at 12:56:31PM +0100, John Paul Adrian Glaubitz wrote: > Ah, bummer. I wanted to keep the MVME drivers but I never managed to get them > ported to the new SCSI layer. > > Anyone out there who could help me with that? Here is how a trivial conversion should look like.

Re: [PATCH V5 2/5] scsi: megaraid_sas: fix selection of reply queue

On Tue, 2018-03-13 at 17:42 +0800, Ming Lei wrote: > From 84676c1f21 (genirq/affinity: assign vectors to all possible CPUs), > one msix vector can be created without any online CPU mapped, then > command may be queued, and won't be notified after its completion. > > This patch setups mapping

[PATCH] ibmvfc: Avoid unnecessary port relogin

Following an RSCN, ibmvfc will issue an ADISC to determine if the underlying target has changed, comparing the SCSI ID, WWPN, and WWNN to determine how to handle the rport in discovery. However, the comparison of the WWPN and WWNN was performing a memcmp between a big endian field against a CPU