RE: Regarding SCSI SANITIZE command support

2018-04-10 Thread Mahesh Rajashekhara
Hi Doug Gilbert, Thanks for your response. During the drive sanitize, INQUIRY and REPORT LUNS commands were working as expected. Drive supports all the 9 commands (sbc4r15.pdf, clause 4.11.2) during sanitize. When the OS sends TUR commands, drive reports SenseKey: NOT READY, ASC: 04 and

[PATCH] scsi: qla2xxx: reduce the time granularity of qla2x00_eh_wait_on_command

2018-04-10 Thread Jianchao Wang
If the cmd has not be returned after aborted by qla2x00_eh_abort, we have to wait for it. However, the time is 1000ms at least currently. If there are a lot cmds need to be aborted, the delay could be long enough to lead to panic due to such as hung task, ocfs2 heartbeat, etc, just before scsi

Re: [PATCH] tcmu: fix error resetting qfull_time_out to default

2018-04-10 Thread Xiubo Li
On 2018/4/9 19:44, Prasanna Kumar Kalever wrote: Problem: --- $ cat /sys/kernel/config/target/core/user_0/block/attrib/qfull_time_out -1 $ echo "-1" > /sys/kernel/config/target/core/user_0/block/attrib/qfull_time_out -bash: echo: write error: Invalid argument Fix: --- This patch will help

Re: [RFC PATCH] mpt3sas: mpt3sas_scsih_enclosure_find_by_handle can be static

2018-04-10 Thread Bart Van Assche
On Tue, 2018-04-10 at 09:15 +0200, Jaco Kroon wrote: > I've not seen additional feedback on this (I may simply not be CCed). > > I've applied the patch to one of our hosts where we've had endless IO > lockups (with MQ enabled the host died within a day or two, sometimes > sub one hour, without it

[PATCH 1/2] scsi: st: Replace GFP_ATOMIC with GFP_KERNEL in st_probe

2018-04-10 Thread Jia-Ju Bai
st_probe() is never called in atomic context. st_probe() is only set as ".probe" in struct scsi_driver. Despite never getting called from atomic context, st_probe() calls kzalloc() with GFP_ATOMIC, which does not sleep for allocation. GFP_ATOMIC is not necessary and can be replaced with

Re: [PATCH v3 1/3] Revert "scsi: core: return BLK_STS_OK for DID_OK in __scsi_error_from_host_byte()"

2018-04-10 Thread Sasha Levin
Hi, [This is an automated email] This commit has been processed because it contains a "Fixes:" tag, fixing commit: e39a97353e53 scsi: core: return BLK_STS_OK for DID_OK in __scsi_error_from_host_byte(). The bot has also determined it's probably a bug fixing patch. (score: 94.6757) The bot has

Re: [PATCH v3 0/3] Report all request failures again to user space

2018-04-10 Thread Bart Van Assche
On Tue, 2018-04-10 at 15:48 +0200, Johannes Thumshirn wrote: > On Mon, Apr 09, 2018 at 09:35:21PM -0400, Martin K. Petersen wrote: > > > > Johannes, > > > > > I did start a series [1] for this but than got distracted by more urgent > > > things. I can pick it up again I think. > > > > > > [1] >

Re: [PATCH v1 14/15] mpt3sas: fix possible memory leak.

2018-04-10 Thread Sasha Levin
Hi, [This is an automated email] This commit has been processed by the -stable helper bot and determined to be a high probability candidate for -stable trees. (score: 12.9808) The bot has tested the following trees: v4.16.1, v4.15.16, v4.14.33, v4.9.93, v4.4.127. v4.16.1: Build OK! v4.15.16:

Re: [PATCH v3 0/3] Report all request failures again to user space

2018-04-10 Thread Sasha Levin
Hi, [This is an automated email] This commit has been processed by the -stable helper bot and determined to be a high probability candidate for -stable trees. (score: 19.8603) The bot has tested the following trees: v4.16.1, v4.15.16, v4.14.33, v4.9.93, v4.4.127. v4.16.1: Failed to apply!

Re: [PATCH 2/3] megaraid_sas: Increase timeout by 1 sec for non-RAID fastpath IOs

2018-04-10 Thread Sasha Levin
Hi, [This is an automated email] This commit has been processed by the -stable helper bot and determined to be a high probability candidate for -stable trees. (score: 8.0623) The bot has tested the following trees: v4.16.1, v4.15.16, v4.14.33, v4.9.93, v4.4.127. v4.16.1: Build OK! v4.15.16:

Re: [PATCH v1 03/15] mpt3sas: Add sanity checks for scsi tracker before accessing it.

2018-04-10 Thread Sasha Levin
Hi, [This is an automated email] This commit has been processed by the -stable helper bot and determined to be a high probability candidate for -stable trees. (score: 28.7865) The bot has tested the following trees: v4.16.1, v4.15.16, v4.14.33, v4.9.93, v4.4.127. v4.16.1: Build OK! v4.15.16:

Re: [PATCH v3 1/3] Revert "scsi: core: return BLK_STS_OK for DID_OK in __scsi_error_from_host_byte()"

2018-04-10 Thread Bart Van Assche
On 04/10/18 07:49, Sasha Levin wrote: [This is an automated email] This commit has been processed because it contains a "Fixes:" tag, fixing commit: e39a97353e53 scsi: core: return BLK_STS_OK for DID_OK in __scsi_error_from_host_byte(). The bot has also determined it's probably a bug fixing

[PATCH] scsi_debug: IMMED related delay adjustments

2018-04-10 Thread Douglas Gilbert
A patch titled: "[PATCH v2] scsi_debug: implement IMMED bit" introduced long delays to the Start stop unit (SSU) and Synchronize cache (SC) commands when the IMMED bit is clear. This patch makes those delays more realistic. It causes SSU to only delay when the start stop state is changed; SC only

Hotplug

2018-04-10 Thread Jens Axboe
Hi, Been running some tests and I keep running into issues with hotplug. This looks similar to what Bart posted the other day, but it looks more deeply rooted than just having to protect the queue in generic_make_request_checks(). The test run is blktests, block/001. Current -git doesn't survive

[PATCH 2/2] scsi: st: Replace GFP_ATOMIC with GFP_KERNEL in new_tape_buffer

2018-04-10 Thread Jia-Ju Bai
new_tape_buffer() is never called in atomic context. new_tape_buffer() is only called by st_probe(), which is only set as ".probe" in struct scsi_driver. Despite never getting called from atomic context, new_tape_buffer() calls kzalloc() with GFP_ATOMIC, which does not sleep for allocation.

Re: usercopy whitelist woe in scsi_sense_cache

2018-04-10 Thread Oleksandr Natalenko
Hi. 10.04.2018 08:35, Oleksandr Natalenko wrote: - does it reproduce _without_ hardened usercopy? (I would assume yes, but you'd just not get any warning until the hangs started.) If it does reproduce without hardened usercopy, then a new bisect run could narrow the search even more. Looks

Re: [PATCH v3 0/3] Report all request failures again to user space

2018-04-10 Thread Johannes Thumshirn
On Mon, Apr 09, 2018 at 09:35:21PM -0400, Martin K. Petersen wrote: > > Johannes, > > > I did start a series [1] for this but than got distracted by more urgent > > things. I can pick it up again I think. > > > > [1] > >

RE: [PATCH v1 03/15] mpt3sas: Add sanity checks for scsi tracker before accessing it.

2018-04-10 Thread Sreekanth Reddy
Yes Sasha, We like to have this patch included in a stable tree. Thanks, Sreekanth -Original Message- From: Sasha Levin [mailto:alexander.le...@microsoft.com] Sent: Tuesday, April 10, 2018 7:19 PM To: Sasha Levin; Chaitra P B; linux-scsi@vger.kernel.org Cc: sathya.prak...@broadcom.com;

RE: [PATCH v1 14/15] mpt3sas: fix possible memory leak.

2018-04-10 Thread Sreekanth Reddy
Yes Sasha, We like to have this patch included in a stable tree. Thanks, Sreekanth -Original Message- From: Sasha Levin [mailto:alexander.le...@microsoft.com] Sent: Tuesday, April 10, 2018 7:19 PM To: Sasha Levin; Chaitra P B; linux-scsi@vger.kernel.org Cc: sathya.prak...@broadcom.com;

Re: usercopy whitelist woe in scsi_sense_cache

2018-04-10 Thread Oleksandr Natalenko
Hi, Kees, Paolo et al. 10.04.2018 08:53, Kees Cook wrote: Unfortunately I only had a single hang with no dumps. I haven't been able to reproduce it since. :( For your convenience I've prepared a VM that contains a reproducer. It consists of 3 disk images (sda.img is for the system, it is

Re: [PATCH v7] scsi: new zorro_esp.c for Amiga Zorro NCR53C9x boards

2018-04-10 Thread Michael Schmitz
Hi Geert, now I see, thanks. I could change the device table to use ZORRO_ID(PHASE5, ...) style IDs instead of the longish defines if you're OK with that. The other changes have passed tests and I'd otherwise just send what I have now, adding Christoph's Reviewed-by. Cheers, Michael On

Re: [PATCH v7] scsi: new zorro_esp.c for Amiga Zorro NCR53C9x boards

2018-04-10 Thread Geert Uytterhoeven
Hi Michael, On Tue, Apr 10, 2018 at 4:16 AM, Michael Schmitz wrote: > On Mon, Apr 9, 2018 at 7:50 PM, Christoph Hellwig wrote: >> On Sun, Apr 08, 2018 at 02:45:32PM +1200, Michael Schmitz wrote: >>> New combined SCSI driver for all ESP based Zorro SCSI

Re: [PATCH 1/1] scsi/ufs: qcom: Don't enable PHY_QCOM_UFS by default

2018-04-10 Thread Vivek Gautam
On 4/10/2018 1:39 AM, Bjorn Andersson wrote: On Mon 09 Apr 10:38 PDT 2018, Vivek Gautam wrote: On 4/9/2018 10:21 PM, Bjorn Andersson wrote: On Mon 09 Apr 06:24 PDT 2018, Vivek Gautam wrote: [..] diff --git a/include/linux/phy/phy-qcom-ufs.h b/include/linux/phy/phy-qcom-ufs.h index

Re: usercopy whitelist woe in scsi_sense_cache

2018-04-10 Thread Oleksandr Natalenko
Hi. 09.04.2018 22:30, Kees Cook wrote: echo 1 | tee /sys/block/sd*/queue/nr_requests I can't get this below "4". Oops, yeah. It cannot be less than BLKDEV_MIN_RQ (which is 4), so it is enforced explicitly in queue_requests_store(). It is the same for me. echo 1 | tee

Re: usercopy whitelist woe in scsi_sense_cache

2018-04-10 Thread Kees Cook
On Mon, Apr 9, 2018 at 11:35 PM, Oleksandr Natalenko wrote: > Did your system hang on smartctl hammering too? Have you got some stack > traces to compare with mine ones? Unfortunately I only had a single hang with no dumps. I haven't been able to reproduce it since. :(

Re: *** SPAM *** Re: [RFC PATCH] mpt3sas: mpt3sas_scsih_enclosure_find_by_handle can be static

2018-04-10 Thread Jaco Kroon
Hi Martin, Bart, I've not seen additional feedback on this (I may simply not be CCed). I've applied the patch to one of our hosts where we've had endless IO lockups (with MQ enabled the host died within a day or two, sometimes sub one hour, without it typically ran for about two weeks).  With

[PATCH] Waiting for scsi_host_template release

2018-04-10 Thread Anatoliy Glagolev
Description: SCSI mid-layer may hold references to Scsi_Host structs when the owning module has already unloaded. Scsi_Host release path touches scsi_host_template struct that is usually allocated in the unloaded module's memory. That results in a crash. To work around the problem, this change

Re: [PATCH] scsi_debug: IMMED related delay adjustments

2018-04-10 Thread Ming Lei
On Tue, Apr 10, 2018 at 01:00:36PM -0400, Douglas Gilbert wrote: > A patch titled: "[PATCH v2] scsi_debug: implement IMMED bit" > introduced long delays to the Start stop unit (SSU) and > Synchronize cache (SC) commands when the IMMED bit is clear. > This patch makes those delays more realistic.

Re: 4.15.14 crash with iscsi target and dvd

2018-04-10 Thread Wakko Warner
Ming Lei wrote: > Sure, thanks for your sharing. > > Wakko, could you test the following patch and see if there is any > difference? > > -- > diff --git a/drivers/target/target_core_pscsi.c > b/drivers/target/target_core_pscsi.c > index 0d99b242e82e..6147178f1f37 100644 > ---

Re: usercopy whitelist woe in scsi_sense_cache

2018-04-10 Thread Kees Cook
On Tue, Apr 10, 2018 at 10:16 AM, Oleksandr Natalenko wrote: > Hi, Kees, Paolo et al. > > 10.04.2018 08:53, Kees Cook wrote: >> >> Unfortunately I only had a single hang with no dumps. I haven't been >> able to reproduce it since. :( > > > For your convenience I've