RE: [PATCH] mpt3sas: Fix calltrace observed while running IO & host reset

2018-06-13 Thread Chaitra Basappa
Bart, When host reset is issued from application, through ioctl reset handler _ctl_do_reset() -> mpt3sas_base_hard_reset_handler() sets “ioc->shost_recovery” flag. If “ioc->shost_recovery” flag is set then driver will return all the incoming SCSI cmds with “SCSI_MLQUEUE_HOST_BUSY” in the

Re: [PATCH v2] scsi: qla2xxx: Spinlock recursion in qla_target

2018-06-13 Thread Mikhail Malygin
Hi Himanshu, I checked the same scenarios using work_lock instead of sess_lock, and I could not reproduce any of the issues mentioned before. Thanks, Mikhail From: Madhani, Himanshu Sent: Wednesday, June 13, 2018 12:29 AM To: Mikhail Malygin Cc: linux-scsi; Hannes Reinecke; Ivan Tchoub

Re: [PATCH v2] scsi: qla2xxx: Spinlock recursion in qla_target

2018-06-13 Thread Mikhail Malygin
Here is the patch used for verification: [PATCH] scsi: qla2xxx: Fixup spinlock recursion in qla_target The patch reverts changes done in qlt_schedule_sess_for_deletion() To avoid spinlock recursion sess->vha->work_lock should be used instead of ha->tgt.sess_lock, that can be locked in callers:

Re: [PATCH v2] scsi: qla2xxx: Spinlock recursion in qla_target

2018-06-13 Thread James Bottomley
On Wed, 2018-06-13 at 16:13 +, Madhani, Himanshu wrote: > > On Jun 13, 2018, at 6:05 AM, Mikhail Malygin > > wrote: > > > > Here is the patch used for verification: > > > > [PATCH] scsi: qla2xxx: Fixup spinlock recursion in qla_target > > > > The patch reverts changes done in

Re: [PATCH v2] scsi: qla2xxx: Spinlock recursion in qla_target

2018-06-13 Thread Madhani, Himanshu
> On Jun 13, 2018, at 9:20 AM, James Bottomley > wrote: > > On Wed, 2018-06-13 at 16:13 +, Madhani, Himanshu wrote: >>> On Jun 13, 2018, at 6:05 AM, Mikhail Malygin >>> wrote: >>> >>> Here is the patch used for verification: >>> >>> [PATCH] scsi: qla2xxx: Fixup spinlock recursion in

Re: [PATCH] mpt3sas: Fix calltrace observed while running IO & host reset

2018-06-13 Thread Bart Van Assche
On Wed, 2018-06-13 at 15:46 +0530, Chaitra Basappa wrote: > When host reset is issued from application, through ioctl reset handler > _ctl_do_reset() -> mpt3sas_base_hard_reset_handler() sets > “ioc->shost_recovery” flag. > If “ioc->shost_recovery” flag is set then driver will return all the >

Re: [PATCH v2] scsi: qla2xxx: Spinlock recursion in qla_target

2018-06-13 Thread Madhani, Himanshu
> On Jun 13, 2018, at 6:05 AM, Mikhail Malygin wrote: > > Here is the patch used for verification: > > [PATCH] scsi: qla2xxx: Fixup spinlock recursion in qla_target > > The patch reverts changes done in qlt_schedule_sess_for_deletion() > To avoid spinlock recursion sess->vha->work_lock should

Re: sd 6:0:0:0: [sdb] Unaligned partial completion

2018-06-13 Thread Ted Cabeen
Will do. It'll be a few weeks, as I have to schedule downtime, but I'll report back my results when it's done. --Ted On 06/11/2018 04:08 PM, James Bottomley wrote: OK, try this: it will print a rate limited warning if it triggers (showing it is this problem) and return ADD_TO_MLQUEUE for all

Re: [PATCH v2] scsi: qla2xxx: Spinlock recursion in qla_target

2018-06-13 Thread Martin K. Petersen
Mikhail, > The patch reverts changes done in qlt_schedule_sess_for_deletion() To > avoid spinlock recursion sess->vha->work_lock should be used instead > of ha->tgt.sess_lock, that can be locked in callers: qlt_reset() or > qlt_handle_login() Applied to 4.18/scsi-fixes. Thanks! -- Martin K.