[PATCH] scsi: lpfc: remove an unnecessary NULL check

2018-08-23 Thread Dan Carpenter
Smatch complains about this code: drivers/scsi/lpfc/lpfc_scsi.c:1053 lpfc_get_scsi_buf_s4() warn: variable dereferenced before check 'lpfc_cmd' (see line 1039) Fortunately the NULL check isn't required so I have removed it. Signed-off-by: Dan Carpenter diff --git

Re: [PATCH] scsi: csiostor: fix incorrect port capabilities

2018-08-23 Thread Martin K. Petersen
Varun, > - use be32_to_cpu() instead of ntohs() for 32 bit port capabilities. > > - add a new function fwcaps32_to_caps16() to convert 32 bit port > capabilities to 16 bit port capabilities. Applied to 4.19/scsi-fixes, thank you! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCHv2] iscsi target: Set conn->sess to NULL when iscsi_login_set_conn_values fails

2018-08-23 Thread Martin K. Petersen
Mike, > this was made over that patch that was going through Mathew's tree. I > do not know exactly which one though. It is in next here Doesn't look like Linus will pull Matthew's tree for 4.19. -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] lpfc: Default fdmi_on to on

2018-08-23 Thread Martin K. Petersen
James, > Change default behavior for fdmi registration to on. Patch was mangled. Applied to 4.19/scsi-fixes by hand. -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] scsi: csiostor: add a check for NULL pointer after kmalloc()

2018-08-23 Thread Martin K. Petersen
Varun, > Reported-by: Colin Ian King > Signed-off-by: Varun Prakash Applied to 4.19/scsi-fixes. Thanks! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] lpfc: Correct MDS diag and nvmet configuration

2018-08-23 Thread Martin K. Petersen
James, > A recent change added some MDS processing in the lpfc_drain_txq > routine that relies on the fcp_wq being allocated. For nvmet operation > the fcp_wq is not allocated because it can only be an nvme-target. > When the original MDS support was added LS_MDS_LOOPBACK was defined > wrong,

[PATCH V10 0/2] Add UFS provisioning support in driver

2018-08-23 Thread Sayali Lokhande
This patch adds Configfs support to provision UFS device at runtime. This feature can be primarily useful in factory or assembly line as some devices may be required to be configured multiple times during initial system development phase. Configuration Descriptors can be written multiple times