Re: [PATCH] lpfc: fixup crash in lpfc_els_unsol_buffer()

2018-10-09 Thread Johannes Thumshirn
Looks good, Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG

[PATCH] lpfc: fixup crash in lpfc_els_unsol_buffer()

2018-10-09 Thread Hannes Reinecke
lpfc_nlp_get() in lpfc_els_unsol_buffer() is not running under a lock, so there is a chance that it might actually fail. But as we never check the return value we'll get a crash in lpfc_nlp_put() later on trying to free an invalid buffer. Signed-off-by: Hannes Reinecke ---

Re: [PATCH 1/3] scsi: Allow state transitions from OFFLINE to BLOCKED

2018-10-09 Thread Hannes Reinecke
On 10/8/18 10:22 PM, Ewan D. Milne wrote: This change would permit a device that was OFFLINE (for any reason) to go back to RUNNING via: OFFLINE -> BLOCKED -> RUNNING Correct. Obviously that was your intention, but e.g. if a device was put OFFLINE due to exceeding max_medium_access_timeouts

Re: aic7xxx DMA overflow error

2018-10-09 Thread Christoph Hellwig
On Mon, Oct 01, 2018 at 04:57:39PM -0400, tedheadster wrote: > Christoph, > I was able to bisect this to your patch "scsi: reduce use of block > bounce buffers". I am getting the error on a 32-bit Dell PowerEdge > 6650. It has the aic7xxx integrated onto the motherboard. > > Again, here is the

Re: [PATCH] lpfc: fixup crash in lpfc_els_unsol_buffer()

2018-10-09 Thread Ewan D. Milne
On Tue, 2018-10-09 at 08:30 +0200, Hannes Reinecke wrote: > lpfc_nlp_get() in lpfc_els_unsol_buffer() is not running under a > lock, so there is a chance that it might actually fail. But as we > never check the return value we'll get a crash in lpfc_nlp_put() > later on trying to free an invalid