On Fri, 2018-10-12 at 12:01 +0200, David Disseldorp wrote:
> +void iscsit_fill_cxn_timeout_err_stats(struct iscsi_session *sess)
> +{
> + struct iscsi_portal_group *tpg = sess->tpg;
> + struct iscsi_tiqn *tiqn = tpg->tpg_tiqn;
> +
> + if (!tiqn)
> + return;
> +
> +
On Fri, Oct 12, 2018 at 04:45:57PM +1100, Finn Thain wrote:
> > + if (esp->flags & ESP_FLAG_NO_DMA_MAP)
> > + return;
> > +
> > + dma_unmap_single(esp->dev, ent->sense_dma, SCSI_SENSE_BUFFERSIZE,
> > +DMA_FROM_DEVICE);
> > + ent->sense_ptr = NULL;
> > +}
> > +
>
On Fri, Oct 12, 2018 at 04:47:23PM +1100, Finn Thain wrote:
> > + esp->dev = >dev;
> >
> > esp->command_block = kzalloc(16, GFP_KERNEL);
> > if (!esp->command_block)
>
>
> Isn't this missing the corresponding dev_set_drvdata() in esp_mac_probe()?
> Also conversion to
On Thu, Oct 11, 2018 at 12:38 PM Christoph Hellwig wrote:
>
> The driver is currently using an odd mix of legacy PCI DMA API and
> generic DMA API calls, switch it over to the generic API entirely.
>
> Signed-off-by: Christoph Hellwig
> ---
> drivers/scsi/3w-9xxx.c | 50
On Thu, Oct 11, 2018 at 12:38 PM Christoph Hellwig wrote:
>
> The driver is currently using an odd mix of legacy PCI DMA API and
> generic DMA API calls, switch it over to the generic API entirely.
>
> Signed-off-by: Christoph Hellwig
> ---
> drivers/scsi/3w-sas.c | 38
Hello
While I have for the longest time used 4.5 as a base for my F/C jammer
that I use every day here in our lab I recently added more jammer code
so I decided to test this all on latest upstream.
Booting the target server on my 4.5 kernel with jammer code is flawless
and serves LUNS with no
On Thu, Oct 11, 2018 at 12:38 PM Christoph Hellwig wrote:
>
> The driver is currently using an odd mix of legacy PCI DMA API and
> generic DMA API calls, switch it over to the generic API entirely.
>
> Signed-off-by: Christoph Hellwig
> ---
> drivers/scsi/3w-.c | 20 ++--
>
On 10/12/18 1:36 PM, Laurence Oberman wrote:
> While I have for the longest time used 4.5 as a base for my F/C jammer
> that I use every day here in our lab I recently added more jammer code
> so I decided to test this all on latest upstream.
>
> Booting the target server on my 4.5 kernel with
> That isn't a limit, just a reporting clause - the real check is this
> line a little above:
>
> if (unlikely(dev && !dma_capable(dev, dma_addr, size))) {
>
> which is purely based on the dma mask. So for some reason we must
> be in 32-bit only mode for the dma-mask, and not actually
> On Fri, 12 Oct 2018, Christoph Hellwig wrote:
>
> >
> > > diff --git a/drivers/scsi/mac_esp.c b/drivers/scsi/mac_esp.c
> > > index eb551f3cc471..85d067889a9b 100644
> > > --- a/drivers/scsi/mac_esp.c
> > > +++ b/drivers/scsi/mac_esp.c
> > > @@ -58,8 +58,7 @@ static struct esp *esp_chips[2];
>
On Thu, 11 Oct 2018, Christoph Hellwig wrote:
> diff --git a/drivers/scsi/esp_scsi.c b/drivers/scsi/esp_scsi.c
> index 90604bff8dd2..73fcbd65b9fe 100644
> --- a/drivers/scsi/esp_scsi.c
> +++ b/drivers/scsi/esp_scsi.c
> @@ -369,19 +369,25 @@ static void esp_map_dma(struct esp *esp, struct
>
Looks good,
Reviewed-by: Johannes Thumshirn
--
Johannes ThumshirnSUSE Labs
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG
Looks good,
Reviewed-by: Johannes Thumshirn
--
Johannes ThumshirnSUSE Labs
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG
On 10/12/18 4:30 AM, Damien Le Moal wrote:
The 32 bits overflow check for the zone size value is already done
within sd_zbc_check_zones() with the test:
} else if (logical_to_sectors(sdkp->device, zone_blocks) > UINT_MAX) {
so there is no need to check again for an out of range value in
Looks good,
Reviewed-by: Johannes Thumshirn
--
Johannes ThumshirnSUSE Labs
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG
Looks good,
Reviewed-by: Johannes Thumshirn
--
Johannes ThumshirnSUSE Labs
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG
Looks good,
Reviewed-by: Johannes Thumshirn
--
Johannes ThumshirnSUSE Labs
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG
Looks good,
Reviewed-by: Johannes Thumshirn
--
Johannes ThumshirnSUSE Labs
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG
Looks good,
Reviewed-by: Johannes Thumshirn
--
Johannes ThumshirnSUSE Labs
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG
On Thu, Oct 11, 2018 at 08:49:58PM +0200, Christoph Hellwig wrote:
> @@ -9026,19 +9026,13 @@ static void qla4xxx_remove_adapter(struct pci_dev
> *pdev)
> */
> static void qla4xxx_config_dma_addressing(struct scsi_qla_host *ha)
> {
> - int retval;
> -
Can you zap that:
At exit, the
Looks good,
Reviewed-by: Johannes Thumshirn
--
Johannes ThumshirnSUSE Labs
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG
On 10/12/18 4:30 AM, Damien Le Moal wrote:
There is no point in allocating more zone descriptors than the number of
zones a block device has for doing a zone report. Avoid doing that in
blkdev_report_zones_ioctl() by limiting the number of zone decriptors
allocated internally to process the user
Looks good,
Reviewed-by: Johannes Thumshirn
--
Johannes ThumshirnSUSE Labs
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG
Looks good,
Reviewed-by: Johannes Thumshirn
--
Johannes ThumshirnSUSE Labs
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG
Looks good,
Reviewed-by: Johannes Thumshirn
--
Johannes ThumshirnSUSE Labs
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG
Looks good,
Reviewed-by: Johannes Thumshirn
--
Johannes ThumshirnSUSE Labs
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG
Looks good,
Reviewed-by: Johannes Thumshirn
--
Johannes ThumshirnSUSE Labs
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG
On Fri, Oct 12, 2018 at 09:41:28AM +0200, Hannes Reinecke wrote:
>> +{
>> +return 0;
>> +}
>> #endif /* CONFIG_BLK_DEV_ZONED */
>> static inline bool rq_is_sync(struct request *rq)
>>
> Actually, we should be checking whether we can't blank out this attribute
> via the is_visible
Looks good,
Reviewed-by: Johannes Thumshirn
--
Johannes ThumshirnSUSE Labs
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG
Looks good,
Reviewed-by: Johannes Thumshirn
--
Johannes ThumshirnSUSE Labs
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG
On Fri, Oct 12, 2018 at 11:30:10AM +0900, Damien Le Moal wrote:
> Expose through sysfs the nr_zones field of struct request_queue.
> Exposing this value helps in debugging disk issues as well as
> facilitating scripts based use of the disk (e.g. blktests).
>
> For zoned block devices, the
Looks good,
Reviewed-by: Johannes Thumshirn
--
Johannes ThumshirnSUSE Labs
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG
Looks good,
Reviewed-by: Johannes Thumshirn
--
Johannes ThumshirnSUSE Labs
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG
Hello my dear.
Did you receive my email message to you? Please, get back to me ASAP as the
matter is becoming late. Expecting your urgent response.
Sean.
Shivasharan S (19):
megaraid_sas: Add watchdog thread to detect FW fault
megaraid_sas: Add support for FW snap dump
megaraid_sas: Fix msleep granularity
megaraid_sas: Add check for reset adapter bit
megaraid_sas: Update copyright information
megaraid_sas: Fix goto labels in error
Issue -
Currently driver checks for Firmware state change from ISR context, and
only when there are interrupts tied with no I/O completions.
We have seen multiple cases where doorbell interrupts sent by firmware,
to indicate FW state change are not processed by driver and it takes long
time for
Latest firmware adds a mechanism to save firmware logs just before
controller reset on pre-allocated internal controller DRAM. This feature
is called snapdump which will help debugging firmware issues.
This feature requires extra time and firmware reports these values through
new driver interface.
Issue -
In megasas_transition_to_ready() driver waits 180seconds for controller
to change FW state. Here we are calling msleep(1) in a loop for this.
As explained in timers-howto.txt, msleep(1) will actually sleep longer
than 1ms. If a faulty controller is connected, we will end up waiting for
Fix -
For Invader series, if FW supports more than 8 MSI-x vectors, driver needs
to enable combined reply queue mode. For Ventura series, driver enables
combined reply queue mode in case of more than 16 MSI-x vectors.
Signed-off-by: Sumit Saxena
Signed-off-by: Shivasharan S
---
For SAS3 and later controllers, FW sets the reset adapter bit indicating
the driver to perform a controller reset.
Driver needs to check if this bit is set before doing a reset.
This reduces the driver probe failure time to 180seconds in case there
is a faulty controller connected.
Signed-off-by:
Module parameter description for rdpq_enable incorrectly lists the default
as enabled.
Also, provide range of valid values for resetwaittime in the description.
Signed-off-by: Shivasharan S
---
drivers/scsi/megaraid/megaraid_sas_base.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
Fix -
For SRIOV based adapters, driver should not set the STOP_ADP bit as part
of kill adapter.
Signed-off-by: Shivasharan S
---
drivers/scsi/megaraid/megaraid_sas_base.c | 8 +---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/drivers/scsi/megaraid/megaraid_sas_base.c
Change copyright to Broadcom Inc. Also update any references to Avago with
Broadcom. Update copyright duration wherever required.
Signed-off-by: Shivasharan S
---
drivers/scsi/megaraid/megaraid_sas.h| 14 ++
drivers/scsi/megaraid/megaraid_sas_base.c | 18 --
Fix -
During init, if pci_alloc_irq_vectors() fails, the driver has not yet
setup the IRQs. Fix the goto labels and error handling for this case.
Signed-off-by: Shivasharan S
---
drivers/scsi/megaraid/megaraid_sas_base.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git
Signed-off-by: Shivasharan S
---
drivers/scsi/megaraid/megaraid_sas.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/scsi/megaraid/megaraid_sas.h
b/drivers/scsi/megaraid/megaraid_sas.h
index 994c6ac6f920..8edba2227cd3 100644
---
In megasas_init_adapter_fusion(), max_mfi_cmds is being calcuated as
(MEGASAS_FUSION_INTERNAL_CMDS + MEGASAS_FUSION_IOCTL_CMDS).
max_mfi_cmds can be used in megasas_configure_queue_sizes.
Signed-off-by: Shivasharan S
---
drivers/scsi/megaraid/megaraid_sas_fusion.c | 4 +---
1 file changed, 1
No functional change.
Rename the scratch pad registers to match firmware headers.
Signed-off-by: Sumit Saxena
Signed-off-by: Shivasharan S
---
drivers/scsi/megaraid/megaraid_sas.h| 9 +++
drivers/scsi/megaraid/megaraid_sas_base.c | 40 +--
Optimization -
No need to hold hba_lock in dpc context for reading atomic variable.
Signed-off-by: Shivasharan S
---
drivers/scsi/megaraid/megaraid_sas_fusion.c | 7 +--
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/drivers/scsi/megaraid/megaraid_sas_fusion.c
Signed-off-by: Shivasharan S
---
drivers/scsi/megaraid/megaraid_sas_fusion.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/scsi/megaraid/megaraid_sas_fusion.c
b/drivers/scsi/megaraid/megaraid_sas_fusion.c
index 0a8b7167d05d..76ea5dc656b1 100644
---
IOC INIT frame needs to be fired with a timeout of 180seconds.
Signed-off-by: Shivasharan S
---
drivers/scsi/megaraid/megaraid_sas_fusion.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/megaraid/megaraid_sas_fusion.c
No functional change.
Use local variables when accessing raid context in IO path.
Improves code readability.
Signed-off-by: Shivasharan S
---
drivers/scsi/megaraid/megaraid_sas_fusion.c | 74 -
1 file changed, 31 insertions(+), 43 deletions(-)
diff --git
When driver fails to start the heartbeat timer, exit from FW init.
Signed-off-by: Shivasharan S
---
drivers/scsi/megaraid/megaraid_sas_base.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/scsi/megaraid/megaraid_sas_base.c
Signed-off-by: Shivasharan S
---
drivers/scsi/megaraid/megaraid_sas.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/scsi/megaraid/megaraid_sas.h
b/drivers/scsi/megaraid/megaraid_sas.h
index 2c044106c35f..994c6ac6f920 100644
--- a/drivers/scsi/megaraid/megaraid_sas.h
+++
The print related to number of VDs that a particular firmware supports is
misleading in some cases.
Even though supportMaxExtLDs is set, certain firmware profiles only
supports upto 64VDs.
Signed-off-by: Shivasharan S
---
drivers/scsi/megaraid/megaraid_sas_base.c | 6 +++---
1 file changed, 3
The following patchset converts existing Data-Out and NOP ping timeout
messages from pr_debug() to pr_error(), to reflect the seriousness of
unexpected connection termination events.
These events can be triggered using a couple of libiscsi client hacks:
sess_err_stats are currently filled on NOP ping timeout, but not
Data-Out timeout. Stash details of Data-Out timeouts using a
ISCSI_SESS_ERR_CXN_TIMEOUT value for last_sess_failure_type.
Signed-off-by: David Disseldorp
---
drivers/target/iscsi/iscsi_target_erl1.c | 1 +
1 file changed, 1
Data-Out timeouts resulting in connection outages should be logged as
errors. Include the I_T Nexus in the message to aid path identification.
Signed-off-by: David Disseldorp
---
drivers/target/iscsi/iscsi_target_erl1.c | 16 +++-
1 file changed, 11 insertions(+), 5 deletions(-)
Replace existing nested code blocks with helper function calls.
Signed-off-by: David Disseldorp
---
drivers/target/iscsi/iscsi_target_erl0.c | 15 +-
drivers/target/iscsi/iscsi_target_util.c | 35 +---
drivers/target/iscsi/iscsi_target_util.h | 1 +
3
Move the ISCSI_IQN_LEN definition up, so that it can be used in more
places instead of a hardcoded value.
Signed-off-by: David Disseldorp
---
drivers/target/iscsi/iscsi_target_stat.c | 4 ++--
include/target/iscsi/iscsi_target_core.h | 6 +++---
include/target/iscsi/iscsi_target_stat.h | 4 ++--
Events resulting in connection outages like this should be logged as
errors. Include the I_T Nexus in the message to aid path identification.
Signed-off-by: David Disseldorp
---
drivers/target/iscsi/iscsi_target_util.c | 8 +---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git
Fixes gcc '-Wunused-but-set-variable' warning:
drivers/scsi/arcmsr/arcmsr_hba.c: In function 'arcmsr_drain_donequeue':
drivers/scsi/arcmsr/arcmsr_hba.c:1320:10: warning:
variable 'lun' set but not used [-Wunused-but-set-variable]
drivers/scsi/arcmsr/arcmsr_hba.c:1320:6: warning:
variable 'id'
On Thu, Oct 11, 2018 at 08:49:41PM +0200, Christoph Hellwig wrote:
> @@ -1124,7 +1124,8 @@ static int inia100_probe_one(struct pci_dev *pdev,
>
> /* Get total memory needed for SCB */
> sz = ORC_MAXQUEUE * sizeof(struct orc_scb);
> - host->scb_virt = pci_zalloc_consistent(pdev,
On Thu, Oct 11, 2018 at 08:49:42PM +0200, Christoph Hellwig wrote:
> Switch from the legacy PCI DMA API to the generic DMA API.
>
> Signed-off-by: Christoph Hellwig
> ---
> drivers/scsi/atp870u.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git
On 10/12/18 4:30 AM, Damien Le Moal wrote:
Drivers exposing zoned block devices have to initialize and maintain
correctness (i.e. revalidate) of the device zone bitmaps attached to
the device request queue (seq_zones_bitmap and seq_zones_wlock).
To simplify coding this, introduce a generic
Looks good,
Reviewed-by: Johannes Thumshirn
--
Johannes ThumshirnSUSE Labs
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG
Looks good,
Reviewed-by: Johannes Thumshirn
--
Johannes ThumshirnSUSE Labs
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG
Looks good,
Reviewed-by: Johannes Thumshirn
--
Johannes ThumshirnSUSE Labs
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG
Looks good,
Reviewed-by: Johannes Thumshirn
--
Johannes ThumshirnSUSE Labs
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG
Looks good,
Reviewed-by: Johannes Thumshirn
--
Johannes ThumshirnSUSE Labs
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG
Looks good,
Reviewed-by: Johannes Thumshirn
--
Johannes ThumshirnSUSE Labs
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG
Looks good,
Reviewed-by: Johannes Thumshirn
--
Johannes ThumshirnSUSE Labs
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG
Looks good,
Reviewed-by: Johannes Thumshirn
--
Johannes ThumshirnSUSE Labs
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG
Christoph Hellwig 于2018年10月11日周四 下午9:38写道：
>
> Switch from the legacy PCI DMA API to the generic DMA API.
>
> Signed-off-by: Christoph Hellwig
Reviewed-by: Jack Wang
Thanks,
Jack
Looks good,
Reviewed-by: Johannes Thumshirn
--
Johannes ThumshirnSUSE Labs
jthumsh...@suse.de+49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG
74 matches
Mail list logo
