Hi Ted,
thanks for the dmesg. This shows your HBA doesn't even support the
odd 39-bit addressing. Now the real question is why we don't use
swiotlb. For that I'd like to see the whole dmesg from the very
beinning if you have it. Also it seems this boot didn't have the
WARN_ON_ONCE I sent you
On Sat, Oct 13, 2018 at 09:24:51AM +1100, Finn Thain wrote:
> > struct scatterlist *sg = scsi_sglist(cmd);
> > - int dir = cmd->sc_data_direction;
> > - int total, i;
> > + int total = 0, i;
> >
> > - if (dir == DMA_NONE)
> > - return;
> > -
>
> Removing this DMA_NONE test
On Sat, 13 Oct 2018, Christoph Hellwig wrote:
> On Sat, Oct 13, 2018 at 09:24:51AM +1100, Finn Thain wrote:
> > > struct scatterlist *sg = scsi_sglist(cmd);
> > > - int dir = cmd->sc_data_direction;
> > > - int total, i;
> > > + int total = 0, i;
> > >
> > > - if (dir == DMA_NONE)
> > > -
On Sat, 13 Oct 2018, Christoph Hellwig wrote:
> Mostly to avoid methods calls for dma mapping, but also to tidy up
> a few bits found while doing that.
>
> Changes since v2:
> - add back required DMA_NONE check
> - also clear sense_ptr for PIO transfers
> - remove the pointless union in
esp_sbus_map_command_block is called straight from the probe routine
without any locks held, so we can safely use GFP_KERNEL here.
Signed-off-by: Christoph Hellwig
---
drivers/scsi/sun_esp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/sun_esp.c
esp->dev is a void pointer that points either to a struct device, or a
struct platform_device. As we can easily get from the device to the
platform_device if needed change it to always point to a struct device
and properly type the pointer to avoid errors.
Signed-off-by: Christoph Hellwig
---
The dma_addr_t member is unused ever since we switched the SCSI
layer to send down single-segement command using a scatterlist
as well many years ago.
Signed-off-by: Christoph Hellwig
---
drivers/scsi/esp_scsi.c | 12 ++--
drivers/scsi/esp_scsi.h | 6 +-
2 files changed, 7
We can simplify use esp->dev now.
Signed-off-by: Christoph Hellwig
---
drivers/scsi/am53c974.c | 2 +-
drivers/scsi/esp_scsi.c | 8
drivers/scsi/esp_scsi.h | 5 ++---
drivers/scsi/jazz_esp.c | 2 +-
drivers/scsi/mac_esp.c | 2 +-
drivers/scsi/sun3x_esp.c | 2 +-
Except for the mac_esp driver, which uses PIO or pseudo DMA, all drivers
share the same dma mapping calls. Move the dma mapping into the core
code using the scsi_dma_map / scsi_dma_unmap helpers, with a special
identify mapping variant triggered off a new ESP_FLAG_NO_DMA_MAP flag
for mac_esp.
Remove usage of the legacy PCI DMA API. To make this easier we also
store a struct device instead of pci_dev in the dev field of struct
esp.
Signed-off-by: Christoph Hellwig
---
drivers/scsi/am53c974.c | 32 +++-
1 file changed, 15 insertions(+), 17 deletions(-)
Mostly to avoid methods calls for dma mapping, but also to tidy up
a few bits found while doing that.
Changes since v2:
- add back required DMA_NONE check
- also clear sense_ptr for PIO transfers
- remove the pointless union in struct esp_cmd_priv
Changes since v1:
- fix a sun_esp compiler
On Fri, 2018-10-12 at 17:51 -0700, Bart Van Assche wrote:
> On 10/12/18 1:36 PM, Laurence Oberman wrote:
> > While I have for the longest time used 4.5 as a base for my F/C
> jammer
> > that I use every day here in our lab I recently added more jammer
> code
> > so I decided to test this all on
On Fri, 12 Oct 2018 09:11:27 -0700, Bart Van Assche wrote:
> There have been too many problems with strcpy() and buffer overflows in the
> past. If the source and destination strings both have the same size, please
> add a BUILD_BUG_ON() statement that verifies that at compile time. If that
>
Christoph,
here is all of the newly patched dmesg output. I also added
'aic7xxx.a9c7xxx=verbose' for extra information.
Matthew
[0.00] Linux version 4.18.12.pentium4-xeon-christoph+
(root@pentium4) (gcc version 5.4.0 (Gentoo 5.4.0-r4 p1.8, pie-0.6.5))
#525 SMP PREEMPT Sat Oct 13
On Sat, Oct 13, 2018 at 10:09:52AM -0400, tedheadster wrote:
> Christoph,
> here is all of the newly patched dmesg output. I also added
> 'aic7xxx.a9c7xxx=verbose' for extra information.
Hi Matthew,
it seems like we do for some reason never actually enable swiotlb
for 32-bit x86. Before my
> it seems like we do for some reason never actually enable swiotlb
> for 32-bit x86. Before my commit the block bounce buffering papered
> over that for networking, Please try this patch:
>
> diff --git a/arch/x86/kernel/pci-swiotlb.c b/arch/x86/kernel/pci-swiotlb.c
> index
Replace existing nested code blocks with helper function calls.
Signed-off-by: David Disseldorp
---
drivers/target/iscsi/iscsi_target_erl0.c | 15 +
drivers/target/iscsi/iscsi_target_util.c | 36 ++--
drivers/target/iscsi/iscsi_target_util.h | 1 +
3
--
Hello dear! I sincerely hope i do not bother you with my message.I know
this might look strange because we don't know each other but i believe
anything is possible if we try. I have actually lost confidence on
dating sites and due to the nature of my work its not easy to find
someone so
Hi David,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on target/master]
[also build test ERROR on v4.19-rc7 next-20181012]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
19 matches
Mail list logo
