eata - issue appeared in Linus git master in last 24-48 hours

Hi, I haven't had time to do a git bisect yet, but just saw this after rebuilding the kernel in the last day or so: [1.044035] EATA0: warning, DMA protocol support not asserted. [1.044035] EATA0: IRQ 11 mapped to IO-APIC IRQ 16. [1.046040] usb usb1: New USB device found,

Re: eata - issue appeared in Linus git master in last 24-48 hours

Arthur Marsh wrote, on 30/06/14 04:31: Hi, I haven't had time to do a git bisect yet, but just saw this after rebuilding the kernel in the last day or so: [1.044035] EATA0: warning, DMA protocol support not asserted. [1.044035] EATA0: IRQ 11 mapped to IO-APIC IRQ 16. [1.046040] usb

Re: eata - issue appeared in Linus git master in last 24-48 hours

Christoph Hellwig wrote, on 11/07/14 18:50: On Mon, Jun 30, 2014 at 04:31:33AM +0930, Arthur Marsh wrote: Hi, I haven't had time to do a git bisect yet, but just saw this after rebuilding the kernel in the last day or so: It seems like some of the routines called during the driver

Re: [PATCH] eata: remove driver_lock

Christoph Hellwig wrote, on 14/07/14 17:56: port_detect is only called from the module_init routine and thus implicitly serialized, so remove the driver lock which was held over potentially sleeping function calls. Signed-off-by: Christoph Hellwig h...@lst.de Reported-by: Arthur Marsh arthur.ma

Fwd: Re: eata fails to load on post 4.2 kernels

+0930 From: Arthur Marsh <arthur.ma...@internode.on.net> To: Jiang Liu <jiang@linux.intel.com> CC: Bjorn Helgaas <bhelg...@google.com>, t...@linutronix.de, linux-scsi@vger.kernel.org, linux-ker...@vger.kernel.org Jiang Liu wrote on 07/09/15 12:36: On 2015/9/7 4:31,

Re: eata fails to load on post 4.2 kernels

Jiang Liu wrote on 08/09/15 14:49: Hi Auhur, Could you please help to apply the test patch against the latest mainstream linux kernel? Thanks! Gerry Done, and it appears to work properly thanks! Arthur. [0.00] Initializing cgroup subsys cpuset [0.00] Initializing

Re: [Bugfix] PCI, x86: Correctly allocate IRQs for PCI devices managed by non-PCI drivers

Jiang Liu wrote on 08/09/15 16:56: Commit 991de2e59090 ("PCI, x86: Implement pcibios_alloc_irq() and pcibios_free_irq()") changes the way to allocate PCI legacy IRQ for PCI devices on x86 platforms. Instead of allocating PCI legacy IRQs when pcibios_enable_device() gets called, now

Re: eata fails to load on post 4.2 kernels

Arthur Marsh wrote on 06/09/15 15:58: Hi, I'm seeing the following on post 4.2 kernels, am currently bisecting to find where it started: an error message suggested trying setting irqpoll on the kernel command line, which worked: [ 85.230148] EATA/DMA 2.0x: Copyright (C) 1994-2003 Dario

Re: eata fails to load on post 4.2 kernels

Arthur Marsh wrote on 06/09/15 18:34: Arthur Marsh wrote on 06/09/15 15:58: Hi, I'm seeing the following on post 4.2 kernels, am currently bisecting to find where it started: First kernel in the bisection that worked without needing irqpoll: [ 73.751482] EATA0: IRQ 10 mapped to IO-APIC IRQ

Re: eata fails to load on post 4.2 kernels

Jiang Liu wrote on 08/09/15 14:49: Hi Auhur, Could you please help to apply the test patch against the latest mainstream linux kernel? Thanks! Gerry ... git bisect good 991de2e59090e55c65a7f59a049142e3c480f7bd is the first bad commit commit 991de2e59090e55c65a7f59a049142e3c480f7bd

Re: eata fails to load on post 4.2 kernels

Jiang Liu wrote on 10/09/15 17:43: Hi Authur, Thanks for the updating. Seem Bjorn doesn't like neither of my two patches. So I'm trying to convert eata to formal PCI driver, but the change will be much more bigger and still not sure whether we could achieve that. Will keep you updated.

Re: [Bugfix 0/3] Convert eata driver to a normal PCI device driver

Jiang Liu wrote on 14/09/15 12:38: Hi Authur, As suggested by Bjorn, patch 1-2 set implement a PCI device driver to manage eata PCI devices. And patch 3 tries to support PCI device hot-removal for eata, but I have no change to test due to limited knowledge about scsi subsystem and

Re: [Bugfix 0/3] Convert eata driver to a normal PCI device driver

Jiang Liu wrote on 16/09/15 14:37: On 2015/9/15 15:19, Arthur Marsh wrote: Jiang Liu wrote on 15/09/15 12:01: HI Arthur, Really appreciate your help to test the patches. That's a good sign we have moved forward a bit:) For kexec, it's always challenging to me. So could you

Re: [Bugfix 0/3] Convert eata driver to a normal PCI device driver

Jiang Liu wrote on 16/09/15 17:51: Hi Arthur, It would be great if we could capture the text as in the picture posted by you at: http://www.users.on.net/~arthur.marsh/20150915547.jpg I guess a serial console could help us to capture those log messages. To use serial

Re: [Bugfix 0/3] Convert eata driver to a normal PCI device driver

Jiang Liu wrote on 15/09/15 12:01: HI Arthur, Really appreciate your help to test the patches. That's a good sign we have moved forward a bit:) For kexec, it's always challenging to me. So could you please help to provide full dmesg logs with working kernels so I could try to

Re: [RFT v3] eata: Convert eata driver as normal PCI and platform device drivers

Arthur Marsh wrote on 24/09/15 15:26: Jiang Liu wrote on 24/09/15 13:58: Hi James, Thanks for review. How about the attached patch which addresses the three suggestions from you? Thanks! Gerry I've applied the patch, rebuilt the kernel and verified that it allows unloading

Re: [RFT v3] eata: Convert eata driver as normal PCI and platform device drivers

Jiang Liu wrote on 03/10/15 17:41: Hi Arthur, The above results suggest that we need to shutdown eata controller for kexec. So could you please try to apply the attached patch upon the previous two patches? Thanks! Gerry Hi, I still get kexec shutdown errors like this with the 3rd

Re: [RFT v3] eata: Convert eata driver as normal PCI and platform device drivers

Jiang Liu wrote on 03/10/15 17:41: If I do a normal boot which includes eata being loaded, the disk attached to the DPT2044W controller having its filesystems checked and mounted, then attempt a kexec reboot, I get the reboot pausing after the "synchronizing SCSI cache" messages as before.

Re: [Bugfix] PCI, x86: Correctly allocate IRQs for PCI devices managed by non-PCI drivers

Jiang Liu wrote on 08/09/15 16:56: Commit 991de2e59090 ("PCI, x86: Implement pcibios_alloc_irq() and pcibios_free_irq()") changes the way to allocate PCI legacy IRQ for PCI devices on x86 platforms. Instead of allocating PCI legacy IRQs when pcibios_enable_device() gets called, now

Re: [RFT v3] eata: Convert eata driver as normal PCI and platform device drivers

Jiang Liu wrote on 23/09/15 14:54: Hi Arthur, I have found the cause of the warning messages, it's caused by a flaw in the conversion. But according to my understanding, it isn't related to the kexec/kdump failure. Could you please help to test the attached new version? Thanks! Gerry

Re: [RFT v3] eata: Convert eata driver as normal PCI and platform device drivers

Jiang Liu wrote on 24/09/15 13:58: Hi James, Thanks for review. How about the attached patch which addresses the three suggestions from you? Thanks! Gerry I've applied the patch, rebuilt the kernel and verified that it allows unloading of the eata module and reloading it, as well

Re: [RFT v3] eata: Convert eata driver as normal PCI and platform device drivers

Jiang Liu wrote on 22/09/15 17:00: Previously the eata driver just grabs and accesses eata PCI devices without implementing a PCI device driver, that causes troubles with latest IRQ related Commit 991de2e59090 ("PCI, x86: Implement pcibios_alloc_irq() and pcibios_free_irq()") changes the way

Re: [RFT v3] eata: Convert eata driver as normal PCI and platform device drivers

James Bottomley wrote on 23/09/15 08:15: On Wed, 2015-09-23 at 07:55 +0930, Arthur Marsh wrote: Jiang Liu wrote on 22/09/15 17:00: Previously the eata driver just grabs and accesses eata PCI devices without implementing a PCI device driver, that causes troubles with latest IRQ related

Re: [Bugfix 3/3] eata: Enhance eata driver to support PCI device hot-removal

Christoph Hellwig wrote on 16/09/15 23:12: Jiang, you also need to convert the driver to scsi_add_host/scsi_remove_host from the legacy scsi_register interface, otherwise the SCSI layer will be very unhappy. Take a look at commit 0d31f8759109cbc1e6fc196d08e6b0e8a9e93b3f for example, the

eata module for DPT SCSI cards

Hi, I'm still having to have the following applied to be able to use the eata driver for my DPT2044W SCSI card. Is there any chance that this could be mainlined or another fix implemented that can be mainlined? As it is with the following patches applied, I still have to unload and reload

Re: [PATCH] eata: Convert eata driver as normal PCI and platform device drivers

Arthur Marsh wrote on 02/03/16 03:57: Christoph Hellwig wrote on 01/03/16 17:22: Hi Jiang. I'd love to see this patch in and abuse of the old PCI API gone. Did you resolve the problems Arthur saw with the previous iteratons of the patch? I applied Jiang Liu's patch of 1st March 2016

Re: [PATCH] eata: Convert eata driver as normal PCI and platform device drivers

Jiang Liu wrote on 02/03/16 13:50: I spoke too soon, without removing and re-inserting the eata module before any filesystems on disks attached to the DPT controller were mounted, I'd get the following messages, similar to ones previously reported: sd 0:0:6:0: tag#0 abort, mbox 1. EATA0:

Re: [PATCH] eata: Convert eata driver as normal PCI and platform device drivers

Christoph Hellwig wrote on 01/03/16 17:22: Hi Jiang. I'd love to see this patch in and abuse of the old PCI API gone. Did you resolve the problems Arthur saw with the previous iteratons of the patch? I applied Jiang Liu's patch of 1st March 2016 to a clean kernel 4.5.0-rc6 source,

Re: [PATCH 0/4] block: Fixes for bdi handling

these commits we had a different set of problems in the code but they were less visible :). I'm still waiting for test confirmation from Omar and Arthur Marsh who reported issues but I'm not able to hit any problem anymore in my testing. I think it would be nice to get the patches to rc2 so to

problem with block: Move bdi_unregister() to del_gendisk() commit 165a5e22fafb127ecb5914e12e8c32a1f0d3f820

On one of my pc's I have 2 PATA disks (one, WDC below is used for booting, the other SAMSUNG is not mounted), plus an IBM SCSI disk using a DPT 2044W controller with eata driver and sometimes a Verbatim Storengo USB stick. On recent 4.10.0+ kernel builds (i386), the resulting kernel would

Re: CPU lock-ups with 4.12.0+ kernels related to usb_storage

Alan Stern wrote on 14/07/17 02:30: All right. In the meantime, changing usb-storage won't hurt. Arthur, can you test the patch below? Alan Stern Index: usb-4.x/drivers/usb/storage/usb.c === ---

Re: CPU lock-ups with 4.12.0+ kernels related to usb_storage

Arthur Marsh wrote on 14/07/17 04:18: Alan Stern wrote on 14/07/17 02:30: All right. In the meantime, changing usb-storage won't hurt. Arthur, can you test the patch below? Alan Stern Index: usb-4.x/drivers/usb/storage/usb.c

Re: [PATCH] scsi: eata: drop VLA in reorder()

egression"). And even then it apparently took a year for people to have noticed the breakage. But because the person who reported that problem is still around, I'll just add him to the cc, just in case. Arthur Marsh, you have the dubious honor and distinction of being the only person to have a