Re: [Announce] Emulex lpfcdriver v8.0.20 available

2005-01-17 Thread Christoph Hellwig
On Tue, Jan 11, 2005 at 01:34:37PM -0500, [EMAIL PROTECTED] wrote: Christoph and Community, The 8.0.20 release of the Emulex driver has been recently posted to SourceForge: http://prdownloads.sourceforge.net/lpfc/lpfcdriver-2.6-8.0.20.tar.gz?download Emulex has been working hard to

[PATCH] drop some attibutes from the FC transport class

2005-01-19 Thread Christoph Hellwig
I think the hardware_version, firmware_version, rom_version and driver_version don't belong into the FC transport class, there's nothign specific to FC or even SCSI specific in them. If you want these attributes talk to Greg about fiding a place in the common driver model code for them. p.s. I

Re: [PATCH] drop some attibutes from the FC transport class

2005-01-19 Thread Christoph Hellwig
On Wed, Jan 19, 2005 at 02:40:16PM -0800, Greg KH wrote: I had a patch to do that around here somewhere, but I think it was rejected as people can get the same info by using 'modinfo' instead. You know, the old, use a userspace tool instead of wasting kernel memory argument :) How's that

Re: [Announce] Emulex lpfcdriver v8.0.20 available

2005-01-20 Thread Christoph Hellwig
o the host removal is still quite hackish and probably racy: - everything what's you're ding with FC_UNLOADING should be done in the midlayer where we already have a state machine for the Scsi_Host There's only 2 uses for this flag... - In the node state machine,

Re: [PATCH 1/2] streamline block SG_IO error processing

2005-01-20 Thread Christoph Hellwig
On Sat, Jan 15, 2005 at 01:35:32PM +1000, Douglas Gilbert wrote: I am working on the assumption that users of the SG_IO ioctl in the block layer (or via st or osst) want SCSI status and sense data returned via the ioctl immediately without: - the error/warning silently disappearing and/or

Re: [PATCH 2/2] streamline block SG_IO error processing

2005-01-20 Thread Christoph Hellwig
On Sat, Jan 15, 2005 at 01:36:21PM +1000, Douglas Gilbert wrote: Changelog: - sd_init_command(): use retry count of 1 for block SG_IO; minor cleanup - sd_rw_init(): bypass sd level error processing for block SG_IO Signed-off-by: Douglas Gilbert [EMAIL PROTECTED] + if (!

Re: [PATCH] sg descriptor sense cleanup lk 2.6.11-rc1-bk1

2005-01-20 Thread Christoph Hellwig
On Mon, Jan 17, 2005 at 09:39:37PM +1000, Douglas Gilbert wrote: Continuation of descriptor sense data expansion to sg driver. Next will be the sd driver which awaits a new utility function in constants.c to read the sense data information field for medium/hardware errors. Changelog:

Re: [PATCH] aacraid 2.6: add scsi synchronize cache support.

2005-01-20 Thread Christoph Hellwig
+static void synchronize_callback(void *context, struct fib * fibptr) +{ + struct aac_synchronize_reply * synchronizereply; + struct scsi_cmnd * scsicmd; Superflous whitespaces before the *. Also the canonical name for scsi_cmnds seems to be cmd - that makes easiert to read code. +

Re: [PATCH] osst: don't use obsolete SCSI APIs

2005-01-20 Thread Christoph Hellwig
On Mon, Jan 03, 2005 at 04:53:05PM +0100, Christoph Hellwig wrote: this patch gets rid of the need for scsi.h, similar to the recent patch to the st driver. (applies ontop of Willem's patches) ping? = drivers/scsi/osst.c 1.65 vs edited = --- 1.65/drivers/scsi/osst.c 2005-01

Re: [Announce] Emulex lpfcdriver v8.0.20 available

2005-01-20 Thread Christoph Hellwig
On Thu, Jan 20, 2005 at 10:27:54AM -0500, [EMAIL PROTECTED] wrote: What console messages do you see? Looks like we'd have to add another allowed state transition from BLOCKED? At one point we were seeing Synchronizing SCSI cache for disk sdc: FAILED status = 0, message =

Re: [Announce] Emulex lpfcdriver v8.0.20 available

2005-01-20 Thread Christoph Hellwig
On Thu, Jan 20, 2005 at 10:54:47AM -0500, [EMAIL PROTECTED] wrote: No, sorry for have been unclear. I want a pointer to the remote port structure in the fc_target transport data. Every driver needs the linkage of these two, and instead of everyone having it in their private data we'd

Re: [Announce] Emulex lpfcdriver v8.0.20 available

2005-01-25 Thread Christoph Hellwig
On Thu, Jan 20, 2005 at 11:26:00AM -0500, [EMAIL PROTECTED] wrote: This sounds like a good idea, but I wonder if we have userland relying on those attributes already. But given that the fc transport class was mostly a joke before you encehanced it it might be worth breaking it.. You

Re: How to disconnect a SCSI device without crashing SLES8?

2005-02-04 Thread Christoph Hellwig
On Fri, Feb 04, 2005 at 02:12:13PM -0500, Eric Raskin wrote: In searching the web, I've found the remove-scsi-device and add-scsi-device commands that can be sent to /proc/scsi/scsi. Does anybody know if the system will stay up if I use these commands to remove all my tape library devices

Re: PATCH [0/3] qla2xxx: new experimental changes...

2005-02-04 Thread Christoph Hellwig
patch3 seems to not have made it to the list. From a quick view the first three patches look fine, except for backing out one msleep conversion and the superflous return at the end of qla2xxx_slave_destroy - To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a

Re: About ARECA RAID driver for Linux i386/x86-64

2005-02-06 Thread Christoph Hellwig
On Thu, Feb 03, 2005 at 12:33:37PM +0800, erich wrote: Hi,Andrew Morton Thanks for your doing. ARECA Linux RAID driver need to support old linux kerenel version. There are a lot of NAS RAID STORAGE SYSTEM development worker still use it at old linux kernel. Maybe I need to released one

Re: About ARECA RAID driver for Linux i386/x86-64

2005-02-06 Thread Christoph Hellwig
On Thu, Feb 03, 2005 at 11:05:32AM +0100, Arjan van de Ven wrote: * needs to use list.h lists not open coded ones the only list uses I saw in a quick scan were for internal queueing which should go away. (see the tmscsim driver in 2.6 on what to return when the queue is full) * uses wrong

Re: [PATCH 3/3] MidLayer updates - extending scsi_target support

2005-02-06 Thread Christoph Hellwig
On Sun, Feb 06, 2005 at 12:28:17PM -0500, [EMAIL PROTECTED] wrote: Since the Emulex driver tracks things by target (actually FC remote port) rather than luns, having the ability to have driver data space in the lun didn't help much. Yes, the driver data space could be in the transport-specific

Re: [PATCH 2/2 scsi-rc-fixes-2.6] FC Remote Port patch

2005-02-09 Thread Christoph Hellwig
This one doesn't apply to scsi-misc + your previous two patches for me. - To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH 1/3] qla1280: remove qla1280_proc_info

2005-02-10 Thread Christoph Hellwig
reading the /proc/scsi/qla1280/* files can easily corrupt kernel memory. As the feature is deprecated, and the qla1280 implementation doesn't return very usefull implementation but is so buggy that any serious user would have noticed we just remove it. --- 1.72/drivers/scsi/qla1280.c 2004-10-22

[PATCH 3/3] qla1280: update changelog

2005-02-10 Thread Christoph Hellwig
, February 10, 2005 Christoph Hellwig + - use pci_map_single to map non-S/G requests + - remove qla1280_proc_info Rev 3.25, September 28, 2004, Christoph Hellwig - add support for ISP1020/1040 - don't include scsi.h anymore for 2.6.x - To unsubscribe from this list

[PATCH 2/3] qla1280: user pci_map_single

2005-02-10 Thread Christoph Hellwig
--- 1.72/drivers/scsi/qla1280.c 2004-10-22 06:20:31 +02:00 +++ edited/drivers/scsi/qla1280.c 2005-02-10 13:42:44 +01:00 @@ -1571,16 +1465,12 @@ qla1280_done(struct scsi_qla_host *ha) /* Release memory used for this I/O */ if (cmd-use_sg) { -

[PATCH] mark qlogicfc broken

2005-02-10 Thread Christoph Hellwig
The hardware is supported by qla2xxx which is much better (and maintained) driver. Keeping the driver around confuses people to actually use it with severe results, e.g. http://marc.theaimsgroup.com/?l=linux-kernelm=110656624623547w=2 --- 1.95/drivers/scsi/Kconfig 2005-01-28 18:14:29

[PATCH] mark qlogicisp broken

2005-02-10 Thread Christoph Hellwig
It's lacking EH support and the hardware is supported by the qla1280 driver now. --- 1.95/drivers/scsi/Kconfig 2005-01-28 18:14:29 +01:00 +++ edited/drivers/scsi/Kconfig 2005-02-10 14:59:56 +01:00 @@ -1249,7 +1227,7 @@ config SCSI_QLOGIC_ISP tristate Qlogic ISP SCSI support (old

[PATCH] mark eata_pio broken

2005-02-10 Thread Christoph Hellwig
it oopses when trying to use it with my SmartRaid IV card, it's a mess and the only hardware supported by it but not the eata driver are two 10-year old ISA boards. --- 1.95/drivers/scsi/Kconfig 2005-01-28 18:14:29 +01:00 +++ edited/drivers/scsi/Kconfig 2005-02-10 14:59:56 +01:00 @@ -611,7

Re: [PATCH] mark qlogicisp broken

2005-02-10 Thread Christoph Hellwig
On Thu, Feb 10, 2005 at 10:30:46AM -0800, Patrick Mansfield wrote: On Thu, Feb 10, 2005 at 07:18:51PM +0100, Christoph Hellwig wrote: It's lacking EH support and the hardware is supported by the qla1280 driver now. Can we instead remove this one and the qlogicfc? Marking it BROKEN

Re: [PATCH] mark qlogicfc broken

2005-02-11 Thread Christoph Hellwig
On Fri, Feb 11, 2005 at 09:06:14AM -0500, Ricky Beam wrote: On Thu, 10 Feb 2005, Christoph Hellwig wrote: The hardware is supported by qla2xxx which is much better (and maintained) driver. Keeping the driver around confuses people to actually use it with severe results, e.g. That's a nice

Re: [PATCH] clean up drivers/scsi/scsi.h

2005-02-14 Thread Christoph Hellwig
On Mon, Feb 14, 2005 at 11:57:29AM +0100, Rolf Eike Beer wrote: Hi, this patch removes some useless struct declarations from drivers/scsi/scsi.h. All this structs are already defined in the header files included above except Scsi_Host, for which we now directly include scsi/scsi_host.h No,

Re: [KJ] [PATCH][RESUBMIT][11/21] drivers/scsi/* - compile warning cleanup

2005-02-15 Thread Christoph Hellwig
On Tue, Feb 15, 2005 at 02:09:02PM +, Matthew Wilcox wrote: On Tue, Feb 15, 2005 at 10:39:59AM +, Christoph Hellwig wrote: - return readb(host-base + (reg^bE)); + return readb((volatile void __iomem *)(host-base + (reg^bE))); Again, no. Stop casting to void __iomem pointers

Re: [patch] add scsi changer driver

2005-02-15 Thread Christoph Hellwig
[this should go to linux-scsi] +#include linux/version.h not needed. +#include asm/system.h I doubt you'll need this one. +#include asm/uaccess.h + +#include linux/chio.h /* here are all the ioctls */ linux/*.h should always go before asm/*.h +#define MAJOR_NR

Re: [ANNOUNCE] Adaptec SAS/SATA device driver [0/27]

2005-02-17 Thread Christoph Hellwig
On Thu, Feb 17, 2005 at 12:34:41PM -0500, Luben Tuikov wrote: Hi, Adaptec would like to announce its SAS/SATA Linux device driver for inclusion into the Linux kernel. The driver supports Adaptec's AIC-94XX chip based, eight port SAS and SATA 64-bit PCI-X, 133MHz ASIC controller. The

Re: [ANNOUNCE] Adaptec SAS/SATA device driver [27/27]

2005-02-17 Thread Christoph Hellwig
On Thu, Feb 17, 2005 at 11:31:31PM +0300, Michael Tokarev wrote: Luben Tuikov wrote: The readme file. diff -Nru a/drivers/scsi/adp94xx/readme.txt [] +=README for= += Red Hat Linux Advanced Server 2.1 =

Re: [PATCH 2/3] qla1280: user pci_map_single

2005-02-18 Thread Christoph Hellwig
On Fri, Feb 18, 2005 at 04:48:00AM -0500, Jes Sorensen wrote: Christoph, When pci_map_page was originally introduced it was meant to deprecate pci_map_single, at least thats what my memory tells me. No, it's for rather different uses. pci_map_page would be nice to get rid of in favour of

Re: [2.6.11-rc4-mm1 patch] drivers/scsi/arcmsr/arcmsr.c cleanups

2005-02-27 Thread Christoph Hellwig
On Sun, Feb 27, 2005 at 04:48:10PM +0100, Adrian Bunk wrote: - aren't the if defined(__x86_64__) wrong for other 64bit architectures? Yes. Having arch or 64bit ifdefs is pretty wrong pretty much always. In one case it's only used to make a typedef a 32bit or 64bit integeger, that should be

Re: [2.6 patch] drivers/scsi/qla2xxx/: cleanups

2005-02-28 Thread Christoph Hellwig
On Mon, Feb 28, 2005 at 10:00:24PM +0100, Adrian Bunk wrote: This patch contains the following cleanups: - make needlessly global code static - kill the unused global *_version and *_version_str variables in the firmware files The firmware files are generated, so it'd be better to leave

Re: [2.6 patch] drivers/scsi/scsi_transport_fc.c: #0 unused code

2005-02-28 Thread Christoph Hellwig
On Mon, Feb 28, 2005 at 11:00:20PM +0100, Adrian Bunk wrote: This patch #if 0's the following EXPORT_SYMBOL'ed but unused functions: - fc_target_block - fc_target_unblock - fc_host_block - fc_host_unblock A driver using them is scheduled to be merged soon, and at least one other will be

Re: [2.6 patch] SCSI: possible cleanups

2005-02-28 Thread Christoph Hellwig
On Mon, Feb 28, 2005 at 10:31:59PM +0100, Adrian Bunk wrote: Before I'm getting flamed to death: This patch contains possible cleanups. If parts of this patch conflict with pending changes these parts of my patch have to be dropped. This patch contains the following possible cleanups: -

Re: [2.6 patch] SCSI: possible cleanups

2005-02-28 Thread Christoph Hellwig
On Tue, Mar 01, 2005 at 12:01:55AM +0100, Adrian Bunk wrote: On Mon, Feb 28, 2005 at 10:25:09PM +, Christoph Hellwig wrote: ... - constants.c: scsi_print_hostbyte - constants.c: scsi_print_driverbyte these we'll probably keep for now. ... keep = #if 0 ? In this case yes

Re: [2.6 patch] SCSI: possible cleanups

2005-03-01 Thread Christoph Hellwig
On Tue, Mar 01, 2005 at 09:40:48AM -0500, Luben Tuikov wrote: On 03/01/05 03:14, Douglas Gilbert wrote: - scsi_error.c: scsi_normalize_sense I introduced scsi_normalize_sense() recently, Christoph H. proposed it should be static but Luben Tuikov (aic7xxx maintainer) said he wished to

Re: [ANNOUNCE] iSCSI enterprise target software

2005-03-01 Thread Christoph Hellwig
On Tue, Mar 01, 2005 at 09:38:34PM +0100, Andi Kleen wrote: Arjan van de Ven [EMAIL PROTECTED] writes: You want to *use* the kernel pagecache as much as you can. You do so by using mmap and such, and msync to force content to disk. That uses the Last time I checked you couldn't mmap

Re: cciss CSMI via sysfs for 2.6

2005-03-01 Thread Christoph Hellwig
On Fri, Feb 18, 2005 at 12:05:52PM -0800, Greg KH wrote: On Fri, Feb 18, 2005 at 07:46:28PM +, Christoph Hellwig wrote: /* + * sysfs stuff + * this should be moved to it's own file, maybe cciss_sysfs.h + */ + +static ssize_t cciss_firmver_show(struct device *dev, char *buf

Re: [RFC] ncr53c8xx updates

2005-03-06 Thread Christoph Hellwig
On Sun, Mar 06, 2005 at 08:11:53PM +, Matthew Wilcox wrote: This isn't for applying so much as it is for showing people where I am with this driver. As with the sym2 driver, I commit each piece to the parisc-linux CVS tree (since parisc is currently the only user of this driver, it makes

Re: [PATCH] m68k link error and NCR5380_exit()

2005-03-06 Thread Christoph Hellwig
.detect = macscsi_detect, - .release= macscsi_release, + .release= __exit_p(macscsi_release), Please get rid of your -detect/-release useage instead. Allocate the host struct directly with scsi_host_alloc

Re: [ANNOUNCE][PATCH 2.6.11 2/3] megaraid_sas: Announcing new mod ule for LSI Logic's SAS based MegaRAID controllers

2005-03-09 Thread 'Christoph Hellwig'
On Wed, Mar 09, 2005 at 09:43:47AM -0500, Bagalkote, Sreenivas wrote: During the module load time, I allocate 32 bit or 64 bit SGLs based on whether I can receive 64 bit DMA addresses or not. If size of dma_addr_t is 4, then I allocate only 32 bit SGLs. During the run time, I prepare 32/64

Re: [ANNOUNCE][PATCH 2.6.11 2/3] megaraid_sas: Announcing new mod ule for LSI Logic's SAS based MegaRAID controllers

2005-03-09 Thread 'Christoph Hellwig'
On Wed, Mar 09, 2005 at 05:47:27PM -0500, Bagalkote, Sreenivas wrote: Even for kernels with a 64bit dma_addr_t you can get 32bit dma addresses only. As a start check whether the pci_set_dma_mask for the 64bit mask failed - in that case you can always use 32bit SGLs. Please help me

Re: [PATCH] dc395x: Fix support for highmem

2005-03-16 Thread Christoph Hellwig
On Wed, Mar 16, 2005 at 05:53:39PM +0100, Jens Axboe wrote: The list doesn't really need dma mapping at that point, the problem here is that the driver needs to punt to pio mode because of foo. So calling pci/dma_map_* is pointless, since the CPU will have to do the transfer anyways. What the

Re: adaptec 2120S software under RedHat 8.0 and FC2

2005-03-20 Thread Christoph Hellwig
On Wed, Mar 16, 2005 at 01:52:51PM -0800, Mark Haverkamp wrote: On Wed, 2005-03-16 at 08:02 -0500, Salyzyn, Mark wrote: The applications require the Adaptec Branch of the driver in order to function (mainly because the kernel.org branch drops the /proc/scsi/aacraid entry). I have submitted

Re: adaptec 2120S software under RedHat 8.0 and FC2

2005-03-23 Thread Christoph Hellwig
On Tue, Mar 22, 2005 at 04:32:04PM -, Ross Macintyre wrote: Since you advise us to stay away from Adaptec, and I assume you are part of the team that manages the Fedora system, I'm not associated with Fedora at all. can you advise users what RAID / Storage vendors to use? ie what quality

Re: adaptec 2120S software under RedHat 8.0 and FC2

2005-03-23 Thread Christoph Hellwig
On Tue, Mar 22, 2005 at 12:43:50PM -0500, Salyzyn, Mark wrote: No, this shows that you have no interest in supporting legacy applications legacy of Adaptec's non linux-supporting past. note that if adaptec simply opensourced their managment tools we wouldn't have this problem at all. I wonder

Re: [PATCH] - MPT FUSION - SPLITTING SCSI HOST DRIVERS

2005-03-26 Thread Christoph Hellwig
I took a quick look an a here's a few comments: - I don't think renaming mptscsih.c to mpt_core.c makes sense. the new name is confusing at best, and keeping the old name allows to keep SCCS history aswell. That means the new SPI stub driver should be called mptspi or something like

Re: adaptec 2120S software under RedHat 8.0 and FC2

2005-03-28 Thread Christoph Hellwig
note that if adaptec simply opensourced their managment tools we wouldn't have this problem at all. I wonder why Adaptec did that for the old i2o-based controllers but not aacraid. Oh yes, that, worked hard on the powers-that-be to permit this. Could not release a substantial majority

Re: [PATCH] 2.6 aacraid: endian cleanup

2005-03-28 Thread Christoph Hellwig
On Mon, Mar 21, 2005 at 10:41:23AM -0800, Mark Haverkamp wrote: A patch from Adaptec with byte order changes: - drop byte swapping on all 0's and all 1's content - fix up missing swapping directives - ensure swapping on 16 bit values does not use 32 bit swap - reconcile the readl/writel

Re: [PATCH] rm unused scan delay var

2005-03-29 Thread Christoph Hellwig
On Fri, Mar 25, 2005 at 10:16:19PM -0800, Mike Christie wrote: Is FC_SCSI_SCAN_DELAY used by a FC driver that is not yet in mainline? This patch just deletes it if not since no one else is. It's not used by either the Emulex or the rewritten qlogic driver, so it can probably go away. - To

Re: [PATCH] 2.6 aacraid: endian cleanup

2005-03-29 Thread Christoph Hellwig
On Tue, Mar 29, 2005 at 08:49:33AM -0800, Mark Haverkamp wrote: I ran sparse on the driver and without the -Wbitwise, it only has 7 warnings such as: CHECK drivers/scsi/aacraid/linit.c drivers/scsi/aacraid/linit.c:218:12: warning: symbol 'aac_info' was not declared. Should it be static?

[PATCH] consolidate timeout defintions in scsi.h

2005-03-29 Thread Christoph Hellwig
Adapted from a patch in SuSE's kernel SRPM. --- 1.65/drivers/block/scsi_ioctl.c 2005-01-20 16:41:57 +01:00 +++ edited/drivers/block/scsi_ioctl.c 2005-03-29 17:54:17 +02:00 @@ -328,11 +328,6 @@ return 0; } -#define FORMAT_UNIT_TIMEOUT(2 * 60 * 60 * HZ) -#define

[PATCH] remove outdated print_* functions

2005-03-29 Thread Christoph Hellwig
We have the scsi_print_* functions in the proper namespace for a long time now and there weren't a lot users left. --- 1.22/drivers/scsi/53c7xx.c 2004-05-12 17:46:19 +02:00 +++ edited/drivers/scsi/53c7xx.c2005-03-29 17:32:18 +02:00 @@ -280,6 +280,7 @@ #endif #include scsi.h

Re: [PATCH scsi-misc-2.6 04/13] scsi: remove meaningless volatile qualifiers from structure definitions

2005-03-31 Thread Christoph Hellwig
On Thu, Mar 31, 2005 at 06:08:10PM +0900, Tejun Heo wrote: struct list_headsiblings; /* list of all devices on this host */ struct list_headsame_target_siblings; /* just the devices sharing same target id */ - volatile unsigned short device_busy;/* commands

Re: [PATCH scsi-misc-2.6 01/13] scsi: don't use blk_insert_request() for requeueing

2005-03-31 Thread Christoph Hellwig
On Thu, Mar 31, 2005 at 06:07:55PM +0900, Tejun Heo wrote: 01_scsi_no_REQ_SPECIAL_on_requeue.patch blk_insert_request() has 'reinsert' argument, which, when set, turns on REQ_SPECIAL and REQ_SOFTBARRIER and requeues the request. SCSI midlayer was the only user of this

Re: [PATCH scsi-misc-2.6 05/13] scsi: remove a timer race from scsi_queue_insert() and cleanup timer

2005-03-31 Thread Christoph Hellwig
/* Queue the command and wait for it to complete */ /* Abuse eh_timeout in the scsi_cmnd struct for our purposes */ init_timer(cmd-eh_timeout); + cmd-eh_timeout.function = NULL; I'd rather not see aic7xxx poke even deeper into this

Re: [PATCH scsi-misc-2.6 08/13] scsi: move request preps in other places into prep_fn()

2005-03-31 Thread Christoph Hellwig
+/* + * Macro to determine the size of SCSI command. This macro takes vendor + * unique commands into account. SCSI commands in groups 6 and 7 are + * vendor unique and we will depend upon the command length being + * supplied correctly in cmd_len. + */ +#define CDB_SIZE(cmd)

Re: [PATCH scsi-misc-2.6 09/13] scsi: in scsi_prep_fn(), remove bogus comments clean up

2005-03-31 Thread Christoph Hellwig
- /* - * This sets up the scatter-gather table (allocating if - * required). - */ + /* This sets up the scatter-gather table (allocating if + * required). */ the old comment style is the preferred in linux, please

Re: [PATCH scsi-misc-2.6 11/13] scsi: add reprep arg to scsi_requeue_command() and make it public

2005-03-31 Thread Christoph Hellwig
- * Arguments:q - queue to operate on - * cmd - command that may need to be requeued. + * Arguments:cmd - command that may need to be requeued. + * reprep - needs to prep the command again? * * Returns: Nothing * @@ -478,11 +478,16

Re: [PATCH scsi-misc-2.6 10/13] scsi: rewrite scsi_request_fn()

2005-03-31 Thread Christoph Hellwig
the changes look good to me (although I haven't tested any of your patches yet), but the code flow is rather confusing. What do you think about the not even compile version of scsi_request_fn() below that should be functionally identical to yours: static void scsi_request_fn(struct

Re: [PATCH] Convert i2o to compat_ioctl

2005-03-31 Thread Christoph Hellwig
Markus, is this patch actually okay? I just talked to Andi about the ioctl32 issues and he told me about this patch. On Tue, Jan 18, 2005 at 12:24:55PM +0100, Andi Kleen wrote: Convert I2O to new compat_ioctl entry points Also broken design in its compat handlers - CONFIG_COMPAT doesn't

Re: iomapping a big endian area

2005-04-04 Thread Christoph Hellwig
On Mon, Apr 04, 2005 at 08:59:03AM -0500, James Bottomley wrote: Well ... it's like this. Native means pass through without swapping and has an easy implementation on both BE and LE platforms. Logically io{read,write}{16,32}be would have to do byte swaps on LE platforms. Being lazy, I'm

Re: [PATCH] Convert i2o to compat_ioctl

2005-04-05 Thread Christoph Hellwig
On Fri, Apr 01, 2005 at 12:20:50PM +0200, Markus Lidel wrote: Hello, Christoph Hellwig wrote: Markus, is this patch actually okay? I just talked to Andi about the ioctl32 issues and he told me about this patch. OK, i don't own a 64-bit system, so i couldn't test it out :-( The only

Re: [PATCH] Use proper seq_file api for /proc/scsi/scsi

2005-04-07 Thread Christoph Hellwig
On Thu, Apr 07, 2005 at 11:46:27AM +0200, Hannes Reinecke wrote: Hi all, /proc/scsi/scsi currently has a very dumb implementation of the seq_file api which causes 'cat /proc/scsi/scsi' to return with -ENOMEM when a large amount of devices are connected. /proc/scsi/scsi is deprecated and

Re: [PATCH] Use proper seq_file api for /proc/scsi/scsi

2005-04-07 Thread Christoph Hellwig
On Thu, Apr 07, 2005 at 01:21:23PM +0200, Hannes Reinecke wrote: /proc/scsi/scsi is deprecated and even only compiled in if legacy /proc/scsi/ support is enabled. Please move over to lssci which is using sysfs ASAP. Ah. And that's enough reason for it not to work properly? Deprecated

Re: [OOPS] 2.6.11 - NMI lockup with CFQ scheduler

2005-04-07 Thread Christoph Hellwig
On Thu, Apr 07, 2005 at 09:18:38AM -0400, James Bottomley wrote: On Thu, 2005-04-07 at 08:49 +0200, Jens Axboe wrote: On Wed, Apr 06 2005, James Bottomley wrote: My proposal is to correct this by moving the data back to the correct object, and make any object using it hold a reference, so

Re: proc_name in sysfs

2005-04-08 Thread Christoph Hellwig
On Wed, Apr 06, 2005 at 01:40:04PM +0200, Frederic TEMPORELLI wrote: Hello, We are using HBAs modules names from proc_name interface in sysfs: /sys/class/scsi_host/hostX/proc_name. But with new Emulex drivers (8.0.21 and +), proc_name is reporting NULL (previous drivers were reporting

Re: [PATCH] aacraid 2.6: Address sparse warnings

2005-04-08 Thread Christoph Hellwig
+ u32 temp = le32_to_cpu(psg-sg[i-1].count) - + (byte_count - scsicmd-request_bufflen); + psg-sg[i-1].count = cpu_to_le32(temp); You really want {be,le}*_{add,sub} helpers. I needed them on various occasions, too. Al, what

Re: [PATCH] Use proper seq_file api for /proc/scsi/scsi

2005-04-08 Thread Christoph Hellwig
On Fri, Apr 08, 2005 at 12:23:46AM -0700, Jeremy Higdon wrote: It works for those setups that already worked with 2.4.x, aka only a few luns. Even if it's deprecated, wouldn't it be good to fix it as long as it's there, unless it hurts something else? Or at least fix the out of memory

Re: [PATCH] Use proper seq_file api for /proc/scsi/scsi

2005-04-08 Thread Christoph Hellwig
On Fri, Apr 08, 2005 at 01:10:11AM -0700, Jeremy Higdon wrote: Just as a sanity check, you meant lsscsi and not lssci in your original reply, right? Yes. - To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to [EMAIL PROTECTED] More majordomo info at

Re: proc_name in sysfs

2005-04-11 Thread Christoph Hellwig
On Fri, Apr 08, 2005 at 06:03:16PM +1000, Douglas Gilbert wrote: The real problem is that someone decided to export the proc_name in sysfs. It's supposed to be only procfs-specific but someone violated that rule. Forget the proc_ part. It is effectively the lld_name. Allowing the LLD to

Re: [PATCH scsi-misc-2.6 03/04] scsi: make scsi_requeue_request() use blk_requeue_request()

2005-04-11 Thread Christoph Hellwig
+ cmd-request-flags |= REQ_SOFTBARRIER; + + spin_lock_irqsave(q-queue_lock, flags); + blk_requeue_request(q, cmd-request); + spin_unlock_irqrestore(q-queue_lock, flags); scsi_run_queue(q); This exact code sequence is duplicated in the previous patch, maybe time for

Re: [ANNOUNCE 2/6] Linux-iSCSI High-Performance Initiator

2005-04-12 Thread Christoph Hellwig
On Mon, Apr 11, 2005 at 10:36:51PM -0700, Greg KH wrote: On Mon, Apr 11, 2005 at 08:24:08PM -0700, Alex Aizman wrote: Common header files: - iscsi_ifev.h (user/kernel events). These structures cross the user/kernel boundry? If so, they _must_ use the __u32 and

Re: [ANNOUNCE 2/6] Linux-iSCSI High-Performance Initiator

2005-04-12 Thread Christoph Hellwig
On Tue, Apr 12, 2005 at 12:45:14AM -0700, Greg KH wrote: Um, why? We've been down this road before, and for types that cross the boundry, we _must_ use the __ version of the kernel types, not the uint32_t stuff. That's total bullshit. C99 types just work in both the kernel and userland,

Re: [PATCH] scsi/a100u2w: Remove custom msecs_to_jiffies and jiffies_to_msecs macros

2005-04-13 Thread Christoph Hellwig
static void waitForPause(unsigned amount) { - ULONG the_time = jiffies + MS_TO_JIFFIES(amount); + ULONG the_time = jiffies + msecs_to_jiffies(amount); while (time_before_eq(jiffies, the_time)) cpu_relax(); You should probably replace this function with msleep

Re: PATCH [2/5] qla2xxx: add remote port codes...

2005-04-13 Thread Christoph Hellwig
+#include linux/version.h not needed (this is in qla_attr.c) +struct scsi_transport_template * +qla2x00_alloc_transport_tmpl(void) +{ + return (fc_attach_transport(qla2xxx_transport_functions)); +} I don't see much of a point in this function vs just making qla2xxx_transport_functions

[PATCH] remove old scsi data direction macros

2005-04-14 Thread Christoph Hellwig
these have been wrappers for the generic dma direction bits since 2.5.x. This patch converts the few remaining drivers and removes the macros. --- 1.24/Documentation/DMA-mapping.txt 2004-07-30 04:35:43 +02:00 +++ edited/Documentation/DMA-mapping.txt2005-04-12 23:52:31 +02:00 @@ -443,15

Re: [linux-iscsi-devel] [ANNOUNCE] open-iscsi and linux-iscsi project teams have merged!

2005-04-14 Thread Christoph Hellwig
On Mon, Apr 11, 2005 at 10:30:58PM -0400, linux-iscsi development team wrote: The linux-iscsi and open-iscsi developers would like to announce that they have combined forces on a single iSCSI initiator effort! What SCM will the code be in? I must admit I really, really prefer the SVN hosting

Re: [PATCH] remove old scsi data direction macros

2005-04-14 Thread Christoph Hellwig
On Thu, Apr 14, 2005 at 12:56:39PM +0200, Christoph Hellwig wrote: these have been wrappers for the generic dma direction bits since 2.5.x. This patch converts the few remaining drivers and removes the macros. Arjan noticed there's some hunk in here that shouldn't. Updated patch below

Re: Fw: [SCSI] Driver broken in 2.6.x?

2005-04-14 Thread Christoph Hellwig
I've recently switched form 2.4.x kernel series to 2.6.x, and I've encourted a problem with my old scanner card, lspci shows it as: begin lspci output 00:0c.0 SCSI storage controller: DTC Technology Corp. Domex 536 Control: I/O+ Mem- BusMaster- SpecCycle- MemWINV- VGASnoop-

Re: Question about scsi_device_online() usage in mptscsih

2005-04-14 Thread Christoph Hellwig
On Sat, Apr 02, 2005 at 02:35:57PM +0900, Tejun Heo wrote: Hello, Eric. Hello, James. I've been working on new SCSI state model and was checking on scsi_device_online() users. As the state model is going to change, I need to audit device state usages in lldd's and I'm having difficult

Re: [RFC][PATCH 2.6.11-rc2] Linux SCSI hotplug infrastructure

2005-04-14 Thread Christoph Hellwig
On Thu, Apr 14, 2005 at 01:24:33PM -0500, Matt Domsch wrote: I posted this back in February, with no response (good or bad). I still think this is useful, and would appreciate feedback. I don't like this at all. It's adding a kernel roundtrip for things that should be handled in userland. -

Fibre Channel state of the union

2005-04-18 Thread Christoph Hellwig
With the upcoming merge of the current SCSI development branch (probably after the 2.6.12 release), Linux will have more advanced Fibre Channel support than any currently available operating system. The new Fibre Channel (FC) transport class offers two major advantages over traditional

Re: [RFC 1 of 9] patches to add diskdump functionality to block layer

2005-04-18 Thread Christoph Hellwig
This looks like a patch for Linux 2.4. Such major changes for the 2.4 tree don't make sense anymore, especially for functionality not even in Linux 2.6. - To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to [EMAIL PROTECTED] More majordomo info at

Re: Can a non-sg scsi write command be more than PAGE_SIZE length?

2005-04-19 Thread Christoph Hellwig
On Tue, Apr 19, 2005 at 11:24:31AM +0200, Olivier Galibert wrote: Yes, it's allowed. Thanks. Pages in that case are continuous then, right? Good question actually. I know XFS does passed vmalloc'ed memory down the block I/O path, but that's as a scatter/gather request. All non-s/g request

[PATCH] aic7xxx: remove inquiry sniffing leftovers

2005-04-19 Thread Christoph Hellwig
--- 1.66/drivers/scsi/aic7xxx/aic7xxx_osm.c 2005-04-17 19:03:05 +02:00 +++ edited/drivers/scsi/aic7xxx/aic7xxx_osm.c 2005-04-19 21:33:10 +02:00 @@ -2335,8 +2335,6 @@ AHC_TRANS_GOAL, /*paused*/FALSE); ahc_update_neg_request(ahc, devinfo, tstate, tinfo,

Re: PATCH [2/5] qla2xxx: add remote port codes...

2005-04-19 Thread Christoph Hellwig
On Tue, Apr 19, 2005 at 12:27:51AM -0700, Andrew Vasquez wrote: why do you still need the special case for delaying registration of the targets? Ok, this is actually a concern I have with the current fc_rport implementation (and yes, I realize I'm a day late) -- the auto-scan logic

Re: streamlining the sym2 io submission path

2005-04-19 Thread Christoph Hellwig
On Wed, Apr 20, 2005 at 12:43:23AM +0100, Matthew Wilcox wrote: We fail the first command to the device if the device is marked as NOSCAN or the lun is non-0 and the device isn't marked as SCAN LUNS. I think the first part should be moved to slave_alloc(); it's a little weird, but supportable.

Re: 5.x branch mainline kernel push in two weeks?

2005-04-20 Thread Christoph Hellwig
On Wed, Apr 20, 2005 at 01:29:11AM -0700, Mike Christie wrote: Are you going to try and push someone like qla4010 which has a similar interface to qla2xxx (it uses the msg box interface) to use the netlink interface? With a lot of the iscsi stuff masked away it seems a little difficult to

Re: 5.x branch mainline kernel push in two weeks?

2005-04-20 Thread Christoph Hellwig
On Wed, Apr 20, 2005 at 11:29:12AM -0700, Duane Grigsby wrote: No, that's not true; we are TOTALLY committed to getting all of our drivers in the upstream kernel. I have been working on the ISCSI driver cleanup to the level of our Fibre Channel driver as Andrew has done. I'm making it conform

Re: The future of host_scribble

2005-04-21 Thread Christoph Hellwig
On Thu, Apr 21, 2005 at 01:23:33AM +0100, Matthew Wilcox wrote: In scsi_cmnd there's an element called host_scribble. The name and the comment by it were sufficiently confusing that I didn't realise that this field is basically for the host's private data. Any objections to something like

[PATCH 1/9] qla1280: remove dead per-host flag variables

2005-07-04 Thread Christoph Hellwig
Signed-off-by: Christoph Hellwig [EMAIL PROTECTED] Signed-off-by: Thiemo Seufer [EMAIL PROTECTED] Index: linux-2.6/drivers/scsi/qla1280.c === --- linux-2.6.orig/drivers/scsi/qla1280.c 2005-06-19 20:47:01.0 +0200

[PATCH 4/9] qla1280: use SAM_ constants

2005-07-04 Thread Christoph Hellwig
Signed-off-by: Christoph Hellwig [EMAIL PROTECTED] Signed-off-by: Thiemo Seufer [EMAIL PROTECTED] Index: linux-2.6/drivers/scsi/qla1280.c === --- linux-2.6.orig/drivers/scsi/qla1280.c 2005-06-19 21:12:55.0 +0200

[PATCH 7/9] qla1280: don't use bitfields for hardware access in isp_config

2005-07-04 Thread Christoph Hellwig
Signed-off-by: Christoph Hellwig [EMAIL PROTECTED] Signed-off-by: Thiemo Seufer [EMAIL PROTECTED] Index: linux-2.6/drivers/scsi/qla1280.c === --- linux-2.6.orig/drivers/scsi/qla1280.c 2005-06-26 16:58:55.0 +0200

[PATCH 8/9] qla1280: qla1280: don't use bitfields for hardware access, parameters

2005-07-04 Thread Christoph Hellwig
Signed-off-by: Christoph Hellwig [EMAIL PROTECTED] Signed-off-by: Thiemo Seufer [EMAIL PROTECTED] Index: linux-2.6/drivers/scsi/qla1280.c === --- linux-2.6.orig/drivers/scsi/qla1280.c 2005-06-26 16:58:59.0 +0200

[PATCH 9/9] qla1280: endianess annotations

2005-07-04 Thread Christoph Hellwig
Signed-off-by: Christoph Hellwig [EMAIL PROTECTED] Index: linux-2.6/drivers/scsi/qla1280.c === --- linux-2.6.orig/drivers/scsi/qla1280.c 2005-06-26 16:59:06.0 +0200 +++ linux-2.6/drivers/scsi/qla1280.c2005-06-26 16

Re: is there going to be aic7xxx driver update

2005-07-07 Thread Christoph Hellwig
On Wed, Jul 06, 2005 at 03:29:49PM +0200, Bhanu, Yogesh wrote: Hi , It is continuation to my last post regarding aic7xxx driver flaking load. I really think this is a driver issue as I have switched several 39160 cards all showing same result . I have seen adaptec has released newer

Re: qla2300 read buffer problems

2005-07-12 Thread Christoph Hellwig
On Tue, Jul 12, 2005 at 04:42:11PM +0200, [EMAIL PROTECTED] wrote: Hi all, we are encountering SAN problems. Twice or threetimes a minute we can neither read nor write for up to five seconds from/to our LUs. After that short periode, it catches up and resumes normally. The diagnostics in

  1   2   3   4   5   6   7   8   9   10   >