Re: [PATCH 1/3] libsas: modify SATA error handler

2014-06-03 Thread Dan Williams
On Tue, Jun 3, 2014 at 12:13 AM, Xiangliang Yu yuxia...@marvell.com wrote: Hi, How about the patch? I'll take a look today. Sorry for the latency. -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord...@vger.kernel.org More majordomo info

Re: [PATCH 1/3] libsas: modify SATA error handler

2014-06-03 Thread Dan Williams
Hi, some notes below: On Thu, Apr 24, 2014 at 6:27 AM, Xiangliang Yu yxlr...@gmail.com wrote: Add support for SATA port softreset and port multiplier error handling. Some more detailed notes about the approach and any caveats would be appreciated. Signed-off-by: Xiangliang Yu

Re: [PATCH 1/3] libsas: modify SATA error handler

2014-08-06 Thread Dan Williams
On Wed, Aug 6, 2014 at 3:50 AM, Xiangliang Yu yuxia...@marvell.com wrote: Hi, Dan James How about the patches about support for PM? Two months had passed since I submitted the patches. Thanks! Did you address my review comments? -- To unsubscribe from this list: send the line unsubscribe

Re: [PATCH 1/3] libsas: modify SATA error handler

2014-08-07 Thread Dan Williams
[ adding yuxia...@marvell.com ] On Tue, Jun 3, 2014 at 6:41 PM, Dan Williams dan.j.willi...@intel.com wrote: Hi, some notes below: On Thu, Apr 24, 2014 at 6:27 AM, Xiangliang Yu yxlr...@gmail.com wrote: Add support for SATA port softreset and port multiplier error handling. Some more

Re: [PATCH 1/3] libsas: modify SATA error handler

2014-08-25 Thread Dan Williams
Some more comments below. [..] + + pmp = sata_srst_pmp(link); + + msecs = 0; + now = jiffies; + if (time_after(deadline, now)) + msecs = jiffies_to_msecs(deadline - now); + + memset(tf, 0, sizeof(struct ata_taskfile)); + tf.ctl =

Re: [RFC] drop libsas task collector mode?

2014-11-04 Thread Dan Williams
On Tue, Nov 4, 2014 at 10:58 AM, Christoph Hellwig h...@infradead.org wrote: The task collector mode in libsas implements internal queueing in libsas, which is somethign we usualy try to avoid, and doesn't seem to get much exposure as it's only supported as a non-default option in two drivers.

Re: [PATCH] libsas: remove task_collector mode

2014-11-24 Thread Dan Williams
. Signed-off-by: Christoph Hellwig h...@lst.de Acked-by: Dan Williams dan.j.willi...@intel.com -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [SCSI PATCH] sd: max-retries becomes configurable

2012-09-28 Thread Dan Williams
On Wed, Sep 26, 2012 at 7:20 PM, Martin K. Petersen martin.peter...@oracle.com wrote: James == James Bottomley james.bottom...@hansenpartnership.com writes: James On Mon, 2012-09-24 at 17:00 -0400, Jeff Garzik wrote: drivers/scsi/sd.c | 4 drivers/scsi/sd.h | 2 +- 2 files changed, 5

Re: [PATCH 3/3] Make blk_cleanup_queue() wait until request_fn finished

2012-10-01 Thread Dan Williams
On Thu, Sep 27, 2012 at 9:39 AM, Bart Van Assche bvanass...@acm.org wrote: Some request_fn implementations, e.g. scsi_request_fn(), unlock the queue lock. Make sure that blk_cleanup_queue() waits until all active request_fn invocations have finished. This fixes a potential use-after-free at

Re: [PATCH 0/3] Insert ATA transport objects in SCSI syfs topology.

2012-10-01 Thread Dan Williams
On Mon, Oct 1, 2012 at 11:22 AM, Gwendal Grignou gwen...@google.com wrote: This set of patches improve ATA transport classes integration with SCSI objects. Before [2.6.x] Ata and scsi transport class where separated: `--:09:00.0 | `--ata1 | | `--port_port | | `--link1 | | |

Re: [PATCH 0/3] Insert ATA transport objects in SCSI syfs topology.

2012-10-07 Thread Dan Williams
On Thu, Oct 4, 2012 at 9:56 AM, Gwendal Grignou gwen...@google.com wrote: What's the benefit of this? + To unify ata transport sysfs topology with other scsi transport. My concern is the thrash and breakage to switch the ordering around given the (minor) growing pains injecting an ata_port into

Re: eSATA Drive Detection issues on mvsas

2013-10-15 Thread Dan Williams
On Tue, Oct 15, 2013 at 5:15 PM, Praveen Murali pmur...@logicube.com wrote: Dan/James, Can you please take a look at this and let me know if I am at the right place? Or point me in the right direction? As I understand, this deost not look like an mvsas driver issue. Looks like a latent bug

Re: [PATCH 3/3] Fix device detection issues with mvsas driver

2013-10-15 Thread Dan Williams
On Thu, Jun 21, 2012 at 10:05 AM, Praveen Murali pmur...@logicube.com wrote: here is the updated patch. On Thu, 2012-06-21 at 09:48 -0700, Dan Williams wrote: On Thu, Jun 21, 2012 at 9:41 AM, Praveen Murali pmur...@logicube.com wrote: Ok, do you want me to regenerate the patch? Yes, James

Re: eSATA Drive Detection issues on mvsas

2013-10-17 Thread Dan Williams
On Wed, Oct 16, 2013 at 10:28 AM, Praveen Murali pmur...@logicube.com wrote: diff --git a/drivers/scsi/libsas/sas_ata.c b/drivers/scsi/libsas/sas_ata.c index 161c98efade9..d0fb99d5da95 100644 --- a/drivers/scsi/libsas/sas_ata.c +++ b/drivers/scsi/libsas/sas_ata.c @@ -211,7 +211,7 @@ static

[PATCH] libsas: fix usage of ata_tf_to_fis

2013-10-22 Thread Dan Williams
...@marvell.com Cc: sta...@vger.kernel.org Reported-by: Praveen Murali pmur...@logicube.com Tested-by: Praveen Murali pmur...@logicube.com Signed-off-by: Dan Williams dan.j.willi...@intel.com --- drivers/scsi/libsas/sas_ata.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers

Re: Backporting 'libsas: fix timeout vs completion race' and related patches to 3.2.51 recommended?

2013-10-28 Thread Dan Williams
On Fri, Oct 25, 2013 at 5:47 PM, Amit Uttamchandani auttamchand...@logicube.com wrote: Hello, Tested kernel 3.4.62, which introduces: libsas error handling + discovery patch set http://lwn.net/Articles/476986/ Is it advisable for me to backport this to v3.2.51? If you need reliable

[PATCH] isci: fix reset timeout handling

2013-12-09 Thread Dan Williams
...@intel.com Tested-by: Xun Ni xun...@intel.com Signed-off-by: Dan Williams dan.j.willi...@intel.com --- drivers/scsi/isci/port_config.c |5 - drivers/scsi/isci/task.c|2 +- 2 files changed, 1 insertions(+), 6 deletions(-) diff --git a/drivers/scsi/isci/port_config.c b/drivers/scsi

Re: spinlock_irqsave() flags (Was: pm80xx: Spinlock fix)

2014-01-03 Thread Dan Williams
On Thu, Jan 2, 2014 at 2:31 AM, Suresh Thiagarajan suresh.thiagara...@pmcs.com wrote: On Fri, Dec 27, 2013 at 9:48 PM, Oleg Nesterov o...@redhat.com wrote: On 12/24, Suresh Thiagarajan wrote: Below is a small pseudo code on protecting/serializing the flag for global access. struct temp {

[PATCH v2] isci: fix reset timeout handling

2014-01-03 Thread Dan Williams
xun...@intel.com Tested-by: Xun Ni xun...@intel.com Signed-off-by: Dan Williams dan.j.willi...@intel.com --- v2: Dave reported the build warning regression the last patch caused, and I clarified the changelog a bit. drivers/scsi/isci/port_config.c |7 --- drivers/scsi/isci/task.c

Re: [PATCH 3/6] libata: resume in the background

2014-01-10 Thread Dan Williams
On Mon, Dec 16, 2013 at 3:30 PM, Phillip Susi ps...@ubuntu.com wrote: Don't block the resume path waiting for the disk to spin up. --- drivers/ata/libata-core.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/drivers/ata/libata-core.c

Re: [PATCH/RESEND v2 1/2] Hard disk S3 resume time optimization

2014-01-13 Thread Dan Williams
On Mon, Jan 13, 2014 at 12:06 PM, Todd E Brandt todd.e.bra...@linux.intel.com wrote: On Fri, Jan 10, 2014 at 07:13:11PM -0800, Dan Williams wrote: On Fri, Jan 10, 2014 at 6:13 PM, Phillip Susi ps...@ubuntu.com wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA512 On 01/10/2014 06:11 PM

Re: [PATCH/RESEND v2 1/2] Hard disk S3 resume time optimization

2014-01-13 Thread Dan Williams
On Mon, Jan 13, 2014 at 3:51 PM, Todd E Brandt todd.e.bra...@linux.intel.com wrote: On Mon, Jan 13, 2014 at 12:37:01PM -0800, Dan Williams wrote: On Mon, Jan 13, 2014 at 12:06 PM, Todd E Brandt Actually there's one other reason. In the ata_port_request_pm function it checks to see if there's

Re: Disk spin-up optimization during system resume

2014-01-17 Thread Dan Williams
On Fri, Jan 17, 2014 at 6:57 AM, Alan Stern st...@rowland.harvard.edu wrote: On Thu, 16 Jan 2014, Todd E Brandt wrote: My patch makes ata port and scsi disk resume 'non-blocking' (asynchronous with respect to system resume). Which means once they're called the power manager pays no more

Re: Disk spin-up optimization during system resume

2014-01-17 Thread Dan Williams
On Fri, Jan 17, 2014 at 12:49 PM, Phillip Susi ps...@ubuntu.com wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 1/17/2014 2:31 PM, Dan Williams wrote: Once dpm_resume of the disk is asynchronous, is there much incremental gain by further deferring spin up? The drawback of doing

Re: [PATCH v4 1/2] asynchronous ata port resume

2014-01-17 Thread Dan Williams
On Wed, Jan 15, 2014 at 8:38 PM, Todd E Brandt todd.e.bra...@linux.intel.com wrote: On resume, the ATA port driver currently waits until the AHCI controller finishes executing the port wakeup command. This patch changes the ata_port_resume callback to issue the wakeup and then return

Re: Disk spin-up optimization during system resume

2014-01-17 Thread Dan Williams
On Fri, Jan 17, 2014 at 5:41 PM, Alan Stern st...@rowland.harvard.edu wrote: On Fri, 17 Jan 2014, Tejun Heo wrote: On Fri, Jan 17, 2014 at 03:15:54PM -0500, Alan Stern wrote: You will have to argue this point with Phillip. If necessary, we could add a sysfs attribute to force a spin-up

Re: Disk spin-up optimization during system resume

2014-01-17 Thread Dan Williams
On Fri, Jan 17, 2014 at 7:18 PM, Phillip Susi ps...@ubuntu.com wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA512 On 01/17/2014 05:17 PM, Dan Williams wrote: Well, at all is overstating it. The system was idle and now it's being woken up to do some work. Inactivity timers

Re: [PATCH] isci: correct erroneous for_each_isci_host macro

2014-01-20 Thread Dan Williams
Tested-by: Lukasz Dorau lukasz.do...@intel.com Cc: Dan Williams dan.j.willi...@intel.com Cc: Dave Jiang dave.ji...@intel.com Cc: sta...@vger.kernel.org --- drivers/scsi/isci/host.h |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/scsi/isci/host.h b/drivers

Re: Disk spin-up optimization during system resume

2014-01-21 Thread Dan Williams
On Sat, Jan 18, 2014 at 6:08 AM, Alan Stern st...@rowland.harvard.edu wrote: On Fri, 17 Jan 2014, Dan Williams wrote: I think it's a bit of an interface surprise to have pm_runtime disable have side effects only for scsi_disk devices. I think lazy_resume needs to be an explicit attribute

Re: Disk spin-up optimization during system resume

2014-01-21 Thread Dan Williams
On Tue, Jan 21, 2014 at 7:44 AM, Alan Stern st...@rowland.harvard.edu wrote: On Tue, 21 Jan 2014, Dan Williams wrote: On Sat, Jan 18, 2014 at 6:08 AM, Alan Stern st...@rowland.harvard.edu wrote: On Fri, 17 Jan 2014, Dan Williams wrote: I think it's a bit of an interface surprise to have

Re: Disk spin-up optimization during system resume

2014-01-21 Thread Dan Williams
On Tue, Jan 21, 2014 at 8:18 AM, Dan Williams dan.j.willi...@intel.com wrote: On Tue, Jan 21, 2014 at 7:44 AM, Alan Stern st...@rowland.harvard.edu wrote: On Tue, 21 Jan 2014, Dan Williams wrote: On Sat, Jan 18, 2014 at 6:08 AM, Alan Stern st...@rowland.harvard.edu wrote: On Fri, 17 Jan

Re: [LSF/MM TOPIC][ATTEND] Plumbing I/O Cache / Tiered Storage Hints

2014-01-31 Thread Dan Williams
On Tue, Jan 28, 2014 at 2:57 PM, Dan Williams dan.j.willi...@intel.com wrote: In addition to disk drives with internally tiered-storage (solid-state + magnetic media) the kernel has also grown native I/O-caching / tiered-storage implementations in bcache and dm-cache. Currently, all

Re: [PATCH] scsi/isci/port_config: Fix a infinite loop.

2014-02-06 Thread Dan Williams
On Tue, Jul 16, 2013 at 7:54 PM, Xinghai Yu yuxing...@cn.fujitsu.com wrote: It seems the phy_index++; have been placed in wrong place, without it the while circle up will do a infinite loop. Signed-off-by: Xinghai Yu yuxing...@cn.fujitsu.com --- drivers/scsi/isci/port_config.c |2 +- 1

[PATCH 3/4] isci: fix needless ata reset escalations

2014-02-06 Thread Dan Williams
-sata_dev.fis[2] = ATA_ERR; The end effect is that isci is needlessly triggering hard resets when they are not necessary. Cc: sta...@vger.kernel.org Reported-by: Xun Ni xun...@intel.com Tested-by: Nelson Cheng nelson.ch...@intel.com Acked-by: Lukasz Dorau lukasz.do...@intel.com Signed-off-by: Dan

[PATCH 0/4] isci, libsas fixes for 3.4-rc2

2014-02-06 Thread Dan Williams
Hi James, Here are some collected fixes. All but patch 2 are tagged for -stable. Patch 1 and 4 have been on the list since before the 3.14 merge window, patch 2 and 3 are new. Please apply, thank you. [PATCH 1/4] isci: fix reset timeout handling [PATCH 2/4] scsi, libsas: introduce scmd_dbg()

[PATCH 2/4] scsi, libsas: introduce scmd_dbg() to quiet false positive timeout messages

2014-02-06 Thread Dan Williams
-by: Dan Williams dan.j.willi...@intel.com --- drivers/scsi/libsas/sas_scsi_host.c |2 +- include/scsi/scsi_device.h | 12 2 files changed, 13 insertions(+), 1 deletions(-) diff --git a/drivers/scsi/libsas/sas_scsi_host.c b/drivers/scsi/libsas/sas_scsi_host.c index

[PATCH 4/4] isci: correct erroneous for_each_isci_host macro

2014-02-06 Thread Dan Williams
Signed-off-by: Dan Williams dan.j.willi...@intel.com --- drivers/scsi/isci/host.h |5 ++--- 1 files changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/scsi/isci/host.h b/drivers/scsi/isci/host.h index 4911310a38f5..22a9bb1abae1 100644 --- a/drivers/scsi/isci/host.h +++ b/drivers/scsi

[PATCH 1/4] isci: fix reset timeout handling

2014-02-06 Thread Dan Williams
xun...@intel.com Tested-by: Xun Ni xun...@intel.com Signed-off-by: Dan Williams dan.j.willi...@intel.com --- drivers/scsi/isci/port_config.c |7 --- drivers/scsi/isci/task.c|2 +- 2 files changed, 1 insertions(+), 8 deletions(-) diff --git a/drivers/scsi/isci/port_config.c b

Re: [PATCH] scsi_transport_sas: move bsg destructor into sas_rphy_remove

2014-02-12 Thread Dan Williams
); + sas_bsg_remove(NULL, rphy); transport_remove_device(dev); device_del(dev); } Acked-by: Dan Williams dan.j.willi...@intel.com I think this is the right move, and some follow-up cleanups / fixes come to mind: 1/ Why is sas_bsg_remove() multiplexing 2 use cases? Let's just have

Re: mpt2sas driver barfs when force removing a drive on 3.13.1

2014-02-12 Thread Dan Williams
On Wed, Feb 12, 2014 at 9:41 AM, Richard Yao r...@gentoo.org wrote: You should use `git send-email` to send the patch to all of the people listed by get_maintainer.pl: I see nothing wrong with the patch Joe originally submitted: http://marc.info/?l=linux-scsim=138609455422179w=2

Re: [PATCH 0/4] isci, libsas fixes for 3.4-rc2

2014-02-24 Thread Dan Williams
On Sun, Feb 23, 2014 at 12:12 PM, James Bottomley james.bottom...@hansenpartnership.com wrote: On Thu, 2014-02-06 at 12:22 -0800, Dan Williams wrote: Hi James, Here are some collected fixes. All but patch 2 are tagged for -stable. Patch 1 and 4 have been on the list since before the 3.14

[PATCH v5 1/3] libata, libsas: kill pm_result and related cleanup

2014-03-05 Thread Dan Williams
...@ubuntu.com Cc: Alan Stern st...@rowland.harvard.edu Suggested-by: Tejun Heo t...@kernel.org Signed-off-by: Todd Brandt todd.e.bra...@intel.com Signed-off-by: Dan Williams dan.j.willi...@intel.com --- drivers/ata/libata-core.c | 75 +++-- drivers/ata/libata

[PATCH v5 3/3] scsi: async sd resume

2014-03-05 Thread Dan Williams
-by: Todd Brandt todd.e.bra...@linux.intel.com [djbw: kick all resume work to the async queue] Signed-off-by: Dan Williams dan.j.willi...@intel.com --- drivers/scsi/scsi.c |3 + drivers/scsi/scsi_pm.c | 115 -- drivers/scsi/scsi_priv.h |1

[PATCH v5 0/3] Accelerate Storage Resume (2x or more)

2014-03-05 Thread Dan Williams
v4 1/2] http://marc.info/?l=linux-idem=138984713203515w=2 [PATCH v4 2/2] http://marc.info/?l=linux-idem=138984722003539w=2 --- Dan Williams (2): libata, libsas: kill pm_result and related cleanup scsi: async sd resume Todd Brandt (1): libata: async resume drivers/ata/libata

[PATCH v5 2/3] libata: async resume

2014-03-05 Thread Dan Williams
Brandt todd.e.bra...@linux.intel.com [djbw: rebase on cleanup patch, changelog wordsmithing] Signed-off-by: Dan Williams dan.j.willi...@intel.com --- drivers/ata/libata-core.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata

Re: [PATCH RESEND] SCSI: sd: don't fail if the device doesn't recognize SYNCHRONIZE CACHE

2014-03-05 Thread Dan Williams
to suspend :) Could anyone from the SCSI people have a quick look maybe? Acked-by: Dan Williams dan.j.willi...@intel.com But I agree with Tejun [1], that this likely does not go far enough. We should also be looking to fail future writes to the device or disabling the cache. Tejun's comment: Ooh

Re: [PATCH v5 3/3] scsi: async sd resume

2014-03-07 Thread Dan Williams
On Fri, Mar 7, 2014 at 7:42 AM, Alan Stern st...@rowland.harvard.edu wrote: On Wed, 5 Mar 2014, Dan Williams wrote: async_schedule() sd resume work to allow disks and other devices to resume in parallel. This moves the entirety of scsi_device resume to an async context to ensure

Re: [PATCH v5 3/3] scsi: async sd resume

2014-03-07 Thread Dan Williams
of the async function inline. 8 Subject: scsi: async sd resume From: Dan Williams dan.j.willi...@intel.com async_schedule() sd resume work to allow disks and other devices to resume in parallel. This moves the entirety of scsi_device resume to an async context to ensure

Re: [PATCH v5 3/3] scsi: async sd resume

2014-03-10 Thread Dan Williams
On Mon, Mar 10, 2014 at 1:43 PM, Tejun Heo t...@kernel.org wrote: On Fri, Mar 07, 2014 at 06:52:06PM -0800, Dan Williams wrote: From: Dan Williams dan.j.willi...@intel.com async_schedule() sd resume work to allow disks and other devices to resume in parallel. This moves the entirety

Re: [PATCH v5 3/3] scsi: async sd resume

2014-03-10 Thread Dan Williams
On Mon, Mar 10, 2014 at 1:59 PM, Alan Stern st...@rowland.harvard.edu wrote: On Mon, 10 Mar 2014, Dan Williams wrote: The only thing which is a bit concerning is that this doesn't have any throttling mechanism for simultaneous wakeups. Would this be able to blow up the PSU if used

Re: [PATCH v5 3/3] scsi: async sd resume

2014-03-10 Thread Dan Williams
On Mon, Mar 10, 2014 at 9:19 PM, James Bottomley james.bottom...@hansenpartnership.com wrote: On Mon, 2014-03-10 at 16:59 -0400, Alan Stern wrote: On Mon, 10 Mar 2014, Dan Williams wrote: The only thing which is a bit concerning is that this doesn't have any throttling mechanism

Re: [PATCH v5 3/3] scsi: async sd resume

2014-03-10 Thread Dan Williams
On Mon, Mar 10, 2014 at 10:16 PM, James Bottomley james.bottom...@hansenpartnership.com wrote: On Mon, 2014-03-10 at 21:47 -0700, Dan Williams wrote: On Mon, Mar 10, 2014 at 9:19 PM, James Bottomley james.bottom...@hansenpartnership.com wrote: On Mon, 2014-03-10 at 16:59 -0400, Alan Stern

Re: [PATCH v5 3/3] scsi: async sd resume

2014-03-14 Thread Dan Williams
On Mon, Mar 10, 2014 at 11:29 PM, James Bottomley james.bottom...@hansenpartnership.com wrote: In the long game, though this whole debate is moot: setups with hard wired start times adhere to them regardless of what the system does, so they ignore start unit commands. Systems without hard

[PATCH v6 0/3] Accelerate Storage Resume (2x or more)

2014-03-14 Thread Dan Williams
-optimization-simpler-approach [2]: Todd's v4 patchset: [PATCH v4 0/2] http://marc.info/?l=linux-idem=138984698103487w=2 [PATCH v4 1/2] http://marc.info/?l=linux-idem=138984713203515w=2 [PATCH v4 2/2] http://marc.info/?l=linux-idem=138984722003539w=2 --- Dan Williams (2): libata, libsas: kill

[PATCH v6 2/3] libata: async resume

2014-03-14 Thread Dan Williams
Brandt todd.e.bra...@linux.intel.com [djbw: rebase on cleanup patch, changelog wordsmithing] Signed-off-by: Dan Williams dan.j.willi...@intel.com --- drivers/ata/libata-core.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata

[PATCH v6 3/3] scsi: async sd resume

2014-03-14 Thread Dan Williams
Susi ps...@ubuntu.com [alan: bug fix and clean up suggestion] Acked-by: Alan Stern st...@rowland.harvard.edu Suggested-by: Todd Brandt todd.e.bra...@linux.intel.com [djbw: kick all resume work to the async queue] Signed-off-by: Dan Williams dan.j.willi...@intel.com --- drivers/scsi/Kconfig |3

[PATCH v6 1/3] libata, libsas: kill pm_result and related cleanup

2014-03-14 Thread Dan Williams
Stern st...@rowland.harvard.edu Suggested-by: Tejun Heo t...@kernel.org Signed-off-by: Todd Brandt todd.e.bra...@intel.com Signed-off-by: Dan Williams dan.j.willi...@intel.com --- drivers/ata/libata-core.c | 135 ++--- drivers/ata/libata-eh.c | 13

Re: [PATCH v5 3/3] scsi: async sd resume

2014-03-17 Thread Dan Williams
On Sun, 2014-03-16 at 11:21 -0700, James Bottomley wrote: On Sat, 2014-03-15 at 16:35 -0700, Dan Williams wrote: On Sat, Mar 15, 2014 at 2:47 PM, James Bottomley james.bottom...@hansenpartnership.com wrote: On Fri, 2014-03-14 at 13:11 -0700, Dan Williams wrote: On Mon, Mar 10, 2014

Re: [PATCH v6 1/3] libata, libsas: kill pm_result and related cleanup

2014-03-18 Thread Dan Williams
On Tue, Mar 18, 2014 at 9:03 AM, Tejun Heo t...@kernel.org wrote: On Fri, Mar 14, 2014 at 01:52:48PM -0700, Dan Williams wrote: Tejun says: At least for libata, worrying about suspend/resume failures don't make whole lot of sense. If suspend failed, just proceed with suspend

Re: [PATCH -next] libata.h: add stub for ata_sas_port_resume

2014-03-19 Thread Dan Williams
: libata: remove unused ata_sas_port_async_resume() stub From: Dan Williams dan.j.willi...@intel.com Commit bc6e7c4b0d1a libata, libsas: kill pm_result and related cleanup renamed ata_sas_port_async_resume() to ata_sas_port_resume(), but missed a CONFIG_PM=n stub conversion. Randy fixed that up

Re: Deadlock in usb-storage error handling

2014-03-19 Thread Dan Williams
On Wed, Mar 19, 2014 at 1:31 PM, Alan Stern st...@rowland.harvard.edu wrote: On Wed, 19 Mar 2014, Andreas Reis wrote: I've uploaded a dmesg with the new debugging patch to bugzilla: https://bugzilla.kernel.org/attachment.cgi?id=130041 Thanks. I have now managed to reproduce many of the

Re: [PATCH v5 3/3] scsi: async sd resume

2014-03-20 Thread Dan Williams
On Mon, 2014-03-17 at 11:20 -0700, Dan Williams wrote: On Sun, 2014-03-16 at 11:21 -0700, James Bottomley wrote: On Sat, 2014-03-15 at 16:35 -0700, Dan Williams wrote: On Sat, Mar 15, 2014 at 2:47 PM, James Bottomley Hm, OK, if this is tied at the hip to async scanning, why do you need

[GIT PULL] async scsi resume for 3.15

2014-04-10 Thread Dan Williams
to 3c31b52f96f7b559d950b16113c0f68c72a1985e: scsi: async sd resume (2014-04-10 15:30:35 -0700) Dan Williams (1): scsi: async sd resume drivers/scsi/Kconfig | 3 ++ drivers/scsi/scsi.c | 9 drivers/scsi

Re: [GIT PULL] async scsi resume for 3.15

2014-04-11 Thread Dan Williams
On Fri, Apr 11, 2014 at 11:20 AM, James Bottomley james.bottom...@hansenpartnership.com wrote: On Thu, 2014-04-10 at 18:24 -0700, Dan Williams wrote: Hi Linus, James might still be in the process of sending this your way. However, given the proximity to -rc1, my reasoning for sending

Re: Please help me to review the patch about supporting SATA PM in LIBSAS

2014-04-17 Thread Dan Williams
On Wed, Apr 16, 2014 at 8:07 PM, xiangliang yu yxlr...@gmail.com wrote: hi, The patch is support SATA PM device and can find all devices that is attached to PM. Until now, i have tested the identified, hot-plug and IO function and result is ok except one mvsas timeout issue. i'll continue

Re: Please help me to review the patch about supporting SATA PM in LIBSAS

2014-04-18 Thread Dan Williams
On Thu, Apr 17, 2014 at 9:03 AM, Dan Williams dan.j.willi...@intel.com wrote: On Wed, Apr 16, 2014 at 8:07 PM, xiangliang yu yxlr...@gmail.com wrote: hi, The patch is support SATA PM device and can find all devices that is attached to PM. Until now, i have tested the identified, hot-plug

Re: 3.2.57 regression: isci driver broken: Unable to reset I T nexus?

2014-04-28 Thread Dan Williams
[ adding Ben ] On Mon, Apr 28, 2014 at 10:22 AM, Ondrej Zary li...@rainbow-software.org wrote: On Monday 28 April 2014 18:51:44 Jiang, Dave wrote: On Mon, 2014-04-28 at 16:28 +, Ondrej Zary wrote: On Monday 28 April 2014 17:50:29 Jiang, Dave wrote: On Mon, 2014-04-28 at 13:03 +0200,

Re: [PATCH 0/3] libsas: add support for port multiplier

2014-05-02 Thread Dan Williams
On Fri, May 2, 2014 at 8:36 AM, Tejun Heo t...@kernel.org wrote: On Thu, Apr 24, 2014 at 09:27:03PM +0800, Xiangliang Yu wrote: This patch set will support SATA port multiplier(PM) in LIBSAS. LIBSAS is need to implement several key handling to support SATA PM: First,low level driver notify

Re: [PATCH RESEND] scsi_transport_sas: move bsg destructor into sas_rphy_remove

2014-05-02 Thread Dan Williams
://marc.info/?t=13849746004 (patch + ACK + comments) http://marc.info/?t=13860945551 (gentoo, LSI repro) mpt2sas driver barfs when force removing a drive on 3.13.1 http://marc.info/?t=13912235131 Dan Williams had a few other suggestions for cleanup in this area, but those

[PATCH RFC 1/2] iop13xx: add base support for the imu

2007-01-24 Thread Dan Williams
From: Greg Tucker [EMAIL PROTECTED] The interprocessor messaging unit supports mailbox style communication between the two Xscale cores on iop342. Signed-off-by: Greg Tucker [EMAIL PROTECTED] Signed-off-by: Dan Williams [EMAIL PROTECTED] --- arch/arm/mach-iop13xx/Kconfig

[PATCH RFC 2/2] iop13xx: imu scsi driver

2007-01-24 Thread Dan Williams
From: Greg Tucker [EMAIL PROTECTED] Enable Linux to access the other core as if it were a scsi target. Signed-off-by: Greg Tucker [EMAIL PROTECTED] Signed-off-by: Dan Williams [EMAIL PROTECTED] --- arch/arm/mach-iop13xx/imu/Kconfig |7 drivers/scsi/Makefile |1 drivers

[PATCH 2.6.20 1/2] iop13xx: add base support for the imu

2007-02-13 Thread Dan Williams
From: Greg Tucker [EMAIL PROTECTED] The interprocessor messaging unit supports mailbox style communication between the two Xscale cores on iop342. Changelog: * cleaned up static functions and exports Signed-off-by: Greg Tucker [EMAIL PROTECTED] Signed-off-by: Dan Williams [EMAIL PROTECTED

[PATCH 2.6.20 2/2] iop13xx: imu scsi driver

2007-02-13 Thread Dan Williams
] Signed-off-by: Dan Williams [EMAIL PROTECTED] --- arch/arm/mach-iop13xx/imu/Kconfig |7 drivers/scsi/Makefile |1 drivers/scsi/iop13xx-imu-scsi.c | 607 + 3 files changed, 615 insertions(+), 0 deletions(-) diff --git a/arch/arm/mach

[set4 resend PATCH 0/5] libsas, libata: suspend / resume and reset once

2012-07-09 Thread Dan Williams
for known well-behaved devices. These have been in -next for the past couple kernel cycles. --- Artur Wojcik (1): isci: implement suspend/resume support Dan Williams (4): libata: reset once libata: export ata_port suspend/resume infrastructure for sas libsas: suspend / resume

[set4 resend PATCH 1/5] async: introduce 'async_domain' type

2012-07-09 Thread Dan Williams
Acked-by: Mark Brown broo...@opensource.wolfsonmicro.com Tested-by: Eldad Zack el...@fogrefinery.com Signed-off-by: Dan Williams dan.j.willi...@intel.com --- drivers/regulator/core.c |2 +- drivers/scsi/libsas/sas_ata.c |2 +- drivers/scsi/scsi.c |3 ++- drivers/scsi

[set4 resend PATCH 2/5] async: make async_synchronize_full() flush all work regardless of domain

2012-07-09 Thread Dan Williams
-by: Eldad Zack el...@fogrefinery.com Signed-off-by: Dan Williams dan.j.willi...@intel.com --- drivers/scsi/scsi.c |1 + include/linux/async.h |1 + kernel/async.c| 43 +-- 3 files changed, 43 insertions(+), 2 deletions(-) diff --git

[set4 resend PATCH 3/5] scsi: queue async scan work to an async_schedule domain

2012-07-09 Thread Dan Williams
Cc: James Bottomley jbottom...@parallels.com Tested-by: Eldad Zack el...@fogrefinery.com Signed-off-by: Dan Williams dan.j.willi...@intel.com --- drivers/scsi/scsi_scan.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/scsi/scsi_scan.c b/drivers/scsi

[set4 resend PATCH 4/5] scsi: cleanup usages of scsi_complete_async_scans

2012-07-09 Thread Dan Williams
...@parallels.com Tested-by: Eldad Zack el...@fogrefinery.com Signed-off-by: Dan Williams dan.j.willi...@intel.com --- drivers/scsi/scsi_scan.c | 12 include/scsi/scsi_scan.h | 11 --- kernel/power/hibernate.c |8 kernel/power/user.c |2 -- 4 files changed, 33

[set4 resend PATCH 5/5] Revert [SCSI] fix async probe regression

2012-07-09 Thread Dan Williams
...@linux.ee Tested-by: Eldad Zack el...@fogrefinery.com Signed-off-by: Dan Williams dan.j.willi...@intel.com --- drivers/scsi/scsi_scan.c |7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/scsi/scsi_scan.c b/drivers/scsi/scsi_scan.c index a0bc663..56a9379 100644

Re: [set4 resend PATCH 0/5] libsas, libata: suspend / resume and reset once

2012-07-09 Thread Dan Williams
schedules, which isn't true. ...and this set aims to make that assumption true, but also with the ability to opt-out for private async work. --- Dan Williams (5): async: introduce 'async_domain' type async: make async_synchronize_full() flush all work regardless of domain scsi

[resend PATCH 0/5] libsas, libata: suspend / resume and reset once

2012-07-09 Thread Dan Williams
for known well-behaved devices. These have been in -next for the past couple kernel cycles. --- Artur Wojcik (1): isci: implement suspend/resume support Dan Williams (4): libata: reset once libata: export ata_port suspend/resume infrastructure for sas libsas: suspend / resume

[resend PATCH 4/5] isci: implement suspend/resume support

2012-07-09 Thread Dan Williams
that all links should be back up. libsas is in charge of handling links that did not resume, or resumed out of order. Signed-off-by: Artur Wojcik artur.woj...@intel.com Signed-off-by: Jacek Danecki jacek.dane...@intel.com Signed-off-by: Dan Williams dan.j.willi...@intel.com --- drivers/scsi/isci

[resend PATCH 3/5] libsas: suspend / resume support

2012-07-09 Thread Dan Williams
...@rowland.harvard.edu Reviewed-by: Jacek Danecki jacek.dane...@intel.com Tested-by: Maciej Patelczyk maciej.patelc...@intel.com Signed-off-by: Dan Williams dan.j.willi...@intel.com --- drivers/scsi/libsas/sas_ata.c | 86 ++ drivers/scsi/libsas/sas_discover.c | 69

[resend PATCH 5/5] libsas, ipr: cleanup ata_host flags initialization via ata_host_init

2012-07-09 Thread Dan Williams
-by: Dan Williams dan.j.willi...@intel.com --- drivers/ata/libata-core.c | 10 ++ drivers/scsi/ipr.c|3 +-- drivers/scsi/libsas/sas_ata.c |5 + include/linux/libata.h|3 +-- 4 files changed, 5 insertions(+), 16 deletions(-) diff --git a/drivers/ata/libata

[resend PATCH 1/5] libata: reset once

2012-07-09 Thread Dan Williams
Hotplug testing with libsas currently encounters a 55 second wait for link recovery to give up. In the case where the user trusts the response time of their devices permit the recovery attempts to be limited to one. Signed-off-by: Dan Williams dan.j.willi...@intel.com --- Documentation/kernel

[GIT PATCH 0/4] isci update for 3.6

2012-07-11 Thread Dan Williams
from Dan Carpenter Dan Carpenter (2): isci: make function declaration match implementation isci: add a couple __iomem annotations Dan Williams (1): isci: fix isci_pci_probe() generates warning on efi failure path

[PATCH 1/4] isci: fix isci_pci_probe() generates warning on efi failure path

2012-07-11 Thread Dan Williams
is unlikely and we keep the memory around in the success case just defer all de-allocation to devm. Cc: sta...@vger.kernel.org Reported-by: Don Morris don.mor...@hp.com Signed-off-by: Dan Williams dan.j.willi...@intel.com --- drivers/scsi/isci/init.c |1 - drivers/scsi/isci/probe_roms.c

[PATCH 2/4] isci: fix COMSAS negation timout workaround for WD SAS drives

2012-07-11 Thread Dan Williams
...@intel.com Reported-by: Dan Thompson daniel.j.thomp...@intel.com Signed-off-by: Dave Maurer david.c.mau...@intel.com Signed-off-by: Dan Williams dan.j.willi...@intel.com --- drivers/scsi/isci/phy.c |2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/scsi/isci/phy.c b/drivers/scsi/isci

[PATCH 4/4] isci: add a couple __iomem annotations

2012-07-11 Thread Dan Williams
From: Dan Carpenter dan.carpen...@oracle.com These are __iomem. Sparse complains if we don't have that. drivers/scsi/isci/phy.c +149 70: warning: incorrect type in initializer (different address spaces) Signed-off-by: Dan Carpenter dan.carpen...@oracle.com Signed-off-by: Dan Williams

[PATCH 3/4] isci: make function declaration match implementation

2012-07-11 Thread Dan Williams
...@oracle.com Signed-off-by: Dan Williams dan.j.willi...@intel.com --- drivers/scsi/isci/remote_node_context.h |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/isci/remote_node_context.h b/drivers/scsi/isci/remote_node_context.h index a703b9c..c7ee81d 100644

Re: [Bug 44771] [REGRESSION] a7a20d103994fd760766e6c9d494daa569cbfe06 makes kernel 3.5 unbootable on an Intel chipset based motherboard

2012-07-18 Thread Dan Williams
On Wed, Jul 18, 2012 at 1:25 PM, Alan Stern st...@rowland.harvard.edu wrote: On Tue, 17 Jul 2012, James Bottomley wrote: On Tue, 2012-07-17 at 12:51 -0700, Linus Torvalds wrote: Wrong people cc'd, it looks like. Guys, commit a7a20d103994 (sd: limit the scope of the async probe domain)

[PATCH] MAINTAINERS: update address for Dan Williams

2012-08-15 Thread Dan Williams
Moved to d...@fb.com Cc: Dave Jiang dave.ji...@intel.com Cc: Vinod Koul vinod.k...@linux.intel.com Signed-off-by: Dan Williams d...@fb.com --- MAINTAINERS | 25 - 1 file changed, 12 insertions(+), 13 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 94b823f

Re: Possible mptsas regression post 3.5.0

2012-08-27 Thread Dan Williams
] [8141782a] scsi_remove_target+0xda/0x1f0 I wonder if we are preventing scsi_device_dev_release_usercontext() from making forward progress? ...the attached patch should confirm this or give more info otherwise. -- Dan scsi_remove_target: debug softlockup From: Dan Williams d...@fb.com

Re: Possible mptsas regression post 3.5.0

2012-08-28 Thread Dan Williams
: 1 dev_del: 1 Thanks! Does the attached patch fix the issue for you? -- Dan scsi_remove_target: fix softlockup condition From: Dan Williams d...@fb.com Don't restart lookup of stargets in the multi-target case, just arrange to traverse the list once, on the assumption that new targets

[PATCH] scsi_remove_target: fix softlockup regression on hot remove

2012-08-28 Thread Dan Williams
-by: Dan Williams d...@fb.com --- drivers/scsi/scsi_sysfs.c | 30 ++ 1 file changed, 14 insertions(+), 16 deletions(-) diff --git a/drivers/scsi/scsi_sysfs.c b/drivers/scsi/scsi_sysfs.c index 093d4f6..ce5224c 100644 --- a/drivers/scsi/scsi_sysfs.c +++ b/drivers/scsi

[resend PATCH] scsi_remove_target: fix softlockup regression on hot remove

2012-08-28 Thread Dan Williams
...@gmail.com Tested-by: John Drescher dresche...@gmail.com Signed-off-by: Dan Williams d...@fb.com --- Jack, thanks for the reminder to cc stable! drivers/scsi/scsi_sysfs.c | 30 ++ 1 file changed, 14 insertions(+), 16 deletions(-) diff --git a/drivers/scsi/scsi_sysfs.c b

Re: [resend PATCH] scsi_remove_target: fix softlockup regression on hot remove

2012-08-29 Thread Dan Williams
On Wed, 2012-08-29 at 06:50 +, Bart Van Assche wrote: On 08/29/12 05:12, Dan Williams wrote: John reports: BUG: soft lockup - CPU#2 stuck for 23s! [kworker/u:8:2202] [..] Call Trace: [8141782a] scsi_remove_target+0xda/0x1f0 [81421de5] sas_rphy_remove+0x55

Re: [resend PATCH] scsi_remove_target: fix softlockup regression on hot remove

2012-09-04 Thread Dan Williams
On Tue, Sep 4, 2012 at 7:02 AM, John Drescher dresche...@gmail.com wrote: On Wed, Aug 29, 2012 at 10:59 AM, Dan Williams d...@fb.com wrote: On Wed, 2012-08-29 at 06:50 +, Bart Van Assche wrote: On 08/29/12 05:12, Dan Williams wrote: John reports: BUG: soft lockup - CPU#2 stuck for 23s

Re: 4 isci patches from isci-for-3.6 tag?

2012-09-11 Thread Dan Williams
isci_pci_probe() generates warning on efi failure path (by: Dan Carpenter, Dave Maurer and Dan Williams) We hope they will get to the upstream kernel soon... They were tagged for -next and managed to miss the merge window because it closed early. Just a one-off growing pain of the new process: http

[PATCH v2] libsas: fix sysfs group not found warnings at port teardown time

2015-05-20 Thread Dan Williams
below sas_port, but recent sysfs changes now exposes this problem. Libsas should delete all the devices from rphy down before deleting the parent port. Cc: sta...@vger.kernel.org Reported-by: Praveen Murali pmur...@logicube.com Tested-by: Praveen Murali pmur...@logicube.com Signed-off-by: Dan

  1   2   >