Re: [PATCH net-next 05/22] cxgb4: Add T5 write combining support

2013-03-12 Thread David Miller
From: Vipul Pandya vi...@chelsio.com Date: Tue, 12 Mar 2013 17:16:17 +0530 + writel(n, adap-bar2 + q-udb + 8); +#if defined(CONFIG_X86_32) || defined(CONFIG_X86_64) + asm volatile(sfence : : : memory); +#endif There is absolutely no way I'm

Re: [PATCH v2 net-next 00/22] Add support for Chelsio T5 adapter

2013-03-14 Thread David Miller
From: Vipul Pandya vi...@chelsio.com Date: Thu, 14 Mar 2013 20:38:46 +0530 We request to merge this patch series via David Miller's net-next tree. We are copying respective maintainers of all the drivers for reviewing the changes. Kindly let us know in case of any review comments. All applied

Re: [PATCH 5/6] scsi: replace obsolete NLMSG_* with type safe nlmsg_*

2013-03-28 Thread David Miller
From: Thomas Graf tg...@suug.ch Date: Thu, 28 Mar 2013 14:45:02 + On 03/28/13 at 12:53am, Hong Zhiguo wrote: Signed-off-by: Hong Zhiguo honk...@gmail.com There are some formatting errors but the Netlink bits themselves look good. I'll fix these up too when I commit. -- To unsubscribe

Re: [PATCH net-next 2/5] net, scsi/csgb4i: convert skb-transport_header into skb_transport_header(skb)

2013-06-17 Thread David Miller
From: Simon Horman ho...@verge.net.au Date: Mon, 17 Jun 2013 11:04:11 +0900 On Fri, Jun 14, 2013 at 05:58:32PM +0900, Isaku Yamahata wrote: The change set of 1a37e412, net: Use 16bits for *_headers fields of struct skbuff converted from sk_buff_data_t into 16bit integer. So skb-tail needs to

Re: sparc ESP SCSI error handling BUG+hang

2013-07-29 Thread David Miller
From: Meelis Roos mr...@linux.ee Date: Sun, 21 Apr 2013 14:02:11 +0300 (EEST) I revived my Sun E3000 after its main disk died, reinstalled Debian and after long apuse I am testing linux kernels again on it. In general it works fine but I left the bad disk connected and sometimes it causes

Re: sparc ESP SCSI error handling BUG+hang

2013-07-29 Thread David Miller
From: David Miller da...@davemloft.net Date: Mon, 29 Jul 2013 15:32:23 -0700 (PDT) Therefore I think the fix is going to involve adding a member to struct esp_cmd_entry called -orig_tag[] so that we can see what the original tag[] values were at esp_alloc_lun_tag() time. Please try this patch

Re: sparc ESP SCSI error handling BUG+hang

2013-08-01 Thread David Miller
From: Meelis Roos mr...@linux.ee Date: Tue, 30 Jul 2013 12:58:44 +0300 (EEST) Therefore I think the fix is going to involve adding a member to struct esp_cmd_entry called -orig_tag[] so that we can see what the original tag[] values were at esp_alloc_lun_tag() time. Please try this

Re: [PATCH 00/22] Add and use pci_zalloc_consistent

2014-06-23 Thread David Miller
From: Joe Perches j...@perches.com Date: Mon, 23 Jun 2014 06:41:28 -0700 Adding the helper reduces object code size as well as overall source size line count. It's also consistent with all the various zalloc mechanisms in the kernel. Done with a simple cocci script and some typing. For

Re: [PATCH net-next 3/4] libcxgbi: Add ipv6 api to driver

2014-07-17 Thread David Miller
From: Anish Bhatt an...@chelsio.com Date: Tue, 15 Jul 2014 19:55:52 -0700 +#define pr_info_ipaddr(fmt_trail,\ + addr1, addr2, args_trail...)\ Barf... use %pIS instead, which takes a pointer to a sockaddr of family

Re: [PATCH net-next v2 0/4] cxgb4i: Add ipv6 support

2014-07-17 Thread David Miller
From: Anish Bhatt an...@chelsio.com Date: Thu, 17 Jul 2014 00:18:14 -0700 The following patchset add ipv6 support for the cxgb4i(iscsi) driver. Patch 1 moves a define from the iw_cxgb4 to cxgb4 to prevent code duplication, as it is used by cxgb4i and iw_cxgb4 both. Patch 2 exports

Re: [PATCH 0/25] Replace DEFINE_PCI_DEVICE_TABLE macro use

2014-07-20 Thread David Miller
From: Benoit Taine benoit.ta...@lip6.fr Date: Fri, 18 Jul 2014 17:26:47 +0200 We should prefer `const struct pci_device_id` over `DEFINE_PCI_DEVICE_TABLE` to meet kernel coding style guidelines. This issue was reported by checkpatch. A simplified version of the semantic patch that makes

Re: [PATCH v2 2/4] driver core: enable drivers to use deferred probe from init

2014-07-30 Thread David Miller
From: Luis R. Rodriguez mcg...@do-not-panic.com Date: Mon, 28 Jul 2014 11:28:28 -0700 Tetsuo bisected and found that commit 786235ee kthread: make kthread_create() killable modified kthread_create() to bail as soon as SIGKILL is received. This is causing some issues with some drivers and at

Re: [PATCH 3] scsi: fix build errors, SCSI_FC_ATTRS needs to depend on SCSI NET

2014-09-15 Thread David Miller
From: Randy Dunlap rdun...@infradead.org Date: Mon, 15 Sep 2014 17:20:42 -0700 From: Randy Dunlap rdun...@infradead.org Fix build errors when CONFIG_SCSI_NETLINK is enabled but CONFIG_NET is not enabled: ... Signed-off-by: Randy Dunlap rdun...@infradead.org Applied, thanks a lot Randy. --

Re: [PATCH -net] scsi: fix users of SCSI_FC_ATTRS to depend on NET

2014-09-16 Thread David Miller
From: Steffen Maier ma...@linux.vnet.ibm.com Date: Tue, 16 Sep 2014 16:56:55 +0200 I think zfcp does not have any (direct) dependency on NET. It looks like SCSI_FC_ATTRS selects SCSI_NETLINK (declaring scsi_nl_sock) and only depends on SCSI but not on NET. SCSI_NETLINK itself only selects

Re: [PATCH -net] scsi: fix users of SCSI_FC_ATTRS to depend on NET

2014-09-16 Thread David Miller
From: Randy Dunlap rdun...@infradead.org Date: Mon, 15 Sep 2014 23:35:21 -0700 From: Randy Dunlap rdun...@infradead.org There are other kconfig symbols which select SCSI_FC_ATTRS, so they also need to depend on NET to fix kconfig warnings and build errors: warning: (LIBFC SCSI_IBMVFC

Re: [PATCH -net] scsi: fix users of SCSI_FC_ATTRS to depend on NET

2014-09-16 Thread David Miller
From: Randy Dunlap rdun...@infradead.org Date: Tue, 16 Sep 2014 13:24:46 -0700 typo: depends on SCSI_FC_ATTRS No, I certainly have no objection and prefer depends over select anyway. Ok, then please send me a patch which fixes things that way. Thanks! -- To unsubscribe

Re: [PATCH v2] scsi: use 'depends' instead of 'select' for SCSI_FC_ATTRS

2014-09-16 Thread David Miller
From: Randy Dunlap rdun...@infradead.org Date: Tue, 16 Sep 2014 13:47:41 -0700 From: Randy Dunlap rdun...@infradead.org There are other kconfig symbols which use SCSI_FC_ATTRS. In order to maintain sanity and prevent kconfig warnings, change all of these from using 'select' to using

Re: [PATCH] scsi: fix kconfig dependency warnings for SCSI_FC_ATTRS

2014-09-22 Thread David Miller
From: Christoph Hellwig h...@infradead.org Date: Mon, 22 Sep 2014 07:42:13 -0700 On Fri, Sep 19, 2014 at 04:50:59PM -0700, Randy Dunlap wrote: --- linux-next-20140918.orig/drivers/scsi/qla2xxx/Kconfig +++ linux-next-20140918/drivers/scsi/qla2xxx/Kconfig @@ -30,7 +30,7 @@ config SCSI_QLA_FC

Re: [PATCH] scsi: fix kconfig dependency warnings for SCSI_FC_ATTRS

2014-09-22 Thread David Miller
From: Christoph Hellwig h...@infradead.org Date: Mon, 22 Sep 2014 07:42:13 -0700 On Fri, Sep 19, 2014 at 04:50:59PM -0700, Randy Dunlap wrote: --- linux-next-20140918.orig/drivers/scsi/qla2xxx/Kconfig +++ linux-next-20140918/drivers/scsi/qla2xxx/Kconfig @@ -30,7 +30,7 @@ config SCSI_QLA_FC

Re: [PATCH] scsi: fix kconfig dependency warnings for SCSI_FC_ATTRS

2014-09-22 Thread David Miller
From: Randy Dunlap rdun...@infradead.org Date: Fri, 19 Sep 2014 16:50:59 -0700 From: Randy Dunlap rdun...@infradead.org Fix kconfig dependency warnings which can lead to build errors: warning: (SCSI_BNX2X_FCOE LIBFCOE TCM_QLA2XXX) selects LIBFC which has unmet direct dependencies

Re: [PATCH/RESEND V6 00/18] UFS: Power management support

2014-09-25 Thread David Miller
Please stop putting listname-owner (in this case linux-scsi-owner) in the CC: list, that goes to me not the list. -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord...@vger.kernel.org More majordomo info at

Re: [PATCH net v2 0/4] ipv6 and related cleanup for cxgb4/cxgb4i

2014-10-14 Thread David Miller
From: Anish Bhatt an...@chelsio.com Date: Tue, 14 Oct 2014 20:07:20 -0700 This patch set removes some duplicated/extraneous code from cxgb4i, guards cxgb4 against compilation failure based on ipv6 tristate, make ipv6 related code no longer be enabled by default irrespective of ipv6 tristate

Re: Sparc ESP problem with blk-mq

2014-10-15 Thread David Miller
From: Christoph Hellwig h...@infradead.org Date: Wed, 15 Oct 2014 06:35:51 -0700 On Tue, Oct 14, 2014 at 08:38:18AM -0600, Jens Axboe wrote: Christoph, any idea on this? The command just times out, for some reason. Only thing I could think of was related to perhaps missing bouncing or

Re: Sparc ESP problem with blk-mq

2014-10-17 Thread David Miller
From: mr...@linux.ee Date: Thu, 16 Oct 2014 09:43:34 +0300 (EEST) [ 158.730919] ESP: tgt[6] lun[0] scsi_cmd [ 12 00 00 00 24 00 ] [ 158.799397] ESP: intr sreg[87] seqreg[00] sreg2[00] ireg[18] Target 6 responds, Bus Service + Function Done interrupt. Status register 1 indicates interrupt

Re: Sparc ESP problem with blk-mq

2014-10-18 Thread David Miller
Christoph, I don't see how the new tagging code with blk-mq can be providing compatible behavior for existing SCSI drivers. Do you know that scsi_populate_tag_msg() is always going to provide a tag? Unconditionally, every time, when using blk-mq? This is because the test: if

Re: [PATCH net-next 0/3] RDMA/cxgb4,cxgb4vf,cxgb4i,csiostor: Cleanup macros

2014-11-03 Thread David Miller
From: Hariprasad Shenai haripra...@chelsio.com Date: Mon, 3 Nov 2014 17:46:51 +0530 This series moves the debugfs code to a new file debugfs.c, Cleans up macros so that they match the hardware generated one. How does hardware generate the macros? I don't understand what this means at all.

Re: [PATCHv2 net-next 0/3] RDMA/cxgb4,cxgb4vf,cxgb4i,csiostor: Cleanup macros

2014-11-05 Thread David Miller
From: Hariprasad Shenai haripra...@chelsio.com Date: Tue, 4 Nov 2014 08:20:54 +0530 It's not really the hardware which generates these hardware constant symbolic macros/register defines of course, it's scripts developed by the hardware team. Various patches have ended up changing the

Re: [PATCHv2 net-next 0/3] RDMA/cxgb4,cxgb4vf,cxgb4i,csiostor: Cleanup macros

2014-11-06 Thread David Miller
From: Hariprasad S haripra...@chelsio.com Date: Thu, 6 Nov 2014 21:45:10 +0530 On Wed, Nov 05, 2014 at 14:54:43 -0500, David Miller wrote: From: Hariprasad Shenai haripra...@chelsio.com Date: Tue, 4 Nov 2014 08:20:54 +0530 It's not really the hardware which generates these hardware

Re: blk_mq: suspicious RCU usage, rcu_read_lock() used illegally while idle!

2014-11-07 Thread David Miller
From: Paul E. McKenney paul...@linux.vnet.ibm.com Date: Fri, 7 Nov 2014 07:06:28 -0800 On Fri, Nov 07, 2014 at 12:50:02PM +0200, Meelis Roos wrote: Perhaps DaveM can tell which one is coreect or if there is any related problem. Happy to push either of them along, if appropriate. We should

Re: [PATCHv3 net-next 0/3] RDMA/cxgb4,cxgb4vf,cxgb4i,csiostor: Cleanup macros

2014-11-10 Thread David Miller
From: Hariprasad Shenai haripra...@chelsio.com Date: Fri, 7 Nov 2014 09:35:22 +0530 This series moves the debugfs code to a new file debugfs.c and cleans up macros/register defines. Various patches have ended up changing the style of the symbolic macros/register defines and some of them

Re: [PATCH net-next] cxgb4i/cxgb4 : Refactor macros to conform to uniform standards

2014-11-13 Thread David Miller
From: Anish Bhatt an...@chelsio.com Date: Wed, 12 Nov 2014 17:15:57 -0800 Refactored all macros used in cxgb4i as part of previously started cxgb4 macro names cleanup. Makes them more uniform and avoids namespace collision. Minor changes in other drivers where required as some of these macros

Re: [PATCH net] cxgb4i : Don't block unload/cxgb4 unload when remote closes TCP connection

2014-11-19 Thread David Miller
From: Anish Bhatt an...@chelsio.com Date: Tue, 18 Nov 2014 19:09:51 -0800 cxgb4i was returning wrong error and not releasing module reference if remote end abruptly closed TCP connection. This prevents the cxgb4 network module from being unloaded, further affecting other network drivers

Re: [PATCH 06/12] esp_scsi: use FIFO for command submission

2014-11-21 Thread David Miller
From: Hannes Reinecke h...@suse.de Date: Fri, 21 Nov 2014 13:41:50 +0100 Using DMA for command submission has the drawback that it might generate additional DMA completion interrupts after the command has been submitted to the device. Additionally the am53c974 has a design flaw causing it to

Re: [PATCH 01/12] esp_scsi: spellcheck 'driver'

2014-11-21 Thread David Miller
From: Hannes Reinecke h...@suse.de Date: Fri, 21 Nov 2014 13:41:45 +0100 Reviewed-by: Paolo Bonzini pbonz...@redhat.com Signed-off-by: Hannes Reinecke h...@suse.de Acked-by: David S. Miller da...@davemloft.net -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body

Re: [PATCH 02/12] esp_scsi: make number of tags configurable

2014-11-21 Thread David Miller
From: Hannes Reinecke h...@suse.de Date: Fri, 21 Nov 2014 13:41:46 +0100 Add a field 'num_tags' to the esp structure to allow drivers to overwrite the number of avialable tags if required. Default is ESP_DEFAULT_TAGS. Reviewed-by: Paolo Bonzini pbonz...@redhat.com Signed-off-by: Hannes

Re: [PATCH 03/12] esp_scsi: convert to dev_printk

2014-11-21 Thread David Miller
From: Hannes Reinecke h...@suse.de Date: Fri, 21 Nov 2014 13:41:47 +0100 Use dev_printk functions for correct device annotations. Reviewed-by: Paolo Bonzini pbonz...@redhat.com Signed-off-by: Hannes Reinecke h...@suse.de Acked-by: David S. Miller da...@davemloft.net -- To unsubscribe from

Re: [PATCH 05/12] esp_scsi: read status registers

2014-11-21 Thread David Miller
From: Hannes Reinecke h...@suse.de Date: Fri, 21 Nov 2014 13:41:49 +0100 A read to ESP_INTRPT will clear ESP_STATUS and ESP_SSTEP. So read all status registers in one go to avoid losing information. Reviewed-by: Paolo Bonzini pbonz...@redhat.com Signed-off-by: Hannes Reinecke h...@suse.de

Re: [PATCH 08/12] am53c974: BLAST residual handling

2014-11-21 Thread David Miller
From: Hannes Reinecke h...@suse.de Date: Fri, 21 Nov 2014 13:41:52 +0100 The am53c974 has an design issue where a single byte might be left in the SCSI FIFO after a DMA transfer. As the handling code is currently untested add a WARN_ON() statement here. Signed-off-by: Hannes Reinecke

Re: [PATCH 09/12] esp: correctly detect am53c974

2014-11-21 Thread David Miller
From: Hannes Reinecke h...@suse.de Date: Fri, 21 Nov 2014 13:41:53 +0100 + if ((config4 ESP_CONFIG4_GE1) == ESP_CONFIG4_GE1) { Please condense this down to the more simple and straightforward: if (x BIT(N)) because this is always equivalent to the expression you have

Re: Another (ESP?) scsi blk-mq problem on sparc64

2014-11-21 Thread David Miller
From: Christoph Hellwig h...@infradead.org Date: Wed, 19 Nov 2014 22:01:35 -0800 On Sat, Nov 15, 2014 at 08:31:00AM -0700, Jens Axboe wrote: My next move would be to add more debug to the CPU map setup and teardown, so that we can verify that the map that is being used above has indeed been

Re: [PATCH net-next 0/5] RDMA/cxgb4,cxgb4vf,csiostor: Cleanup macros

2014-11-22 Thread David Miller
From: Hariprasad Shenai haripra...@chelsio.com Date: Fri, 21 Nov 2014 12:52:00 +0530 This series continues to cleanup all the macros/register defines related to filter, port, VI, queue, RSS, LDST, firmware, etc that are defined in t4fw_api.h and the affected files. Will post few more

Re: [PATCH 12/12] Replace tmscsim by am53c974

2014-11-23 Thread David Miller
Please do not _EVER_ quote an entire huge patch just to add a signoff or ACK. This wastes tons of mailing list resources because it means that the entire huge patch is sent once again to every single recipient on the mailing list. Instead, just at most quote the commit message, then add your

Re: Another (ESP?) scsi blk-mq problem on sparc64

2014-11-24 Thread David Miller
From: Jens Axboe ax...@kernel.dk Date: Mon, 24 Nov 2014 10:16:15 -0700 How about this one? The num in num_possible_cpus() means a count, as in how many are there. It doesn't mean largest ID of members of set X, which is what you are asking for. Even worse, having num_online_cpus() and

Re: Another (ESP?) scsi blk-mq problem on sparc64

2014-11-24 Thread David Miller
From: Jens Axboe ax...@kernel.dk Date: Mon, 24 Nov 2014 15:01:55 -0700 I'll just updated blk-mq to use nr_cpu_ids and be done with it. Wow, a grep on nr_cpu_ids gets a lot of hits on people allocating just these kinds of tables :) -- To unsubscribe from this list: send the line unsubscribe

Re: Another (ESP?) scsi blk-mq problem on sparc64

2014-11-24 Thread David Miller
From: mr...@linux.ee Date: Tue, 25 Nov 2014 00:23:20 +0200 (EET) Yes, that does look like the case. Do you have a good trick on how to allocate a map for the highest possible cpu number without first iterating the cpu map? I couldn't find something that looks like a

Re: [PATCH net-next] cxgb4/cxgb4vf/csiostor: Add T4/T5 PCI ID Table

2014-11-25 Thread David Miller
From: Hariprasad Shenai haripra...@chelsio.com Date: Tue, 25 Nov 2014 08:33:58 +0530 Add a new file t4_pci_id_tbl.h that contains T4/T5 PCI ID Table so that for all drivers that uses T4/T5 PCI functions changes can be done in one place. checkpatch.pl script reports following error, which

Re: [hch-scsi-queue:drivers-for-3.19 174/180] drivers/scsi/wd719x.c:247:2: error: implicit declaration of function 'dma_cache_sync'

2014-11-26 Thread David Miller
From: Christoph Hellwig h...@lst.de Date: Wed, 26 Nov 2014 20:13:09 +0100 On Wed, Nov 26, 2014 at 06:32:48PM +0100, Ondrej Zary wrote: wd819x should probably depend on VIRT_TO_BUS? But that means it will not work on sparc. Is there a way to make it work? I have a sparc machine but haven't

Re: queued patches for SCSI for 2.6.24

2007-09-25 Thread David Miller
From: James Bottomley [EMAIL PROTECTED] Date: Tue, 25 Sep 2007 20:00:02 -0500 David Miller (1): esp: fix instance numbering. I'd like to request that this one goes into 2.6.23 as it is a bug fix and the bug confuses users. Thanks. - To unsubscribe from this list: send the line

Re: slave_configure for qlogicpti

2007-09-30 Thread David Miller
From: Matthew Wilcox [EMAIL PROTECTED] Date: Wed, 19 Sep 2007 06:46:37 -0600 I haven't even compile-tested this. But look how much ugly code it deletes if it works! It compiles :-) You deleted the only uses of scsi_rbuf_{get,put}() so you can kill those off too. I don't have the time to

Re: slave_configure for qlogicpti

2007-09-30 Thread David Miller
From: Jeff Garzik [EMAIL PROTECTED] Date: Sun, 30 Sep 2007 20:52:45 -0400 David Miller wrote: It compiles :-) You deleted the only uses of scsi_rbuf_{get,put}() so you can kill those off too. Seeing as how they are exact duplicates of libata's ata_scsi_rbuf_{get,put}, I wonder how

Re: generating a Linux WWN?

2007-10-03 Thread David Miller
From: Luben Tuikov [EMAIL PROTECTED] Date: Wed, 3 Oct 2007 15:08:48 -0700 (PDT) Your want to get their card working way of view is very simplistic to justify generating and assigning SAS WWN in the kernel. This is the job of the manufacturer/packager, not the host OS. When you are thousands

Re: generating a Linux WWN?

2007-10-05 Thread David Miller
From: James Bottomley [EMAIL PROTECTED] Date: Fri, 05 Oct 2007 18:14:48 -0400 On Fri, 2007-10-05 at 15:11 -0700, David Miller wrote: auto_wwn=1 or somthing like that I'd far prefer override_wwn = fully specific WWN since I assume auto_wwn means get the kernel to generate one? I think

Re: generating a Linux WWN?

2007-10-05 Thread David Miller
From: Jeff Garzik [EMAIL PROTECTED] Date: Fri, 05 Oct 2007 18:41:40 -0400 And that's been my plan from day one... which is remarkably a lot like the behavior of several net drivers. :) * attempt to read WWN during module load * admin may optionally choose to manually specify OR

Re: generating a Linux WWN?

2007-10-06 Thread David Miller
From: James Bottomley [EMAIL PROTECTED] Date: Sat, 06 Oct 2007 09:11:10 -0500 My problem with auto generated is that it's provably impossible to generate globally unique numbers for WWNs without some internal source of uniqueness (I know sparcs have this in their serial number, but most PCs

Re: generating a Linux WWN?

2007-10-06 Thread David Miller
From: James Bottomley [EMAIL PROTECTED] Date: Sat, 06 Oct 2007 10:04:55 -0500 If you remember Rusty's guide to interfaces, this is a level 14 easy to misuse interface: The obvious use is wrong; since the obvious use is to put it in module parameters and have the problem go away (for now ...).

Re: [PATCH 21/24 ver2] qlogicpti.c: convert to accessors and !use_sg cleanup

2007-10-10 Thread David Miller
From: Boaz Harrosh [EMAIL PROTECTED] Date: Wed, 10 Oct 2007 20:25:30 +0200 - convert to accessors and !use_sg cleanup Signed-off-by: Boaz Harrosh [EMAIL PROTECTED] Acked-by: David S. Miller [EMAIL PROTECTED] - To unsubscribe from this list: send the line unsubscribe linux-scsi in the body

Re: [2.6 patch] esp_scsi.c: remove __dev{init,exit}

2007-10-11 Thread David Miller
From: Rob Landley [EMAIL PROTECTED] Date: Thu, 11 Oct 2007 17:47:02 -0500 On Thursday 11 October 2007 10:35:20 am Adrian Bunk wrote: Since scsi_esp_{,un}register() are EXPORT_SYMBOL'ed, these functions (and the functions they use) can't be __dev{init,exit}. Based on a bug report by Rob

Re: drivers/fc4/fc.c in git-scsi-misc

2007-10-11 Thread David Miller
From: Andrew Morton [EMAIL PROTECTED] Date: Thu, 11 Oct 2007 11:20:58 -0700 Well if fc4.c compiles OK on non-sparc64 then perhaps we should enable compilation on non-sparc64. It will increase maintainability and code quality and stuff. No objections to including drivers/fc4/Kconfig directly

Re: drivers/fc4/fc.c in git-scsi-misc

2007-10-12 Thread David Miller
From: James Bottomley [EMAIL PROTECTED] Date: Fri, 12 Oct 2007 13:04:33 -0500 On Thu, 2007-10-11 at 17:38 -0700, David Miller wrote: From: Andrew Morton [EMAIL PROTECTED] Date: Thu, 11 Oct 2007 11:20:58 -0700 Well if fc4.c compiles OK on non-sparc64 then perhaps we should enable

Re: [PATCH] SPARC64: fix iommu sg chaining

2007-10-17 Thread David Miller
From: Jens Axboe [EMAIL PROTECTED] Date: Wed, 17 Oct 2007 09:21:49 +0200 On Wed, Oct 17 2007, FUJITA Tomonori wrote: Commit 2c941a204070ab32d92d40318a3196a7fb994c00 looks incomplete. The helper functions like prepare_sg() need to support sg chaining too. Thanks Tomo, applied. I'll get

Re: [PATCH] SPARC64: fix iommu sg chaining

2007-10-17 Thread David Miller
From: Jens Axboe [EMAIL PROTECTED] Date: Wed, 17 Oct 2007 10:45:28 +0200 Righto, it's invalid to call sg_next() on the last entry! Unfortunately, that's what the sparc64 code wanted to do, this transformation in the sparc64 sg chaining patch is not equilavent: - struct scatterlist

Re: [PATCH] SPARC64: fix iommu sg chaining

2007-10-17 Thread David Miller
From: FUJITA Tomonori [EMAIL PROTECTED] Date: Wed, 17 Oct 2007 18:24:01 +0900 On Wed, 17 Oct 2007 11:16:29 +0200 Jens Axboe [EMAIL PROTECTED] wrote: On Wed, Oct 17 2007, David Miller wrote: I would suggest that other sg_last() uses be audited for the same bug. Agree. Only libata

Re: [PATCH] SPARC64: fix iommu sg chaining

2007-10-17 Thread David Miller
From: Jens Axboe [EMAIL PROTECTED] Date: Wed, 17 Oct 2007 11:16:29 +0200 On Wed, Oct 17 2007, David Miller wrote: From: Jens Axboe [EMAIL PROTECTED] Date: Wed, 17 Oct 2007 10:45:28 +0200 Righto, it's invalid to call sg_next() on the last entry! Unfortunately, that's what

Re: [PATCH] SPARC64: fix iommu sg chaining

2007-10-17 Thread David Miller
From: Jens Axboe [EMAIL PROTECTED] Date: Wed, 17 Oct 2007 12:58:40 +0200 The problem is that you cannot zero the entire sg entry, because then you'd potentially overwrite the chain pointer. I'd propose just adding a sg_dma_address(sg) = 0; sg_dma_len(sg) = 0; there for

Re: [PATCH] SPARC64: fix iommu sg chaining

2007-10-17 Thread David Miller
From: Jens Axboe [EMAIL PROTECTED] Date: Wed, 17 Oct 2007 13:01:42 +0200 Actually, just clearing AFTER sg_next() would be fine, since we know that is not a link entry. Duh... Yes and I'm running a kernel successfully with this fix. Jens, please also add the following on top of Fujita-san's

Re: [PATCH] SPARC64: fix iommu sg chaining

2007-10-17 Thread David Miller
From: Jens Axboe [EMAIL PROTECTED] Date: Wed, 17 Oct 2007 13:11:46 +0200 On Wed, Oct 17 2007, David Miller wrote: Jens, please also add the following on top of Fujita-san's most recent sparc64 patch and we should be good to go. Awesome, thanks. And sorry for messing up sparc64. Don't

Re: [PATCH] Make advansys depend on CONFIG_VIRT_TO_BUS

2007-10-18 Thread David Miller
From: Stephen Rothwell [EMAIL PROTECTED] Date: Fri, 19 Oct 2007 15:04:31 +1000 At least for now. Signed-off-by: Stephen Rothwell [EMAIL PROTECTED] Acked-by: David S. Miller [EMAIL PROTECTED] - To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to

Re: why disk info gets printk'ed twice?

2007-10-22 Thread David Miller
From: Michael Tokarev [EMAIL PROTECTED] Date: Tue, 23 Oct 2007 01:37:28 +0400 So it seems to me that scsi_driver.probe() method gets called twice for some reason... This question has been asked several times, but I don't recall any answers to it. I seem to remember that this happens as a

Re: [GIT PATCH] final SCSI pieces for the merge window

2007-10-23 Thread David Miller
From: Jeff Garzik [EMAIL PROTECTED] Date: Tue, 23 Oct 2007 18:06:51 -0400 James Bottomley wrote: On Tue, 2007-10-23 at 17:09 -0400, Jeff Garzik wrote: James Bottomley wrote: This should be the final SCSI updates; it's mainly just a few accessor completion updates and two driver merges

Re: SCSI breakage on non-cache coherent architectures

2007-11-19 Thread David Miller
From: Benjamin Herrenschmidt [EMAIL PROTECTED] Date: Mon, 19 Nov 2007 16:35:23 +1100 I'm not sure what is the best way to fix that. Internally, I've done some test whacking some cacheline_aligned in the scsi_cmnd data structure to verify I no longer get random SLAB corruption when using my

Re: SCSI breakage on non-cache coherent architectures

2007-11-19 Thread David Miller
From: Benjamin Herrenschmidt [EMAIL PROTECTED] Date: Tue, 20 Nov 2007 06:51:14 +1100 On Mon, 2007-11-19 at 00:38 -0800, David Miller wrote: From: Benjamin Herrenschmidt [EMAIL PROTECTED] Date: Mon, 19 Nov 2007 16:35:23 +1100 You could make a dma_cacheline_aligned and use

Re: SCSI breakage on non-cache coherent architectures

2007-11-19 Thread David Miller
From: Benjamin Herrenschmidt [EMAIL PROTECTED] Date: Tue, 20 Nov 2007 11:55:01 +1100 BTW. What is the status nowadays with skb's ? Good question. Some drivers are problematic (or were) because they put DMA descriptor chaining information at the head of the buffer, but those have been fixed

Re: [PATCH] esp_scsi: Fix reset cleanup spinlock recursion

2007-12-05 Thread David Miller
From: Maciej W. Rozycki [EMAIL PROTECTED] Date: Wed, 5 Dec 2007 16:10:54 + (GMT) The esp_reset_cleanup() function is called with the host lock held and invokes starget_for_each_device() which wants to take it too. Here is a fix along the lines of

Re: [PATCH 2/5] dma_map_sg_ring() helper

2007-12-19 Thread David Miller
From: FUJITA Tomonori [EMAIL PROTECTED] Date: Thu, 20 Dec 2007 16:06:31 +0900 On Thu, 20 Dec 2007 16:49:30 +1100 Rusty Russell [EMAIL PROTECTED] wrote: +/** + * dma_map_sg_ring - Map an entire sg ring + * @dev: Device to free noncoherent memory for + * @sg: The sg_ring + *

Re: [PATCH 2/5] dma_map_sg_ring() helper

2007-12-20 Thread David Miller
From: Rusty Russell [EMAIL PROTECTED] Date: Fri, 21 Dec 2007 11:35:12 +1100 On Friday 21 December 2007 11:00:27 FUJITA Tomonori wrote: We need to pass the whole sg entries to the IOMMUs at a time. Hi Fujita, OK, it's certainly possible to have an arch override. For which

Re: [PATCH 1/1] Remove of old NCR53C9x/esp family of drivers

2008-01-03 Thread David Miller
From: Geert Uytterhoeven [EMAIL PROTECTED] Date: Thu, 3 Jan 2008 20:05:27 +0100 (CET) On Thu, 3 Jan 2008, James Bottomley wrote: On Thu, 2008-01-03 at 17:40 +0200, Boaz Harrosh wrote: As recommended by Christoph Hellwig. There is no use of Fixing these drivers, since there is a much

Re: [PATCH 1/1] Remove of old NCR53C9x/esp family of drivers

2008-01-04 Thread David Miller
From: Finn Thain [EMAIL PROTECTED] Date: Fri, 4 Jan 2008 22:05:20 +1100 (EST) I have a partially written replacement for mac_esp. Unlike the other NCR53C9x drivers it needs PIO or pseudo DMA depending on the machine -- so it is not as straight-forward as jazz_esp. The new esp_scsi core

Re: [PATCH] eisa: standardize on eisa_register_driver like similar bus registrations

2013-10-07 Thread David Miller
From: Matthew Whitehead tedheads...@gmail.com Date: Sat, 5 Oct 2013 22:35:58 -0400 The other buses (isa, pci, pnp, parport, usb, tty, etc) all use the convention of ${BUSNAME}_register_driver. Rewrite the little remaining code that uses EISA to follow this convention for easier readability.

Re: [PATCH 3.13] genetlink/pmcraid: use proper genetlink multicast API

2013-11-28 Thread David Miller
From: Johannes Berg johan...@sipsolutions.net Date: Sun, 24 Nov 2013 21:09:26 +0100 From: Johannes Berg johannes.b...@intel.com The pmcraid driver is abusing the genetlink API and is using its family ID as the multicast group ID, which is invalid and may belong to somebody else (and likely

Re: esp_scsi QTAG in FAS216

2014-04-04 Thread David Miller
From: Tuomas Vainikka tuomas.vaini...@aalto.fi Date: Thu, 12 Sep 2013 18:36:09 +0300 Does anyone have the register descriptions for the FAS216 chip? It would seem that receiving only one byte during reconnect is perfectly normal [1] unless SCSI-2 features are explicitly enabled (which

Re: esp_scsi QTAG in FAS216

2014-04-06 Thread David Miller
From: Michael Schmitz schmitz...@gmail.com Date: Mon, 7 Apr 2014 08:33:12 +1200 Hello Dave, Tuomas, Also, looking at the timeout formulae in the old NCR53C9x.c driver, the values would be different for FAS216. Why was this dropped from the modern esp_scsi? I've never seen a formula for

Re: esp_scsi QTAG in FAS216

2014-04-13 Thread David Miller
From: Michael Schmitz schmitz...@gmail.com Date: Mon, 14 Apr 2014 10:38:09 +1200 That appears to be our problem if I recall correctly Tuomas' debugging report. (reselection, not selection as initiator). As esp_slave_configure() enables queue tags regardless of chip config, we'd best make

Re: Oops in scsi_send_eh_cmnd 2.6.21-rc5-git6,7,10,13

2007-04-05 Thread David Miller
From: Andrew Burgess [EMAIL PROTECTED] Date: Thu, 5 Apr 2007 15:13:27 -0700 David, do you see any other problems with scsi_send_eh_cmnd? I've switched back to 2.6.18 which seems to not oops and am happy to try patches. Does 2.6.20 with my patch OOPS too? Does reverting my patch make the

Re: Oops in scsi_send_eh_cmnd 2.6.21-rc5-git6,7,10,13

2007-04-05 Thread David Miller
From: James Bottomley [EMAIL PROTECTED] Date: Thu, 05 Apr 2007 19:02:19 -0500 On Thu, 2007-04-05 at 15:36 -0700, David Miller wrote: From: Andrew Burgess [EMAIL PROTECTED] Date: Thu, 5 Apr 2007 15:13:27 -0700 David, do you see any other problems with scsi_send_eh_cmnd? I've

Re: Oops in scsi_send_eh_cmnd 2.6.21-rc5-git6,7,10,13

2007-04-06 Thread David Miller
From: James Bottomley [EMAIL PROTECTED] Date: Fri, 06 Apr 2007 10:27:57 -0500 On Fri, 2007-04-06 at 08:12 -0700, Andrew Burgess wrote: Yes. The 3w-.c driver changed between 2.6.18 and 2.6.20 but nothing jumps out to my untrained eyes. Here's the diff: Also, I should mention that the

scsi_set_tag_type()

2007-04-10 Thread David Miller
I don't believe this function behaves as some call sites intend. For example, if the driver implements the -change_queue_type() method, and I say to use simple tags in sysfs, and sdev-ordered_tags is already set, I am not going to get simple tags since sdev-ordered_tags will stay set and

Major qla2xxx regression on sparc64

2007-04-16 Thread David Miller
Sparc64 systems which have an on-board qla2xxx chip (such as SunBlade-1000 and SunBlade-2000, there are probably some other systems like this too) do not have any NVRAM information present, in fact the NVRAM is basically all 0's from what I can tell. This always worked just fine since the code

Re: Major qla2xxx regression on sparc64

2007-04-16 Thread David Miller
From: David Miller [EMAIL PROTECTED] Date: Mon, 16 Apr 2007 12:37:43 -0700 (PDT) Now I'm happy to code up the sparc OFW property bits but your attitude and perspective on this absolutely has to change and the old fallback code still has to go back in there, possible FC ID collisions

Re: Major qla2xxx regression on sparc64

2007-04-16 Thread David Miller
From: Andrew Vasquez [EMAIL PROTECTED] Date: Mon, 16 Apr 2007 14:10:49 -0700 Ok, how about the following patch based on the one you posted which adds the codes to retrieve the WWPN/WWNN from firmware on SPARC, and also adds the module-parameter override I mentioned above. Perhaps the

Re: Major qla2xxx regression on sparc64

2007-04-16 Thread David Miller
From: Andrew Vasquez [EMAIL PROTECTED] Date: Mon, 16 Apr 2007 15:25:17 -0700 Fine, I'll agree that wacking-users (and I'll wager the outliers) with a 2x4 was a bit extreme, And that, right there, is basically the end of the conversation. You don't do this to users, ever. Put a big loud

Re: Major qla2xxx regression on sparc64

2007-04-16 Thread David Miller
From: Andrew Vasquez [EMAIL PROTECTED] Date: Mon, 16 Apr 2007 16:28:51 -0700 Sorry, but let's be realistic, this type of warning would have *NEVER* been addressed if we kept the status quo Wrong. I watch the logs all the time and would have sent you a fix to use the Sparc firmware info as

Re: Major qla2xxx regression on sparc64

2007-04-16 Thread David Miller
From: Andrew Vasquez [EMAIL PROTECTED] Date: Mon, 16 Apr 2007 16:47:05 -0700 Dave, according to your earlier emails, the qla2xxx driver worked 'fine' in driver versions before commit 7aef45ac92f49e76d990b51b7ecd714b9a608be1. If that were the case, then you would have seen the warning

Re: Major qla2xxx regression on sparc64

2007-04-16 Thread David Miller
From: Andrew Vasquez [EMAIL PROTECTED] Date: Mon, 16 Apr 2007 19:41:07 -0700 That verbiage sounds fine -- so would you consider the previous patch I submitted (with module parameter) along with the wording above? Yes, that sounds fine. I'm in transit for a redeye to NY so I won't be able to

Re: Major qla2xxx regression on sparc64

2007-04-17 Thread David Miller
From: Seokmann Ju [EMAIL PROTECTED] Date: Tue, 17 Apr 2007 11:28:07 -0700 Hello David, On Mon 4/16/2007 10:02 PM, David Miller wrote: I'm in transit for a redeye to NY so I won't be able to modify the patch, If you would be amenable to the above, Seokmann, could you rework the patch

Re: Major qla2xxx regression on sparc64

2007-04-18 Thread David Miller
From: Christoph Hellwig [EMAIL PROTECTED] Date: Wed, 18 Apr 2007 18:13:46 +0100 Note that I expect Sun put in the invalid ROM intentionally, as we have similar cases with other cards that have totally messed up ROMs in Sun-branded versions. Personally I think that's an utterly bad decision

Re: Major qla2xxx regression on sparc64

2007-04-18 Thread David Miller
From: Christoph Hellwig [EMAIL PROTECTED] Date: Wed, 18 Apr 2007 18:16:32 +0100 On Tue, Apr 17, 2007 at 11:28:07AM -0700, Seokmann Ju wrote: Hello David, On Mon 4/16/2007 10:02 PM, David Miller wrote: I'm in transit for a redeye to NY so I won't be able to modify the patch, If you

Re: Major qla2xxx regression on sparc64

2007-04-18 Thread David Miller
From: Andrew Vasquez [EMAIL PROTECTED] Date: Wed, 18 Apr 2007 10:28:02 -0700 On Wed, 18 Apr 2007, Christoph Hellwig wrote: I don't think a module option is a good idea at this point. The problem is you broke some so far perfectly working setups, which is not okay. The only first step

Re: qla2xxx hba crashes with older 2310 cards

2007-04-20 Thread David Miller
From: Robert Peterson [EMAIL PROTECTED] Date: Fri, 20 Apr 2007 10:40:30 -0500 I've seen some chatter about the qla2xxx driver but not paid attention, so I'm sorry if this is a known issue. I've got an older qlogic hba, and recent drivers don't seem to play nice with it. I've got the latest

Re: [RFC PATCH]: Rewritten ESP driver, porters needed!

2007-04-24 Thread David Miller
From: Christoph Hellwig [EMAIL PROTECTED] Date: Tue, 24 Apr 2007 13:22:35 +0100 Overall the driver looks really nice, thanks a lot! Thanks. would be nice to have dev_printk here, but sbus still seems to lack driver model integration. There is only partial integration at the moment, but

Re: [RFC PATCH]: Rewritten ESP driver, porters needed!

2007-04-24 Thread David Miller
From: Christoph Hellwig [EMAIL PROTECTED] Date: Tue, 24 Apr 2007 13:45:27 +0100 Oh, btw - there is a problem with the generic code beeing esp.ko - we already have drivers/char/esp.c which buids into esp.ko for ISA platforms, which have a bit of overlap with ESP-using platforms. Maybe the

  1   2   3   >