[PATCH 0/3] debloat aic7xxx and aic79xx drivers

2007-10-14 Thread Denys Vlasenko
. Signed-off-by: Denys Vlasenko [EMAIL PROTECTED] -- vda - To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH 3/3] debloat aic7xxx and aic79xx drivers

2007-10-14 Thread Denys Vlasenko
Adds more consts Signed-off-by: Denys Vlasenko [EMAIL PROTECTED] -- vda diff -urpN linux-2.6.23-aic-2-addstatic/drivers/scsi/aic7xxx/aic79xx.h linux-2.6.23-aic-3-addconst/drivers/scsi/aic7xxx/aic79xx.h --- linux-2.6.23-aic-2-addstatic/drivers/scsi/aic7xxx/aic79xx.h 2007-10-14 15:05:07.0

Re: [PATCH 0/3] debloat aic7xxx and aic79xx drivers

2007-10-18 Thread Denys Vlasenko
Hi Andrew, James, On Monday 15 October 2007 14:53, Gabriel C wrote: Compile tested and applies cleanly to 2.6.23. I don't have this hardware anymore and cannot run test these patches. I can test these patches on an aic7892 controller later on today if you want. Works fine for me

Re: [GIT PATCH] final SCSI pieces for the merge window

2007-10-30 Thread Denys Vlasenko
On Wednesday 24 October 2007 15:27, Matthew Wilcox wrote: On Wed, Oct 24, 2007 at 09:28:10AM -0400, James Bottomley wrote: OK, so it's no secret that I'm the last of the subsystem maintainers whose day job isn't working on the linux kernel. If you want a full time person, who did you have

Re: [PATCH] drivers/scsi/lpfc/lpfc_hw.h: Some minor cleanup.

2007-10-30 Thread Denys Vlasenko
On Tuesday 30 October 2007 10:54, Richard Knutsson wrote: Signed-off-by: Richard Knutsson [EMAIL PROTECTED] --- Diffed against linus-git Checked with script/checkpatch.pl diff --git a/drivers/scsi/lpfc/lpfc_hw.h b/drivers/scsi/lpfc/lpfc_hw.h index 451accd..6f56528 100644 ---

Re: [PATCH] debloat aic7xxx and aic79xx drivers by deinlining

2007-08-26 Thread Denys Vlasenko
On Saturday 25 August 2007 22:57, Arjan van de Ven wrote: On Sat, 25 Aug 2007 22:57:07 +0100 Denys Vlasenko [EMAIL PROTECTED] wrote: Hi, Attached patch deinlines and moves big functions from .h to .c files in drivers/scsi/aic7xxx/*. I also had to add prototypes for ahc_lookup_scb

Re: [PATCH] debloat aic7xxx and aic79xx drivers by deinlining

2007-08-28 Thread Denys Vlasenko
On Monday 27 August 2007 03:03, Adrian Bunk wrote: On Sun, Aug 26, 2007 at 04:21:30PM +0100, Denys Vlasenko wrote: On Saturday 25 August 2007 22:57, Arjan van de Ven wrote: ... Did you run the find static script or are you waiting for Adrian to do that ;-) $ find -name '*find

Re: [PATCH] debloat aic7xxx and aic79xx drivers by deinlining

2007-08-28 Thread Denys Vlasenko
On Tuesday 28 August 2007 16:17, Arjan van de Ven wrote: On Tue, 28 Aug 2007 12:56:34 +010 Denys Vlasenko [EMAIL PROTECTED] wrote: make namespacecheck Thanks, nice tool. aic7xxx is kind of not very nice in this regard. See below what I get even on non-patched driver. I am

[PATCH 0/3] debloat aic7xxx and aic79xx drivers

2007-08-31 Thread Denys Vlasenko
On Friday 31 August 2007 14:42, Hannes Reinecke wrote: Jan Engelhardt wrote: On Aug 30 2007 13:02, Matthew Wilcox wrote: Well, you can send it to Linus/Andrew, that will usually upset people and they start commenting on it. Or they don't, and everything is fine. (The default y approach so

[PATCH 1/3] debloat aic7xxx and aic79xx drivers

2007-08-31 Thread Denys Vlasenko
On Friday 31 August 2007 16:13, Denys Vlasenko wrote: Attached are three patches which fix that: textdata bss dec hex filename 261433 500181172 312623 4c52f linux-2.6.23-rc1.org.t/drivers/scsi/aic7xxx/built-in.o 199654 500181172 250844 3d3dc linux

[PATCH 2/3] debloat aic7xxx and aic79xx drivers

2007-08-31 Thread Denys Vlasenko
On Friday 31 August 2007 16:15, Denys Vlasenko wrote: On Friday 31 August 2007 16:13, Denys Vlasenko wrote: Attached are three patches which fix that: textdata bss dec hex filename 261433 500181172 312623 4c52f linux-2.6.23-rc1.org.t/drivers/scsi/aic7xxx

[PATCH 3/3] debloat aic7xxx and aic79xx drivers

2007-08-31 Thread Denys Vlasenko
On Friday 31 August 2007 16:16, Denys Vlasenko wrote: On Friday 31 August 2007 16:15, Denys Vlasenko wrote: On Friday 31 August 2007 16:13, Denys Vlasenko wrote: Attached are three patches which fix that: textdata bss dec hex filename 261433 500181172

Re: [PATCH 0/3] debloat aic7xxx and aic79xx drivers

2007-08-31 Thread Denys Vlasenko
On Friday 31 August 2007 17:27, [EMAIL PROTECTED] wrote: On Fri, 31 Aug 2007 16:13:59 BST, Denys Vlasenko said: textdata bss dec hex filename 261433 500181172 312623 4c52f linux-2.6.23-rc1.org.t/drivers/scsi/aic7xxx/built-in.o 199654 500181172

[PATCH] bfa: deinline __bfa_trc, wwn2str and fcid2str

2015-09-21 Thread Denys Vlasenko
8cdbfbe vmlinux Signed-off-by: Denys Vlasenko <dvlas...@redhat.com> CC: Krishna Gudipati <kgudi...@brocade.com> CC: Vijaya Mohan Guvva <vmo...@brocade.com> CC: Anil Gurumurthy <anil.gurumur...@qlogic.com> CC: James Bottomley <jbottom...@parallels.com> CC: Fabian Frede

[PATCH RESEND] bfa: deinline __bfa_trc() and __bfa_trc32()

2016-02-04 Thread Denys Vlasenko
is about 130,000 bytes: text data bss dec hex filename 85975426 22294712 20627456 128897594 7aed23a vmlinux.before 85842882 22294584 20627456 128764922 7accbfa vmlinux Signed-off-by: Denys Vlasenko <dvlas...@redhat.com> Acked-by: Anil Gurumurthy <anil.gurumur...@qlogi

[PATCH] drivers/scsi/fnic/fnic_scsi.c: Deinline fnic_queue_abort_io_req, save 1792 bytes

2016-04-08 Thread Denys Vlasenko
This function compiles to 511 bytes of machine code. Abort commands are not time-critical at all. Signed-off-by: Denys Vlasenko <dvlas...@redhat.com> CC: James Bottomley <james.bottom...@hansenpartnership.com> CC: Hiral Patel <hiral...@cisco.com> CC: Suma Ramars <sram...

Re: [PATCH] qla2xxx: rewrite code to avoid hitting gcc bug 70646

2016-04-15 Thread Denys Vlasenko
On 04/15/2016 04:40 PM, James Bottomley wrote: > On Fri, 2016-04-15 at 12:36 +0200, Denys Vlasenko wrote: >> More info here: >> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=70646 > > This bug is under investigation, so I'd rather not alter code for a gcc > bug until

Re: [PATCH] qla2xxx: rewrite code to avoid hitting gcc bug 70646

2016-04-15 Thread Denys Vlasenko
On 04/15/2016 09:05 PM, James Bottomley wrote: > On Fri, 2016-04-15 at 20:56 +0200, Denys Vlasenko wrote: >> On 04/15/2016 04:40 PM, James Bottomley wrote: >>> On Fri, 2016-04-15 at 12:36 +0200, Denys Vlasenko wrote: >>>> More info here: >>>> https://

[PATCH] qla2xxx: rewrite code to avoid hitting gcc bug 70646

2016-04-15 Thread Denys Vlasenko
More info here: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=70646 Signed-off-by: Denys Vlasenko <dvlas...@redhat.com> CC: Himanshu Madhani <himanshu.madh...@qlogic.com> CC: James Bottomley <james.bottom...@hansenpartnership.com> CC: qla2xxx-upstr...@qlogic.com CC: Jos

Re: This patch triggers a bad gcc bug (was Re: [PATCH] force inlining of some byteswap operations)

2016-04-14 Thread Denys Vlasenko
On 04/13/2016 07:10 PM, Josh Poimboeuf wrote: >> From the disassembly of drivers/scsi/qla2xxx/qla_attr.o: >> >> 2f53 : >> 2f53: 55 push %rbp >> 2f54: 48 89 e5mov%rsp,%rbp >> >> 2f57 :

[PATCH] scsi: aic7xxx: fix ahc_delay and ahd_delay

2016-10-14 Thread Denys Vlasenko
use all callers use values far from "pathological" ones, such as 500 and 1000 - these work fine with buggy code. This was reported in 2006 but was missed. Signed-off-by: Denys Vlasenko <dvlas...@redhat.com> CC: James Bottomley <jbottom...@parallels.com> CC: Hannes Reinicke