Re: [PATCH v2 07/38] cxlflash: Setup function acTag range

2018-03-22 Thread Frederic Barrat
onfiguration (only 1 function with AFU, all actags to that AFU), you could even have a warning if supported != enabled, to detect suspicious AFU images. Reviewed-by: Frederic Barrat <fbar...@linux.vnet.ibm.com> + ocxl_config_set_actag(pdev, fcfg->dvsec_function_pos, base, enabled); +

Re: [PATCH v2 16/38] cxlflash: MMIO map the AFU

2018-03-22 Thread Frederic Barrat
-by: Uma Krishnan <ukri...@linux.vnet.ibm.com> Acked-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com> --- Reviewed-by: Frederic Barrat <fbar...@linux.vnet.ibm.com> drivers/scsi/cxlflash/ocxl_hw.c | 74 - drivers/scsi/cxlflash/ocxl

Re: [PATCH v2 19/38] cxlflash: Support AFU state toggling

2018-03-22 Thread Frederic Barrat
- Reviewed-by: Frederic Barrat <fbar...@linux.vnet.ibm.com> drivers/scsi/cxlflash/ocxl_hw.c | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/scsi/cxlflash/ocxl_hw.c b/drivers/scsi/cxlflash/ocxl_hw.c index 67f0252..364e7a5 100644 --- a/drivers/scsi/cxlflash/ocxl_hw.c +++ b/dri

Re: [PATCH v2 06/38] cxlflash: Read host function configuration

2018-03-22 Thread Frederic Barrat
Acked-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com> --- Reviewed-by: Frederic Barrat <fbar...@linux.vnet.ibm.com> drivers/scsi/cxlflash/ocxl_hw.c | 41 + drivers/scsi/cxlflash/ocxl_hw.h | 2 ++ 2 files changed, 43 insertions(+) diff --

Re: [PATCH v2 11/38] cxlflash: Adapter context support for OCXL

2018-03-22 Thread Frederic Barrat
. To satisfy this requirement, one host adapter context is created when the hardware AFU is initialized. This is returned by the get_context() fop. Signed-off-by: Uma Krishnan <ukri...@linux.vnet.ibm.com> Acked-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com> --- Reviewed-by: Frederic

Re: [PATCH v2 08/38] cxlflash: Read host AFU configuration

2018-03-22 Thread Frederic Barrat
Le 26/02/2018 à 23:21, Uma Krishnan a écrit : The host AFU configuration is read on the initialization path to identify the features and configuration of the AFU. This data is cached for use in later configuration steps. Signed-off-by: Uma Krishnan Acked-by:

Re: [PATCH v2 10/38] cxlflash: Setup AFU PASID

2018-03-22 Thread Frederic Barrat
, the entire range is used. Signed-off-by: Uma Krishnan <ukri...@linux.vnet.ibm.com> Acked-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com> --- It sure helps to know you've got only one function/AFU :-) Reviewed-by: Frederic Barrat <fbar...@linux.vnet.ibm.com> drivers/scsi/cxlf

Re: [PATCH v2 12/38] cxlflash: Use IDR to manage adapter contexts

2018-03-22 Thread Frederic Barrat
Le 26/02/2018 à 23:21, Uma Krishnan a écrit : A range of PASIDs are used as identifiers for the adapter contexts. These contexts may be destroyed and created randomly. Use an IDR to keep track of contexts that are in use and assign a unique identifier to new ones. Signed-off-by: Uma Krishnan

Re: [PATCH v2 13/38] cxlflash: Support adapter file descriptors for OCXL

2018-03-22 Thread Frederic Barrat
Le 26/02/2018 à 23:21, Uma Krishnan a écrit : Allocate a file descriptor for an adapter context when requested. In order to allocate inodes for the file descriptors, a pseudo filesystem is created and used. Signed-off-by: Uma Krishnan Acked-by: Matthew R. Ochs

Re: [PATCH v2 09/38] cxlflash: Setup AFU acTag range

2018-03-22 Thread Frederic Barrat
to the AFU. Signed-off-by: Uma Krishnan <ukri...@linux.vnet.ibm.com> Acked-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com> --- Reviewed-by: Frederic Barrat <fbar...@linux.vnet.ibm.com> drivers/scsi/cxlflash/ocxl_hw.c | 13 + drivers/scsi/cxlflash/ocxl_hw.h | 2 ++

Re: [PATCH v2 21/38] cxlflash: Setup function OCXL link

2018-03-22 Thread Frederic Barrat
. Ochs <mro...@linux.vnet.ibm.com> --- Reviewed-by: Frederic Barrat <fbar...@linux.vnet.ibm.com> drivers/scsi/cxlflash/ocxl_hw.c | 25 ++--- drivers/scsi/cxlflash/ocxl_hw.h | 1 + 2 files changed, 23 insertions(+), 3 deletions(-) diff --git a/drivers/scsi/

Re: [PATCH v2 08/38] cxlflash: Read host AFU configuration

2018-03-22 Thread Frederic Barrat
Acked-by: Matthew R. Ochs <mro...@linux.vnet.ibm.com> --- Reviewed-by: Frederic Barrat <fbar...@linux.vnet.ibm.com> drivers/scsi/cxlflash/ocxl_hw.c | 34 ++ drivers/scsi/cxlflash/ocxl_hw.h | 1 + 2 files changed, 35 insertions(+) diff --git a/dri