Re: Backport of a fix for HPSA (Disabling a disabled device problem during kdump) driver

2015-04-26 Thread Greg KH
On Mon, Apr 13, 2015 at 03:18:44PM +0200, Tomas Henzl wrote: > On 04/11/2015 12:45 AM, Vinson Lee wrote: > > On Tue, Jan 27, 2015 at 4:18 PM, Greg KH wrote: > >> On Tue, Jan 06, 2015 at 05:15:19PM +0100, Tomas Henzl wrote: > >>> On 01/05/2015 07:41 PM, Masoud Sharb

Re: Backport of a fix for HPSA (Disabling a disabled device problem during kdump) driver

2015-04-27 Thread Greg KH
On Mon, Apr 27, 2015 at 02:17:32PM +0200, Tomas Henzl wrote: > On 04/26/2015 11:27 AM, Greg KH wrote: > > On Mon, Apr 13, 2015 at 03:18:44PM +0200, Tomas Henzl wrote: > >> On 04/11/2015 12:45 AM, Vinson Lee wrote: > >>> On Tue, Jan 27, 2015 at 4:18 PM, Greg KH wrot

Re: [PATCH] st: convert to using driver attr groups for sysfs

2015-06-23 Thread Greg KH
On Tue, Jun 23, 2015 at 08:11:00AM +, Seymour, Shane M wrote: > This patch changes the st driver to use attribute groups so > driver sysfs files are created automatically. See the > following for reference: > > http://kroah.com/log/blog/2013/06/26/how-to-create-a-sysfs-file-correctly/ > > Sig

Re: Backport of a fix for HPSA (Disabling a disabled device problem during kdump) driver

2015-06-29 Thread Greg KH
On Fri, May 22, 2015 at 12:19:16PM -0700, Vinson Lee wrote: > On Sat, May 2, 2015 at 10:56 AM, Greg KH wrote: > > On Mon, Apr 27, 2015 at 03:10:35PM +0200, Tomas Henzl wrote: > >> On 04/27/2015 02:55 PM, Greg KH wrote: > >> > On Mon, Apr 27, 2015 at 02:17:32PM +0200,

Re: [PATCH] hpsa: convert DEVICE_ATTR to RO|WO|RW and show methods must use scnprintf

2015-06-30 Thread Greg KH
On Tue, Jun 30, 2015 at 05:22:20AM +, Seymour, Shane M wrote: > > Changed DEVICE_ATTR macro usage to DEVICE_ATTR_RO|WO|RW. > This also forced some show/store function names to change. > > Changed all show method sprint/snprintf usage to scnprintf per > Documentation/filesystems/sysfs.txt. Th

Re: [PATCH v2] hpsa: convert DEVICE_ATTR to RO|WO|RW and show methods must not use snprintf

2015-06-30 Thread Greg KH
On Wed, Jul 01, 2015 at 01:56:03AM +, Seymour, Shane M wrote: > > Changed DEVICE_ATTR macro usage to DEVICE_ATTR_RO|WO|RW. > This also forced some show/store function names to change. > > Changed all show method snprintf() usage to scnprintf() per > Documentation/filesystems/sysfs.txt. Forgo

Re: [PATCH v1 1/3] Synchronization of cmds during termination conditions

2016-10-11 Thread Greg KH
On Tue, Oct 11, 2016 at 05:58:03PM -0500, Michael Cyr wrote: > Signed-off-by: Michael Cyr I almost never accept patches with no changelog information. For a patch that changes 1082 lines in a non-trivial way, you would think that you could explain why you are doing this work... Also, check the

Re: [PATCH v2 6/7] megaraid_sas: Do not set MPI2_TYPE_CUDA for JBOD FP path for FW which does not support JBOD sequence map

2016-10-20 Thread Greg KH
On Thu, Oct 20, 2016 at 02:05:04AM -0700, Sumit Saxena wrote: > CC: sta...@vger.kernel.org > Signed-off-by: Sumit Saxena > Reviewed-by: Hannes Reinecke > Reviewed-by: Tomas Henzl > --- > drivers/scsi/megaraid/megaraid_sas_fusion.c | 8 > 1 file changed, 4 insertions(+), 4 deletions(-)

Re: [PATCH] Avoid that SCSI device removal through sysfs triggers a deadlock

2016-11-07 Thread Greg KH
On Mon, Nov 07, 2016 at 04:32:18PM -0800, Bart Van Assche wrote: > The SCSI core holds scan_mutex around SCSI device addition and > removal operations. sysfs serializes attribute read and write > operations against attribute removal through s_active. Avoid that > grabbing scan_mutex during self-rem

Re: [PATCH] [SCSI] mpt3sas: Fix secure erase premature termination (v3)

2016-11-10 Thread Greg KH
On Thu, Nov 10, 2016 at 08:42:52AM -0500, Andrey Grodzovsky wrote: > Problem: > This is a work around for a bug with LSI Fusion MPT SAS2 when > pefroming secure erase. Due to the very long time the operation > takes commands issued during the erase will time out and will trigger > execution of abor

Re: [PATCH] mpt2sas: Fix secure erase premature termination.

2016-11-18 Thread Greg KH
On Fri, Nov 18, 2016 at 05:12:49PM +0530, Suganath Prabu S wrote: > Problem: > This is a work around for a bug with LSI Fusion MPT SAS2 when > pefroming secure erase. Due to the very long time the operation > takes commands issued during the erase will time out and will trigger > execution of abort

Re: [PATCH] mpt2sas: Fix secure erase premature termination.

2016-11-21 Thread Greg KH
On Mon, Nov 21, 2016 at 03:05:38PM +0530, Suganath Prabu Subramani wrote: > Commit id and other details are given below: > > commit 18f6084a989ba1b38702f9af37a2e4049a924be6 > Author: Andrey Grodzovsky > Date:   Thu Nov 10 09:35:27 2016 -0500 > >     scsi: mpt3sas: Fix secure erase premature term

Re: Samsung SSD 1.92TB PM863 Enterprise 2.5" SATA3 errors withc stable 4.4.34

2016-12-14 Thread Greg KH
On Wed, Dec 14, 2016 at 03:07:48PM +0300, Vasiliy Tolstov wrote: > Hi! I have stable problems with all Samsung SSD drivers like PM863 and > EVO 850 Pro. > > Time after time scsi bus reset link with messages: > [ 2477.973617] ata1: exception Emask 0x50 SAct 0x0 SErr 0x4090800 > action 0xe frozen >

Re: [PATCH] ibmvscsis: Fix srp_transfer_data fail return code

2017-01-09 Thread Greg KH
On Mon, Jan 09, 2017 at 10:21:20AM -0600, Bryant G. Ly wrote: > From: "Bryant G. Ly" > > If srp_transfer_data fails within ibmvscsis_write_pending, then > the most likely scenario is that the client timed out the op and > removed the TCE mapping. Thus it will loop forever retrying the > op that i

Re: [PATCH] ibmvscsis: Fix srp_transfer_data fail return code

2017-01-09 Thread Greg KH
On Mon, Jan 09, 2017 at 11:23:23AM -0600, Bryant G. Ly wrote: > On 1/9/17 10:47 AM, Greg KH wrote: > > > On Mon, Jan 09, 2017 at 10:21:20AM -0600, Bryant G. Ly wrote: > > > From: "Bryant G. Ly" > > > > > > If srp_transfer_data fails within ib

Re: [PATCH] drivers: block: Remove unnecessary cast

2017-01-11 Thread Greg KH
On Wed, Jan 11, 2017 at 12:41:05PM -0600, Gustavo A. R. Silva wrote: > This issue was detected using Coccinelle and the following semantic patch: > > @@ > expression * e; > expression arg1, arg2; > type T; > @@ > > - e = (T *) > + e = > kmalloc(arg1, arg2); > > Signed-off-by: Gustavo A. R. Silva

Re: [PATCH v3 01/16] lpfc: Correct WQ creation for pagesize

2017-03-07 Thread Greg KH
On Tue, Mar 07, 2017 at 10:44:51AM -0300, Mauricio Faria de Oliveira wrote: > Hello stable kernel maintainers, > > On 03/07/2017 12:35 AM, Martin K. Petersen wrote: > > Mauricio> Please flag this patch for stable. > > > > Mauricio> This patch resolves a serious problem on IBM Power systems at > >

Re: [PATCH 0/25] Replace DEFINE_PCI_DEVICE_TABLE macro use

2014-07-18 Thread Greg KH
On Fri, Jul 18, 2014 at 12:22:13PM -0400, John W. Linville wrote: > On Fri, Jul 18, 2014 at 05:26:47PM +0200, Benoit Taine wrote: > > We should prefer `const struct pci_device_id` over > > `DEFINE_PCI_DEVICE_TABLE` to meet kernel coding style guidelines. > > This issue was reported by checkpatch. >

Re: [PATCH 0/25] Replace DEFINE_PCI_DEVICE_TABLE macro use

2014-07-18 Thread Greg KH
On Fri, Jul 18, 2014 at 09:54:32AM -0700, James Bottomley wrote: > On Fri, 2014-07-18 at 09:43 -0700, Greg KH wrote: > > On Fri, Jul 18, 2014 at 12:22:13PM -0400, John W. Linville wrote: > > > On Fri, Jul 18, 2014 at 05:26:47PM +0200, Benoit Taine wrote: > > > >

Re: [PATCH v2 2/4] driver core: enable drivers to use deferred probe from init

2014-07-28 Thread Greg KH
On Mon, Jul 28, 2014 at 11:28:28AM -0700, Luis R. Rodriguez wrote: > From: "Luis R. Rodriguez" > > Tetsuo bisected and found that commit 786235ee "kthread: make > kthread_create() killable" modified kthread_create() to bail as > soon as SIGKILL is received. This is causing some issues with > some

Re: [PATCH v2 2/4] driver core: enable drivers to use deferred probe from init

2014-07-28 Thread Greg KH
On Mon, Jul 28, 2014 at 12:48:32PM -0700, Luis R. Rodriguez wrote: > On Mon, Jul 28, 2014 at 12:04 PM, Luis R. Rodriguez > wrote: > > On Mon, Jul 28, 2014 at 11:55 AM, Greg KH > > wrote: > >> So, what drivers are having problems in their init sequence, and why &

Re: [PATCH v2 2/4] driver core: enable drivers to use deferred probe from init

2014-07-28 Thread Greg KH
On Mon, Jul 28, 2014 at 05:26:34PM -0700, Luis R. Rodriguez wrote: > On Mon, Jul 28, 2014 at 4:46 PM, Greg KH wrote: > > On Mon, Jul 28, 2014 at 12:48:32PM -0700, Luis R. Rodriguez wrote: > >> On Mon, Jul 28, 2014 at 12:04 PM, Luis R. Rodriguez > >> wrote: > >>

Re: [PATCH v2 2/4] driver core: enable drivers to use deferred probe from init

2014-07-29 Thread Greg KH
On Mon, Jul 28, 2014 at 06:13:43PM -0700, Luis R. Rodriguez wrote: > >> > Why not just put the initial "register the device" in a single-shot > >> > workqueue or thread or something like that so that modprobe returns > >> > instantly back with a success and all is fine? > >> > >> That surely is pos

Re: [PATCH v2 2/4] driver core: enable drivers to use deferred probe from init

2014-07-29 Thread Greg KH
On Wed, Jul 30, 2014 at 02:05:41AM +0200, Luis R. Rodriguez wrote: > On Tue, Jul 29, 2014 at 04:14:22PM -0700, Greg KH wrote: > > On Mon, Jul 28, 2014 at 06:13:43PM -0700, Luis R. Rodriguez wrote: > > > >> > Why not just put the initial "register the device"

Re: [PATCH v2 2/4] driver core: enable drivers to use deferred probe from init

2014-08-10 Thread Greg KH
e you'll be notified this happen upon init for each > > > device but now with a message such as: > > > > > > pci :03:00.0: Driver cxgb4 requests probe deferral on init > > > > > > You should see one of these per struct device probed. > > &g

Re: [PATCH] uas: replace WARN_ON_ONCE() with assert_spin_locked().

2014-08-11 Thread Greg KH
On Mon, Aug 11, 2014 at 01:29:26PM +0530, Sanjeev Sharma wrote: > spin_is_locked() always return false in uniprocessor configuration Really? On what processor type? I don't see that being the case on a few processors, but I didn't check them all, or I might be totally confused with all of the ar

Re: [PATCH] uas: replace WARN_ON_ONCE() with assert_spin_locked().

2014-08-11 Thread Greg KH
On Mon, Aug 11, 2014 at 11:56:17AM +, Sharma, Sanjeev wrote: > Hi Greg, > > Please find my comment in line. As it should, but where is it, your quoting is all messed up... > -Original Message----- > From: Greg KH [mailto:gre...@linuxfoundation.org] > Sent: Monday, Au

Re: [PATCH v2] uas: replace WARN_ON_ONCE() with lockdep_assert_held()

2014-08-11 Thread Greg KH
On Tue, Aug 12, 2014 at 11:38:37AM +0530, Sanjeev Sharma wrote: > spin_is_locked() always return false in uniprocessor configuration and > therefore it > would be advise to replace with lockdep_assert_held(). Add "on some architectures" in here somewhere, as it's not broken on the large majority

Re: [PATCH v3 1/3] init / kthread: add module_long_probe_init() and module_long_probe_exit()

2014-08-12 Thread Greg KH
On Wed, Aug 13, 2014 at 07:59:06AM +0900, Tetsuo Handa wrote: > Luis R. Rodriguez wrote: > > Tetsuo bisected and found that commit 786235ee \"kthread: make > > kthread_create() killable\" modified kthread_create() to bail as > > soon as SIGKILL is received. > > I just wrote commit 786235ee. It is

Re: [PATCH v1 5/5] driver-core: add driver asynchronous probe support

2014-09-29 Thread Greg KH
On Mon, Sep 29, 2014 at 11:22:08PM +0200, Luis R. Rodriguez wrote: > On Sun, Sep 28, 2014 at 11:03:29AM -0400, Tejun Heo wrote: > > Hello, > > > > On Fri, Sep 26, 2014 at 02:57:17PM -0700, Luis R. Rodriguez wrote: > > ... > > > Systemd should consider enabling async probe on device drivers > > > i

Re: [PATCH v1 5/5] driver-core: add driver asynchronous probe support

2014-09-29 Thread Greg KH
On Mon, Sep 29, 2014 at 03:10:22PM -0700, Luis R. Rodriguez wrote: > On Mon, Sep 29, 2014 at 2:59 PM, Greg KH wrote: > >> Sure make sense, I wasn't quite sure how to make this quite clear, > >> a naming convention seems good to me but I also had added at least > >

Re: [PATCH v7] scsi: ufs: add ioctl interface for query request

2016-03-09 Thread Greg KH
On Wed, Mar 09, 2016 at 04:11:33PM +0200, Yaniv Gardi wrote: > This patch exposes the ioctl interface for UFS driver via SCSI device > ioctl interface. As of now UFS driver would provide the ioctl for query > interface to connected UFS device. > > Reviewed-by: Subhash Jadavani > Signed-off-by: Do

Re: [PATCH v7] scsi: ufs: add ioctl interface for query request

2016-03-09 Thread Greg KH
On Wed, Mar 09, 2016 at 07:09:49PM -, yga...@codeaurora.org wrote: > > On Wed, Mar 09, 2016 at 04:11:33PM +0200, Yaniv Gardi wrote: > >> This patch exposes the ioctl interface for UFS driver via SCSI device > >> ioctl interface. As of now UFS driver would provide the ioctl for query > >> interf

Re: [PATCH v7] scsi: ufs: add ioctl interface for query request

2016-03-09 Thread Greg KH
On Wed, Mar 09, 2016 at 08:52:59PM -, yga...@codeaurora.org wrote: > > On Wed, Mar 09, 2016 at 07:09:49PM -, yga...@codeaurora.org wrote: > >> > On Wed, Mar 09, 2016 at 04:11:33PM +0200, Yaniv Gardi wrote: > >> >> This patch exposes the ioctl interface for UFS driver via SCSI device > >> >>

Re: [PATCH v7] scsi: ufs: add ioctl interface for query request

2016-03-10 Thread Greg KH
On Thu, Mar 10, 2016 at 03:52:54PM -, yga...@codeaurora.org wrote: > > On Wed, Mar 09, 2016 at 08:52:59PM -, yga...@codeaurora.org wrote: > >> > On Wed, Mar 09, 2016 at 07:09:49PM -, yga...@codeaurora.org wrote: > >> >> > On Wed, Mar 09, 2016 at 04:11:33PM +0200, Yaniv Gardi wrote: > >>

Re: [PATCH v7] scsi: ufs: add ioctl interface for query request

2016-03-10 Thread Greg KH
On Thu, Mar 10, 2016 at 04:29:55PM -, yga...@codeaurora.org wrote: > > On Thu, Mar 10, 2016 at 03:52:54PM -, yga...@codeaurora.org wrote: > >> > On Wed, Mar 09, 2016 at 08:52:59PM -, yga...@codeaurora.org wrote: > >> >> > On Wed, Mar 09, 2016 at 07:09:49PM -, yga...@codeaurora.org >

Re: [PATCH v7] scsi: ufs: add ioctl interface for query request

2016-03-10 Thread Greg KH
On Thu, Mar 10, 2016 at 06:48:54PM -, yga...@codeaurora.org wrote: > > On Thu, Mar 10, 2016 at 04:29:55PM -, yga...@codeaurora.org wrote: > >> > On Thu, Mar 10, 2016 at 03:52:54PM -, yga...@codeaurora.org wrote: > >> >> > On Wed, Mar 09, 2016 at 08:52:59PM -, yga...@codeaurora.org >

Re: [PATCH] csiostor: Fix backwards locking in the function __csio_unreg_rnode

2016-04-06 Thread Greg KH
On Wed, Apr 06, 2016 at 01:28:24PM -0400, James Bottomley wrote: > On Wed, 2016-04-06 at 13:23 -0400, Bastien Philbert wrote: > > > > On 2016-04-06 01:14 PM, James Bottomley wrote: > > > On Wed, 2016-04-06 at 10:36 -0400, Bastien Philbert wrote: > > > > > > > > On 2016-04-06 10:24 AM, James Botto

Re: [PATCH 0/4] Decouple X86_32 dependency from the ISA Kconfig option

2016-04-13 Thread Greg KH
On Wed, Apr 13, 2016 at 10:48:42AM -0400, William Breathitt Gray wrote: > On Wed, Apr 13, 2016 at 04:38:38PM +0200, Ingo Molnar wrote: > >Ah, ok, so it's for enabling real hardware, not just a cleanup, right? You > >might > >want to put that info into the boilerplate mail or so. > > > >I'm perfec

Re: raid 5 creation fails on usb3 connected drives kernel 4.4.x, 4.5

2016-04-16 Thread Greg KH
On Sat, Apr 09, 2016 at 08:18:26PM +1000, Brian Chadwick wrote: > On 09/04/16 00:24, Greg KH wrote: > > On Fri, Apr 08, 2016 at 07:37:12PM +1000, Brian Chadwick wrote: > > > On 08/04/16 01:59, Greg KH wrote: > > > > On Fri, Apr 08, 2016 at 01:34:51AM +1000, Brian Chad

Re: raid 5 creation fails on usb3 connected drives kernel 4.4.x, 4.5

2016-04-16 Thread Greg KH
On Sat, Apr 16, 2016 at 09:25:13AM -0700, James Bottomley wrote: > On Sat, 2016-04-16 at 09:08 -0700, Greg KH wrote: > > On Sat, Apr 09, 2016 at 08:18:26PM +1000, Brian Chadwick wrote: > > > On 09/04/16 00:24, Greg KH wrote: > > > > On Fri, Apr 08, 2016 at 07:37:12

Re: raid 5 creation fails on usb3 connected drives kernel 4.4.x, 4.5

2016-04-16 Thread Greg KH
On Sun, Apr 17, 2016 at 02:41:51PM +1000, Brian Chadwick wrote: > On 17/04/16 02:46, Greg KH wrote: > > On Sat, Apr 16, 2016 at 09:25:13AM -0700, James Bottomley wrote: > > > On Sat, 2016-04-16 at 09:08 -0700, Greg KH wrote: > > > > On Sat, Apr 09, 2016 at 08:18:26

Re: [PATCH 0/4] Decouple X86_32 dependency from the ISA Kconfig option

2016-05-01 Thread Greg KH
On Sun, May 01, 2016 at 12:17:07PM -0400, William Breathitt Gray wrote: > On Wed, Apr 13, 2016 at 08:18:26AM -0700, Greg KH wrote: > >On Wed, Apr 13, 2016 at 10:48:42AM -0400, William Breathitt Gray wrote: > >> On Wed, Apr 13, 2016 at 04:38:38PM +0200, Ingo Molnar wrote: > &g

Re: [PATCH 1/1] uas: leave can_queue as MAX_CMNDS if device reports larger qdepth

2016-05-23 Thread Greg KH
On Tue, May 24, 2016 at 12:02:43AM +0800, tom.t...@gmail.com wrote: > From: Tom Yan > > Commit 198de51dbc34 ("USB: uas: Limit qdepth at the scsi-host level") made > qdepth limit set in host template (`.can_queue = MAX_CMNDS`) useless. > > Instead of removing the template limit, now we only chang

Re: [PATCH] ibmvscsis: Initial commit of IBM VSCSI Tgt Driver

2016-05-24 Thread Greg KH
On Tue, May 24, 2016 at 08:52:58AM -0500, Bryant G. Ly wrote: > From: bgly Really? Please go get a proper review from the other internal IBM developers to fix this, and the other obvious problems with your patch, before you send it publically and force us to tell you these things... thanks, gr

Re: [PATCH] ibmvscsis: Initial commit of IBM VSCSI Tgt Driver

2016-05-24 Thread Greg KH
On Tue, May 24, 2016 at 09:25:05AM -0700, Bart Van Assche wrote: > > +static inline long h_send_crq(struct ibmvscsis_adapter *adapter, > > + u64 word1, u64 word2) > > +{ > > + long rc; > > + struct vio_dev *vdev = adapter->dma_dev; > > + > > + pr_debug("ibmvscsis: ibmvscsis_

Re: [PATCH] ibmvscsis: Initial commit of IBM VSCSI Tgt Driver

2016-05-24 Thread Greg KH
On Tue, May 24, 2016 at 09:44:43AM -0700, Bart Van Assche wrote: > On 05/24/2016 09:34 AM, Greg KH wrote: > > On Tue, May 24, 2016 at 09:25:05AM -0700, Bart Van Assche wrote: > > > > +static inline long h_send_crq(struct ibmvscsis_adapter *adapter, > > > > +

Re: [PATCH v3 2/2] Documentation/scsi: update scsi_eh.txt about ->host_failed

2016-06-02 Thread Greg KH
On Thu, Jun 02, 2016 at 04:42:38PM +0800, Wei Fang wrote: > Update the new rules of ->host_failed. > > Signed-off-by: Wei Fang > --- > Documentation/scsi/scsi_eh.txt |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) This is not the correct way to submit patches for inclusion in t

Re: [PATCH v3 1/2] scsi: fix race between simultaneous decrements of ->host_failed

2016-06-02 Thread Greg KH
On Thu, Jun 02, 2016 at 04:42:37PM +0800, Wei Fang wrote: > sas_ata_strategy_handler() adds the works of the ata error handler > to system_unbound_wq. This workqueue asynchronously runs work items, > so the ata error handler will be performed concurrently on different > CPUs. In this case, ->host_f

Re: [Ksummit-2013-discuss] [ATTEND] scsi-mq prototype discussion

2013-07-11 Thread Greg KH
On Thu, Jul 11, 2013 at 05:23:32PM -0700, Nicholas A. Bellinger wrote: > Drilling down the work items ahead of a real mainline push is high on > priority list for discussion. > > The parties to be included in such a discussion are: > > - Jens Axboe (blk-mq author) > - James Bottomley (scsi ma

Re: [PATCH 2/2] qla2xxx: Properly set the tagging for commands.

2013-07-19 Thread Greg KH
On Fri, Jul 19, 2013 at 09:16:51AM +, Saurav Kashyap wrote: > This should go to stable also, added in to list. This fixes a BZ > https://bugzilla.kernel.org/show_bug.cgi?id=59601 > > Thanks, > ~Saurav > > > -Original Message- > From: Saurav Kashyap [mailto:saurav.kash...@qlogic.com]

Re: [PATCH] scsi disk: Use its own buffer for the vpd request

2013-08-30 Thread Greg KH
On Fri, Aug 30, 2013 at 11:01:56AM +0100, Nix wrote: > On 1 Aug 2013, Bernd Schubert said: > > > Once I noticed that scsi_get_vpd_page() works fine from other function > > calls and that it is not 0x89, but already 0x0 that fails fixing it became > > easy. > > > > Nix, any chance you could verify

Re: Drivers: scsi: FLUSH timeout

2013-09-20 Thread Greg KH
On Fri, Sep 20, 2013 at 12:32:27PM -0700, K. Y. Srinivasan wrote: > The SD_FLUSH_TIMEOUT value is currently hardcoded. Hardcoded where? Please, more context. > On our cloud, we sometimes hit this timeout. I was wondering if we > could make this a module parameter. If this is acceptable, I can se

Re: [PATCH RFC 04/77] PCI/MSI/s390: Remove superfluous check of MSI type

2013-10-02 Thread Greg KH
On Wed, Oct 02, 2013 at 12:48:20PM +0200, Alexander Gordeev wrote: > arch_setup_msi_irqs() hook can only be called from the generic > MSI code which ensures correct MSI type parameter. > > Signed-off-by: Alexander Gordeev > --- > arch/s390/pci/pci.c |2 -- > 1 files changed, 0 insertions(+),

Re: Backport of a fix for HPSA (Disabling a disabled device problem during kdump) driver

2015-01-27 Thread Greg KH
On Tue, Jan 06, 2015 at 05:15:19PM +0100, Tomas Henzl wrote: > On 01/05/2015 07:41 PM, Masoud Sharbiani wrote: > > Dear stable maintainers, > > Can you please backport commitid 132aa220b45d60e9b20def1e9d8be9422eed9616 > > (hpsa: refine the pci enable/disable handling) to 3.10 stable (and > > earli

Re: [RFC] implementing tape statistics single file vs multi-file in sysfs

2015-02-06 Thread Greg KH
On Fri, Feb 06, 2015 at 12:20:53AM +, Seymour, Shane M wrote: > Hello linux-api'ers > > There has been some ongoing discussion about the best way to implement tape > statistics. The original method suggested a long time ago used a single file > in sysfs similar to block statistics in sysfs.

Re: [RFC] implementing tape statistics single file vs multi-file in sysfs

2015-02-06 Thread Greg KH
On Fri, Feb 06, 2015 at 09:13:55AM +, Bryn M. Reeves wrote: > > The sysfs documentation says that files should contain one item per > > file (with some small exceptions): > > > > > "Attributes should be ASCII text files, preferably with only one value > > > per file. It is noted that it may no

Re: [RFC] implementing tape statistics single file vs multi-file in sysfs

2015-02-07 Thread Greg KH
On Fri, Feb 06, 2015 at 03:41:58PM +, Bryn M. Reeves wrote: > On Fri, Feb 06, 2015 at 04:59:16AM -0800, Greg KH wrote: > > On Fri, Feb 06, 2015 at 12:20:53AM +, Seymour, Shane M wrote: > > > The current patch that implements tape statistics is here: > > > >

Re: [RFC] implementing tape statistics single file vs multi-file in sysfs

2015-02-07 Thread Greg KH
On Sat, Feb 07, 2015 at 09:27:05PM -0500, Laurence Oberman wrote: > Hello > Its not going to be tens of thousands of devices. That count was an > aggregate based on 1000's of servers. > In reality its unlikely to ever be more than 100 tapes drives per > individual Linux kernel instance. > Therefore

Re: [PATCH] st implement tape statistics v3

2015-02-09 Thread Greg KH
On Mon, Feb 09, 2015 at 06:01:39AM +, Seymour, Shane M wrote: > Hi All, > > Please find attached v3 of the patch. It implements the changes requested by > Greg. The statistics files aren't in a separate directory any more they're > implemented directly as device attributes unless someone has

Re: [PATCH] st implement tape statistics v3 (updated patch)

2015-02-09 Thread Greg KH
On Mon, Feb 09, 2015 at 11:56:25AM +, Seymour, Shane M wrote: > Hi Greg, > > Thank you for pushing me to go that little further. The statistics directory > is back. Any feedback from anyone would be appreciated. > > Thanks > Shane > -- > > Signed-off-by: shane.seym...@hp.com > Tested-by: sh

Re: [PATCH RESEND] st implement tape statistics v3

2015-02-09 Thread Greg KH
Comment about your subject: the "v3" needs to go inside the [] And you need to put below the --- line what has changed from the last version, I don't see any of my comments address here :( On Mon, Feb 09, 2015 at 10:41:38PM +, Seymour, Shane M wrote: > The following patch exposes statistics f

Re: [RFC] implementing tape statistics single file vs multi-file in sysfs

2015-02-10 Thread Greg KH
On Tue, Feb 10, 2015 at 02:27:20PM +, Bryn M. Reeves wrote: > On Sat, Feb 07, 2015 at 12:07:43PM +0800, Greg KH wrote: > > $ cat /sys/fs/selinux/avc/cache_stats > lookups hits misses allocations reclaims frees > 18938916 18921707 17209 17209 17328 22215 > 38164283 38146514

Re: linux-next: build failure after merge of the scsi tree

2013-01-11 Thread Greg KH
On Fri, Jan 11, 2013 at 03:37:17PM +, James Bottomley wrote: > On Fri, 2013-01-11 at 09:27 -0600, Brian King wrote: > > It looks like this was a due to the fact that the new patches > > added __devinit tags in the same merge window the __devinit tag > > itself was getting removed. > > Not exac

Re: [PATCH 2/8] [SCSI] mpt2sas : Fix for issue Missing delay not getting set during system bootup

2013-01-31 Thread Greg KH
On Fri, Feb 01, 2013 at 09:52:40PM +0530, Sreekanth Reddy wrote: > Missing delay is not getting set properly. The reason is it is not defined in > the same file from where it is being invoked. > > The fix is to move the missing delay module parameter from mpt2sas_base.c to > mpt2sas_scsh.c. > >

Re: [PATCH 5/8] [SCSI] mpt2sas : Fix for device scan following host reset could get stuck in a infinite loop

2013-01-31 Thread Greg KH
On Fri, Feb 01, 2013 at 09:58:30PM +0530, Sreekanth Reddy wrote: > Modified device scan routine so each configuration page read breaks from the > while loop > when the ioc_status is not equal to MPI2_IOCSTATUS_SUCCESS. > > Signed-off-by: Sreekanth Reddy > --- > This is not the correct way to

Re: [PATCH 6/8] [SCSI] mpt2sas : When SCSI command is received with task atrribute not set, set it to SIMPLE

2013-01-31 Thread Greg KH
On Fri, Feb 01, 2013 at 10:00:26PM +0530, Sreekanth Reddy wrote: > When SCSI command is received with task attribute not set, set it to SIMPLE. > Previously it is set to untagged. This causes the firmware to fail the > commands. > > Signed-off-by: Sreekanth Reddy > --- > This is not the corr

Re: SYSFS "errors"

2013-02-18 Thread Greg KH
On Mon, Feb 18, 2013 at 06:47:42PM -0300, Mauro Carvalho Chehab wrote: > In the past, the sysfs node creation was done using the raw sysfs support. > Doing dynamic creation with the old code were much more complex. I guess > that's the reason why the code was written this way. Now that the code >

Re: SYSFS "errors"

2013-02-18 Thread Greg KH
On Mon, Feb 18, 2013 at 11:13:06PM +0100, Borislav Petkov wrote: > On Mon, Feb 18, 2013 at 01:54:34PM -0800, Greg KH wrote: > > Because sysfs is "one value per file" the lack of a file showing up > > shouldn't cause any userspace tools any problems, that is

Re: [PATCH 2/3] PCI: Handle device quirks when accessing sysfs resource entries

2013-03-21 Thread Greg KH
On Thu, Mar 21, 2013 at 06:51:31PM -0600, Robert Hancock wrote: > On 03/20/2013 10:35 PM, Myron Stowe wrote: > >Sysfs includes entries to memory regions that back a PCI device's BARs. > >The pci-sysfs entries backing I/O Port BARs can be accessed by userspace, > >providing direct access to the devi

Re: [OT] LDD3 Query

2013-04-05 Thread Greg KH
On Fri, Apr 05, 2013 at 12:17:54PM +0530, Vijay Chauhan wrote: > Hi, > > I am new to Linux Device Driver and reading LDD3. > > It mentions that the disadvantage of dynamic major number allocation > is that you can’t create the device nodes in > advance, because the major number assigned to your m

[PATCH 01/02] drivers/scsi: use module_pcmcia_driver() in pcmcia drivers

2013-04-16 Thread Greg KH
From: H Hartley Sweeten Use the new module_pcmcia_driver() macro to remove the boilerplate module init/exit code in the pcmcia drivers. Signed-off-by: H Hartley Sweeten Signed-off-by: Greg Kroah-Hartman --- Note, this needs the module_pcmcia_driver() macro, which is in my char-misc-next branc

Re: [PATCH 10/28] proc: Add proc_mkdir_data() [RFC]

2013-04-16 Thread Greg KH
On Tue, Apr 16, 2013 at 07:26:30PM +0100, David Howells wrote: > Add proc_mkdir_data() to allow procfs directories to be created that are > annotated at the time of creation with private data rather than doing this > post-creation. This means no access is then required to the proc_dir_entry > stru

Re: [PATCH 14/28] proc: Supply an accessor for getting the data from a PDE's parent [RFC]

2013-04-16 Thread Greg KH
On Tue, Apr 16, 2013 at 07:26:46PM +0100, David Howells wrote: > Supply an accessor function for getting the private data from the parent > proc_dir_entry struct of the proc_dir_entry struct associated with an inode. > > ReiserFS, for instance, stores the super_block pointer in the proc directory

Re: [PATCH RESEND^2] sd: fix infinite kernel/udev loop on non-removable Medium Not Present

2013-04-26 Thread Greg KH
On Fri, Apr 26, 2013 at 11:39:33AM -0500, Steven J. Magnani wrote: > Commit eface65c336eff420d70beb0fb6787a732e05ffb (2.6.38) altered > set_media_not_present() in a way that prevents the sd driver from > remembering that a non-removable device has reported "Medium Not Present". > This condition can

Re: [PATCH 0/6] Drivers: hv/scsi: Implement multi-channel support

2013-05-15 Thread Greg KH
On Wed, May 15, 2013 at 03:02:00PM -0700, K. Y. Srinivasan wrote: > This patch-set implements multi-channel support for Hyper-V devices. Also > support for synthetic Fiber Channel device is included. The first two > patches in the series are the foundational pieces for the remaining patches. > > J

Re: [PATCH 1/6] Drivers: hv: vmbus: Implement multi-channel support

2013-05-15 Thread Greg KH
On Wed, May 15, 2013 at 03:02:29PM -0700, K. Y. Srinivasan wrote: > +/* > + * Retrieve the (sub) channel on which to send an outgoing request. > + * When a primary channel has multiple sub-channels, we choose a > + * channel whose VCPU binding is closest to the VCPU on which > + * this call is bein

Re: [PATCH 2/6] Drivers: hv: Add the GUID fot synthetic fiber channel device

2013-05-15 Thread Greg KH
On Wed, May 15, 2013 at 03:02:30PM -0700, K. Y. Srinivasan wrote: > In preparation for supporting synthetic Fiber Channel device, add the GUID for > this service. > > Signed-off-by: K. Y. Srinivasan > Reviewed-by: Haiyang Zhang > --- > include/linux/hyperv.h | 10 ++ > 1 files changed

Re: [PATCH V1 1/7] Drivers: hv: vmbus: Implement multi-channel support

2013-05-16 Thread Greg KH
On Thu, May 16, 2013 at 05:21:13AM -0700, K. Y. Srinivasan wrote: > Starting with Win8, the host supports multiple sub-channels for a given > device. As in the past, the initial channel offer specifies the device and > is associated with both the type and the instance GUIDs. For performance > criti

Re: [PATCH V1 2/7] Drivers: hv: Add the GUID fot synthetic fiber channel device

2013-05-16 Thread Greg KH
On Thu, May 16, 2013 at 05:21:14AM -0700, K. Y. Srinivasan wrote: > In preparation for supporting synthetic Fiber Channel device, add the GUID for > this service. > > Signed-off-by: K. Y. Srinivasan > Reviewed-by: Haiyang Zhang Acked-by: Greg Kroah-Hartman -- To unsubscribe from this list: sen

Re: [PATCH v2] megaraid_sas: add an i/o barrier

2016-02-01 Thread Greg KH
On Mon, Feb 01, 2016 at 03:12:04PM +0100, Tomas Henzl wrote: > A barrier should be added to ensure proper > ordering of memory mapped writes. > > V2: - added the barrier also to megasas_fire_cmd_skinny, > as suggested by Kashyap Desai > > Signed-off-by: Tomas Henzl > --- > drivers/scsi/megaraid

Re: [PATCHv4 1/1] SCSI: hosts: update to use ida_simple for host_no management

2015-10-16 Thread Greg KH
On Fri, Oct 16, 2015 at 01:03:42PM -0700, Lee Duncan wrote: > Adding linux-usb and linux-hotplug to cc list, in case they wish to comment. > > Summary: I want to change SCSI host number so that it gets re-used, like > disk index numbers, instead of always increasing. > > Please see below. > > On

Re: [PATCH] megaraid_sas : Add locking to megasas_aen_polling

2015-10-30 Thread Greg KH
On Fri, Oct 30, 2015 at 01:47:50PM -0400, Ben Guthro wrote: > From: Glenn Watkins > > Under conditions of offlining drives, and rescanning the scsi host, > we can get into situations that the megasas_aen_polling kthread > can crash(GPF) in the megasas_aen_polling work queue: > > [ 1206.568641] g

Re: [PATCH] sysfs: add filter function to groups

2007-10-30 Thread Greg KH
On Tue, Oct 30, 2007 at 01:25:43PM -0500, James Bottomley wrote: > On Mon, 2007-10-29 at 18:58 +0100, Stefan Richter wrote: > > James Bottomley wrote: > > >> > struct attribute_group { > > >> >const char *name; > > >> > + int (*filter_show)(struct kobj

Re: BUG in: Driver core: convert block from raw kobjects to core devices (fwd)

2007-10-30 Thread Greg KH
On Mon, Oct 29, 2007 at 02:47:59PM -0400, Alan Stern wrote: > On Mon, 29 Oct 2007, James Bottomley wrote: > > > I'm not sure if we can do this patch. If you kill a device, you see > > there's a processing state in scsi_prep_fn() for SDEV_DEL, which has a > > printk message I see quite often when

Re: BUG in: Driver core: convert block from raw kobjects to core devices (fwd)

2007-10-30 Thread Greg KH
On Mon, Oct 29, 2007 at 08:13:17PM +0100, Kay Sievers wrote: > On Mon, 2007-10-29 at 14:47 -0400, Alan Stern wrote: > > On Mon, 29 Oct 2007, James Bottomley wrote: > > > > > I'm not sure if we can do this patch. If you kill a device, you see > > > there's a processing state in scsi_prep_fn() for

Re: BUG in: Driver core: convert block from raw kobjects to core devices (fwd)

2007-10-31 Thread Greg KH
On Wed, Oct 31, 2007 at 11:46:30AM +0100, Kay Sievers wrote: > On Tue, 2007-10-30 at 21:25 -0700, Greg KH wrote: > > On Mon, Oct 29, 2007 at 08:13:17PM +0100, Kay Sievers wrote: > > > On Mon, 2007-10-29 at 14:47 -0400, Alan Stern wrote: > > > > On Mon, 29 O

Re: [PATCH] sysfs: add filter function to groups

2007-10-31 Thread Greg KH
On Wed, Oct 31, 2007 at 09:38:04AM -0500, James Bottomley wrote: > On Tue, 2007-10-30 at 20:55 -0700, Greg KH wrote: > > OSame problem here, if grp->is_visible is not set, sysfs_add_file() would > > never be called, right? > > > > Other than the logic problem (I thi

Re: [PATCH] sysfs: add filter function to groups

2007-11-04 Thread Greg KH
On Sun, Nov 04, 2007 at 08:12:02AM -0600, James Bottomley wrote: > On Wed, 2007-10-31 at 10:29 -0700, Greg KH wrote: > > On Wed, Oct 31, 2007 at 09:38:04AM -0500, James Bottomley wrote: > > > On Tue, 2007-10-30 at 20:55 -0700, Greg KH wrote: > > > > OSame problem h

Re: [stable] [patch 16/26] hptiop: avoid buffer overflow when returning sense data

2007-11-19 Thread Greg KH
On Mon, Nov 19, 2007 at 11:38:35AM -0700, Matthew Wilcox wrote: > On Mon, Nov 19, 2007 at 10:19:12AM -0800, Greg Kroah-Hartman wrote: > > > > 2.6.22-stable review patch. If anyone has any objections, please let us > > know. > > Makes sense to backport this. > > Acked-by: Matthew Wilcox <[EMAIL

Re: [stable] broken dpt_i2o in 2.6.23 (was: ext2 check page: bad entry in directory) (fwd)

2007-12-12 Thread Greg KH
On Wed, Dec 12, 2007 at 02:54:54PM -0500, James Bottomley wrote: > > On Wed, 2007-12-12 at 11:16 -0800, Andrew Morton wrote: > > On Wed, 12 Dec 2007 14:43:42 +0100 Anders Henke <[EMAIL PROTECTED]> wrote: > > > > > Am 12.12.2007 schrieb Miquel van Smoorenburg: > > > > On Wed, 2007-12-12 at 03:38 -

Re: [PATCH 0/7] convert semaphore to mutex in struct class

2008-01-07 Thread Greg KH
On Mon, Jan 07, 2008 at 10:09:44AM +0800, Dave Young wrote: > > Thanks for your comment, I rewrite it for 2.6.24-rc7 as a all-in-one > patch, please see following. Drop i2c maintainer and list in cc > because there's no changes about i2c in this patch: > > Convert semaphore to mutex in struct cla

Re: [PATCH 0/7] convert semaphore to mutex in struct class

2008-01-07 Thread Greg KH
On Mon, Jan 07, 2008 at 02:23:33PM +0100, Stefan Richter wrote: > David Brownell wrote: > > On Monday 07 January 2008, Greg KH wrote: > >> Most of the non-driver core code should be converted to not use the > >> lock in the class at all. They should use a local lock

Re: [PATCH 0/7] convert semaphore to mutex in struct class

2008-01-07 Thread Greg KH
On Mon, Jan 07, 2008 at 06:13:37PM +0100, Stefan Richter wrote: > It's already in the driver core to the most part. It remains to be seen > what is less complicated in the end: Transparent mutex-protected list > accesses provided by driver core (requires the iterator), or all the > necessary lock

Re: [PATCH 0/7] convert semaphore to mutex in struct class

2008-01-08 Thread Greg KH
On Tue, Jan 08, 2008 at 03:05:10PM +0800, Dave Young wrote: > On Jan 8, 2008 1:20 AM, Greg KH <[EMAIL PROTECTED]> wrote: > > On Mon, Jan 07, 2008 at 06:13:37PM +0100, Stefan Richter wrote: > > > It's already in the driver core to the most part. It remains to be seen &

Re: [PATCH 0/7] convert semaphore to mutex in struct class

2008-01-10 Thread Greg KH
On Thu, Jan 10, 2008 at 05:48:43PM +0800, Dave Young wrote: > The patches are done on my side, please help to check. Along with all of the other comments from people, I have a few. > This is the first one of the series about driver core changes. > If this one is accepted and there's no other pr

Re: [PATCH] scsi_transport_spi: convert to attribute groups

2008-01-11 Thread Greg KH
On Sat, Jan 05, 2008 at 10:18:27AM -0600, James Bottomley wrote: > This conversion makes full use of the is_visible() callback on attribute > groups. Now, each device appears only with its capability flags in the > transport class directory. Previously each device appeared with the > capability o

Re: [PATCH] fix the sysfs_add_file_to_group interfaces

2008-01-11 Thread Greg KH
On Wed, Jan 02, 2008 at 06:44:05PM -0600, James Bottomley wrote: > I can't see a reason why these shouldn't work on every group. However, > they only seem to work on named groups. This patch allows the group > functions to work on anonymous groups (those with NULL names). > > Signed-off-by: Jame

Re: [PATCH] attribute_container: update to use the group interface

2008-01-11 Thread Greg KH
On Wed, Jan 02, 2008 at 06:48:47PM -0600, James Bottomley wrote: > This patch is the beginning of moving the attribute_containers to use > attribute groups exclusively. The attr element is now deprecated and > will eventually be removed (along with all the hand rolled code for > doing exactly what

Re: PATCH: scsi-sd-last-sector-bug-flag.patch

2008-01-20 Thread Greg KH
On Sun, Jan 20, 2008 at 11:12:26AM +0100, Hans de Goede wrote: > Hi all, > > This patch adds a new scsi_device flag for devices which contain a bug > where > the device crashes when the last sector is read in a larger then 1 sector > read. > > This is for example the case with sdcards in the HP P

  1   2   3   >