[PATCH] Fix SATA ATAPI error handling

2005-03-23 Thread Hannes Reinecke
by the strategy handler. Comments are welcome. Cheers, Hannes -- Dr. Hannes Reinecke [EMAIL PROTECTED] SuSE Linux AG S390 zSeries Maxfeldstraße 5 +49 911 74053 688 90409 Nürnberg http://www.suse.de

[PATCH] Use proper seq_file api for /proc/scsi/scsi

2005-04-07 Thread Hannes Reinecke
for a better solution. Cheers, Hannes -- Dr. Hannes Reinecke [EMAIL PROTECTED] SuSE Linux AG S390 zSeries Maxfeldstraße 5 +49 911 74053 688 90409 Nürnberg http://www.suse.de From: Hannes Reinecke

Re: [PATCH] Use proper seq_file api for /proc/scsi/scsi

2005-04-07 Thread Hannes Reinecke
Christoph Hellwig wrote: On Thu, Apr 07, 2005 at 11:46:27AM +0200, Hannes Reinecke wrote: Hi all, /proc/scsi/scsi currently has a very dumb implementation of the seq_file api which causes 'cat /proc/scsi/scsi' to return with -ENOMEM when a large amount of devices are connected. /proc/scsi

[Patch 0/2] Update aic79xx

2005-07-22 Thread Hannes Reinecke
by hand ... Hope it finds your blessing. Comments etc welcome. target27:0:10: FAST-160 WIDE SCSI 320.0 MB/s ST IU (6.25 ns, offset 127) Cool, eh? Cheers, Hannes -- Dr. Hannes Reinecke [EMAIL PROTECTED] SuSE Linux Products GmbHS390 zSeries Maxfeldstraße 5

[PATCH 1/2] aic79xx update

2005-07-22 Thread Hannes Reinecke
This patch removes the busyq from aic79xx, using the midlayer queue instead. Re-worked patch from Jeff Garzik. Cheers, Hannes -- Dr. Hannes Reinecke [EMAIL PROTECTED] SuSE Linux Products GmbHS390 zSeries Maxfeldstraße 5 +49 911 74053

Re: [PATCH] aic79xx: fix up transport settings

2005-08-04 Thread Hannes Reinecke
. Hannes Reinecke [EMAIL PROTECTED] SuSE Linux Products GmbHS390 zSeries Maxfeldstraße 5 +49 911 74053 688 90409 Nürnberg http://www.suse.de - To unsubscribe from this list: send the line unsubscribe linux-scsi

Re: [PATCH v2][RFC] scsi_transport_fc: Implement I_T nexus reset

2013-03-12 Thread Hannes Reinecke
On 03/11/2013 07:04 PM, James Smart wrote: On 3/11/2013 1:05 PM, Hannes Reinecke wrote: On 03/07/2013 09:35 PM, Jeremy Linton wrote: On 3/7/2013 2:20 PM, Mike Christie wrote: On 03/07/2013 02:13 PM, Jeremy Linton wrote: For lpfc, you never get to the code. Or rather when I was testing

Re: [PATCH V2 05/12] pm80xx: MSI-X implementation for using 64 interrupts

2013-03-14 Thread Hannes Reinecke
, Hannes -- Dr. Hannes Reinecke zSeries Storage h...@suse.de +49 911 74053 688 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg) -- To unsubscribe from this list: send the line unsubscribe linux

[PATCH][RFC] scsi: Use W_LUN for scanning

2013-03-15 Thread Hannes Reinecke
to use LUN 0. For broken W_LUN implementations a new blacklist flag 'BLIST_NO_WLUN' is added. Signed-off-by: Hannes Reinecke h...@suse.de diff --git a/drivers/scsi/scsi_scan.c b/drivers/scsi/scsi_scan.c index 3e58b22..f4ccdea 100644 --- a/drivers/scsi/scsi_scan.c +++ b/drivers/scsi/scsi_scan.c

Re: [PATCH] scsi_transport_fc: Make 'port_state' writeable

2013-03-15 Thread Hannes Reinecke
. Testing has been successful on our side, plus I've posted a patchset for multipath-tools utilizing this patch. So it would be good if it could be included. James? Cheers, Hannes -- Dr. Hannes Reinecke zSeries Storage h...@suse.de +49 911 74053 688 SUSE LINUX

Re: [PATCH] scsi_transport_fc: Make 'port_state' writeable

2013-03-18 Thread Hannes Reinecke
and none of the current LLDs have it implemented. Cheers, Hannes -- Dr. Hannes Reinecke zSeries Storage h...@suse.de +49 911 74053 688 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg

Re: [PATCH][RFC] scsi: Use W_LUN for scanning

2013-03-18 Thread Hannes Reinecke
irrespective of the PQ setting. So from what I'm seeing this case should be covered. Unless I'm missing something ... On 03/15/2013 10:46 AM, Hannes Reinecke wrote: SAM advertises the use of a Well-known LUN (W_LUN) for scanning. As this avoids exposing LUN 0 (which might be a valid LUN) for all

Re: [PATCH V3 05/12] pm80xx: MSI-X implementation for using 64 interrupts

2013-03-26 Thread Hannes Reinecke
Reinecke h...@suse.de Cheers, Hannes -- Dr. Hannes Reinecke zSeries Storage h...@suse.de +49 911 74053 688 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg) -- To unsubscribe from

Re: [PATCH 0/4] scsi: 64-bit LUN support

2013-03-27 Thread Hannes Reinecke
On 03/26/2013 07:00 PM, Chad Dupuis wrote: On Tue, 19 Feb 2013, Hannes Reinecke wrote: This patchset updates the SCSI midlayer to use 64-bit LUNs internally. It eliminates the need to limit the number of LUNs artificially to avoid aliasing issues; the SCSI midlayer can now accept any LUN

Re: error handler scheduling

2013-03-27 Thread Hannes Reinecke
. Hannes Reinecke zSeries Storage h...@suse.de +49 911 74053 688 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg) -- To unsubscribe from this list: send the line unsubscribe linux-scsi

Re: [PATCH 0/4] scsi: 64-bit LUN support

2013-03-30 Thread Hannes Reinecke
On 03/29/2013 05:32 PM, Tomas Henzl wrote: On 03/27/2013 08:37 AM, Hannes Reinecke wrote: On 03/26/2013 07:00 PM, Chad Dupuis wrote: On Tue, 19 Feb 2013, Hannes Reinecke wrote: This patchset updates the SCSI midlayer to use 64-bit LUNs internally. It eliminates the need to limit the number

Re: [PATCH] scsi_dh_alua: Add module parameter to allow failover to non preferred path without STPG

2013-03-31 Thread Hannes Reinecke
...@netapp.com Acked-by: Hannes Reinecke h...@suse.de Cheers, Hannes -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] scsi_transport_fc: Make 'port_state' writeable

2013-04-04 Thread Hannes Reinecke
On 04/01/2013 11:06 PM, James Smart wrote: On 3/18/2013 3:09 AM, Hannes Reinecke wrote: On 03/15/2013 08:13 PM, Bart Van Assche wrote: On 03/15/13 19:51, Mike Christie wrote: On 03/15/2013 08:41 AM, Bart Van Assche wrote: How about using the value of scsi_cmnd.jiffies_at_alloc to finish

Re: [PATCH 0/4] scsi: 64-bit LUN support

2013-04-04 Thread Hannes Reinecke
On 03/31/2013 07:44 PM, Tomas Henzl wrote: On 03/30/2013 05:53 PM, Hannes Reinecke wrote: On 03/29/2013 05:32 PM, Tomas Henzl wrote: [ .. ] in scsi_report_lun_scan is max_lun compared with the result of scsilun_to_int, but in that value is also stored the address method. This means, that we

Re: [PATCH][RFC] scsi: Use W_LUN for scanning

2013-04-07 Thread Hannes Reinecke
On 04/06/2013 11:08 AM, James Bottomley wrote: On Fri, 2013-03-15 at 10:46 +0100, Hannes Reinecke wrote: SAM advertises the use of a Well-known LUN (W_LUN) for scanning. As this avoids exposing LUN 0 (which might be a valid LUN) for all initiators it is the preferred method for LUN scanning

Re: scanning for LUNs

2013-04-08 Thread Hannes Reinecke
for this (check the mailing list). Using W_LUN is precisely for this type of setup. (And would provide me with another scenario for using W_LUNs :-) Cheers, Hannes -- Dr. Hannes Reinecke zSeries Storage h...@suse.de +49 911 74053 688 SUSE LINUX Products GmbH

Re: [PATCH 0/4] scsi: 64-bit LUN support

2013-04-09 Thread Hannes Reinecke
On 04/08/2013 05:37 PM, Tomas Henzl wrote: On 04/05/2013 05:24 PM, James Smart wrote: On 4/4/2013 6:17 AM, Hannes Reinecke wrote: On 03/31/2013 07:44 PM, Tomas Henzl wrote: What we can do is to decode the LUN and compare it to max_lun provided by the driver, I think that sg_luns is able

Re: [PATCH 0/4] scsi: 64-bit LUN support

2013-04-09 Thread Hannes Reinecke
On 04/09/2013 04:27 PM, Elliott, Robert (Server Storage) wrote: -Original Message- From: Hannes Reinecke [mailto:h...@suse.de] Sent: Tuesday, 09 April, 2013 2:38 AM To: Tomas Henzl Cc: james.sm...@emulex.com; Chad Dupuis; linux-scsi@vger.kernel.org; James Bottomley; Jeremy Linton

Re: [PATCH 18/26] megaraid: Don't use create_proc_read_entry() [RFC]

2013-04-12 Thread Hannes Reinecke
...@parallels.com cc: linux-scsi@vger.kernel.org Hmm? What is the general stance on /proc entries for devices? I was under the impression that it was marked as deprecated. Is it not? Has it been resurrected? Cheers, Hannes -- Dr. Hannes Reinecke zSeries Storage h...@suse.de

Re: [PATCH V2 1/1] scsi: Handle MLQUEUE busy response in scsi_send_eh_cmnd

2013-04-23 Thread Hannes Reinecke
see to have the msleep into section where the return command from queuecommand is evaluated; here we'll actually decrease responsiveness as we're always waiting for X seconds, even if the command would've been completed during that time. Cheers, Hannes -- Dr. Hannes Reinecke

Re: T10 WCE interpretation in Linux device level access

2013-04-24 Thread Hannes Reinecke
). You can always set the 'IMMED' bit for these arrays :-) Cheers, Hannes -- Dr. Hannes Reinecke zSeries Storage h...@suse.de +49 911 74053 688 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG

[PATCH][v3] scsi: Handle MLQUEUE busy response in scsi_send_eh_cmnd

2013-04-24 Thread Hannes Reinecke
...@linux.vnet.ibm.com Cc: Brian King brk...@linux.vnet.ibm.com Signed-off-by: Hannes Reinecke h...@suse.de diff --git a/drivers/scsi/scsi_error.c b/drivers/scsi/scsi_error.c index c1b05a8..1fc6da94 100644 --- a/drivers/scsi/scsi_error.c +++ b/drivers/scsi/scsi_error.c @@ -791,22 +791,32 @@ static int

Re: T10 WCE interpretation in Linux device level access

2013-04-24 Thread Hannes Reinecke
On 04/24/2013 02:08 PM, Paolo Bonzini wrote: Il 24/04/2013 14:07, Hannes Reinecke ha scritto: On 04/24/2013 01:17 PM, Paolo Bonzini wrote: Il 23/04/2013 22:07, James Bottomley ha scritto: On Tue, 2013-04-23 at 15:41 -0400, Ric Wheeler wrote: For many years, we have used WCE as an indication

Re: [PATCH][v3] scsi: Handle MLQUEUE busy response in scsi_send_eh_cmnd

2013-04-24 Thread Hannes Reinecke
On 04/24/2013 04:48 PM, James Bottomley wrote: On Wed, 2013-04-24 at 13:32 +0200, Hannes Reinecke wrote: scsi_send_eh_cmnd() is calling queuecommand() directly, so it needs to check the return value here. The only valid return codes for queuecommand() are 'busy' states, so we need to wait

[PATCH] scsi: Handle MLQUEUE busy response in scsi_send_eh_cmnd

2013-04-25 Thread Hannes Reinecke
...@linux.vnet.ibm.com Cc: Brian King brk...@linux.vnet.ibm.com Signed-off-by: Hannes Reinecke h...@suse.de diff --git a/drivers/scsi/scsi_error.c b/drivers/scsi/scsi_error.c index d58db32..6a3c1d2 100644 --- a/drivers/scsi/scsi_error.c +++ b/drivers/scsi/scsi_error.c @@ -889,22 +889,32 @@ static int

Re: [PATCH 2/2] dm mpath: attach scsi_dh during table resume

2013-04-26 Thread Hannes Reinecke
changes. Cheers, Hannes -- Dr. Hannes Reinecke zSeries Storage h...@suse.de +49 911 74053 688 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg) -- To unsubscribe from this list: send

Re: [PATCH v2 0/9] fix max discard sectors limit

2013-04-26 Thread Hannes Reinecke
); if (unlikely(cmd_flags REQ_WRITE_SAME)) return q-limits.max_write_same_sectors; Patch works, and fixes the discard failing issue I've been pestering mkp with at LSF. Please apply. Cheers, Hannes -- Dr. Hannes Reinecke zSeries Storage h...@suse.de

Re: linux-next: Tree for May 1

2013-05-02 Thread Hannes Reinecke
-- Dr. Hannes Reinecke zSeries Storage h...@suse.de +49 911 74053 688 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg) -- To unsubscribe from this list: send the line unsubscribe linux

[PATCH] scsi: Double completion on retry

2013-05-02 Thread Hannes Reinecke
(). Cc: Mike Christie micha...@cs.wisc.edu Cc: Tejun Heo t...@kernel.org Signed-off-by: Hannes Reinecke h...@suse.de diff --git a/drivers/scsi/scsi_lib.c b/drivers/scsi/scsi_lib.c index c31187d..8dba66b 100644 --- a/drivers/scsi/scsi_lib.c +++ b/drivers/scsi/scsi_lib.c @@ -581,9 +581,11 @@ static

Re: [PATCH] scsi: Double completion on retry

2013-05-02 Thread Hannes Reinecke
On 05/02/2013 10:31 AM, Hannes Reinecke wrote: When blk_end_request() returns 'false' in scsi_end_request the request is invalid after blk_end_request_all(). So we must not return the then stale request pointer. Doing so will result in a potential double completion. And we should be calling

[PATCH 0/5] Cleanup struct Scsi_Host

2013-05-06 Thread Hannes Reinecke
there the usage is questionable. So move the 'last_reset' field into the internal host structure where needed and remove both fields from struct Scsi_Host. Hannes Reinecke (5): scsi: remove 'resetting' field from struct Scsi_Host tmscsim: Move 'last_reset' into host structure dc395: Move

[PATCH 4/5] advansys: Remove references to 'last_reset'

2013-05-06 Thread Hannes Reinecke
The 'last_reset' field is only displayed in logging messages but never actually used. Remove references to it. Signed-off-by: Hannes Reinecke h...@suse.de --- drivers/scsi/advansys.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/scsi/advansys.c b/drivers

[PATCH 1/5] scsi: remove 'resetting' field from struct Scsi_Host

2013-05-06 Thread Hannes Reinecke
struct Scsi_Host has a field 'resetting' which is only ever used in dpt_i2o. And even there the usage is questionable. So remove the field and have dpt_i2o use the standard mechanism for delaying I/O. Signed-off-by: Hannes Reinecke h...@suse.de --- drivers/scsi/dpt_i2o.c | 22

[PATCH 5/5] scsi: Remove 'last_reset' for struct Scsi_Host

2013-05-06 Thread Hannes Reinecke
Field is now unused, so remove it. Signed-off-by: Hannes Reinecke h...@suse.de --- include/scsi/scsi_host.h | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/include/scsi/scsi_host.h b/include/scsi/scsi_host.h index af7ad0e..dcf17dc 100644 --- a/include/scsi/scsi_host.h +++ b

[PATCH 3/5] dc395: Move 'last_reset' into internal host structure

2013-05-06 Thread Hannes Reinecke
'last_reset' is only used internally, so move it into the internal host structure. Signed-off-by: Hannes Reinecke h...@suse.de --- drivers/scsi/dc395x.c | 24 +--- 1 file changed, 13 insertions(+), 11 deletions(-) diff --git a/drivers/scsi/dc395x.c b/drivers/scsi/dc395x.c

[PATCH] sd: avoid deadlocks when running under multipath

2013-05-10 Thread Hannes Reinecke
it'll speed up device scanning. Signed-off-by: Hannes Reinecke h...@suse.de diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c index 7992635..2ee0aa6 100644 --- a/drivers/scsi/sd.c +++ b/drivers/scsi/sd.c @@ -489,6 +489,16 @@ static struct scsi_driver sd_template = { }; /* + * Dummy kobj_map-probe

Re: [PATCH] scsi: Allow error handling timeout to be specified

2013-05-10 Thread Hannes Reinecke
paths to the device exist. Acked-by: Ewan D. Milne emi...@redhat.com Seconded. Acked-by: Hannes Reinecke h...@suse.de Cheers, Hannes -- Dr. Hannes Reinecke zSeries Storage h...@suse.de +49 911 74053 688 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409

Re: [PATCH] scsi: Allow error handling timeout to be specified

2013-05-10 Thread Hannes Reinecke
wouldn't have all these obnoxious issues no-one has ever seen... And there is nothing wrong with reducing the timeout per se. It's just that the current error recovery strategy isn't well equipped to handle it :-) Cheers, Hannes -- Dr. Hannes Reinecke zSeries Storage h...@suse.de

Re: [PATCH] scsi: Allow error handling timeout to be specified

2013-05-10 Thread Hannes Reinecke
On 05/10/2013 07:51 PM, Baruch Even wrote: On Fri, May 10, 2013 at 5:01 PM, Ewan Milne emi...@redhat.com wrote: On Fri, 2013-05-10 at 16:22 +0300, Baruch Even wrote: On Fri, May 10, 2013 at 3:43 PM, Ewan Milne emi...@redhat.com wrote: On Thu, 2013-05-09 at 23:11 -0400, Martin K. Petersen

Re: [PATCH] scsi: Allow error handling timeout to be specified

2013-05-12 Thread Hannes Reinecke
On 05/10/2013 09:27 PM, Baruch Even wrote: On Fri, May 10, 2013 at 11:18 PM, Hannes Reinecke h...@suse.de wrote: On 05/10/2013 07:51 PM, Baruch Even wrote: The error handling I have in mind (admittedly, not fully thought out) should work for both FC and SAS. Currently the error recovery

Re: [PATCH] scsi: Allow error handling timeout to be specified

2013-05-13 Thread Hannes Reinecke
On 05/13/2013 04:40 PM, Jeremy Linton wrote: On 5/13/2013 12:46 AM, Hannes Reinecke wrote: True. But and the end of the day, we _do_ want to recover the failed LUN. If we were to disable that faulty LUN and continue running with the others we won't have a chance of _ever_ recovering that one

[PATCH 0/4] New FC timeout handler

2013-05-24 Thread Hannes Reinecke
the 'dd' command as indicated. Comments etc are welcome. Hannes Reinecke (4): scsi: move initialization of scmd-eh_entry blk-timeout: add BLK_EH_SCHEDULED return code scsi: export functions for new fc timeout handler scsi_transport_fc: FC timeout handler drivers/scsi/scsi_error.c

[PATCH 2/4] blk-timeout: add BLK_EH_SCHEDULED return code

2013-05-24 Thread Hannes Reinecke
Add a 'BLK_EH_SCHEDULED' return code for blk-timeout to indicate that a delayed error recovery has been initiated. Signed-off-by: Hannes Reinecke h...@suse.de --- drivers/scsi/scsi_error.c | 3 +++ include/linux/blkdev.h| 1 + 2 files changed, 4 insertions(+) diff --git a/drivers/scsi

[PATCH 1/4] scsi: move initialization of scmd-eh_entry

2013-05-24 Thread Hannes Reinecke
The 'eh_entry' list might be used even before scsi_softirq_done() is called. Hence we should rather initialize it together with the other eh-related variables. Signed-off-by: Hannes Reinecke h...@suse.de --- drivers/scsi/scsi_lib.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff

[PATCH 4/4] scsi_transport_fc: FC timeout handler

2013-05-24 Thread Hannes Reinecke
succeeded and the command is completed with the LLDD. For any other return code from 'eh_abort_handler' the command will be pushed onto the existing SCSI EH handler, or aborted with an error if that fails. Signed-off-by: Hannes Reinecke h...@suse.de --- drivers/scsi/scsi_transport_fc.c | 63

[PATCH 3/4] scsi: export functions for new fc timeout handler

2013-05-24 Thread Hannes Reinecke
Export some more functions which are used by the new FC timeout handler. Signed-off-by: Hannes Reinecke h...@suse.de --- drivers/scsi/scsi_error.c | 5 - drivers/scsi/scsi_lib.c | 2 ++ drivers/scsi/scsi_priv.h | 2 ++ 3 files changed, 8 insertions(+), 1 deletion(-) diff --git a/drivers

Question: eh_abort_handler() and terminate commands

2013-05-24 Thread Hannes Reinecke
; this way we at least have a chance of getting a decent status back ... Cheers, Hannes -- Dr. Hannes Reinecke zSeries Storage h...@suse.de +49 911 74053 688 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: J. Hawn, J. Guild, F. Imendörffer, HRB

Re: [PATCH 4/4] scsi_transport_fc: FC timeout handler

2013-05-25 Thread Hannes Reinecke
On 05/25/2013 07:08 AM, Christoph Hellwig wrote: This looks like a good start, but why would we make this FC specific? Because James B. said so :-) No, seriously: You would need to revisit the good old SCSI parallel LLDDs to figure out if this approach works for them. Eg aic7xxx basically

Re: Question: eh_abort_handler() and terminate commands

2013-05-25 Thread Hannes Reinecke
On 05/25/2013 12:26 AM, Jeremy Linton wrote: On 5/24/2013 5:57 AM, Hannes Reinecke wrote: Which leads to the interesting question: What happens with the actual command once eh_abort_handler returns? Well, eventually it ends up on the done_q and gets returned up the stack via

Re: [PATCH 4/4] scsi_transport_fc: FC timeout handler

2013-05-25 Thread Hannes Reinecke
On 05/25/2013 10:42 AM, Christoph Hellwig wrote: On Sat, May 25, 2013 at 11:38:55AM +0200, Hannes Reinecke wrote: On 05/25/2013 07:08 AM, Christoph Hellwig wrote: This looks like a good start, but why would we make this FC specific? Because James B. said so :-) I can't remember that at all

Re: SCSI error handling -- one error blocks the whole SCSI host

2013-05-27 Thread Hannes Reinecke
and we're better off using the existing syntax for command aborts. Plus it makes life _so much_ easier for the implementation ... But to answer Roland: Have you checked my patchset? It should help for command timeouts ... Cheers, Hannes -- Dr. Hannes Reinecke zSeries Storage h

[PATCH 0/3] scsi: More detailed I/O errors

2013-06-05 Thread Hannes Reinecke
for thin provisioning failure and ENODATA for medium error. Hannes Reinecke (3): scsi: Document enhanced error codes scsi: Return ENOSPC on thin provisioning failure scsi: Return ENODATA on medium error drivers/scsi/scsi_error.c | 26 ++ drivers/scsi/scsi_lib.c | 21

[PATCH 2/3] scsi: Return ENOSPC on thin provisioning failure

2013-06-05 Thread Hannes Reinecke
When the thin provisioning hard threshold is reached we should return ENOSPC to inform upper layers about this fact. Signed-off-by: Hannes Reinecke h...@suse.de --- drivers/scsi/scsi_error.c | 12 +++- drivers/scsi/scsi_lib.c | 5 + include/scsi/scsi.h | 2 ++ 3 files

[PATCH 3/3] scsi: Return ENODATA on medium error

2013-06-05 Thread Hannes Reinecke
When a medium error is detected the SCSI stack should return ENODATA to the upper layers. Signed-off-by: Hannes Reinecke h...@suse.de --- drivers/scsi/scsi_error.c | 7 ++- drivers/scsi/scsi_lib.c | 5 + include/scsi/scsi.h | 2 ++ 3 files changed, 13 insertions(+), 1 deletion

[PATCH 1/3] scsi: Document enhanced error codes

2013-06-05 Thread Hannes Reinecke
Document the various error codes returned on I/O failure. Signed-off-by: Hannes Reinecke h...@suse.de --- drivers/scsi/scsi_error.c | 7 +-- drivers/scsi/scsi_lib.c | 11 +++ 2 files changed, 16 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/scsi_error.c b/drivers/scsi

Re: [PATCH 1/3] scsi: Document enhanced error codes

2013-06-05 Thread Hannes Reinecke
On 06/06/2013 07:49 AM, Ren Mingxin wrote: Hi, Hannes: I have two questions about the comments: On 06/05/2013 03:10 PM, Hannes Reinecke wrote: Document the various error codes returned on I/O failure. Signed-off-by: Hannes Reineckeh...@suse.de --- drivers/scsi/scsi_error.c | 7

[PATCHv2 0/3] scsi: More detailed I/O errors

2013-06-06 Thread Hannes Reinecke
for thin provisioning failure and ENODATA for medium error. Changes since the initial version, suggested by Ren Mingxin: - Add error description to blk_update_request() - Document missing values Hannes Reinecke (3): scsi: Document enhanced error codes scsi: Return ENOSPC on thin provisioning

[PATCH 1/3] scsi: Document enhanced error codes

2013-06-06 Thread Hannes Reinecke
Document the various error codes returned on I/O failure. Signed-off-by: Hannes Reinecke h...@suse.de --- drivers/scsi/scsi_error.c | 8 ++-- drivers/scsi/scsi_lib.c | 12 2 files changed, 18 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/scsi_error.c b/drivers/scsi

[PATCH 2/3] scsi: Return ENOSPC on thin provisioning failure

2013-06-06 Thread Hannes Reinecke
When the thin provisioning hard threshold is reached we should return ENOSPC to inform upper layers about this fact. Signed-off-by: Hannes Reinecke h...@suse.de --- block/blk-core.c | 3 +++ drivers/scsi/scsi_error.c | 12 +++- drivers/scsi/scsi_lib.c | 5 + include/scsi

[PATCH 3/3] scsi: Return ENODATA on medium error

2013-06-06 Thread Hannes Reinecke
When a medium error is detected the SCSI stack should return ENODATA to the upper layers. Signed-off-by: Hannes Reinecke h...@suse.de --- block/blk-core.c | 3 +++ drivers/scsi/scsi_error.c | 7 ++- drivers/scsi/scsi_lib.c | 5 + include/scsi/scsi.h | 2 ++ 4 files

Re: [PATCH] [SCSI] scsilun_to_int should ignore the highest 2 bits

2013-06-06 Thread Hannes Reinecke
pretend to be SCSI-2, but supporting more than 256 LUNs per host. Which, of course, it totally bonkers. I'll be posting my 64-bit LUN patchset, that should fix this issue. Cheers, Hannes -- Dr. Hannes Reinecke zSeries Storage h...@suse.de +49 911 74053

[PATCH 0/4] New SCSI command timeout handler

2013-06-06 Thread Hannes Reinecke
, and then start the 'dd' command as indicated. As a proof-of-concept I've also enabled the new timeout handler for virtio, so that things can be tested out more easily. Comments etc are welcome. Hannes Reinecke (4): scsi: move initialization of scmd-eh_entry blk-timeout: add BLK_EH_SCHEDULED return code

[PATCH 2/4] blk-timeout: add BLK_EH_SCHEDULED return code

2013-06-06 Thread Hannes Reinecke
Add a 'BLK_EH_SCHEDULED' return code for blk-timeout to indicate that a delayed error recovery has been initiated. Signed-off-by: Hannes Reinecke h...@suse.de --- drivers/scsi/scsi_error.c | 3 +++ include/linux/blkdev.h| 1 + 2 files changed, 4 insertions(+) diff --git a/drivers/scsi

[PATCH 3/4] scsi: improved eh timeout handler

2013-06-06 Thread Hannes Reinecke
to assume the TMF succeeded and the command is completed with the LLDD. For any other return code from 'eh_abort_handler' the command will be pushed onto the existing SCSI EH handler, or aborted with DID_TIME_OUT if that fails. Signed-off-by: Hannes Reinecke h...@suse.de --- drivers/scsi/scsi_error.c

[PATCH 4/4] virtio_scsi: use improved eh timeout handler

2013-06-06 Thread Hannes Reinecke
Hook in the improved eh timeout handler for virtio. Signed-off-by: Hannes Reinecke h...@suse.de --- drivers/scsi/virtio_scsi.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers/scsi/virtio_scsi.c b/drivers/scsi/virtio_scsi.c index 2168258..3fb588d 100644 --- a/drivers/scsi

[PATCH 1/4] scsi: move initialization of scmd-eh_entry

2013-06-06 Thread Hannes Reinecke
The 'eh_entry' list might be used even before scsi_softirq_done() is called. Hence we should rather initialize it together with the other eh-related variables. Signed-off-by: Hannes Reinecke h...@suse.de --- drivers/scsi/scsi_lib.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff

Re: [PATCH 3/3] scsi: Return ENODATA on medium error

2013-06-06 Thread Hannes Reinecke
On 06/06/2013 09:52 AM, Ren Mingxin wrote: Hi, Hannes: On 06/05/2013 03:11 PM, Hannes Reinecke wrote: When a medium error is detected the SCSI stack should return ENODATA to the upper layers. Signed-off-by: Hannes Reineckeh...@suse.de --- drivers/scsi/scsi_error.c | 7

Re: [PATCH 3/4] scsi: improved eh timeout handler

2013-06-06 Thread Hannes Reinecke
On 06/06/2013 06:23 PM, Jörn Engel wrote: On Thu, 6 June 2013 11:43:54 +0200, Hannes Reinecke wrote: When a command runs into a timeout we need to send an 'ABORT TASK' TMF. This is typically done by the 'eh_abort_handler' LLDD callback. Conceptually, however, this function is a normal SCSI

Re: [PATCH 3/4] scsi: improved eh timeout handler

2013-06-07 Thread Hannes Reinecke
On 06/07/2013 08:25 AM, Ren Mingxin wrote: Hi, Hannes: On 06/07/2013 04:28 AM, Jörn Engel wrote: On Thu, 6 June 2013 22:39:14 +0200, Hannes Reinecke wrote: +spin_unlock_irqrestore(sdev-list_lock, flags); +SCSI_LOG_ERROR_RECOVERY(3, +scmd_printk(KERN_INFO, scmd

Re: [PATCH 0/4] New SCSI command timeout handler

2013-06-07 Thread Hannes Reinecke
On 06/07/2013 08:54 AM, Ren Mingxin wrote: Hi, Hannes: On 06/06/2013 05:43 PM, Hannes Reinecke wrote: this is the first step towards a new non-blocking error handler. This patch implements a new command timeout handler which will be sending command aborts inline without engaging SCSI EH

Re: [PATCH 3/4] scsi: improved eh timeout handler

2013-06-09 Thread Hannes Reinecke
On 06/10/2013 02:12 AM, Baruch Even wrote: On Thu, Jun 6, 2013 at 12:43 PM, Hannes Reinecke h...@suse.de wrote: When a command runs into a timeout we need to send an 'ABORT TASK' TMF. This is typically done by the 'eh_abort_handler' LLDD callback. Conceptually, however, this function

[PATCH 1/9] scsi: move initialization of scmd-eh_entry

2013-06-10 Thread Hannes Reinecke
The 'eh_entry' list might be used even before scsi_softirq_done() is called. Hence we should rather initialize it together with the other eh-related variables. Signed-off-by: Hannes Reinecke h...@suse.de --- drivers/scsi/scsi_lib.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff

[PATCH 9/9] mpt3sas: Enable new EH timeout handler

2013-06-10 Thread Hannes Reinecke
Signed-off-by: Hannes Reinecke h...@suse.de --- drivers/scsi/mpt3sas/mpt3sas_scsih.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/drivers/scsi/mpt3sas/mpt3sas_scsih.c b/drivers/scsi/mpt3sas/mpt3sas_scsih.c index dcbf7c8..3a35ddc 100644 --- a/drivers/scsi/mpt3sas

[PATCH 8/9] mpt2sas: Enable new EH timeout handler

2013-06-10 Thread Hannes Reinecke
Signed-off-by: Hannes Reinecke h...@suse.de --- drivers/scsi/mpt2sas/mpt2sas_scsih.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/drivers/scsi/mpt2sas/mpt2sas_scsih.c b/drivers/scsi/mpt2sas/mpt2sas_scsih.c index c6bdc92..47fc66c 100644 --- a/drivers/scsi/mpt2sas

[PATCH 6/9] libsas: Enable new EH timeout handler

2013-06-10 Thread Hannes Reinecke
Signed-off-by: Hannes Reinecke h...@suse.de --- drivers/scsi/libsas/sas_scsi_host.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/libsas/sas_scsi_host.c b/drivers/scsi/libsas/sas_scsi_host.c index 6e795a1..9d5bd29 100644 --- a/drivers/scsi/libsas

[PATCH 4/9] virtio_scsi: Enable new EH timeout handler

2013-06-10 Thread Hannes Reinecke
Signed-off-by: Hannes Reinecke h...@suse.de --- drivers/scsi/virtio_scsi.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/scsi/virtio_scsi.c b/drivers/scsi/virtio_scsi.c index 2168258..1efd219 100644 --- a/drivers/scsi/virtio_scsi.c +++ b/drivers/scsi/virtio_scsi.c @@ -654,6

[PATCH 3/9] scsi: improved eh timeout handler

2013-06-10 Thread Hannes Reinecke
to assume the TMF succeeded and the command is completed with the LLDD. If the TMF fails the command will be pushed back onto the list of failed commands and the SCSI EH handler will be called immediately for all timed-out commands. Signed-off-by: Hannes Reinecke h...@suse.de --- drivers/scsi

[PATCHv2 0/9] New SCSI command timeout handler

2013-06-10 Thread Hannes Reinecke
to avoid list starvation (pointed out by Joern Engel) - Terminate command aborts when the first abort fails - Do not attempt command aborts if the host is already in recovery or if the device is removed. - Flush abort workqueue if the device is removed. Comments etc are welcome. Hannes Reinecke

[PATCH 7/9] mptsas: Enable new EH timeout handler

2013-06-10 Thread Hannes Reinecke
Signed-off-by: Hannes Reinecke h...@suse.de --- drivers/message/fusion/mptsas.c | 1 + drivers/message/fusion/mptscsih.c | 7 +++ drivers/message/fusion/mptscsih.h | 1 + 3 files changed, 9 insertions(+) diff --git a/drivers/message/fusion/mptsas.c b/drivers/message/fusion/mptsas.c index

[PATCH 5/9] virtio-scsi: Implement TMF timeout

2013-06-10 Thread Hannes Reinecke
Any TMF might be take longer as expected, or not return at all. So we need to use 'wait_for_completion_timeout' when sending a TMF to protect against these cases. Cc: Paolo Bonzini pbonz...@redhat.com Signed-off-by: Hannes Reinecke h...@suse.de --- drivers/scsi/virtio_scsi.c | 7 +-- 1 file

[PATCH 2/9] blk-timeout: add BLK_EH_SCHEDULED return code

2013-06-10 Thread Hannes Reinecke
Add a 'BLK_EH_SCHEDULED' return code for blk-timeout to indicate that a delayed error recovery has been initiated. Signed-off-by: Hannes Reinecke h...@suse.de --- drivers/scsi/scsi_error.c | 3 +++ include/linux/blkdev.h| 1 + 2 files changed, 4 insertions(+) diff --git a/drivers/scsi

Re: [PATCH 3/9] scsi: improved eh timeout handler

2013-06-10 Thread Hannes Reinecke
On 06/10/2013 10:20 AM, Christoph Hellwig wrote: On Mon, Jun 10, 2013 at 09:40:52AM +0200, Hannes Reinecke wrote: When a command runs into a timeout we need to send an 'ABORT TASK' TMF. This is typically done by the 'eh_abort_handler' LLDD callback. Conceptually, however, this function

[PATCH 3/7] advansys: Remove 'last_reset' references

2013-06-10 Thread Hannes Reinecke
Serves no purpose whatsoever. Signed-off-by: Hannes Reinecke h...@suse.de --- drivers/scsi/advansys.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/scsi/advansys.c b/drivers/scsi/advansys.c index c67e401..d814588 100644 --- a/drivers/scsi/advansys.c +++ b

[PATCH 2/7] dpt_i2o: return SCSI_MLQUEUE_HOST_BUSY when in reset

2013-06-10 Thread Hannes Reinecke
When the HBA is in reset we should be returning 'busy' and not rely on the obscure 'last_reset' feature. Signed-off-by: Hannes Reinecke h...@suse.de --- drivers/scsi/dpt_i2o.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/scsi/dpt_i2o.c b/drivers/scsi

[PATCH 4/7] tmscsim: Move 'last_reset' into host structure

2013-06-10 Thread Hannes Reinecke
The 'last_reset' value is only used internally, so move it into the internal host structure. Signed-off-by: Hannes Reinecke h...@suse.de --- drivers/scsi/tmscsim.c | 14 +++--- drivers/scsi/tmscsim.h | 1 + 2 files changed, 8 insertions(+), 7 deletions(-) diff --git a/drivers/scsi

[PATCH 6/7] scsi: remove check for 'resetting'

2013-06-10 Thread Hannes Reinecke
Field is now unused, so this is dead code. Signed-off-by: Hannes Reinecke h...@suse.de --- drivers/scsi/scsi.c | 28 1 file changed, 28 deletions(-) diff --git a/drivers/scsi/scsi.c b/drivers/scsi/scsi.c index 2c0d0ec..ebe3b0a 100644 --- a/drivers/scsi/scsi.c +++ b

[PATCH 5/7] dc395: Move 'last_reset' into internal host structure

2013-06-10 Thread Hannes Reinecke
'last_reset' is only used internally, so move it into the internal host structure. Signed-off-by: Hannes Reinecke h...@suse.de --- drivers/scsi/dc395x.c | 24 +--- 1 file changed, 13 insertions(+), 11 deletions(-) diff --git a/drivers/scsi/dc395x.c b/drivers/scsi/dc395x.c

[PATCH 7/7] scsi: Add 'eh_deadline' to limit SCSI EH runtime

2013-06-10 Thread Hannes Reinecke
and falls through to issue a host reset only. Signed-off-by: Hannes Reinecke h...@suse.de --- drivers/scsi/hosts.c | 7 +++ drivers/scsi/scsi_error.c | 142 +++--- drivers/scsi/scsi_sysfs.c | 37 include/scsi/scsi_host.h | 2 +- 4 files

[PATCH 0/7] Limit overall SCSI EH runtime

2013-06-10 Thread Hannes Reinecke
earlier patchset 'scsi: improved eh timeout handler'. As usual, comments etc are welcome. Hannes Reinecke (7): dpt_i2o: Remove DPTI_STATE_IOCTL dpt_i2o: return SCSI_MLQUEUE_HOST_BUSY when in reset advansys: Remove 'last_reset' references tmscsim: Move 'last_reset' into host structure dc395

[PATCH 1/7] dpt_i2o: Remove DPTI_STATE_IOCTL

2013-06-10 Thread Hannes Reinecke
scsi_block_host/scsi_unlock_host provides the required functionality. Signed-off-by: Hannes Reinecke h...@suse.de --- drivers/scsi/dpt_i2o.c | 30 -- drivers/scsi/dpti.h| 1 - 2 files changed, 12 insertions(+), 19 deletions(-) diff --git a/drivers/scsi/dpt_i2o.c

Re: [PATCH 8/9] mpt2sas: Enable new EH timeout handler

2013-06-10 Thread Hannes Reinecke
On 06/10/2013 05:31 PM, Jörn Engel wrote: On Mon, 10 June 2013 09:40:57 +0200, Hannes Reinecke wrote: Signed-off-by: Hannes Reinecke h...@suse.de --- drivers/scsi/mpt2sas/mpt2sas_scsih.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/drivers/scsi/mpt2sas/mpt2sas_scsih.c

Re: [PATCH 3/9] scsi: improved eh timeout handler

2013-06-11 Thread Hannes Reinecke
the remaining bits like LUN reset working correctly. Cheers, Hannes -- Dr. Hannes Reinecke zSeries Storage h...@suse.de +49 911 74053 688 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg

Re: [PATCH 3/9] scsi: improved eh timeout handler

2013-06-11 Thread Hannes Reinecke
On 06/11/2013 08:57 PM, James Bottomley wrote: On Mon, 2013-06-10 at 01:20 -0700, Christoph Hellwig wrote: On Mon, Jun 10, 2013 at 09:40:52AM +0200, Hannes Reinecke wrote: When a command runs into a timeout we need to send an 'ABORT TASK' TMF. This is typically done by the 'eh_abort_handler

eh_abort_handler implementations

2013-06-12 Thread Hannes Reinecke
was working. If _that_ should be the case it looks as if we _always_ should be issuing a RESET LUN TMF whenever command aborts have been processed. Would that be correct? Cheers, Hannes -- Dr. Hannes Reinecke zSeries Storage h...@suse.de +49 911 74053 688

[PATCH] scsi: Fix erratic device offline during EH

2013-06-13 Thread Hannes Reinecke
K. Petersen martin.peter...@oracle.com Cc: Ewan Milne emi...@redhat.com Signed-off-by: Hannes Reinecke h...@suse.de --- drivers/scsi/scsi_error.c | 26 +- drivers/scsi/sd.c | 8 +++- include/scsi/scsi_driver.h | 2 +- 3 files changed, 21 insertions(+), 15

  1   2   3   4   5   6   7   8   9   10   >