Re: Linux not adhering to BIOS Drive boot order?

2001-01-17 Thread James Bottomley
are off. If there is sufficient interest in this, I could look at putting together a patch to 2.4.x which would implement the scheme. James Bottomley - To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to [EMAIL PROTECTED]

Re: Scan past lun 7 in 2.4.0

2001-02-08 Thread James Bottomley
[EMAIL PROTECTED] said: James mentioned there might be a patch problem with reservations; has this been sorted? I believe so. A problem still shows up on an IA-64 system with an AHA2944UW SCSI card but cannot be duplicated on an x86 system with the same configuration. All of the tests on

[PATCH] SCSI reservation handling and reset for 2.2.18 and 2.4.2

2001-03-21 Thread James Bottomley
the reset (to prevent heavy I/O starving the command allocation when a reset is requested) and also corrects a locking problem in the old mid-layer issuing the reset. James Bottomley Index: linux/2.4/drivers/scsi/scsi.c diff -c linux/2.4/drivers/scsi/scsi.c:1.1.1.5 linux/2.4/drivers/scsi/scsi.c

Re: Linux Cluster using shared scsi

2001-05-01 Thread James Bottomley
[EMAIL PROTECTED] said: Does this package also tell the kernel to re-establish a reservation for all devices after a bus reset, or at least inform a user level program? Finding out when there has been a bus reset has been a stumbling block for me. [EMAIL PROTECTED] said: You cannot rely

Re: Linux Cluster using shared scsi

2001-05-01 Thread James Bottomley
[EMAIL PROTECTED] said: So, will Linux ever support the scsi reservation mechanism as standard? That's not within my gift. I can merely write the code that corrects the behaviour. I can't force anyone else to accept it. [EMAIL PROTECTED] said: Isn't there a standard that says if you scsi

Re: [NEW SCSI DRIVER] for 53c700 chip and NCR_D700 card against 2.4.4

2001-05-13 Thread James Bottomley
[EMAIL PROTECTED] said: If I am not mistaken, Richard Hirst has also done work on this thing. The Panther/lp486e/PWS/... has on-board ethernet (82596) and this now works under both 2.2 and 2.4. It also has on-board SCSI (NCR 53c700-66), maybe memory mapped, I forget. Maybe nobody knows the

Re: [NEW SCSI DRIVER] for 53c700 chip and NCR_D700 card against 2.4.4

2001-05-14 Thread James Bottomley
I've implemented most of these as you suggest, with these exceptions: + default: + printk(KERN_INFO scsi%d (%d:%d): Unexpected message %s: , + host-host_no, pun, lun, + NCR_700_phase[(dsps 0xf00) 8]); +

Re: issuing ioctl()'s to an adapter driver wo/ devices

2001-05-24 Thread James Bottomley
a reasonable convention for drivers like yours and requires no modifications to the current SCSI subsystem. James Bottomley - To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to [EMAIL PROTECTED]

Re: Simulate a SCSI disk

2001-05-24 Thread James Bottomley
controller OS. To get this to work, they'd essentially have to have done what you're proposing. James Bottomley - To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to [EMAIL PROTECTED]

Re: [PATCH as448] Fix reference to deallocated memory in sr.c

2005-01-18 Thread James Bottomley
On Tue, 2005-01-18 at 09:56 -0500, Alan Stern wrote: When I posted a patch last week to fix a reference to deallocated memory in sd.c, I forgot to check whether the same problem exists in sr.c. It does, and here's the patch to fix it. Yes, I already caught that in the scsi-rc-fixes-2.6 tree

Re: [PATCH] Add compat_ioctl to scsi host structure

2005-01-18 Thread James Bottomley
On Tue, 2005-01-18 at 12:03 +0100, Andi Kleen wrote: Add a call vector for 32bit compat ioctls to the SCSI host structure. This is needed for some followon patches. Signed-off-by: Andi Kleen [EMAIL PROTECTED] Shouldn't this also be surrounded by #ifdef CONFIG_COMPAT (on the grounds that you

Re: [PATCH] Add compat_ioctl to scsi host structure

2005-01-19 Thread James Bottomley
On Wed, 2005-01-19 at 00:27 +0100, Andi Kleen wrote: On Tue, Jan 18, 2005 at 07:35:36AM -0800, James Bottomley wrote: Shouldn't this also be surrounded by #ifdef CONFIG_COMPAT (on the grounds that you never fill it in unless CONFIG_COMPAT is defined)? At least the standard file_operations

RE: How to add/drop SCSI drives from within the driver?

2005-01-21 Thread James Bottomley
On Fri, 2005-01-21 at 17:11 -0500, Mukker, Atul wrote: All right! The implementation is complete for this and the driver has thoroughly gone through testing. Everything looks good except for a minor glitch. That's good news. After the new logical drives are created with - - - written to the

Re: Fw: [Bugme-new] [Bug 4077] New: kernel oops with Fusion MPT SCSI driver

2005-01-21 Thread James Bottomley
On Fri, 2005-01-21 at 15:32 -0800, Andrew Morton wrote: NIP [c007f94c] .free_block+0xf0/0x1b8 LR [c007fad8] .drain_array_locked+0xc4/0x138 Call Trace: [cff8fb80] [cff8fc20] 0xcff8fc20 (unreliable) [cff8fc30]

Re: [PATCH] zfcp: updates for -bk

2005-01-24 Thread James Bottomley
On Mon, 2005-01-24 at 15:48 +0100, Heiko Carstens wrote: I thought that having release methods that just called kfree() were also verboten? We do a kmalloc(sizeof(struce device),...) somewhere and this is how we get rid of it again. How are we supposed to free this object otherwise? The

Re: [PATCH] add iSCSI session creation sysfs attributes

2005-01-24 Thread James Bottomley
On Mon, 2005-01-24 at 02:39 -0800, Mike Christie wrote: The attached patch built against scsi-misc-2.6 moves the target iSCSI attributes to a new structure representing a iSCSI session. The reason for doing this is to create a interface that allows the Sourceforge iSCSI driver to create and

Re: [PATCH] zfcp: updates for -bk

2005-01-25 Thread James Bottomley
On Tue, 2005-01-25 at 07:08 +0100, Heiko Carstens wrote: Originally this generic device was part of your adapter structure. Now you're trying to separate it and causing these problems. What it's Could you please elaborate where this patch does cause a problem? You're look to be breaking

Re: [PATCH] zfcp: updates for -bk

2005-01-25 Thread James Bottomley
On Tue, 2005-01-25 at 19:10 +0100, Martin Peschke3 wrote: Actually, you will find the adapter structure be an anchor for several other objects, or lists of them respectively. We tried to organize all the driver private data in a sane way. That means there is a tree of objects representing the

Re: [PATCH] add iSCSI session creation sysfs attributes

2005-01-25 Thread James Bottomley
On Tue, 2005-01-25 at 12:37 -0800, Mike Christie wrote: Will do. One question though. If a function like transport_add_device or transport_setup_device fails, how does the caller detect this? It doesn't; the system runs degraded. James - To unsubscribe from this list: send the line

[BK PATCH] SCSI updates for 2.6.11-rc2

2005-01-25 Thread James Bottomley
o streamline block SG_IO error processing in sd o streamline block SG_IO error processing o sense data helpers lk 2.6.11-rc1-bk1 o sg descriptor sense cleanup lk 2.6.11-rc1-bk1 o scsi_debug dsense Geert Uytterhoeven: o SCSI NCR53C9x.c: some cleanups James Bottomley: o SCSI: Fix

Re: [PATCH] add missing class_device_del to transport classes

2005-01-27 Thread James Bottomley
On Wed, 2005-01-26 at 15:59 -0800, Mike Christie wrote: It appears there is a missing class_device_del. Yes, my fault for converting it incorrectly. What it's supposed to use is the (nonexistent) equivalent of attribute_container_class_device_del and attribute_container_add_class_attrs, but

Re: [PATCH] scsi/sata write barrier support

2005-01-28 Thread James Bottomley
On Fri, 2005-01-28 at 10:38 +0100, Jens Axboe wrote: +/* + * snoop succesfull completion of mode select commands that update the + * write back cache state + */ +#define MS_CACHE_PAGE0x08 +static void sd_snoop_cmd(struct scsi_cmnd *cmd) +{ + struct scsi_disk *sdpk; + char

Re: [PATCH] scsi/sata write barrier support

2005-01-28 Thread James Bottomley
On Fri, 2005-01-28 at 10:38 +0100, Jens Axboe wrote: +/* + * snoop succesfull completion of mode select commands that update the + * write back cache state + */ +#define MS_CACHE_PAGE0x08 +static void sd_snoop_cmd(struct scsi_cmnd *cmd) +{ + struct scsi_disk *sdpk; + char

Re: Ooops unmounting a defect DVD

2005-01-29 Thread James Bottomley
I wouldn't have noticed this at all since you didn't send it to the scsi list, but fortunately, Al Viro drew it politely to my attention as another example of SCSI refcounting problems. The issue seems to be that we have a spurious scsi_cd_put() on the error path of sr_open(). The sr_block_..()

Re: Mid-layer handling of NOT_READY conditions...

2005-01-29 Thread James Bottomley
On Fri, 2005-01-28 at 21:46 -0800, Andrew Vasquez wrote: Returning back DID_IMM_RETRY for these 'transport' related conditions would of course help in this issue -- but at the same time bring with it several side-effects which may not be desirable. So, beyond this particular circumstance,

[PATCH] fix multiple HBA problem with transport classes

2005-01-29 Thread James Bottomley
All of the transport class patches contain a thinko in device matching (and, unfortunately, one I exhorted everyone not to make in the generic transport class comments): The match matches every container in the class instead of the specific container belonging to the HBA. This causes a oops when

Re: Mid-layer handling of NOT_READY conditions...

2005-01-29 Thread James Bottomley
On Sat, 2005-01-29 at 11:34 -0800, Patrick Mansfield wrote: But the transport hit a failure, not the storage device. I thought Andrew hit this sequence: - pull / replace cable - IO resumes but gets NOT_READY (the device could be logging back into the fibre or such)

Re: [PATCH] add missing class_device_del to transport classes

2005-01-29 Thread James Bottomley
On Wed, 2005-01-26 at 15:59 -0800, Mike Christie wrote: It appears there is a missing class_device_del. The comments for transport_remove_device indicate that transport_remove_classdev should call it (which the attached patch does), but the comment in attribute_container_remove_device: OK,

[PATCH] fix HBA removal problem with transport classes

2005-02-01 Thread James Bottomley
James Smart pointed out that if you insert and remove a HBA driver a few times, eventually the system oopses. The reason is that the transport classes all kfree their attribute containers, but don't actually unregister them first (so we have freed memory on the container list). The attached

Re: [PATCH] fix the fix for multiple HBA problem with transport classes

2005-02-02 Thread James Bottomley
On Wed, 2005-02-02 at 15:55 -0500, [EMAIL PROTECTED] wrote: Testing was showing transport devices not being enumerated. The reason was the wrong attribute container was being compared against in the match functions. This patch fixes it. OK, I confess ... I quietly fixed these three before

[PATCH] fix warnings in new compat code for scsi

2005-02-03 Thread James Bottomley
I just got around to applying and testing this. I needed the attached to get around the compile warnings it gave me on ia64 I've got to say, it doesn't look pretty to have the block layer compat_ioctl returning long but the scsi one returning int; likewise with the void __user *arg vs unsigned

Re: [PATCH 2/3] MidLayer updates - Add device io statistics

2005-02-03 Thread James Bottomley
On Sat, 2005-01-29 at 09:03 -0500, [EMAIL PROTECTED] wrote: Adds io statistics (requests, completions, error count) as generic attributes for scsi devices. I needed the attached to make this compile without warnings on ia64 James = drivers/scsi/scsi_sysfs.c 1.65 vs edited = ---

Re: About ARECA RAID driver for Linux i386/x86-64

2005-02-03 Thread James Bottomley
On Wed, 2005-02-02 at 20:51 -0800, Andrew Morton wrote: Well that's a decision which the scsi maintainers will need to make. Lots of current drivers use LINUX_VERSION_CODE, even though we'd prefer they not do so. I don't know what the scsi policy is for new submissions. Hey ... I have to

Re: [PATCH 1/3] MidLayer updates - extending transport/attribute container changes

2005-02-04 Thread James Bottomley
On Sat, 2005-01-29 at 09:03 -0500, [EMAIL PROTECTED] wrote: Updates the recent transport container patch for : - allow device driver-specific attributes to be added to class objects - exposes classdev to transport via setup function I'm not very keen on this for two reasons: 1) The

Re: [PATCH 3/3] MidLayer updates - extending scsi_target support

2005-02-04 Thread James Bottomley
On Sat, 2005-01-29 at 09:03 -0500, [EMAIL PROTECTED] wrote: This patch extends scsi_target support: - Allows for driver-specific data to be allocated along with the target structure and accessible via the starget-hostdata pointer. - Adds scsi target alloc/configure/destory callbacks

[BK PATCH] Critical SCSI fixes for 2.6.11-rc2

2005-02-01 Thread James Bottomley
for them? Everything else in this tree is also a regression bugfix (except the addition of the qla maintainer, which is a documentation bugfix) The tree contains: Andrew Vasquez: o MAINTAINERS: add entry for qla2xxx driver Douglas Gilbert: o fix scsi cdrom problem James Bottomley: o Fix

Re: Bug: audio playing broke with my SCSI CD and DVD drives in 2.6.11-rc2-bk7 and beyond.

2005-01-31 Thread James Bottomley
On Tue, 2005-02-01 at 00:22 +0100, Jesper Juhl wrote: audio Could you try the attached? James ---BeginMessage--- Jens Axboe wrote: On Mon, Jan 31 2005, Douglas Gilbert wrote: Jens Axboe wrote: On Mon, Jan 31 2005, Fabio Coatti wrote: Alle 09:00, lunedì 31 gennaio 2005, Jens Axboe ha scritto:

RE: [Announce] megaraid_mbox 2.20.4.4 patch

2005-02-02 Thread James Bottomley
On Wed, 2005-02-02 at 10:56 -0500, Ju, Seokmann wrote: + .sdev_attrs = megaraid_device_attrs, + .shost_attrs= megaraid_class_device_attrs, These are, perhaps, slightly confusing names. The terms device and class_device have well defined meanings

[BK PATCH] SCSI bug fixes for 2.6.11-rc3

2005-02-10 Thread James Bottomley
: fix BUG's for smp_processor_id() on interrupt Christoph Hellwig: o cciss: handle scsi_add_host failure James Bottomley: o SCSI: fix HBA removal problem with transport classes Seokmann Ju: o megaraid_mbox 2.20.4.3 patch and the diffstat is: Documentation/scsi/ChangeLog.megaraid | 104

Re: [PATCH] mark qlogicisp broken

2005-02-10 Thread James Bottomley
On Thu, 2005-02-10 at 10:30 -0800, Patrick Mansfield wrote: On Thu, Feb 10, 2005 at 07:18:51PM +0100, Christoph Hellwig wrote: It's lacking EH support and the hardware is supported by the qla1280 driver now. Can we instead remove this one and the qlogicfc? Dave Miller still has a problem

Re: [usb-storage] Re: MPIO HS200 Gigabox weird behaviour again

2005-02-11 Thread James Bottomley
On Fri, 2005-02-11 at 11:00 -0500, Alan Stern wrote: SCSI developers: Is there any hope of this? Well, IBM also has some old buggy piece of hardware that apparently gives fatal errors but actually wants them retried: http://marc.theaimsgroup.com/?t=11008869615 After a bit of argument, they

Re: [Repost] [PATCH scsi-rc-fixes-2.6] Re-enable FC Transport Host Statistics

2005-02-11 Thread James Bottomley
On Wed, 2005-02-09 at 13:06 -0500, [EMAIL PROTECTED] wrote: The patch contained in the original message had a mixed up diff line... Here's the corrected patch. Well, no, not this way. attribute containers are supposed to be pure abstractions, so we can't put statistics in them. The

Re: [KJ] [PATCH][RESUBMIT][11/21] drivers/scsi/* - compile warning cleanup

2005-02-15 Thread James Bottomley
On Tue, 2005-02-15 at 14:09 +, Matthew Wilcox wrote: Actually, for 53c700, I think this *is* the right fix. Unless we want to move it away from using host-base (which is marked as legacy crap, so maybe we do). I guess pushing it into hostdata is the preferred way? Well, no it's not

[RFC] target code updates to support scanned targets

2005-02-15 Thread James Bottomley
Since everyone's been asking for the ability to do target scanning, I took a look at how this might be done in our current infrastructure. The attached patch does three things: 1. Pulls target allocation forward so it's now allocated and destroyed as a separate entity instead of being bound into

Re: [RFC] target code updates to support scanned targets

2005-02-15 Thread James Bottomley
On Tue, 2005-02-15 at 15:29 -0800, Joe Scsi wrote: I see the internal changes to scsi_scan.c that this refers to, but I'm not totally clear on what a driver should do to allocate a target and scan it when it finds out about a new target port. A driver doesn't allocate a target. In this code,

Re: [RFC] target code updates to support scanned targets

2005-02-15 Thread James Bottomley
On Tue, 2005-02-15 at 16:53 -0800, Andrew Vasquez wrote: Yes, but the parent needs to know if the starget is actually created. With the fc_rports snapshot I've been working with, I've coded up the following: Why do you need to know if the scan actually found any LUNs? +

Re: [RFC] target code updates to support scanned targets

2005-02-15 Thread James Bottomley
On Tue, 2005-02-15 at 16:54 -0800, Joe Scsi wrote: OK (and sorry if I'm being dense) but does this mean that a network SCSI transport should make up an id for each target port it connects to and then call scsi_scan_target()? Currently yes ... now that we allow unscanned hosts, it's not

Re: scsi_device::single_lun name change

2005-02-15 Thread James Bottomley
On Wed, 2005-02-16 at 10:57 +1000, Douglas Gilbert wrote: scsi_target: representation of a scsi target, for now, this is only used for single_lun devices. This is just above the definition of the scsi_target structure in scsi_device.h Yes, I suppose that's historical junk now. Elsewhere in

Re: [ANNOUNCE] Adaptec SAS/SATA device driver [0/27]

2005-02-17 Thread James Bottomley
On Thu, 2005-02-17 at 12:34 -0500, Luben Tuikov wrote: Adaptec would like to announce its SAS/SATA Linux device driver for inclusion into the Linux kernel. Well, the initial reaction is yuk. Just from a brief glance over the files, the code is full of obfuscation and unnecessary compatibility

Re: cciss CSMI via sysfs for 2.6

2005-02-18 Thread James Bottomley
On Fri, 2005-02-18 at 12:05 -0800, Greg KH wrote: For a device? It seems a huge overkill to add this attribute for _every_ device in the system, when only a small minority can actually use it. Just put it as a default scsi or transport class attribute instead. Actually, we might be able to

Re: [PATCH 9/13] nsp32, nsp_cs driver update

2005-02-28 Thread James Bottomley
On Tue, 2005-02-22 at 16:11 +0900, Yokota Hiroshi wrote: + if (data-CurrentSC != NULL) { + nsp_msg(KERN_WARNING, CurrentSC!=NULL this can't be happen); SCpnt-result = DID_BAD_TARGET 16; nsp_scsi_done(SCpnt); - return 0; +

Re: [PATCH as470] Add a NOREPORTLUN blacklist flag

2005-02-28 Thread James Bottomley
On Sun, 2005-02-20 at 22:44 -0500, Alan Stern wrote: James, please withdraw the patch above. Actually, I already have this in the tree. Could you just do an incremental to remove the blacklist line since I think the IBM people still want their shark fix? Thanks, James - To unsubscribe from

Re: [PATCH] Fix selection of command serial numbers and pids

2005-03-06 Thread James Bottomley
On Sun, 2005-02-06 at 20:51 +0100, Andi Kleen wrote: This patch fixes one of Christroph's fixme comments in the SCSI midlayer. Could you reroll this against scsi-misc-2.6, please? I get mainly rejections when I try to apply it. Thanks, James - To unsubscribe from this list: send the line

Re: [patch] add scsi changer driver

2005-03-06 Thread James Bottomley
Looking through this, the only things I really noticed that need work are: ch_do_scsi(): It looks like this has an effective reimplementation of scsi_wait_req. We're trying to deprecate the usage of scsi_do_req so we can make it private eventually. What's the reason you can't use

Re: [patch] add scsi changer driver

2005-03-07 Thread James Bottomley
On Mon, 2005-03-07 at 09:21 +0100, Gerd Knorr wrote: Probably historical reasons, I havn't tracked the scsi layer changes for quite some time, so this might simply be a 2.6 cleanup I've missed because of that. Will check ... OK, Thanks. ch_ioctl() (and the compat): since this is a new

Re: [RFC] ncr53c8xx updates

2005-03-11 Thread James Bottomley
On Mon, 2005-03-07 at 02:32 +, Matthew Wilcox wrote: Thanks for reminding me; still the only person who cares about the Q720 also follows the parisc-linux-cvs list ;-) Hey, I have more than one user! Also, I don't really follow the parisc CVS tree on the voyagers; primarily because I

Re: [PATCH 1/2] SCSI tape fixes (new version): sense descriptor init, bsf-weof, blkno, debugging

2005-03-15 Thread James Bottomley
On Sat, 2005-03-12 at 19:04 +0200, Kai Makisara wrote: This is an updated version of the patch I sent March 7. The sense descriptor initialization has been made lighter. The patch at the end of this message applies to 2.6.11-bk7 + st descriptor sense patch + st auto eof patch (i.e., st

[BK PATCH] SCSI updates for 2.6.11

2005-03-15 Thread James Bottomley
Liakhovetski: o dc395x: Fix support for highmem James Bottomley: o FC Remote Port Patch o SCSI: dc395x.c add missing #include linux/vmalloc.h o SCSI: fix transport statistics mismerge o Add statistics to generic transport class o SCSI: revamp target scanning routines o SCSI: fix io

Re: [PATCH] dc395x: Fix support for highmem

2005-03-16 Thread James Bottomley
On Wed, 2005-03-16 at 08:58 +0100, Jens Axboe wrote: Guys, who reviewed this? It looks completely bogus, using kmap() for tha entire sg list is just wrong and can deadlock easily. The proper way is of course to skip the virtual address requirement and dma map the sg array properly. I suppose

Re: [BK PATCH] SCSI updates for 2.6.11

2005-03-16 Thread James Bottomley
On Wed, 2005-03-16 at 13:35 -0500, Jeff Garzik wrote: Are my 3ware bugfixes in the queue? Currently 3ware claims it handled the interrupt, even the interrupt is a shared one and the event was meant for another driver. Not in my queue ... you could try Adam Radford directly ... James - To

Re: [BK PATCH] SCSI updates for 2.6.11

2005-03-16 Thread James Bottomley
On Wed, 2005-03-16 at 15:31 -0500, Jeff Garzik wrote: More info? Were they dropped on purpose, or just never arrived? If dropped on purpose, what was the reason? You posted substantive updates to a maintained driver. Adam Radford is the maintainer, but I haven't heard anything from him

Re: [PATCH] 2/2 Use bus dev_attrs to create scsi_device attributes

2005-03-17 Thread James Bottomley
On Wed, 2005-03-16 at 14:45 -0800, Patrick Mansfield wrote: Any comments on this? Should I resend these patches? Well, the basic comment is that there are a lot of features that SCSI has that the driver core lacks: 1) Attribute overrides. This is actually part of the published API for SCSI 2)

Re: [PATCH] [4/5] ncr53c8xx update

2005-03-19 Thread James Bottomley
On Fri, 2005-03-18 at 20:56 -0700, Matthew Wilcox wrote: ncr53c8xx update There's actually a slight problem with this one: on my Q720 it produces messages like this: ncr53c720-1: ID 7, Fast-10, Parity Checking scsi1 : ncr53c8xx-3.4.3g target1:0:1: target did not report SYNC. Vendor: TOSHIBA

Re: [PATCH] [2/5] Improve 53c700 /proc/interrupt output

2005-03-20 Thread James Bottomley
On Sat, 2005-03-19 at 16:23 +, Matthew Wilcox wrote: On Sat, Mar 19, 2005 at 09:53:07AM -0600, James Bottomley wrote: How about I look at abstracting the name so that the glue driver (in your case lasi700) can set the name? That would work too ... OK, how about the attached. It does

Re: [PATCH] scsi_allocate_request() reference

2005-03-21 Thread James Bottomley
On Mon, 2005-03-21 at 14:26 +0100, Jens Axboe wrote: scsi_allocate_request() doesn't hold a reference to the device that it points to, that is not good. This patch fixes that up. Actually, I don't think this is correct. The reference is taken when the command is attached to a request in the

Re: queue - sdev reference counting problem

2005-03-21 Thread James Bottomley
On Mon, 2005-03-21 at 15:59 +0100, Jens Axboe wrote: This is not even enough, since the queue lock is embedded in sdev structure. Guys, this is a serious issue. Oopsing a kernel is trivial with a hotplug device like a usb stick. Do you have the instructions to reproduce and a trace ... I've

Re: [PATCH] scsi_allocate_request() reference

2005-03-22 Thread James Bottomley
On Tue, 2005-03-22 at 12:17 +0100, Jens Axboe wrote: You need to have io in progress. The one ref problem with scsi_allocate_request() is easy to trigger, if you just open/close the device repeatedly while inserting and removing it. OK, this is the python program I've been using: while 1:

Re: [PATCH] - Fusion-MPT much faster as module

2005-03-22 Thread James Bottomley
On Tue, 2005-03-22 at 11:40 -0700, Moore, Eric Dean wrote: History on this: Between the 3.01.16 and 3.01.18, we introduced new method to passing command line options to the driver. Some of the command line options are used for fine tuning dv(domain validation) in the driver. By accident,

RE: [PATCH] - Fusion-MPT much faster as module

2005-03-22 Thread James Bottomley
On Tue, 2005-03-22 at 13:35 -0700, Moore, Eric Dean wrote: I still wonder if the SPI transport layer will work for RAID volumes. Do you know if the spi transport layer supports dv on hidden devices in a raid volume? Meaning these hidden physical disks will not been seen by the block layer,

Re: [PATCH scsi-misc-2.6 08/08] scsi: fix hot unplug sequence

2005-03-22 Thread James Bottomley
On Wed, 2005-03-23 at 11:14 +0900, Tejun Heo wrote: When hot-unplugging using scsi_remove_host() function (as usb does), scsi_forget_host() used to be called before scsi_host_cancel(). So, the device gets removed first without request cleanup and scsi_host_cancel()

Re: [PATCH scsi-misc-2.6 04/08] scsi: remove meaningless volatile qualifiers from structure definitions

2005-03-22 Thread James Bottomley
On Wed, 2005-03-23 at 11:14 +0900, Tejun Heo wrote: scsi_device-device_busy, Scsi_Host-host_busy and -host_failed have volatile qualifiers, but the qualifiers don't serve any purpose. Kill them. While at it, protect -host_failed update in scsi_error for consistency

Re: [PATCH scsi-misc-2.6 07/08] scsi: remove bogus {get|put}_device() calls

2005-03-22 Thread James Bottomley
On Wed, 2005-03-23 at 11:14 +0900, Tejun Heo wrote: So, basically, SCSI high-level object (scsi_disk) and mid-level object (scsi_device) are reference counted by users, not the requests they submit. Reference count cannot go zero with active users and users cannot

Re: [PATCH scsi-misc-2.6 08/08] scsi: fix hot unplug sequence

2005-03-23 Thread James Bottomley
On Wed, 2005-03-23 at 13:50 +0900, Tejun Heo wrote: Well, but it's because scsi midlayer calls back into usb-storage eh after the detaching process is complete. Yes, but that's legitimate. It's always been explicitly stated that we can't ensure absolute synchronisation in the stack:

Re: [PATCH scsi-misc-2.6 04/08] scsi: remove meaningless volatile qualifiers from structure definitions

2005-03-23 Thread James Bottomley
On Tue, 2005-03-22 at 23:22 -0500, Jeff Garzik wrote: volatile is almost always (a) buggy, or (b) hiding bugs. At the very least, barriers are usually needed. The choice is either barrier or volatile usually. volatile is nasty primarily because it causes compiler pessimism in variable

Re: [PATCH scsi-misc-2.6 08/08] scsi: fix hot unplug sequence

2005-03-23 Thread James Bottomley
On Wed, 2005-03-23 at 08:19 +0100, Jens Axboe wrote: It is not the oops I am getting. When I get a few minutes today, I'll reproduce with vanilla and post it here. Well, I have news too. Unfortunately, the python script I posted is hanging in D wait. When I tested all of this out (with a

Re: Proposal to add a new sysfs attribute to SCSI device

2005-03-23 Thread James Bottomley
On Tue, 2005-03-22 at 11:05 +0800, Zhao, Forrest wrote: Let me tell you the testing experience in our lab: 1 we install kernel 2.6.11.2 on a Tiger4 platform, 2 there're two SCSI disks, one is sda for root fs, the other is sdb for /mnt 3 execute cp -r /usr/src/linux-2.6.11.2 /mnt 4 during

Re: [PATCH 1/1] 3ware driver update for linux-2.6.12-rc1-bk2

2005-03-23 Thread James Bottomley
On Mon, 2005-03-21 at 19:38 -0800, adam radford wrote: This patch updates the driver for the 3ware 5/6/7/8000 series to do the following: This one got mangled by your mailer ... (looks like it broke long lines). Could you resend? Thanks, James - To unsubscribe from this list: send the line

Re: [PATCH scsi-misc-2.6 08/08] scsi: fix hot unplug sequence

2005-03-24 Thread James Bottomley
On Fri, 2005-03-25 at 12:15 +0900, Tejun Heo wrote: I think I found the cause. Special requests submitted using scsi_do_req() never initializes -end_io(). Normally, SCSI midlayer terminates special requests inside the SCSI midlayer without passing through the blkdev layer. However, if a

Re: [PATCH 1/7] - MPT FUSION - SPLITTING SCSI HOST DRIVERS

2005-03-25 Thread James Bottomley
On Thu, 2005-03-24 at 16:56 -0700, Moore, Eric Dean wrote: + config FUSION_FC - tristate Fusion MPT (base + ScsiHost) drivers for FC - depends on PCI SCSI + tristate Fusion MPT (ScsiHost) drivers for FC This rejects completely in Kconfig. Could you check your base for

Re: [PATCH 6/7] - MPT FUSION - SPLITTING SCSI HOST DRIVERS

2005-03-25 Thread James Bottomley
On Thu, 2005-03-24 at 16:57 -0700, Moore, Eric Dean wrote: +static struct device_attribute mptscsih_queue_depth_attr = { + .attr = { + .name = queue_depth, + .mode = S_IWUSR, + }, + .store = mpt_core_store_queue_depth, +}; But

Re: [PATCH scsi-misc-2.6 08/08] scsi: fix hot unplug sequence

2005-03-26 Thread James Bottomley
On Sat, 2005-03-26 at 09:27 +0200, Kai Makisara wrote: I fully agree that doing done() correctly _is_ a problem, especially when the SCSI subsystem evolves and the high-level driver writers do not follow the development closely enough. One solution to these problems would be to let the

Re: [PATCH 6/7] - MPT FUSION - SPLITTING SCSI HOST DRIVERS

2005-03-27 Thread James Bottomley
On Sun, 2005-03-27 at 01:16 -0800, Jeremy Higdon wrote: James, actually this queue depth code predates your change_queue_depth API. I don't think it was ever converted to the new API. Erk, you're right. My todo list says I'm only waiting on 3ware patches for all the conversions to be

Re: program scsi_unique_id is using a deprecated SCSI ioctl, please convert it to SG_IO

2005-03-28 Thread James Bottomley
On Mon, 2005-03-28 at 07:33 -0300, Marcelo Tosatti wrote: You probably already know about this, but just in case: v2.6.12-rc1 yields program scsi_unique_id is using a deprecated SCSI ioctl, please convert it to SG_IO Actually, a lot of programs do this. Since about 2.6.11 (I think,

Re: [2.6 patch] SCSI: cleanups

2005-03-28 Thread James Bottomley
On Mon, 2005-03-28 at 17:29 +0200, Arjan van de Ven wrote: how about a CONFIG_SCSI_DRIVER_DEBUG ? In principle, that's fine ... in practice does the few bytes saved by this really justify adding yet another option? James - To unsubscribe from this list: send the line unsubscribe linux-scsi in

Re: program scsi_unique_id is using a deprecated SCSI ioctl, please convert it to SG_IO

2005-03-28 Thread James Bottomley
On Mon, 2005-03-28 at 09:34 -0300, Marcelo Tosatti wrote: I'm using FC2 - FC3 probably has it updated. Sorry for the noise. Heh, not necessarily ... the reason for making the SCSI subsystem print these messages is that no-one was updating any user level programs to move to the new API ... now

Re: [PATCH] 2.6 aacraid: endian cleanup

2005-03-28 Thread James Bottomley
On Mon, 2005-03-21 at 10:41 -0800, Mark Haverkamp wrote: + Adaptec 2130S Why are we getting updated card support in an endian cleanup patch? +/* + * Some configurations of BE Linux have writel and readl automatically perform + * byte swapping, and some configurations (embedded) do not.

Re: [PATCH] 2.6 aacraid: endian cleanup

2005-03-28 Thread James Bottomley
On Mon, 2005-03-28 at 14:04 -0800, Mark Haverkamp wrote: On Mon, 2005-03-28 at 15:58 -0600, James Bottomley wrote: What exactly is this for? I know of no platforms that implement readl and friends incorrectly, so all of this should be unnecessary. I wondered about this. Mark S. thought

[BK PATCH] SCSI updates for 2.6.12-rc1

2005-03-30 Thread James Bottomley
: o drivers/scsi/osst.c: remove unused code o drivers/scsi/osst.c: make code static Alan Cox: o atp870u DMA mask fix o atp870u: Re-merge cleanups Alan Stern: o Add a scsi_device flag for RETRY_HWERROR Eric Moore: o Make Fusion-MPT much faster as module James Bottomley: o Fix SCSI

Re: [PATCH] dc395x: Fix support for highmem

2005-03-30 Thread James Bottomley
On Wed, 2005-03-30 at 23:22 +0200, Guennadi Liakhovetski wrote: What is going to happen to this stuff? The current Linus' tree contains a broken (by me:-() dc395x, other drivers (including tmscsim) would benefit from a generic API. I understand, the drivers are not top importance, but

Re: [PATCH scsi-misc-2.6 02/13] scsi: don't turn on REQ_SPECIAL on sgtable allocation failure.

2005-03-31 Thread James Bottomley
On Thu, 2005-03-31 at 18:08 +0900, Tejun Heo wrote: Don't turn on REQ_SPECIAL on sgtable allocation failure. This was the last place where REQ_SPECIAL is turned on for normal requests. If you do this, you'll leak a command every time the sgtable allocation fails. James -

Re: [PATCH scsi-misc-2.6 01/13] scsi: don't use blk_insert_request() for requeueing

2005-03-31 Thread James Bottomley
On Thu, 2005-03-31 at 18:07 +0900, Tejun Heo wrote: 01_scsi_no_REQ_SPECIAL_on_requeue.patch blk_insert_request() has 'reinsert' argument, which, when set, turns on REQ_SPECIAL and REQ_SOFTBARRIER and requeues the request. SCSI midlayer was the only user of this feature and

Re: [PATCH scsi-misc-2.6 09/13] scsi: in scsi_prep_fn(), remove bogus comments clean up

2005-03-31 Thread James Bottomley
On Thu, 2005-03-31 at 18:08 +0900, Tejun Heo wrote: - * come up when there is a medium error. We have to treat - * these two cases differently. We differentiate by looking - * at request-cmd, as this tells us the real story. + * come up when there is a medium error. This

Re: [PATCH scsi-misc-2.6 08/13] scsi: move request preps in other places into prep_fn()

2005-03-31 Thread James Bottomley
On Thu, 2005-03-31 at 18:08 +0900, Tejun Heo wrote: Move request preparations scattered in scsi_request_fn() and scsi_dispatch_cmd() into scsi_prep_fn(). * CDB_SIZE check in scsi_dispatch_cmd() * SCSI-2 LUN preparation in scsi_dispatch_cmd() *

Re: [PATCH scsi-misc-2.6 01/13] scsi: don't use blk_insert_request() for requeueing

2005-04-01 Thread James Bottomley
On Fri, 2005-04-01 at 14:01 +0900, Tejun Heo wrote: Well, REQ_SPECIAL is the signal to the mid-layer that we've allocated the resources necessary to process the command, so in practice it will be turned on for every requeue request (because we set it when the command is prepared),

RE: How to find which (physical) SCSI HBA corresponds to which ho st n umber?

2005-04-01 Thread James Bottomley
On Fri, 2005-04-01 at 09:47 -0800, Bryan Henderson wrote: If you and Linux could identify the host in common terms, you wouldn't have to do this. But the question is open as to in what terms you personally identify the host to which you attached the device. Is it the controller to the

Re: [2.6 patch] drivers/scsi/dpti.h: remove kernel 2.2 #if's

2005-04-02 Thread James Bottomley
On Sun, 2005-03-27 at 16:34 +0200, Adrian Bunk wrote: This patch removes #if's for kernel 2.2 . this one looks like it's not quite complete: -#ifndef LINUX_VERSION_CODE #include linux/version.h -#endif Once there are no more KERNEL_VERSION dependencies in a file, it's inclusion of

[PATCH] finally fix 53c700 to use the generic iomem infrastructure

2005-04-02 Thread James Bottomley
This driver has had it's own different infrastructure for doing this for ages, but it's time it used the common one. James = drivers/scsi/53c700.c 1.64 vs edited = --- 1.64/drivers/scsi/53c700.c 2005-03-20 21:04:31 -06:00 +++ edited/drivers/scsi/53c700.c2005-04-02 14:15:04

Re: iomapping a big endian area

2005-04-04 Thread James Bottomley
On Mon, 2005-04-04 at 17:50 +1000, Benjamin Herrenschmidt wrote: I disagree. The driver will never know ... ? the driver has to know. Look at the 53c700 to see exactly how awful it is. This beast has byte and word registers. When used BE, all the byte registers alter their position (to both

Re: [PATCH scsi-misc-2.6 08/13] scsi: move request preps in other places into prep_fn()

2005-04-04 Thread James Bottomley
On Fri, 2005-04-01 at 14:25 +0900, Tejun Heo wrote: Ah.. with later requeue path consolidation patches, all requests get their sense buffer cleared during requeueing, which, IMHO, is more logical. Moving scsi_init_cmd_errh() should come after the patch. Sorry. :-) I'll make another take

Re: iomapping a big endian area

2005-04-04 Thread James Bottomley
OK, I sent the patch off to Andrew. To complete the original problem, the attached is the patch that uses it in the parisc lasi driver (although, actually, it sets up 53c700 to work everywhere including BE on a LE system). I changed some of the flags around to reflect the fact that we now have

  1   2   3   4   5   6   7   8   9   10   >