Re: [PATCH 01/14] lpfc: The lpfc driver does not issue RFF_ID and RFT_ID in the correct sequence

On 4/21/2015 7:23 AM, Sebastian Herbszt wrote: James Smart wrote: The lpfc driver does not issue RFF_ID and RFT_ID in the correct sequence Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc_hbadisc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion

Re: [PATCH kernel] commit 4fbdf9cb ("lpfc: Fix for lun discovery issue with saturn adapter.")

Not sure - I'll go look. -- james On 5/19/2015 11:55 PM, Alexey Kardashevskiy wrote: On 05/06/2015 07:46 AM, Sebastian Herbszt wrote: James Smart wrote: Reviewed-By: James Smart Alexey, Sebastian, Yes - this section needs to be reverted. This patch is good. -- james s Review

Re: [PATCH kernel] commit 4fbdf9cb ("lpfc: Fix for lun discovery issue with saturn adapter.")

Alexey, Can you send me boot messages so I can see everything the lpfc driver may have done ? And you're using 10.5.0.0 verbatim ? -- james On 5/20/2015 9:11 AM, James Smart wrote: Not sure - I'll go look. -- james On 5/19/2015 11:55 PM, Alexey Kardashevskiy wrote: On 05/06/

Re: [PATCH trivial] lpfc: Grammar s/an negative/a negative/

Reviewed-By: James Smart looks fine. Thanks -- james s On 5/21/2015 8:11 AM, Geert Uytterhoeven wrote: Signed-off-by: Geert Uytterhoeven --- drivers/scsi/lpfc/lpfc_debugfs.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/scsi/lpfc

[PATCH v2 02/15] lpfc: Correct loss of target discovery after cable swap.

Correct loss of target discovery after cable swap. Fix incorrect reference counting Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc_hbadisc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/lpfc/lpfc_hbadisc.c b/drivers

[PATCH v2 01/15] lpfc: The lpfc driver does not issue RFF_ID and RFT_ID in the correct sequence

The lpfc driver does not issue RFF_ID and RFT_ID in the correct sequence Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc_hbadisc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/lpfc/lpfc_hbadisc.c b/drivers/scsi/lpfc

[PATCH v2 00/15] lpfc: Update to revision 10.6.0.1

double spacing with single spacing Revised LS_RJT codes for lpfc_els_rcv_rdp() The patches were cut against scsi-misc -- james James Smart (15): The lpfc driver does not issue RFF_ID and RFT_ID in the correct sequence Correct loss of target discovery after cable swap. Add

[PATCH v2 07/15] lpfc: Correct reporting of vport state on fdisc command failure.

Correct reporting of vport state on fdisc command failure. Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc_els.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/scsi/lpfc/lpfc_els.c b/drivers/scsi/lpfc/lpfc_els.c index 724b61c

[PATCH v2 13/15] lpfc: Fix incorrect log message reported for empty FCF record.

Fix incorrect log message reported for empty FCF record. Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc_hbadisc.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/lpfc/lpfc_hbadisc.c b/drivers/scsi/lpfc/lpfc_hbadisc.c

[PATCH v2 15/15] lpfc: Update driver version for upstream patch set 10.6.0.1.

Update driver version for upstream patch set 10.6.0.1. Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc_version.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/lpfc/lpfc_version.h b/drivers/scsi/lpfc/lpfc_version.h index

[PATCH v2 14/15] lpfc: Change buffer pool empty message to miscellaneous category

Change buffer pool empty message to miscellaneous category Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc_scsi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/lpfc/lpfc_scsi.c b/drivers/scsi/lpfc/lpfc_scsi.c index c140f99

[PATCH v2 12/15] lpfc: Fix rport leak.

Fix rport leak. Correct locking and refcounting in tracking our rports Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc_disc.h| 4 +- drivers/scsi/lpfc/lpfc_els.c | 12 +++- drivers/scsi/lpfc/lpfc_hbadisc.c | 145

[PATCH v2 11/15] lpfc: Correct loss of RSCNs during array takeaway/giveback testing.

Correct loss of RSCNs during array takeaway/giveback testing. Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc_els.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/drivers/scsi/lpfc/lpfc_els.c b/drivers/scsi/lpfc/lpfc_els.c

[PATCH v2 03/15] lpfc: Add support for ELS LCB.

Add support for ELS LCB. Also has a little whitespace fixing. Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc.h | 1 + drivers/scsi/lpfc/lpfc_els.c | 239 +- drivers/scsi/lpfc/lpfc_hw.h | 32 ++ drivers

[PATCH v2 09/15] lpfc: Fix to remove IRQF_SHARED flag for MSI/MSI-X vectors.

Fix to remove IRQF_SHARED flag for MSI/MSI-X vectors. Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc_init.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/scsi/lpfc/lpfc_init.c b/drivers/scsi/lpfc/lpfc_init.c index

[PATCH v2 05/15] lpfc: Fix ABORTs WQ selection in terminate_rport_io

Fix ABORTs WQ selection in terminate_rport_io Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc_sli.c | 32 +--- 1 file changed, 21 insertions(+), 11 deletions(-) diff --git a/drivers/scsi/lpfc/lpfc_sli.c b/drivers/scsi/lpfc

[PATCH v2 04/15] lpfc: Correct reference counting of rport

Correct reference counting of rport Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc_hbadisc.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/scsi/lpfc/lpfc_hbadisc.c b/drivers/scsi/lpfc/lpfc_hbadisc.c index 72388a6..e93705d

[PATCH v2 06/15] lpfc: Add support for RDP ELS command.

Add support for RDP ELS command. Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc.h | 1 + drivers/scsi/lpfc/lpfc_crtn.h | 2 + drivers/scsi/lpfc/lpfc_els.c | 420 ++ drivers/scsi/lpfc/lpfc_hw.h | 169

[PATCH v2 10/15] lpfc: Fix crash in vport_delete.

Fix crash in vport_delete. We inadvertantly took the path to recreate the vport while in a driver teardown path Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc_init.c | 8 +++- drivers/scsi/lpfc/lpfc_nportdisc.c | 8 +++- drivers/scsi/lpfc

[PATCH v2 08/15] lpfc: Fix discovery issue when changing from Pt2Pt to Fabric.

Fix discovery issue when changing from Pt2Pt to Fabric. Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc_hbadisc.c | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/drivers/scsi/lpfc/lpfc_hbadisc.c b/drivers/scsi/lpfc

[PATCH 3/9] lpfc: Devices are not discovered during takeaway/giveback testing

g the state of the 2 ndlp's when a DID swap is detected. Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc_els.c | 22 ++ 1 file changed, 10 insertions(+), 12 deletions(-) diff --git a/drivers/scsi/lpfc/lpfc_els.c b/drivers/scsi/lpfc/lpfc_e

[PATCH 2/9] lpfc: Fix vport deletion failure.

Fix vport deletion failure. If a vport was deleted while in the middle of discovery, we weren't clearing the nport discovery flag. Correct by clearing the flag and cancelling our discovery timeout timer. Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc_

[PATCH 1/9] lpfc: Check for active portpeerbeacon.

igned-off-by: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc_els.c | 19 +++ drivers/scsi/lpfc/lpfc_hw4.h | 6 ++ 2 files changed, 21 insertions(+), 4 deletions(-) diff --git a/drivers/scsi/lpfc/lpfc_els.c b/drivers/scsi/lpfc/lpfc_els.c index 011c8d8..3a

[PATCH 0/9] lpfc: Update to revision 10.7.0.0

This patch set updates the lpfc driver to revision 10.7.0.0 The patches were cut against scsi-misc -- james s James Smart (9): Check for active portpeerbeacon. Fix vport deletion failure. Devices are not discovered during takeaway/giveback testing Add support for using block multi

[PATCH 6/9] lpfc: Fix cq_id masking problem.

nnedy Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc_hw4.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/lpfc/lpfc_hw4.h b/drivers/scsi/lpfc/lpfc_hw4.h index b94fa46..33ec4fa 100644 --- a/drivers/scsi/lpfc/lpfc_hw4.h +++ b/drivers/scsi/lpfc/lpfc_

[PATCH 5/9] lpfc: Fix scsi prep dma buf error.

Fix scsi prep dma buf error. Didn't check for less-than-or-equal zero. Means we may later call scsi_dma_unmap() even though we don't have valid mappings. Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc_scsi.c | 2 +- 1 file changed, 1 inser

[PATCH 7/9] lpfc: Fix scsi task management error message.

ed-off-by: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc_scsi.c | 18 ++ 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/drivers/scsi/lpfc/lpfc_scsi.c b/drivers/scsi/lpfc/lpfc_scsi.c index b3b195f..e5eb40d 100644 --- a/drivers/scsi/lpfc/lpfc_scsi.c +++

[PATCH 8/9] lpfc: Fix to drop PLOGIs from fabric node till LOGO processing completes

mes resulted in Warning messages indicating kref.h via lfpc_nlp_get+0x128. Correct by dropping any new PLOGI until the prior nport state has settled. Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc_els.c | 14 +++--- drivers/scsi/lpfc/lpfc_h

[PATCH 4/9] lpfc: Add support for using block multi-queue

turned on via CONFIG_SCSI_MQ_DEFAULT or passing scsi_mod.use_blk_mq=Y as a parameter to the kernel. Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc_init.c | 4 ++- drivers/scsi/lpfc/lpfc_scsi.c | 43 + drivers/scsi/lpfc/lpfc_scsi.h | 3

[PATCH 9/9] lpfc: Update version to 10.7.0.0 for upstream patch set.

Update version to 10.7.0.0 for upstream patch set. Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc_version.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/lpfc/lpfc_version.h b/drivers/scsi/lpfc/lpfc_version.h index 8b96d10

Re: [PATCH v2 12/15] lpfc: Fix rport leak.

this error quite a bit in the past and believe we have been grandfathered as there's a lot of this already. James B - any comments on the above ? -- james s On 5/24/2015 7:56 AM, Sebastian Herbszt wrote: James Smart wrote: Fix rport leak. Correct locking and refcounting in tracking

Re: [PATCH 3/9] lpfc: Devices are not discovered during takeaway/giveback testing

uh - we're flagging issues with in a patch explanation (such as 2 spaces after a period) and not something in the patch itself ?? I'm not going to revise patches for minor typos or styles disagreements in patch descriptions. -- james On 5/24/2015 3:56 PM, Sebastian Herbszt wro

Re: [PATCH] lpfc: fix model description

Yes - this is acceptable. Not a big deal per-say, but good to be uniform. Reviewed-By: James Smart -- james s On 5/27/2015 5:40 PM, Sebastian Herbszt wrote: I wrote: Remove trailing space from model description. Signed-off-by: Sebastian Herbszt diff -up 4.0/drivers/scsi/lpfc.orig

Re: [PATCH] lpfc: in sli3 use configured sg_seg_cnt for sg_tablesize

Bodo, This is a valid fix. Thank you. I assume you were changing the driver module parameter to up the SG count ? without the fix we would have been capped at 64 sges. -- james Reviewed-By: James Smart On 5/29/2015 8:22 AM, bstroes...@ts.fujitsu.com wrote: Hi James, We had some

Re: [PATCH v2 12/15] lpfc: Fix rport leak.

That's good to know. We have a fair amount of existing strings that are split, so I don't want to retrofit those. But, on future submits, we'll keep the string on a single line. Thanks -- james On 5/27/2015 5:32 PM, Sebastian Herbszt wrote: James Smart wrote: Sebastian,

Re: [PATCH] lpfc: Destroy lpfc_hba_index IDR on module exit

Reviewed-By: James Smart -- james s On 7/8/2015 11:19 AM, Johannes Thumshirn wrote: Destroy lpfc_hba_index IDR on module exit, reclaiming the allocated memory. This was detected by the following semantic patch (written by Luis Rodriguez ) @ defines_module_init @ declarer name module_init

Re: [RESEND][PATCH] lpfc: fix model description

As mentioned previously, it's a nit, and not too meaningful, but fine. If not merged prior, we'll repost as part of an upcoming commit that cleans up sparse warnings. Reviewed-By: James Smart -- james s On 7/6/2015 5:22 PM, Sebastian Herbszt wrote: Remove trailing space

Re: [PATCH] Fix kmalloc overflow in LPFC driver at large core count

Looks fine. If not merged prior, we'll pull it in our next update. Reviewed-By: James Smart -- james s On 7/10/2015 12:31 PM, ian mitchell wrote: This patch allows the LPFC to start up without a fatal kernel bug based on an exceeded KMALLOC_MAX_SIZE and a too large NR_CPU-based mas

Re: [PATCH] lpfc: Use && instead of & for boolean expression

Reviewed-by: James Smart Thanks -- james On 7/22/2015 4:53 AM, Sebastian Herbszt wrote: Use logical instead of bitwise AND. Signed-off-by: Sebastian Herbszt --- diff -urp a/drivers/scsi/lpfc/lpfc_hbadisc.c b/drivers/scsi/lpfc/lpfc_hbadisc.c --- a/drivers/scsi/lpfc/lpfc_hbadisc.c 2015-07

Re: [PATCH] scsi: Export SCSI Inquiry data to sysfs

On 8/14/2015 2:32 AM, Hannes Reinecke wrote: On 08/13/2015 01:50 PM, Johannes Thumshirn wrote: Export the RAW SCSI Inquiry to sysfs as binfile. This way the data can be used by userlang without the need to have and ioctl or use the sg_inq tool. userland! Just be careful. There are condition

[PATCH 00/14] lpfc: Update to revision 11.0.0.0

This patch set updates the lpfc driver to revision 11.0.0.0 The patches were cut against scsi-misc -- james s James Smart (14): Pull in patches posted to linux-scsi prior: lpfc: fix model description lpfc: Remove unnessary cast lpfc: in sli3 use configured sg_seg_cnt for

[PATCH 02/14] lpfc: Remove unnessary cast

From: Firo Yang kzalloc() returns a void pointer - no need to cast it in drivers/scsi/lpfc/lpfc_init.c::lpfc_sli_driver_resource_setup() Signed-off-by: Firo Yang Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc_init.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git

[PATCH 03/14] lpfc: in sli3 use configured sg_seg_cnt for sg_tablesize

s the template used for sli4 only. Thus the value should correctly be written to lpfc_template_s3->sg_tablesize. This patch is for kernel 4.1-rc5, but is tested with lpfc 10.2.405.26 only. Signed-off-by: Bodo Stroesser Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc_init.c | 2 +-

[PATCH 01/14] lpfc: fix model description

From: Sebastian Herbszt Remove trailing space from model description. Signed-off-by: Sebastian Herbszt Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc_init.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/lpfc/lpfc_init.c b/drivers/scsi/lpfc

[PATCH 10/14] lpfc: Add support for Lancer G6 and 32G FC links

Add support for Lancer G6 and 32G FC links Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc.h | 8 +--- drivers/scsi/lpfc/lpfc_attr.c| 17 + drivers/scsi/lpfc/lpfc_ct.c | 6 ++ drivers/scsi/lpfc/lpfc_els.c | 2

[PATCH 11/14] lpfc: Fix for discovery failure in PT2PT when FLOGI's ELS ACC response gets aborted

GI, before processing PLOGI's. Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc_els.c | 31 +-- 1 file changed, 17 insertions(+), 14 deletions(-) diff --git a/drivers/scsi/lpfc/lpfc_els.c b/drivers/scsi/lpfc/lpfc_els.c index 598313d.

[PATCH 05/14] Fix kmalloc overflow in LPFC driver at large core count

86 (0.003652)| [] ? kthread_freezable_should_stop+0x5b/0x5b 2199383.192333 (0.012247)| ehci-pci :00:1a.0: EHCI Host Controller >8 The proposed solution was approved by James Smart at Emulex and tested on a UV2 machine with 6144 cores. With the fix, th

[PATCH 07/14] lpfc: remove set but not used variables

From: Sebastian Herbszt Remove set but not used variables. Signed-off-by: Sebastian Herbszt Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc_attr.c | 6 drivers/scsi/lpfc/lpfc_bsg.c | 20 -- drivers/scsi/lpfc/lpfc_ct.c| 5 drivers/scsi/lpfc

[PATCH 00/17 v2] lpfc: Update driver to version 11.2.0.2

This patch set updates the lpfc driver to revision 11.2.0.2 The patches were cut against scsi-misc James Smart (17): Fix few small typos in lpfc_scsi.c originally posted by Milan Gandhi lpfc: Correct embedded io wq element size lpfc: Fix sg_reset on SCSI device causing kernel

[PATCH 05/17 v2] lpfc: Make lpfc_prot_xxx params per hba parameters

Make lpfc_prot_mask and lpfc_prot_guard per hba parameters Signed-off-by: Dick Kennedy Signed-off-by: James Smart Reviewed-by: Johannes Thumshirn --- drivers/scsi/lpfc/lpfc.h | 2 ++ drivers/scsi/lpfc/lpfc_attr.c | 23 ++- drivers/scsi/lpfc/lpfc_crtn.h | 2

[PATCH 04/17 v2] lpfc: Set driver environment data on adapter

Set driver environment data on adapter Signed-off-by: Dick Kennedy Signed-off-by: James Smart Reviewed-by: Johannes Thumshirn --- drivers/scsi/lpfc/lpfc_hw4.h | 12 drivers/scsi/lpfc/lpfc_sli.c | 29 + 2 files changed, 41 insertions(+) diff --git a

[PATCH 03/17 v2] lpfc: Fix sg_reset on SCSI device causing kernel crash

-by: James Smart --- drivers/scsi/lpfc/lpfc_scsi.c | 22 +- 1 file changed, 13 insertions(+), 9 deletions(-) diff --git a/drivers/scsi/lpfc/lpfc_scsi.c b/drivers/scsi/lpfc/lpfc_scsi.c index ca56f28..4c53149e 100644 --- a/drivers/scsi/lpfc/lpfc_scsi.c +++ b/drivers/scsi/lpfc

[PATCH 07/17 v2] lpfc: Code cleanup for lpfc_enable_rrq parameter

Code cleanup for lpfc_enable_rrq parameter Signed-off-by: Dick Kennedy Signed-off-by: James Smart Reviewed-by: Johannes Thumshirn --- drivers/scsi/lpfc/lpfc_attr.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/scsi/lpfc/lpfc_attr.c b/drivers/scsi/lpfc

[PATCH 09/17 v2] lpfc: Code cleanup for lpfc_topology parameter

Code cleanup for lpfc_topology parameter Signed-off-by: Dick Kennedy Signed-off-by: James Smart Reviewed-by: Johannes Thumshirn --- drivers/scsi/lpfc/lpfc_attr.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/scsi/lpfc/lpfc_attr.c b/drivers/scsi/lpfc

[PATCH 08/17 v2] lpfc: Code cleanup for lpfc_aer_support parameter

Code cleanup for lpfc_aer_support parameter Signed-off-by: Dick Kennedy Signed-off-by: James Smart Reviewed-by: Johannes Thumshirn --- drivers/scsi/lpfc/lpfc_attr.c | 43 +++ 1 file changed, 3 insertions(+), 40 deletions(-) diff --git a/drivers/scsi

[PATCH 01/17 v2] Fix few small typos in lpfc_scsi.c

From: "Milan P. Gandhi" This patch does a cleanup and fixes few small typos in lpfc_scsi.c Signed-off-by: Milan P. Gandhi Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc_scsi.c | 21 - 1 file changed, 12 insertions(+), 9 deletions(-) diff --git a/dr

[PATCH 10/17 v2] lpfc: Code cleanup for lpfc_max_scsicmpl_time parameter

Code cleanup for lpfc_max_scsicmpl_time parameter Signed-off-by: Dick Kennedy Signed-off-by: James Smart Reviewed-by: Johannes Thumshirn --- drivers/scsi/lpfc/lpfc_attr.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/scsi/lpfc/lpfc_attr.c b/drivers/scsi

[PATCH 06/17 v2] lpfc: Code clean up for lpfc_iocb_cnt parameter

Code clean up for lpfc_iocb_cnt parameter Signed-off-by: Dick Kennedy Signed-off-by: James Smart Reviewed-by: Johannes Thumshirn --- drivers/scsi/lpfc/lpfc_attr.c | 8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/drivers/scsi/lpfc/lpfc_attr.c b/drivers/scsi/lpfc

[PATCH 15/17 v2] lpfc: Synchronize link speed with boot driver

picked up by the boot driver. Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc.h | 4 drivers/scsi/lpfc/lpfc_attr.c | 7 +- drivers/scsi/lpfc/lpfc_bsg.c | 44 +++ drivers/scsi/lpfc/lpfc_bsg.h | 10 drivers

[PATCH 14/17 v2] lpfc: Correct panics with eh_timeout and eh_deadline

-off-by: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc_scsi.c | 6 +++--- drivers/scsi/lpfc/lpfc_sli.c | 12 2 files changed, 11 insertions(+), 7 deletions(-) diff --git a/drivers/scsi/lpfc/lpfc_scsi.c b/drivers/scsi/lpfc/lpfc_scsi.c index 4c53149e..1b0ef79

[PATCH 12/17 v2] lpfc: Revise strings with full lpfc parameter name

Revise strings with full lpfc parameter name Signed-off-by: Dick Kennedy Signed-off-by: James Smart Reviewed-by: Johannes Thumshirn --- drivers/scsi/lpfc/lpfc_attr.c | 23 --- 1 file changed, 12 insertions(+), 11 deletions(-) diff --git a/drivers/scsi/lpfc/lpfc_attr.c b

[PATCH 02/17 v2] lpfc: Correct embedded io wq element size

Correct embedded io wq element size. Embedded element sizes are 128 byte elements Modified per review: change style of selecting wqesize using local variable Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc_init.c | 14 +- 1 file changed, 5

[PATCH 13/17 v2] lpfc: Fix lost target in pt-to-pt connect

Fix lost target in pt-to-pt connect Change reject code to something that allows a retry Signed-off-by: Dick Kennedy Signed-off-by: James Smart Reviewed-by: Johannes Thumshirn --- drivers/scsi/lpfc/lpfc_els.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi

[PATCH 11/17 v2] lpfc: Code cleanup for lpfc_sriov_nr_virtfn parameter

Code cleanup for lpfc_sriov_nr_virtfn parameter Signed-off-by: Dick Kennedy Signed-off-by: James Smart Reviewed-by: Johannes Thumshirn --- drivers/scsi/lpfc/lpfc_attr.c | 35 +++ 1 file changed, 3 insertions(+), 32 deletions(-) diff --git a/drivers/scsi/lpfc

[PATCH 17/17 v2] lpfc: lpfc version changed to 11.2.0.2

lpfc version changed to 11.2.0.2 Signed-off-by: Dick Kennedy Signed-off-by: James Smart Reviewed-by: Johannes Thumshirn --- drivers/scsi/lpfc/lpfc_version.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/lpfc/lpfc_version.h b/drivers/scsi/lpfc/lpfc_version.h

[PATCH 16/17 v2] lpfc: Fix fw download on SLI-4 FC adapters

Fix fw download on SLI-4 FC adapters Driver performs a quick validation of magic numbers in the fw download image. Driver needed to be updated for more recent magic numbers. Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc_hw4.h | 3 ++- drivers/scsi/lpfc

[PATCH v3 12/17] lpfc: Revise strings with full lpfc parameter name

Revise strings with full lpfc parameter name Signed-off-by: Dick Kennedy Signed-off-by: James Smart Reviewed-by: Johannes Thumshirn --- drivers/scsi/lpfc/lpfc_attr.c | 23 --- 1 file changed, 12 insertions(+), 11 deletions(-) diff --git a/drivers/scsi/lpfc/lpfc_attr.c b

[PATCH v3 14/17] lpfc: Correct panics with eh_timeout and eh_deadline

-off-by: Dick Kennedy Signed-off-by: James Smart Reviewed-by: Johannes Thumshirn --- drivers/scsi/lpfc/lpfc_scsi.c | 6 +++--- drivers/scsi/lpfc/lpfc_sli.c | 12 2 files changed, 11 insertions(+), 7 deletions(-) diff --git a/drivers/scsi/lpfc/lpfc_scsi.c b/drivers/scsi/lpfc

[PATCH v3 17/17] lpfc: lpfc version changed to 11.2.0.2

lpfc version changed to 11.2.0.2 Signed-off-by: Dick Kennedy Signed-off-by: James Smart Reviewed-by: Johannes Thumshirn --- drivers/scsi/lpfc/lpfc_version.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/lpfc/lpfc_version.h b/drivers/scsi/lpfc/lpfc_version.h

[PATCH v3 15/17] lpfc: Synchronize link speed with boot driver

picked up by the boot driver. Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- v3 mods: parens cleanup use shost_priv() on new code drivers/scsi/lpfc/lpfc.h | 4 drivers/scsi/lpfc/lpfc_attr.c | 7 +- drivers/scsi/lpfc/lpfc_bsg.c | 45

[PATCH v3 10/17] lpfc: Code cleanup for lpfc_max_scsicmpl_time parameter

Code cleanup for lpfc_max_scsicmpl_time parameter Signed-off-by: Dick Kennedy Signed-off-by: James Smart Reviewed-by: Johannes Thumshirn --- drivers/scsi/lpfc/lpfc_attr.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/scsi/lpfc/lpfc_attr.c b/drivers/scsi

[PATCH v3 13/17] lpfc: Fix lost target in pt-to-pt connect

Fix lost target in pt-to-pt connect Change reject code to something that allows a retry Signed-off-by: Dick Kennedy Signed-off-by: James Smart Reviewed-by: Johannes Thumshirn --- drivers/scsi/lpfc/lpfc_els.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi

[PATCH v3 16/17] lpfc: Fix fw download on SLI-4 FC adapters

Fix fw download on SLI-4 FC adapters Driver performs a quick validation of magic numbers in the fw download image. Driver needed to be updated for more recent magic numbers. Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- v3 mods: code cleanup: parsing image header fields

[PATCH v3 11/17] lpfc: Code cleanup for lpfc_sriov_nr_virtfn parameter

Code cleanup for lpfc_sriov_nr_virtfn parameter Signed-off-by: Dick Kennedy Signed-off-by: James Smart Reviewed-by: Johannes Thumshirn --- drivers/scsi/lpfc/lpfc_attr.c | 35 +++ 1 file changed, 3 insertions(+), 32 deletions(-) diff --git a/drivers/scsi/lpfc

[PATCH v3 04/17] lpfc: Set driver environment data on adapter

Set driver environment data on adapter Signed-off-by: Dick Kennedy Signed-off-by: James Smart Reviewed-by: Johannes Thumshirn --- drivers/scsi/lpfc/lpfc_hw4.h | 12 drivers/scsi/lpfc/lpfc_sli.c | 29 + 2 files changed, 41 insertions(+) diff --git a

[PATCH v3 06/17] lpfc: Code clean up for lpfc_iocb_cnt parameter

Code clean up for lpfc_iocb_cnt parameter Signed-off-by: Dick Kennedy Signed-off-by: James Smart Reviewed-by: Johannes Thumshirn --- drivers/scsi/lpfc/lpfc_attr.c | 8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/drivers/scsi/lpfc/lpfc_attr.c b/drivers/scsi/lpfc

[PATCH v3 01/17] Fix few small typos in lpfc_scsi.c

From: "Milan P. Gandhi" This patch does a cleanup and fixes few small typos in lpfc_scsi.c Signed-off-by: Milan P. Gandhi Signed-off-by: James Smart Reviewed-by: Johannes Thumshirn --- drivers/scsi/lpfc/lpfc_scsi.c | 21 - 1 file changed, 12 insertions(+), 9

[PATCH v3 03/17] lpfc: Fix sg_reset on SCSI device causing kernel crash

Fix sg_reset on SCSI device causing kernel crash Driver could reference stale node pointers in task mgmt call. Changed to use resetting cmd and look up node pointer in task mgmt function. Signed-off-by: Dick Kennedy Signed-off-by: James Smart Reviewed-by: Johannes Thumshirn --- v2 mods

[PATCH v3 02/17] lpfc: Correct embedded io wq element size

Correct embedded io wq element size. Embedded element sizes are 128 byte elements Signed-off-by: Dick Kennedy Signed-off-by: James Smart Reviewed-by: Johannes Thumshirn --- v2 mods: change style of selecting wqesize using local variable drivers/scsi/lpfc/lpfc_init.c | 14 +- 1

[PATCH v3 00/17] lpfc: Update driver to version 11.2.0.2

This patch set updates the lpfc driver to revision 11.2.0.2 The patches were cut against scsi-misc James Smart (17): Fix few small typos in lpfc_scsi.c originally posted by Milan Gandhi lpfc: Correct embedded io wq element size lpfc: Fix sg_reset on SCSI device causing kernel crash

[PATCH v3 07/17] lpfc: Code cleanup for lpfc_enable_rrq parameter

Code cleanup for lpfc_enable_rrq parameter Signed-off-by: Dick Kennedy Signed-off-by: James Smart Reviewed-by: Johannes Thumshirn --- drivers/scsi/lpfc/lpfc_attr.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/scsi/lpfc/lpfc_attr.c b/drivers/scsi/lpfc

[PATCH v3 08/17] lpfc: Code cleanup for lpfc_aer_support parameter

Code cleanup for lpfc_aer_support parameter Signed-off-by: Dick Kennedy Signed-off-by: James Smart Reviewed-by: Johannes Thumshirn --- drivers/scsi/lpfc/lpfc_attr.c | 43 +++ 1 file changed, 3 insertions(+), 40 deletions(-) diff --git a/drivers/scsi

[PATCH v3 09/17] lpfc: Code cleanup for lpfc_topology parameter

Code cleanup for lpfc_topology parameter Signed-off-by: Dick Kennedy Signed-off-by: James Smart Reviewed-by: Johannes Thumshirn --- drivers/scsi/lpfc/lpfc_attr.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/scsi/lpfc/lpfc_attr.c b/drivers/scsi/lpfc

[PATCH v3 05/17] lpfc: Make lpfc_prot_xxx params per hba parameters

Make lpfc_prot_mask and lpfc_prot_guard per hba parameters Signed-off-by: Dick Kennedy Signed-off-by: James Smart Reviewed-by: Johannes Thumshirn --- drivers/scsi/lpfc/lpfc.h | 2 ++ drivers/scsi/lpfc/lpfc_attr.c | 23 ++- drivers/scsi/lpfc/lpfc_crtn.h | 2

Re: [PATCH] lpfc: use %zd format string for size_t

Thanks Signed-off-by: James Smart -- james On 10/17/2016 5:35 AM, Arnd Bergmann wrote: A recent bugfix introduced a harmless warning in the lpfc driver: drivers/scsi/lpfc/lpfc_init.c: In function 'lpfc_write_firmware': drivers/scsi/lpfc/lpfc_logmsg.h:56:45: error: format &#x

Re: [PATCH 07/20] scsi_transport_fc: rename 'fc_rport_create' to 'fc_remote_port_create'

On 10/18/2016 1:01 AM, Hannes Reinecke wrote: Required for the next patch. Signed-off-by: Hannes Reinecke --- drivers/scsi/scsi_transport_fc.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/scsi/scsi_transport_fc.c b/drivers/scsi/scsi_transport_fc.c inde

Re: [PATCH 07/20] scsi_transport_fc: rename 'fc_rport_create' to 'fc_remote_port_create'

On 10/18/2016 9:18 AM, Johannes Thumshirn wrote: Hi James, fc_rport_create() in scsi_transport_fc.c is static so there is no interface change here. Johannes ah - that this was the published routine. ok. -- james -- To unsubscribe from this list: send the line "unsubscribe linux-scsi"

[PATCH] lpfc: Revise MAINTAINERS to reflect Broadcom

Avago is now known as Broadcom. Revise the emails and website for lpfc accordingly Signed-off-by: James Smart --- MAINTAINERS | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 072fe36..96e0ec6 100644 --- a/MAINTAINERS +++ b/MAINTAINERS

Re: [PATCH] scsi_transport_fc: Hold queue lock while calling blk_run_queue_async()

Reviewed-By: James Smart (Bart: fyi - note my change in email address) -- james On 11/11/2016 4:55 PM, Bart Van Assche wrote: It is required to hold the queue lock when calling blk_run_queue_async() to avoid that a race between blk_run_queue_async() and blk_cleanup_queue() is triggered

Re: use PCI layer IRQ affinity in lpfc

Hi Christoph, We had already done this work in the larger lpfc patch that had been posted for nvme work. I'll look at separating out just the irq part and post a reply. -- james On 11/17/2016 7:14 AM, Christoph Hellwig wrote: This series has two patches: the first is a simple conversion of

[PATCH 11/11] lpfc: lpfc version change to 11.2.0.4

lpfc version change to 11.2.0.4 Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc_version.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/lpfc/lpfc_version.h b/drivers/scsi/lpfc/lpfc_version.h index 50bfc43..0ee0623 100644

[PATCH 06/11] lpfc: FCoE VPort enable-disable does not bring up the VPort

FCoE VPort enable-disable does not bring up the VPort. VPI structure needed to be initialized before being re-registered. Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc_vport.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers/scsi/lpfc

[PATCH 00/11] lpfc: Update driver to version 11.2.0.4

This patch set updates the lpfc driver to revision 11.2.0.4 The patches were cut against 12/17 scsi.git tree, misc branch -- james James Smart (11): Clear the VendorVersion in the PLOGI/PLOGI ACC payload Correct error in setting OS Driver Version with FW Deprecate lpfc_soft_wwn

[PATCH 04/11] lpfc: Correct issue leading to opps during link reset

Correct issue leading to opps during link reset. Missing vport pointer. Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc_sli.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/scsi/lpfc/lpfc_sli.c b/drivers/scsi/lpfc/lpfc_sli.c index 230f924

[PATCH 08/11] lpfc: Deprecate lpfc_prot_sg_seg_cnt parameter

Deprecate lpfc_prot_sg_seg_cnt parameter. Eliminates driver from unnecessarily limiting DIF s/g list length. Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc.h | 1 - drivers/scsi/lpfc/lpfc_attr.c | 10 -- 2 files changed, 11 deletions(-) diff

[PATCH 02/11] lpfc: Correct error in setting OS Driver Version with FW

Correct error in setting OS Driver Version with FW. Prior length was too short. Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc_sli.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/scsi/lpfc/lpfc_sli.c b/drivers/scsi/lpfc

[PATCH 05/11] lpfc: Correct host name in symbolic_name field

Correct host name in symbolic_name field of nameserver registrations Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc_attr.c | 17 + 1 file changed, 17 insertions(+) diff --git a/drivers/scsi/lpfc/lpfc_attr.c b/drivers/scsi/lpfc/lpfc_attr.c

[PATCH 03/11] lpfc: Deprecate lpfc_soft_wwn parameter

Deprecate lpfc_soft_wwn parameter. No longer allow override of hw-assigned wwns Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc.h | 4 - drivers/scsi/lpfc/lpfc_attr.c | 216 -- drivers/scsi/lpfc/lpfc_init.c | 16

[PATCH 01/11] lpfc: Clear the VendorVersion in the PLOGI/PLOGI ACC payload

Clear the VendorVersion in the PLOGI/PLOGI ACC payload Vendor version info may have been set on fabric login. Before sending PLOGI payloads, ensure that it's cleared. Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc_els.c | 6 ++ drivers/scsi

[PATCH 09/11] lpfc: Correct oops on vport port resets

Correct oops on vport port resets. Incorrect WQE type, thus the clearing code actually overstepped the WQE. Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc_sli.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/scsi/lpfc

  1   2   3   4   5   6   7   8   9   10   >