Re: [Xen-devel] [PATCH 1/4] Add XEN pvSCSI protocol description

2014-06-30 Thread Juergen Gross
On 06/27/2014 07:11 PM, Konrad Rzeszutek Wilk wrote: On Fri, Jun 27, 2014 at 04:34:33PM +0200, jgr...@suse.com wrote: From: Juergen Gross jgr...@suse.com Add the definition of pvSCSI protocol used between the pvSCSI frontend in a XEN domU and the pvSCSI backend in a XEN driver domain (usually

Re: [Xen-devel] [PATCH 1/4] Add XEN pvSCSI protocol description

2014-06-30 Thread Juergen Gross
On 06/30/2014 01:02 PM, Jan Beulich wrote: On 27.06.14 at 19:11, konrad.w...@oracle.com wrote: On Fri, Jun 27, 2014 at 04:34:33PM +0200, jgr...@suse.com wrote: +/* + * Maximum scatter/gather segments per request. + * + * Considering balance between allocating at least 16 vscsiif_request + *

Re: [Xen-devel] [PATCH 2/4] Introduce xen-scsifront module

2014-06-30 Thread Juergen Gross
On 06/30/2014 03:35 PM, David Vrabel wrote: On 27/06/14 15:34, jgr...@suse.com wrote: +/* .resume = scsifront_resume, */ Following on from the recent discussion on migration with front/backends I thought I'd review how this new driver does it. New is an attribute I

Re: Re: [PATCH 3/4] Introduce XEN scsiback module

2014-07-11 Thread Juergen Gross
On 06/28/2014 08:09 PM, Christoph Hellwig wrote: On Fri, Jun 27, 2014 at 04:34:35PM +0200, jgr...@suse.com wrote: From: Juergen Gross jgr...@suse.com Introduces the XEN pvSCSI backend. With pvSCSI it is possible for a XEN domU to issue SCSI commands to a SCSI LUN assigned to that domU

Re: [PATCH V2 0/4] Add XEN pvSCSI support

2014-07-26 Thread Juergen Gross
On 07/25/2014 07:38 PM, Konrad Rzeszutek Wilk wrote: On Fri, Jul 25, 2014 at 01:37:29PM +0200, jgr...@suse.com wrote: This series adds XEN pvSCSI support. With pvSCSI it is possible to use physical SCSI devices from a XEN domain. The support consists of a backend in the privileged Domain-0

Re: [Xen-devel] [PATCH V2 1/4] Add XEN pvSCSI protocol description

2014-07-29 Thread Juergen Gross
On 07/28/2014 04:28 PM, David Vrabel wrote: On 25/07/14 12:37, jgr...@suse.com wrote: From: Juergen Gross jgr...@suse.com Add the definition of pvSCSI protocol used between the pvSCSI frontend in a XEN domU and the pvSCSI backend in a XEN driver domain (usually Dom0). This header

Re: [Xen-devel] [PATCH V2 2/4] Introduce xen-scsifront module

2014-07-29 Thread Juergen Gross
On 07/29/2014 03:53 PM, Christoph Hellwig wrote: + * Patched to support 2TB drives + * 2010, Samuel Kvasnica, IMS Nanofabrication AG + */ This doesn't really belong into the top of the file comment and should be moved to the patch description. Okay. + +#include linux/version.h not

Re: [Xen-devel] [PATCH V2 2/4] Introduce xen-scsifront module

2014-07-29 Thread Juergen Gross
On 07/29/2014 04:57 PM, Juergen Gross wrote: On 07/29/2014 03:53 PM, Christoph Hellwig wrote: +switch (op) { +case VSCSIFRONT_OP_ADD_LUN: +if (device_state == XenbusStateInitialised) { +sdev = scsi_device_lookup(info-host, chn, tgt

Oops in scsi_put_host_cmd_pool

2014-07-31 Thread Juergen Gross
During test of Xen pvSCSI frontend module I found the following issue: When unplugging a passed-through SCSI-device the SCSI Host is removed. When calling the final scsi_host_put() from the driver an Oops is happening: [ 219.816292] (file=drivers/scsi/xen-scsifront.c, line=808)

Re: Oops in scsi_put_host_cmd_pool

2014-08-01 Thread Juergen Gross
On 08/01/2014 07:41 AM, Juergen Gross wrote: During test of Xen pvSCSI frontend module I found the following issue: When unplugging a passed-through SCSI-device the SCSI Host is removed. When calling the final scsi_host_put() from the driver an Oops is happening: [ 219.816292] (file=drivers

Re: Oops in scsi_put_host_cmd_pool

2014-08-01 Thread Juergen Gross
On 08/01/2014 09:05 AM, James Bottomley wrote: On Fri, 2014-08-01 at 08:02 +0200, Juergen Gross wrote: On 08/01/2014 07:41 AM, Juergen Gross wrote: During test of Xen pvSCSI frontend module I found the following issue: When unplugging a passed-through SCSI-device the SCSI Host is removed

Re: [Xen-devel] [PATCH V2 2/4] Introduce xen-scsifront module

2014-08-01 Thread Juergen Gross
On 08/01/2014 02:08 PM, Christoph Hellwig wrote: On Wed, Jul 30, 2014 at 06:53:59AM +0200, Juergen Gross wrote: Hmm, I looked into scsi_add_device(). It seems as if the caller can't distinguish between a new created and an already existing device. Am I missing something? That's right. If you

Re: [PATCH] Save command pool address of Scsi_Host

2014-08-03 Thread Juergen Gross
On 08/01/2014 10:24 PM, James Bottomley wrote: On Fri, 2014-08-01 at 05:03 -0700, Christoph Hellwig wrote: On Fri, Aug 01, 2014 at 08:27:05AM +0200, jgr...@suse.com wrote: From: Juergen Gross jgr...@suse.com If a scsi host driver specifies .cmd_len in it's scsi_host_template, a driver's

Re: [Xen-devel] [PATCH V3 1/4] Add XEN pvSCSI protocol description

2014-08-04 Thread Juergen Gross
On 08/04/2014 12:10 PM, Jan Beulich wrote: On 04.08.14 at 10:27, jgr...@suse.com wrote: +/* Requests from the frontend to the backend */ + +/* + * Request a SCSI operation specified via a CDB in vscsiif_request.cmnd. + * The target is specified via channel, id and lun. + */ +#define

Re: [PATCH V3] Save command pool address of Scsi_Host

2014-08-04 Thread Juergen Gross
On 08/04/2014 01:08 PM, Christoph Hellwig wrote: On Mon, Aug 04, 2014 at 06:26:09AM +0200, jgr...@suse.com wrote: From: Juergen Gross jgr...@suse.com If a scsi host driver specifies .cmd_len in it's scsi_host_template, a driver's private command pool is needed. scsi_find_host_cmd_pool

Re: [PATCH V4] Save command pool address of Scsi_Host

2014-08-04 Thread Juergen Gross
On 08/04/2014 01:24 PM, jgr...@suse.com wrote: From: Juergen Gross jgr...@suse.com If a scsi host driver specifies .cmd_len in it's scsi_host_template, a driver's private command pool is needed. scsi_find_host_cmd_pool() will locate it, but scsi_alloc_host_cmd_pool() isn't saving the pool

Re: [PATCH V5] Save command pool address of Scsi_Host

2014-08-04 Thread Juergen Gross
On 08/04/2014 01:49 PM, Boaz Harrosh wrote: On 08/04/2014 02:30 PM, jgr...@suse.com wrote: From: Juergen Gross jgr...@suse.com If a scsi host driver specifies .cmd_len in it's scsi_host_template, a driver's private command pool is needed. scsi_find_host_cmd_pool() will locate

Re: [Xen-devel] [PATCH V4 2/4] Introduce xen-scsifront module

2014-08-11 Thread Juergen Gross
On 08/11/2014 11:54 AM, Christoph Hellwig wrote: + BUG_ON(sc-cmd_len VSCSIIF_MAX_COMMAND_SIZE); + + if (sc-cmd_len) I can't see how you can get a zero cmd_len here. Ahh, thanks for spotting this. In a previous version it could be zero in case of reset. +static int

Re: [Xen-devel] [PATCH V4 2/4] Introduce xen-scsifront module

2014-08-12 Thread Juergen Gross
On 08/11/2014 07:50 PM, Christoph Hellwig wrote: On Mon, Aug 11, 2014 at 12:27:29PM +0200, Juergen Gross wrote: What do you mean with unusual? You mean transferring the EH action to Dom0? Yes. Note that hyperv tries something similar and they've run into timeout issues, you might want

Re: [Xen-devel] [PATCH V4 3/4] Introduce XEN scsiback module

2014-08-12 Thread Juergen Gross
On 08/11/2014 08:14 PM, Christoph Hellwig wrote: +#include scsi/scsi_dbg.h __scsi_print_sense() +#include scsi/scsi_eh.h struct scsi_sense_hdr +#include scsi/scsi_tcq.h SG_ALL What do you need these for? Normally target drivers shouldn't need these. +struct vscsibk_emulate { +

Re: [PATCH V4 3/4] Introduce XEN scsiback module

2014-08-13 Thread Juergen Gross
On 08/12/2014 11:13 PM, Nicholas A. Bellinger wrote: Hi Juergen Co, Finally had a chance to review this code. Comments are inline below.. Thank you very much for your review! On Fri, 2014-08-08 at 09:49 +0200, jgr...@suse.com wrote: From: Juergen Gross jgr...@suse.com Introduces

Re: Re: [Xen-devel] [PATCH V4 3/4] Introduce XEN scsiback module

2014-08-13 Thread Juergen Gross
On 08/13/2014 09:02 AM, Juergen Gross wrote: On 08/12/2014 11:13 PM, Nicholas A. Bellinger wrote: Hi Juergen Co, Finally had a chance to review this code. Comments are inline below.. +static struct se_node_acl * +scsiback_alloc_fabric_acl(struct se_portal_group *se_tpg) +{ +struct

Re: Re: [Xen-devel] [PATCH V4 3/4] Introduce XEN scsiback module

2014-08-14 Thread Juergen Gross
Nicholas, just one more question (see below): On 08/12/2014 11:13 PM, Nicholas A. Bellinger wrote: Hi Juergen Co, Finally had a chance to review this code. Comments are inline below.. On Fri, 2014-08-08 at 09:49 +0200, jgr...@suse.com wrote: ... + if

Re: [Xen-devel] [PATCH V4 3/4] Introduce XEN scsiback module

2014-08-14 Thread Juergen Gross
On 08/14/2014 10:53 AM, Juergen Gross wrote: Nicholas, just one more question (see below): On 08/12/2014 11:13 PM, Nicholas A. Bellinger wrote: Hi Juergen Co, Finally had a chance to review this code. Comments are inline below.. On Fri, 2014-08-08 at 09:49 +0200, jgr...@suse.com wrote

Re: [Xen-devel] [PATCH V4 3/4] Introduce XEN scsiback module

2014-08-18 Thread Juergen Gross
On 08/17/2014 04:38 AM, Nicholas A. Bellinger wrote: On Thu, 2014-08-14 at 12:14 +0200, Juergen Gross wrote: On 08/14/2014 10:53 AM, Juergen Gross wrote: Nicholas, just one more question (see below): On 08/12/2014 11:13 PM, Nicholas A. Bellinger wrote: Hi Juergen Co, Finally had a chance

Re: [Xen-devel] [PATCH V5 2/5] Add XEN pvSCSI protocol description

2014-08-20 Thread Juergen Gross
On 08/20/2014 03:25 PM, Konrad Rzeszutek Wilk wrote: On Mon, Aug 18, 2014 at 11:31:47AM +0200, jgr...@suse.com wrote: From: Juergen Gross jgr...@suse.com Add the definition of pvSCSI protocol used between the pvSCSI frontend in a XEN domU and the pvSCSI backend in a XEN driver domain (usually

Re: [Xen-devel] [PATCH V5 2/5] Add XEN pvSCSI protocol description

2014-08-21 Thread Juergen Gross
On 08/21/2014 09:26 PM, Konrad Rzeszutek Wilk wrote: On Wed, Aug 20, 2014 at 04:01:57PM +0200, Juergen Gross wrote: On 08/20/2014 03:25 PM, Konrad Rzeszutek Wilk wrote: On Mon, Aug 18, 2014 at 11:31:47AM +0200, jgr...@suse.com wrote: ... +struct vscsiif_request { + uint16_t rqid

Re: [Xen-devel] [PATCH V5 3/5] Introduce xen-scsifront module

2014-08-25 Thread Juergen Gross
On 08/23/2014 12:25 AM, Konrad Rzeszutek Wilk wrote: --- /dev/null +++ b/drivers/scsi/xen-scsifront.c @@ -0,0 +1,1017 @@ +/* + * Xen SCSI frontend driver + * + * Copyright (c) 2008, FUJITSU Limited + * + * This program is free software; you can redistribute it and/or + * modify it under the

Re: [Xen-devel] [PATCH V5 5/5] add xen pvscsi maintainer

2014-08-26 Thread Juergen Gross
On 08/26/2014 04:14 PM, David Vrabel wrote: On 18/08/14 10:31, jgr...@suse.com wrote: From: Juergen Gross jgr...@suse.com Add myself as maintainer for the Xen pvSCSI stuff. Signed-off-by: Juergen Gross jgr...@suse.com --- MAINTAINERS | 8 1 file changed, 8 insertions(+) diff

Re: [Xen-devel] [PATCH V5 5/5] add xen pvscsi maintainer

2014-08-26 Thread Juergen Gross
On 08/26/2014 07:12 PM, David Vrabel wrote: On 26/08/14 17:37, James Bottomley wrote: On Tue, 2014-08-26 at 16:23 +0200, Juergen Gross wrote: On 08/26/2014 04:14 PM, David Vrabel wrote: On 18/08/14 10:31, jgr...@suse.com wrote: From: Juergen Gross jgr...@suse.com Add myself as maintainer

[PATCH V6 5/5] add xen pvscsi maintainer

2014-08-27 Thread Juergen Gross
Add myself as maintainer for the Xen pvSCSI stuff. Signed-off-by: Juergen Gross jgr...@suse.com Acked-by: Konrad Rzeszutek Wilk konrad.w...@oracle.com --- MAINTAINERS | 9 + 1 file changed, 9 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 1ff06de..0ae6238 100644

[PATCH V6 0/5] Add XEN pvSCSI support

2014-08-27 Thread Juergen Gross
support for larger SG lists by putting them in grant page(s) - add command abort capability Juergen Gross (5): xen/events: support threaded irqs for interdomain event channels Add XEN pvSCSI protocol description Introduce xen-scsifront module Introduce XEN scsiback module add xen pvscsi

[PATCH V6 2/5] Add XEN pvSCSI protocol description

2014-08-27 Thread Juergen Gross
for larger SG-lists by putting them in an own granted page - remove stale definitions Signed-off-by: Juergen Gross jgr...@suse.com --- include/xen/interface/io/vscsiif.h | 229 + 1 file changed, 229 insertions(+) create mode 100644 include/xen/interface/io

[PATCH V6 1/5] xen/events: support threaded irqs for interdomain event channels

2014-08-27 Thread Juergen Gross
Export bind_interdomain_evtchn_to_irq() so drivers can use threaded interrupt handlers with: irq = bind_interdomain_evtchn_to_irq(remote_dom, remote_port); if (irq 0) /* error */ ret = request_threaded_irq(...); Signed-off-by: Juergen Gross jgr...@suse.com Acked-by: David Vrabel

[PATCH V6 3/5] Introduce xen-scsifront module

2014-08-27 Thread Juergen Gross
style guide - some minor code simplifications - replace constants with defines - remove not used defines - add support for larger SG lists by putting them in a granted page Signed-off-by: Juergen Gross jgr...@suse.com Xen related parts Acked-by: David Vrabel david.vra...@citrix.com --- drivers/scsi

[PATCH V6 4/5] Introduce XEN scsiback module

2014-08-27 Thread Juergen Gross
emulation, now handled by target core infrastructure Signed-off-by: Juergen Gross jgr...@suse.com Xen related parts Acked-by: David Vrabel david.vra...@citrix.com Reviewed-by: Nicholas Bellinger n...@linux-iscsi.org --- drivers/xen/Kconfig|9 + drivers/xen/Makefile |1

Re: [Xen-devel] [patch] xen-scsifront: use GFP_ATOMIC under spin_lock

2014-09-08 Thread Juergen Gross
On 09/08/2014 01:15 PM, Dan Carpenter wrote: This function is only called with a spin_lock held and IRQs disabled. The allocation is not allowed to sleep and NOIO is not sufficient, it has to be ATOMIC. Signed-off-by: Dan Carpenter dan.carpen...@oracle.com Reviewed-by: Juergen Gross jgr

Re: [Xen-devel] [patch] xen-scsiback: clean up a type issue in scsiback_make_tpg()

2014-09-08 Thread Juergen Gross
dan.carpen...@oracle.com Reviewed-by: Juergen Gross jgr...@suse.com Thanks, Juergen diff --git a/drivers/xen/xen-scsiback.c b/drivers/xen/xen-scsiback.c index 7b565632..ad11258 100644 --- a/drivers/xen/xen-scsiback.c +++ b/drivers/xen/xen-scsiback.c @@ -1885,13 +1885,14 @@ scsiback_make_tpg(struct

Re: [PATCH] xen-scsifront: don't deadlock if the ring becomes full

2014-09-11 Thread Juergen Gross
be difficult. :-) Reviewed-by: Juergen Gross jgr...@suse.com Thanks for spotting this. Juergen --- drivers/scsi/xen-scsifront.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/scsi/xen-scsifront.c b/drivers/scsi/xen-scsifront.c index 7e88659..cc14c8d 100644

[PATCH] xen: make pvscsi frontend dependant on xenbus frontend

2014-09-14 Thread Juergen Gross
The pvscsi frontend driver requires the xenbus frontend driver. Reflect this in Kconfig. Signed-off-by: Juergen Gross jgr...@suse.com --- drivers/scsi/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/scsi/Kconfig b/drivers/scsi/Kconfig index 9130df1..ff62dc1 100644

Re: [Xen-devel] [PATCH] xen/xenbus: Use 'void' instead of 'int' for the return of xenbus_switch_state()

2014-09-28 Thread Juergen Gross
the return value must let 'err' be 0. And also need change the related comments for xenbus_switch_state(). Signed-off-by: Chen Gang gang.chen.5...@gmail.com Acked-by: Juergen Gross jgr...@suse.com --- drivers/block/xen-blkback/xenbus.c | 9 ++--- drivers/net/xen-netback/xenbus.c | 5

Re: [PATCH] xen-scsiback: some modifications about code comment

2015-02-08 Thread Juergen Gross
On 02/07/2015 04:31 AM, Rudy Zhang wrote: From: Tao Chen boby.c...@huawei.com Signed-off-by: Tao Chen boby.c...@huawei.com Are some white space fixes in comments really worth a patch? Juergen --- drivers/xen/xen-scsiback.c | 16 1 file changed, 8 insertions(+), 8

Re: [Xen-devel] [PATCH v4] xen-scsiback: define a pr_fmt macro with xen-pvscsi

2015-03-15 Thread Juergen Gross
boby.c...@huawei.com Reviewed-by: Juergen Gross jgr...@suse.com --- drivers/xen/xen-scsiback.c | 75 ++ 1 file changed, 36 insertions(+), 39 deletions(-) diff --git a/drivers/xen/xen-scsiback.c b/drivers/xen/xen-scsiback.c index 9faca6a..d0b0bc5

Re: [PATCH] xen-scsiback: use DRV_PFX in the pr macros

2015-03-03 Thread Juergen Gross
you can have my: Acked-by: Juergen Gross jgr...@suse.com Signed-off-by: Tao Chen boby.c...@huawei.com --- drivers/xen/xen-scsiback.c | 67 +++--- 1 file changed, 34 insertions(+), 33 deletions(-) diff --git a/drivers/xen/xen-scsiback.c b/drivers/xen/xen

Re: [PATCH-v2 11/12] xen-scsiback: Convert to percpu_ida tag allocation

2016-01-26 Thread Juergen Gross
On 25/01/16 09:11, Nicholas A. Bellinger wrote: > From: Nicholas Bellinger <n...@linux-iscsi.org> > > Cc: Juergen Gross <jgr...@suse.com> > Cc: Hannes Reinecke <h...@suse.de> > Cc: David Vrabel <david.vra...@citrix.com> > Signed-off-by: Nicholas Belling

Re: [PATCH-v2 12/12] xen-scsiback: Convert to TARGET_SCF_ACK_KREF I/O krefs

2016-01-26 Thread Juergen Gross
On 25/01/16 09:11, Nicholas A. Bellinger wrote: > From: Nicholas Bellinger <n...@linux-iscsi.org> > > Cc: Juergen Gross <jgr...@suse.com> > Cc: Hannes Reinecke <h...@suse.de> > Cc: David Vrabel <david.vra...@citrix.com> > Signed-off-by: Nicholas Belling

Re: [PATCH-v3 12/14] xen-scsiback: Convert to TARGET_SCF_ACK_KREF I/O krefs

2016-02-02 Thread Juergen Gross
On 30/01/16 08:05, Nicholas A. Bellinger wrote: > From: Nicholas Bellinger <n...@linux-iscsi.org> > > Cc: Juergen Gross <jgr...@suse.com> > Cc: Hannes Reinecke <h...@suse.de> > Cc: David Vrabel <david.vra...@citrix.com> > Signed-off-by: Nicholas Bellinge

Re: [PATCH 3/3] xen-scsiback: fix license ident used in MODULE_LICENSE

2016-01-22 Thread Juergen Gross
On 22/01/16 13:34, Wei Liu wrote: > The comment at the beginning of the file is the canonical source of > licenses for this module. Currently it contains GPL and MIT license. > Fix the code to reflect the reality. > > Signed-off-by: Wei Liu <wei.l...@citrix.com> Acked-b

Re: [PATCH-v2 11/12] xen-scsiback: Convert to percpu_ida tag allocation

2016-01-25 Thread Juergen Gross
On 25/01/16 09:11, Nicholas A. Bellinger wrote: > From: Nicholas Bellinger <n...@linux-iscsi.org> > > Cc: Juergen Gross <jgr...@suse.com> > Cc: Hannes Reinecke <h...@suse.de> > Cc: David Vrabel <david.vra...@citrix.com> > Signed-off-by: Nicholas Bellinge

Re: [PATCH-v2 11/12] xen-scsiback: Convert to percpu_ida tag allocation

2016-01-27 Thread Juergen Gross
On 27/01/16 07:28, Nicholas A. Bellinger wrote: > On Tue, 2016-01-26 at 10:45 +0100, Juergen Gross wrote: >> On 25/01/16 09:11, Nicholas A. Bellinger wrote: >>> From: Nicholas Bellinger <n...@linux-iscsi.org> >>> >>> Cc: Juergen Gross <jgr...@suse.com&g

Re: [PATCH 41/42] block: do not use REQ_FLUSH for tracking flush support

2016-04-17 Thread Juergen Gross
E_FLAG_WC/FUA > patches and modified patch to check feature_flush/fua bits. > > Signed-off-by: Mike Christie <mchri...@redhat.com> > Reviewed-by: Hannes Reinecke <h...@suse.com> > Cc: Juergen Gross <ker...@pfupf.net> Acked-by: Juergen Gross <jgr...@suse.com> Ju

Re: [PATCH 41/42] block: do not use REQ_FLUSH for tracking flush support

2016-04-15 Thread Juergen Gross
On 15/04/16 12:40, mchri...@redhat.com wrote: > From: Mike Christie > > The last patch added a REQ_OP_FLUSH for request_fn drivers > and the next patch renames REQ_FLUSH to REQ_PREFLUSH which > will be used by file systems and make_request_fn drivers so > they can send a

Re: [PATCH v2] xen_pvscsi: reclaim the ring request when the prepairing failed

2016-07-12 Thread Juergen Gross
wei.com> Reviewed-by: Juergen Gross <jgr...@suse.com> > --- > drivers/scsi/xen-scsifront.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/scsi/xen-scsifront.c b/drivers/scsi/xen-scsifront.c > index 9dc8687..8646db1 100644 > --- a/d

Re: [PATCH 2/3] xen-scsiback: One function call less in scsiback_device_action() after error detection

2016-07-19 Thread Juergen Gross
On 19/07/16 16:56, SF Markus Elfring wrote: >>> @@ -606,7 +606,7 @@ static void scsiback_device_action(struct vscsibk_pend >>> *pending_req, >>> tmr = kzalloc(sizeof(struct scsiback_tmr), GFP_KERNEL); >>> if (!tmr) { >>> target_put_sess_cmd(se_cmd); >>> - goto err;

Re: [PATCH 2/3] xen-scsiback: One function call less in scsiback_device_action() after error detection

2016-07-19 Thread Juergen Gross
On 20/07/16 07:10, SF Markus Elfring wrote: > @@ -606,7 +606,7 @@ static void scsiback_device_action(struct > vscsibk_pend *pending_req, > tmr = kzalloc(sizeof(struct scsiback_tmr), GFP_KERNEL); > if (!tmr) { > target_put_sess_cmd(se_cmd); > - goto

Re: [PATCH v2 1/3] xen-scsiback: Delete an unnecessary check before the function call "kfree"

2016-07-20 Thread Juergen Gross
eded. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring <elfr...@users.sourceforge.net> Even if already given, here it is again: Reviewed-by: Juergen Gross <jgr...@suse.com> Juergen -- To unsubscribe from this list: send

Re: [PATCH v2 3/3] xen-scsiback: Pass a failure indication as a constant

2016-07-20 Thread Juergen Gross
; Signed-off-by: Markus Elfring <elfr...@users.sourceforge.net> Even if already given, here it is again: Reviewed-by: Juergen Gross <jgr...@suse.com> Juergen -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vge

Re: [PATCH v2 2/3] xen-scsiback: Rename jump labels in scsiback_device_action()

2016-07-20 Thread Juergen Gross
Suggested-by: Jürgen Groß <jgr...@suse.com> > Signed-off-by: Markus Elfring <elfr...@users.sourceforge.net> Reviewed-by: Juergen Gross <jgr...@suse.com> Juergen -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a mess

Re: [PATCH 1/3] xen-scsiback: Delete an unnecessary check before the function call "kfree"

2016-07-17 Thread Juergen Gross
eded. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring <elfr...@users.sourceforge.net> Reviewed-by: Juergen Gross <jgr...@suse.com> Juergen -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in

Re: [PATCH 2/3] xen-scsiback: One function call less in scsiback_device_action() after error detection

2016-07-17 Thread Juergen Gross
On 16/07/16 22:23, SF Markus Elfring wrote: > From: Markus Elfring > Date: Sat, 16 Jul 2016 21:42:42 +0200 > > The kfree() function was called in one case by the > scsiback_device_action() function during error handling > even if the passed variable "tmr" contained

Re: [PATCH 3/3] xen-scsiback: Pass a failure indication as a constant

2016-07-17 Thread Juergen Gross
; Signed-off-by: Markus Elfring <elfr...@users.sourceforge.net> Reviewed-by: Juergen Gross <jgr...@suse.com> Juergen -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] xen_pvscsi: reclaim the ring request when mapping data failed

2016-07-11 Thread Juergen Gross
On 11/07/16 04:51, Bin Wu wrote: > During scsi command queueing, if mapping data fails, we need to > reclaim the failed request. Otherwise, the garbage request will > be pushed into the ring for the backend to work. Well spotted. There is another instance of this problem in

Re: [Xen-devel] [PATCH] xen_pvscsi: reclaim the ring request when mapping data failed

2016-07-11 Thread Juergen Gross
On 11/07/16 11:50, David Vrabel wrote: > On 11/07/16 10:33, Juergen Gross wrote: >> On 11/07/16 04:51, Bin Wu wrote: >>> During scsi command queueing, if mapping data fails, we need to >>> reclaim the failed request. Otherwise, the garbage request will >>> be

Re: [PATCH] xen-scsifront: correct return value checks on xenbus_scanf()

2016-07-07 Thread Juergen Gross
On 07/07/16 10:01, Jan Beulich wrote: > Only a positive return value indicates success. > > Signed-off-by: Jan Beulich <jbeul...@suse.com> Acked-by: Juergen Gross <jgr...@suse.com> > --- > drivers/scsi/xen-scsifront.c |4 ++-- > 1 file changed, 2 insertions(+

Re: [PATCH] xen-scsiback: correct return value checks on xenbus_scanf()

2016-07-07 Thread Juergen Gross
On 07/07/16 10:01, Jan Beulich wrote: > Only a positive return value indicates success. > > Signed-off-by: Jan Beulich <jbeul...@suse.com> Acked-by: Juergen Gross <jgr...@suse.com> > --- > drivers/xen/xen-scsiback.c |4 ++-- > 1 file changed, 2 insertions(+

Re: [PATCH] xen-scsifront: Add a missing call to kfree

2016-11-24 Thread Juergen Gross
On 19/11/16 19:22, Quentin Lambert wrote: > Most error branches following the call to kmalloc contain > a call to kfree. This patch add these calls where they are > missing. > > This issue was found with Hector. > > Signed-off-by: Quentin Lambert Applied to

Re: [PATCH] xen-scsifront: Add a missing call to kfree

2016-11-21 Thread Juergen Gross
On 22/11/16 04:40, Martin K. Petersen wrote: >>>>>> "Juergen" == Juergen Gross <jgr...@suse.com> writes: > > Juergen, > > Juergen> On 19/11/16 19:22, Quentin Lambert wrote: >>> Most error branches following the call to kmalloc con

Re: [PATCH] xen-scsifront: Add a missing call to kfree

2016-11-20 Thread Juergen Gross
om> Nice catch. I think this will need some more work, I'll do a follow-on patch. Reviewed-by: Juergen Gross <jgr...@suse.com> > > --- > drivers/scsi/xen-scsifront.c |1 + > 1 file changed, 1 insertion(+) > > --- a/drivers/scsi/xen-scsifront.c > +++ b/drivers

Re: [Xen-devel] [PATCH] xen/scsifront: don't advance ring request pointer in case of error

2016-11-29 Thread Juergen Gross
On 29/11/16 12:14, Jan Beulich wrote: On 29.11.16 at 11:50, wrote: >> --- a/drivers/scsi/xen-scsifront.c >> +++ b/drivers/scsi/xen-scsifront.c >> @@ -184,8 +184,6 @@ static struct vscsiif_request *scsifront_pre_req(struct >> vscsifrnt_info *info) >> >> ring_req =

[PATCH] xen/scsifront: don't advance ring request pointer in case of error

2016-11-29 Thread Juergen Gross
in case of an error. Signed-off-by: Juergen Gross <jgr...@suse.com> --- In case accepted I'll take this patch through the Xen tree as it is based on another patch by lambert.quen...@gmail.com which is going through Xen, too. --- drivers/scsi/xen-scsifront.c | 5 +++-- 1 file changed, 3 inse

Re: [Xen-devel] [PATCH] xen/scsifront: don't advance ring request pointer in case of error

2016-11-29 Thread Juergen Gross
On 29/11/16 12:28, David Vrabel wrote: > On 29/11/16 11:19, Juergen Gross wrote: >> On 29/11/16 12:14, Jan Beulich wrote: >>>>>> On 29.11.16 at 11:50, <jgr...@suse.com> wrote: >>>> --- a/drivers/scsi/xen-scsifront.c >>>> +++ b/drivers/sc

Re: [PATCH v2] xen/scsifront: don't request a slot on the ring until request is ready

2016-12-09 Thread Juergen Gross
On 02/12/16 07:15, Juergen Gross wrote: > Instead of requesting a new slot on the ring to the backend early, do > so only after all has been setup for the request to be sent. This > makes error handling easier as we don't need to undo the request id > allocation and ring slo

Re: [Xen-devel] [PATCH] xen/scsifront: don't advance ring request pointer in case of error

2016-11-29 Thread Juergen Gross
On 29/11/16 12:40, Jan Beulich wrote: On 29.11.16 at 12:19, wrote: >> On 29/11/16 12:14, Jan Beulich wrote: >> On 29.11.16 at 11:50, wrote: --- a/drivers/scsi/xen-scsifront.c +++ b/drivers/scsi/xen-scsifront.c @@ -184,8 +184,6 @@ static

Re: [PATCH] xen-scsifront: Add a missing call to kfree

2016-12-05 Thread Juergen Gross
On 05/12/16 21:53, Dan Carpenter wrote: > On Mon, Nov 21, 2016 at 07:01:36AM +0100, Juergen Gross wrote: >> On 19/11/16 19:22, Quentin Lambert wrote: >>> Most error branches following the call to kmalloc contain >>> a call to kfree. This patch add these calls

Re: [PATCH v2] xen/scsifront: don't request a slot on the ring until request is ready

2016-12-05 Thread Juergen Gross
On 05/12/16 16:32, Boris Ostrovsky wrote: > On 12/02/2016 01:15 AM, Juergen Gross wrote: >> >> -static struct vscsiif_request *scsifront_pre_req(struct vscsifrnt_info >> *info) >> +static int scsifront_do_request(struct vscsifrnt_info *info, >> +

[PATCH v2] xen/scsifront: don't request a slot on the ring until request is ready

2016-12-01 Thread Juergen Gross
ed-off-by: Juergen Gross <jgr...@suse.com> --- drivers/scsi/xen-scsifront.c | 190 +++ 1 file changed, 84 insertions(+), 106 deletions(-) diff --git a/drivers/scsi/xen-scsifront.c b/drivers/scsi/xen-scsifront.c index c01316c..9aa1fe1 100644 --- a/driv

[PATCH v2] xen/scsifront: don't request a slot on the ring until request is ready

2016-12-01 Thread Juergen Gross
ed-off-by: Juergen Gross <jgr...@suse.com> --- Resend with corrected mail address for Martin Peter --- drivers/scsi/xen-scsifront.c | 190 +++ 1 file changed, 84 insertions(+), 106 deletions(-) diff --git a/drivers/scsi/xen-scsifront.c b/driv

[PATCH v2] xen/scsifront: don't request a slot on the ring until request is ready

2016-12-01 Thread Juergen Gross
ed-off-by: Juergen Gross <jgr...@suse.com> --- Aargh! Need more coffee! Resend with corrected mail address for Martin Petersen --- drivers/scsi/xen-scsifront.c | 190 +++ 1 file changed, 84 insertions(+), 106 deletions(-) diff --git a/drivers/scsi/xen

Re: [PATCH] xen/scsifront: use offset_in_page() macro

2017-04-23 Thread Juergen Gross
On 22/04/17 03:21, Geliang Tang wrote: > Use offset_in_page() macro instead of open-coding. > > Signed-off-by: Geliang Tang <geliangt...@gmail.com> Reviewed-by: Juergen Gross <jgr...@suse.com> Thanks, Juergen

Re: [PATCH] xen/scsifront: use offset_in_page() macro

2017-04-24 Thread Juergen Gross
On 25/04/17 00:15, Martin K. Petersen wrote: > > Juergen, > >> On 22/04/17 03:21, Geliang Tang wrote: >>> Use offset_in_page() macro instead of open-coding. >>> >>> Signed-off-by: Geliang Tang <geliangt...@gmail.com> >> >> Reviewed-

Re: [PATCH] xen/scsifront: use offset_in_page() macro

2017-04-25 Thread Juergen Gross
On 22/04/17 03:21, Geliang Tang wrote: > Use offset_in_page() macro instead of open-coding. > > Signed-off-by: Geliang Tang Pushed to xen/tip for-linus-4.12 Thanks, Juergen

Re: [PATCH 31/31] xen/scsifront: Remove code that zeroes driver-private command data

2017-05-24 Thread Juergen Gross
On 24/05/17 02:34, Bart Van Assche wrote: > Since the SCSI core zeroes driver-private command data, remove > that code from the xen-scsifront driver. > > Signed-off-by: Bart Van Assche <bart.vanass...@sandisk.com> > Cc: Juergen Gross <jgr...@suse.com> > Cc:

Re: DISABLE_CLUSTERING in scsi drivers

2018-11-23 Thread Juergen Gross
On 21/11/2018 10:41, Christoph Hellwig wrote: > Hi all, > > you in the To list maintain or wrote SCSI drivers that set the > DISABLE_CLUSTERING flag, which basically disable merges of any > bio segments. We already have the actual max_segment size limit > to say which length a segment should