[PATCH v2 6/6] qedi: Add support for data path.

2016-11-07 Thread Manish Rangankar
This patch adds support for data path and TMF handling. Signed-off-by: Nilesh Javali Signed-off-by: Adheer Chandravanshi Signed-off-by: Chad Dupuis Signed-off-by: Saurav Kashyap Signed-off-by: Arun Easi Signed-off-by: Manish Rangankar --- drivers/scsi/qedi/qedi_fw.c| 1272

[PATCH v2 5/6] qedi: Add support for iSCSI session management.

2016-11-07 Thread Manish Rangankar
Easi Signed-off-by: Manish Rangankar --- drivers/scsi/qedi/qedi_fw.c| 1106 +++ drivers/scsi/qedi/qedi_gbl.h | 67 ++ drivers/scsi/qedi/qedi_iscsi.c | 1611 drivers/scsi/qedi/qedi_iscsi.h | 232 ++ drivers/scsi/qedi

[PATCH v2 1/6] qed: Add support for hardware offloaded iSCSI.

2016-11-08 Thread Manish Rangankar
From: Yuval Mintz This adds the backbone required for the various HW initalizations which are necessary for the iSCSI driver (qedi) for QLogic FastLinQ 4 line of adapters - FW notification, resource initializations, etc. Signed-off-by: Arun Easi Signed-off-by: Yuval Mintz --- drivers/net/

[PATCH v2 4/6] qedi: Add LL2 iSCSI interface for offload iSCSI.

2016-11-08 Thread Manish Rangankar
This patch adds support for iscsiuio interface using Light L2 (LL2) qed interface. Signed-off-by: Nilesh Javali Signed-off-by: Adheer Chandravanshi Signed-off-by: Chad Dupuis Signed-off-by: Saurav Kashyap Signed-off-by: Arun Easi Signed-off-by: Manish Rangankar --- drivers/scsi/qedi/qedi.h

[PATCH v2 3/6] qedi: Add QLogic FastLinQ offload iSCSI driver framework.

2016-11-08 Thread Manish Rangankar
, - Debugfs and log level infrastructure. Signed-off-by: Nilesh Javali Signed-off-by: Adheer Chandravanshi Signed-off-by: Chad Dupuis Signed-off-by: Saurav Kashyap Signed-off-by: Arun Easi Signed-off-by: Manish Rangankar --- MAINTAINERS |6 + drivers/net/ethernet/qlogic

[PATCH v2 2/6] qed: Add iSCSI out of order packet handling.

2016-11-08 Thread Manish Rangankar
From: Yuval Mintz This patch adds out of order packet handling for hardware offloaded iSCSI. Out of order packet handling requires driver buffer allocation and assistance. Signed-off-by: Arun Easi Signed-off-by: Yuval Mintz --- drivers/net/ethernet/qlogic/qed/Makefile | 2 +- drivers/net/

[PATCH v2 0/6] Add QLogic FastLinQ iSCSI (qedi) driver.

2016-11-08 Thread Manish Rangankar
6. Using multiple memory barriers. - We kept both memory barriers as a failsafe, as for some architectures the call is the same but on others they are two different assembly operations. We have updated patch with same information in comments. Manish Rangankar (4): qedi:

[PATCH v3 net-next 2/3] qed: Add iSCSI out of order packet handling.

2016-12-01 Thread Manish Rangankar
From: Yuval Mintz This patch adds out of order packet handling for hardware offloaded iSCSI. Out of order packet handling requires driver buffer allocation and assistance. Signed-off-by: Arun Easi Signed-off-by: Yuval Mintz Reviewed-by: Johannes Thumshirn Reviewed-by: Hannes Reinecke --- dr

[PATCH v3 0/3] Add QLogic FastLinQ iSCSI (qedi) driver.

2016-12-01 Thread Manish Rangankar
IG_QED_ISCSI instead of CONFIG_QEDI 8. Added bad task mem access fix. Manish Rangankar (1): qedi: Add QLogic FastLinQ offload iSCSI driver framework. Yuval Mintz (2): qed: Add support for hardware offloaded iSCSI. qed: Add iSCSI out of order packet handling. MAINTAINERS

[PATCH v3 net-next 1/3] qed: Add support for hardware offloaded iSCSI.

2016-12-01 Thread Manish Rangankar
From: Yuval Mintz This adds the backbone required for the various HW initalizations which are necessary for the iSCSI driver (qedi) for QLogic FastLinQ 4 line of adapters - FW notification, resource initializations, etc. Signed-off-by: Arun Easi Signed-off-by: Yuval Mintz Reviewed-by: Joha

[PATCH] qedi: Fix memory leak in tmf response processing.

2017-02-24 Thread Manish Rangankar
From: "Dupuis, Chad" Signed-off-by: Manish Rangankar Signed-off-by: Chad Dupuis --- drivers/scsi/qedi/qedi_fw.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/qedi/qedi_fw.c b/drivers/scsi/qedi/qedi_fw.c index b1d3904..c9f0ef4 100644 --- a/dr

RE: [EXT] [PATCH -next] scsi: qla4xxx: check return code of qla4xxx_copy_from_fwddb_param

2018-12-24 Thread Manish Rangankar
f (rc) > + goto free_sess; > > ql4_printk(KERN_INFO, ha, "%s: sysfs entry %s created\n", >__func__, fnode_sess->dev.kobj.name); > -- > 2.7.0 > Thanks Acked-by: Manish Rangankar

RE: [EXT] [PATCH] scsi: bnx2i: fix indentation issue, remove a tab

2019-01-07 Thread Manish Rangankar
> hba->dummy_buffer = NULL; > } > - return; > + return; > } > > /** > -- > 2.19.1 Thanks Acked-by: Manish Rangankar

[PATCH] qedi: Add ep_state for login completion on un-reachable targets.

2019-01-09 Thread Manish Rangankar
-reachable target and thus proceed login to other reachable targets. Signed-off-by: Manish Rangankar --- drivers/scsi/qedi/qedi_iscsi.c | 3 +++ drivers/scsi/qedi/qedi_iscsi.h | 1 + 2 files changed, 4 insertions(+) diff --git a/drivers/scsi/qedi/qedi_iscsi.c b/drivers/scsi/qedi/qedi_iscsi.c index

RE: [PATCH 6/7] scsi: qlogic: no need to check return value of debugfs_create functions

2019-01-22 Thread Manish Rangankar
debugfs_remove_recursive(qedi->bdf_dentry); > - return; > - } > + debugfs_create_file(dops->name, 0600, qedi->bdf_dentry, qedi, > + fops); > dops++; > fops++; > } > @@ -60,8 +49,6 @@ void > qedi_dbg_init(char *drv_name) > { > qedi_dbg_root = debugfs_create_dir(drv_name, NULL); > - if (!qedi_dbg_root) > - QEDI_INFO(NULL, QEDI_LOG_DEBUGFS, "Init of debugfs failed\n"); > } > > void > -- > 2.20.1 Thanks Acked-by: Manish Rangankar

RE: [PATCH -next] scsi: qedf: Remove set but not used variable 'fr_len'

2019-04-01 Thread Manish Rangankar
oid qedf_fcoe_send_vlan_req(struct qedf_ctx *qedf) > if (!skb) > return; > > - fr_len = sizeof(*vlan); > eth_fr = (char *)skb->data; > vlan = (struct fip_vlan *)eth_fr; > > Thanks, Acked-by: Manish Rangankar

[PATCH] qedi: Drop cqe response during connection recovery

2018-01-18 Thread Manish Rangankar
We get stuck in the loop when firmware sends a cqe response during connection recovery. Signed-off-by: Manish Rangankar --- drivers/scsi/qedi/qedi_main.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/scsi/qedi/qedi_main.c b/drivers/scsi/qedi/qedi_main.c index

[PATCH] qla4xxx: skip error recovery in case of register disconnect.

2018-02-11 Thread Manish Rangankar
A system crashes when continuously removing/re-adding the storage controller. Signed-off-by: Manish Rangankar --- drivers/scsi/qla4xxx/ql4_def.h | 2 ++ drivers/scsi/qla4xxx/ql4_os.c | 46 ++ 2 files changed, 48 insertions(+) diff --git a/drivers/scsi

[PATCH] qedi: Fix kernel crash during port toggle.

2018-02-26 Thread Manish Rangankar
] [ 985.803294] qedi_percpu_io_thread+0x10f/0x1b0 [qedi] [ 985.808931] kthread+0xf5/0x130 [ 985.812434] ? qedi_free_uio+0xd0/0xd0 [qedi] [ 985.817298] ? kthread_bind+0x10/0x10 [ 985.821372] ? do_syscall_64+0x6e/0x1a0 Signed-off-by: Manish Rangankar --- drivers/scsi/qedi/qedi_fw.c | 5 + 1

[PATCH 1/2] qedi: Abort ep termination if offload not scheduled.

2019-04-19 Thread Manish Rangankar
6/0x50 kernel: ___sys_sendmsg+0x280/0x2a0 kernel: ? timerqueue_add+0x54/0x80 kernel: ? enqueue_hrtimer+0x38/0x90 kernel: ? hrtimer_start_range_ns+0x19f/0x2c0 kernel: __sys_sendmsg+0x58/0xa0 kernel: do_syscall_64+0x5b/0x180 kernel: entry_SYSCALL_64_after_hwframe+0x44/0xa9 Signed-off-by: Manish Ran

[PATCH 2/2] qedi: Adjust termination and offload ramrod timers.

2019-04-19 Thread Manish Rangankar
Signed-off-by: Manish Rangankar --- drivers/scsi/qedi/qedi_iscsi.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/qedi/qedi_iscsi.c b/drivers/scsi/qedi/qedi_iscsi.c index bf371e7..3032bfc 100644 --- a/drivers/scsi/qedi/qedi_iscsi.c +++ b/drivers/scsi/qedi

[PATCH 0/2] Ramrod timer and ep state fixes.

2019-04-19 Thread Manish Rangankar
Hi Martin, Please apply the following patches to the scsi tree at your earliest convenience. Thanks, Manish Manish Rangankar (2): qedi: Abort ep termination if offload not scheduled. qedi: Adjust termination and offload ramrod timers. drivers/scsi/qedi/qedi_iscsi.c | 8 ++-- 1 file

RE: [EXT] Re: [PATCH 0/2] Ramrod timer and ep state fixes.

2019-04-21 Thread Manish Rangankar
> -Original Message- > From: Lee Duncan > Sent: Friday, April 19, 2019 8:01 PM > To: Manish Rangankar ; > martin.peter...@oracle.com; cle...@redhat.com > Cc: linux-scsi@vger.kernel.org; qlogic-storage-upstr...@cavium.com > Subject: [EXT] Re: [PATCH 0/2] Ramrod tim

[PATCH v2 1/2] qedi: Abort ep termination if offload not scheduled.

2019-04-26 Thread Manish Rangankar
8/0x90 kernel: ? hrtimer_start_range_ns+0x19f/0x2c0 kernel: __sys_sendmsg+0x58/0xa0 kernel: do_syscall_64+0x5b/0x180 kernel: entry_SYSCALL_64_after_hwframe+0x44/0xa9 Signed-off-by: Manish Rangankar --- drivers/scsi/qedi/qedi_iscsi.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/scs

[PATCH v2 2/2] qedi: Adjust termination and offload ramrod timers.

2019-04-26 Thread Manish Rangankar
-off-by: Manish Rangankar --- drivers/scsi/qedi/qedi_iscsi.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/qedi/qedi_iscsi.c b/drivers/scsi/qedi/qedi_iscsi.c index bf371e7..3032bfc 100644 --- a/drivers/scsi/qedi/qedi_iscsi.c +++ b/drivers/scsi/qedi/qedi_iscsi.c

[PATCH v2 0/2] Ramrod timer and ep state fixes.

2019-04-26 Thread Manish Rangankar
Hi Martin, Please apply the following patches to the scsi tree at your earliest convenience. Changes from v1 -> v2 - Updated commit with description. Thanks, Manish Manish Rangankar (2): qedi: Abort ep termination if offload not scheduled. qedi: Adjust termination and offload ramrod tim

RE: [PATCH] scsi: qedi: fix spelling mistake "oflload" -> "offload"

2019-04-17 Thread Manish Rangankar
iscsi_conn_start(cls_conn); > if (rval) { > iscsi_conn_printk(KERN_ALERT, conn, > - "iscsi_conn_start: FW oflload conn > failed!!\n"); > + "iscsi_conn_start: FW offload conn > failed!!\n"); > } > > start_err: > -- > 2.20.1 Thanks, Acked-by: Manish Rangankar

RE: [PATCH -next] scsi: qedi: remove set but not used variables 'cdev' and 'udev'

2019-05-09 Thread Manish Rangankar
*shost, struct > sockaddr *dst_addr, > } > > qedi = iscsi_host_priv(shost); > - cdev = qedi->cdev; > - udev = qedi->udev; > > if (test_bit(QEDI_IN_OFFLINE, &qedi->flags) || > test_bit(QEDI_IN_RECOVERY, &qedi->flags)) { > -- > 2.7.4 > Thanks, Acked-by: Manish Rangankar

[PATCH 0/2] qedi: Remove unwanted warnings.

2017-06-15 Thread Manish Rangankar
Martin, Please consider below patches for next 'scsi-fixes' submission. Thanks, Manish Manish Rangankar (2): qedi: Remove WARN_ON for untracked cleanup. qedi: Remove WARN_ON from clear task context. drivers/scsi/qedi/qedi_fw.c | 1 - drivers/scsi/qedi/qedi_main.c | 4 +--

[PATCH 1/2] qedi: Remove WARN_ON for untracked cleanup.

2017-06-15 Thread Manish Rangankar
Signed-off-by: Manish Rangankar --- drivers/scsi/qedi/qedi_fw.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/scsi/qedi/qedi_fw.c b/drivers/scsi/qedi/qedi_fw.c index 8bc7ee1..507512c 100644 --- a/drivers/scsi/qedi/qedi_fw.c +++ b/drivers/scsi/qedi/qedi_fw.c @@ -870,7 +870,6

[PATCH 2/2] qedi: Remove WARN_ON from clear task context.

2017-06-15 Thread Manish Rangankar
Signed-off-by: Manish Rangankar --- drivers/scsi/qedi/qedi_main.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/scsi/qedi/qedi_main.c b/drivers/scsi/qedi/qedi_main.c index 09a2946..879d3b7 100644 --- a/drivers/scsi/qedi/qedi_main.c +++ b/drivers/scsi/qedi

[PATCH] qedi: Limit number for CQ queues.

2017-08-10 Thread Manish Rangankar
that qedi will know how much CQs are allowed. Signed-off-by: Manish Rangankar --- drivers/scsi/qedi/qedi.h | 5 ++--- drivers/scsi/qedi/qedi_iscsi.c | 2 +- drivers/scsi/qedi/qedi_main.c | 10 +++--- 3 files changed, 10 insertions(+), 7 deletions(-) diff --git a/drivers/scsi/qedi

[PATCH] qedi: Add PCI device-ID for QL41xxx adapters.

2017-03-15 Thread Manish Rangankar
Signed-off-by: Manish Rangankar --- drivers/scsi/qedi/qedi_main.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/scsi/qedi/qedi_main.c b/drivers/scsi/qedi/qedi_main.c index 8e3d928..92775a8 100644 --- a/drivers/scsi/qedi/qedi_main.c +++ b/drivers/scsi/qedi/qedi_main.c @@ -2007,6

[PATCH 5/7] qedi: Set firmware tcp msl timer value.

2017-05-19 Thread Manish Rangankar
Signed-off-by: Manish Rangankar --- drivers/scsi/qedi/qedi_main.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/scsi/qedi/qedi_main.c b/drivers/scsi/qedi/qedi_main.c index 997e305..62ba0550 100644 --- a/drivers/scsi/qedi/qedi_main.c +++ b/drivers/scsi/qedi/qedi_main.c @@ -827,6

[PATCH 0/7]qedi: Bug fixes.

2017-05-19 Thread Manish Rangankar
Martin, Please apply this patch set to next 'scsi-fixes' series. Thanks, Manish Arun Easi (1): qedi: Fix bad pte call trace when iscsiuio is stopped. Manish Rangankar (5): qedi: Correctly set firmware max supported BDs. qedi: Set dma_boundary to 0xfff. qedi: Fix endpoint NUL

[PATCH 3/7] qedi: Set dma_boundary to 0xfff.

2017-05-19 Thread Manish Rangankar
Signed-off-by: Manish Rangankar --- drivers/scsi/qedi/qedi.h | 1 + drivers/scsi/qedi/qedi_iscsi.c | 1 + 2 files changed, 2 insertions(+) diff --git a/drivers/scsi/qedi/qedi.h b/drivers/scsi/qedi/qedi.h index 269dac6..32632c9 100644 --- a/drivers/scsi/qedi/qedi.h +++ b/drivers/scsi/qedi

[PATCH 1/7] qedi: Fix bad pte call trace when iscsiuio is stopped.

2017-05-19 Thread Manish Rangankar
acesys+0xdd/0xe2 Signed-off-by: Arun Easi Signed-off-by: Manish Rangankar --- drivers/scsi/qedi/qedi_main.c | 23 +++ 1 file changed, 11 insertions(+), 12 deletions(-) diff --git a/drivers/scsi/qedi/qedi_main.c b/drivers/scsi/qedi/qedi_main.c index 92775a8..997e305 100644 --- a/d

[PATCH 6/7] qedi: set max_fin_rt default value

2017-05-19 Thread Manish Rangankar
From: Nilesh Javali max_fin_rt is the maximum re-transmission of FIN packets as part of the termination flow. After reaching this value the FW will send a single RESET. Signed-off-by: Nilesh Javali Signed-off-by: Manish Rangankar --- drivers/scsi/qedi/qedi_main.c | 1 + 1 file changed, 1

[PATCH 2/7] qedi: Correctly set firmware max supported BDs.

2017-05-19 Thread Manish Rangankar
Signed-off-by: Manish Rangankar --- drivers/scsi/qedi/qedi.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/qedi/qedi.h b/drivers/scsi/qedi/qedi.h index 5ca3e8c..269dac6 100644 --- a/drivers/scsi/qedi/qedi.h +++ b/drivers/scsi/qedi/qedi.h @@ -38,7 +38,7

[PATCH 4/7] qedi: Fix endpoint NULL panic in qedi_set_path.

2017-05-19 Thread Manish Rangankar
[] ? __schedule+0x2d8/0x900 [] ___sys_sendmsg+0x3a9/0x3c0 [] ? get_futex_key+0x1c8/0x2b0 [] ? futex_wake+0x80/0x160 Signed-off-by: Manish Rangankar --- drivers/scsi/qedi/qedi_iscsi.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/scsi/qedi/qedi_iscsi.c b/drivers

[PATCH 7/7] qedi: Fix endpoint NULL panic during recovery.

2017-05-19 Thread Manish Rangankar
Signed-off-by: Manish Rangankar --- drivers/scsi/qedi/qedi_fw.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/scsi/qedi/qedi_fw.c b/drivers/scsi/qedi/qedi_fw.c index d6978cb..8bc7ee1 100644 --- a/drivers/scsi/qedi/qedi_fw.c +++ b/drivers/scsi/qedi/qedi_fw.c @@ -1494,6 +1494,8

[PATCH] qedi: Send driver state to mfw.

2018-07-03 Thread Manish Rangankar
In case of iSCSI offload BFS environment, mfw requires to mark virtual link based upon qedi load status. Signed-off-by: Manish Rangankar --- drivers/scsi/qedi/qedi_main.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/drivers/scsi/qedi/qedi_main.c b/drivers/scsi/qedi