Re: [PATCH] [SCSI] sd: workaround invalid OPTIMAL TRANSFER LENGTH

2013-04-24 Thread Martin K. Petersen
skip_vpd_pages scsi_device parameter to bypass VPD scanning. Also blacklist the offending Seagate drive model. Reported-by: Mike Snitzer snit...@redhat.com Signed-off-by: Martin K. Petersen martin.peter...@oracle.com diff --git a/drivers/scsi/scsi_devinfo.c b/drivers/scsi/scsi_devinfo.c index 43fca91

Re: T10 WCE interpretation in Linux device level access

2013-04-24 Thread Martin K. Petersen
that bit when issuing flush_cmnd. But it would be something we would do manually on a per-device basis and not something that is automatically keyed off of NV_SUP (SYNC_NV doesn't require NV_SUP, btw., so that's not even a valid check). -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH 2/6] scsi_debug: prohibit scsi_debug_unmap_granularity == scsi_debug_unmap_alignment

2013-04-24 Thread Martin K. Petersen
with scsi_debug_unmap_alignment == 0 is the logical Akinobu blocks from 0 to scsi_debug_unmap_alignment - 1 cannot be Akinobu unmapped. But the difference is not properly handled in the Akinobu current code. Akinobu So this prohibits such unusual setting. Acked-by: Martin K. Petersen martin.peter

Re: [PATCH 3/6] scsi_debug: clear correct memory region when LBPRZ is enabled

2013-04-24 Thread Martin K. Petersen
, it is a index of probisioning map (map_storep). Acked-by: Martin K. Petersen martin.peter...@oracle.com -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord...@vger.kernel.org More majordomo

Re: [PATCH 4/6] scsi_debug: add translation functions between LBA and index of provisioning map

2013-04-24 Thread Martin K. Petersen
these functions will be done by Akinobu forthcoming patches. Acked-by: Martin K. Petersen martin.peter...@oracle.com -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord...@vger.kernel.org More

Re: [PATCH 5/6] scsi_debug: fix initialization of provisioning map

2013-04-24 Thread Martin K. Petersen
of memset(). Akinobu Otherwise it will cause problem on big-endian architecture if Akinobu the number of bits is not a multiple of BITS_PER_LONG. Acked-by: Martin K. Petersen martin.peter...@oracle.com -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line

Re: [PATCH 6/6] scsi_debug: fix logical block provisioning support

2013-04-24 Thread Martin K. Petersen
Akinobu == Akinobu Mita akinobu.m...@gmail.com writes: Akinobu This problem is due to the wrong translation between LBA and Akinobu index of provisioning map. Fix it by using correct translation Akinobu functions added previously. Acked-by: Martin K. Petersen martin.peter...@oracle.com

Re: [patch 1/1] sd_dif: problem with verify of type 1 protection information (PI)

2013-04-24 Thread Martin K. Petersen
was reported recently by Keith Busch. Signed-off-by: Martin K. Petersen martin.peter...@oracle.com -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord...@vger.kernel.org More majordomo info

Re: [PATCH 1/6] scsi_debug: call map_region() and unmap_region() only when needed

2013-04-24 Thread Martin K. Petersen
scsi_debug_lbp() returns true, i.e. logical block Akinobu provisioning is enabled. Acked-by: Martin K. Petersen martin.peter...@oracle.com Akinobu Because scsi_debug_unmap_granularity cannot be zero with usual Akinobu setting: scsi_debug_unmap_granularity is 1 by default, and it Akinobu can

Re: [PATCH 1/3] scsi_debug: fix data integrity support on highmem machine

2013-04-24 Thread Martin K. Petersen
issue that invalid kmap address is used Akinobu for kunmap_atomic(): the kmap address 'daddr' is incremented in Akinobu the loop for each data page, and it can reach the next page Akinobu boundary. That fix is fine. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list

Re: [PATCH 3/3] scsi_debug: simplify offset calculation for dif_storep

2013-04-24 Thread Martin K. Petersen
Akinobu == Akinobu Mita akinobu.m...@gmail.com writes: + sector += len / sizeof(*dif_storep); I'd rather see sizeof(struct scsi_dif_tuple) here. But that's just personal preference. Otherwise ok. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from

Re: [PATCH 2/3] scsi_debug: fix NULL pointer dereference with parameters dif=0 dix=1

2013-04-24 Thread Martin K. Petersen
of scsi_debug_dix. But it's very important to me that I'm able to set P_TYPE and the host protection mask as I see fit using the module parameters. Even when the combination of options don't make strict sense. Acked-by: Martin K. Petersen martin.peter...@oracle.com -- Martin K. Petersen

Re: WRITE SAME failed. Manually zeroing with 3w-xxxx driver

2013-04-29 Thread Martin K. Petersen
please test the patch below? Florian This goes on and on. The second question is what it is that's issuing these zeroouts at boot? Which filesystem are you using? What's your DM/MD config? -- Martin K. Petersen Oracle Linux Engineering 3w-: Create sense buffer for unsupported commands

Re: linux-next: Tree for May 6 (lpfc)

2013-05-06 Thread Martin K. Petersen
would seem to be James this. Patch ok as a short term fix. Longer term I'd like to provide a helper function that HBAs can call to validate the data and PI scatterlists. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line unsubscribe linux-scsi

Re: SCSI testing/USB devices are amazing

2013-05-09 Thread Martin K. Petersen
expect RDPROTECT/WRPROTECT 0 to fail, but they should succeed if the device is formatted with PI. FWIW, my slightly outdated document is here: https://oss.oracle.com/~mkp/docs/linux-advanced-storage.pdf -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list

[PATCH] scsi: Allow error handling timeout to be specified

2013-05-09 Thread Martin K. Petersen
) before we give up. Signed-off-by: Martin K. Petersen martin.peter...@oracle.com diff --git a/drivers/scsi/scsi_error.c b/drivers/scsi/scsi_error.c index c1b05a8..91adc52 100644 --- a/drivers/scsi/scsi_error.c +++ b/drivers/scsi/scsi_error.c @@ -44,8 +44,6 @@ static void scsi_eh_done(struct

Re: [PATCH] scsi: Allow error handling timeout to be specified

2013-05-10 Thread Martin K. Petersen
to tune this as it can take several iterations (bus device, target, bus, controller) before we give up. Signed-off-by: Martin K. Petersen martin.peter...@oracle.com diff --git a/drivers/scsi/scsi_error.c b/drivers/scsi/scsi_error.c index c1b05a8..91adc52 100644 --- a/drivers/scsi/scsi_error.c +++ b

Re: [PATCH] scsi: Allow error handling timeout to be specified

2013-05-10 Thread Martin K. Petersen
not required and the Baruch Linux kernel currently reaches to this big hammer too fast. I'm also working on a patch to add some heuristics to avoid the HBA and bus resets if I/O is completing successfully on other attached targets. But that's an orthogonal issue. -- Martin K. Petersen Oracle Linux

Re: [PATCH] scsi: Allow error handling timeout to be specified

2013-05-10 Thread Martin K. Petersen
Martin == Martin K Petersen martin.peter...@oracle.com writes: Martin I'm also working on a patch to add some heuristics to avoid the Martin HBA and bus resets Or rather: Defer the HBA and bus resets... Martin if I/O is completing successfully on other attached targets. But Martin that's

Re: [PATCH] scsi: Allow error handling timeout to be specified

2013-05-13 Thread Martin K. Petersen
completing successfully on other targets connected to the same HBA. So at some point we do need to give up and escalate to a full HBA reset. We would just like to defer that hammer until we have run out of other options. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from

Re: SCSI testing/USB devices are amazing

2013-05-14 Thread Martin K. Petersen
, if it is not Ronnie SBC-3 and if PROTECT is clear, then the test will be skipped but Ronnie not fail if the opcode is missing. *nod* -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord...@vger.kernel.org

Re: PING^7 (was Re: [PATCH v2 00/14] Corrections and customization of the SG_IO command whitelist (CVE-2012-4542))

2013-05-22 Thread Martin K. Petersen
in line with how Unix works... -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v3 0/6] scsi_debug: bug fixes and cleanups for data integrity support

2013-05-28 Thread Martin K. Petersen
of these things more palatable at the block/SCSI level. Akinobu voiced interest in finishing the scsi_debug work on top of my code. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord

Re: PING^7 (was Re: [PATCH v2 00/14] Corrections and customization of the SG_IO command whitelist (CVE-2012-4542))

2013-05-28 Thread Martin K. Petersen
consider it a failure when we start having applications that know about hardware intricacies, cylinders/heads/sectors, etc. That road leads straight to the 1980s... -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body

Re: RAID-10 keeps aborting

2013-06-05 Thread Martin K. Petersen
means write entire device. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] scsi: Check if the device support WRITE_SAME_10

2013-06-06 Thread Martin K. Petersen
specimens that report MAX WRITE SAME BLOCKS. -- Martin K. Petersen Oracle Linux Engineering [PATCH] sd: Update WRITE SAME heuristics SATA drives located behind a SAS controller would incorrectly receive WRITE SAME commands. Tweak the heuristics so that: - If REPORT SUPPORTED OPERATION CODES

Re: [PATCH v3 0/6] scsi_debug: bug fixes and cleanups for data integrity support

2013-06-06 Thread Martin K. Petersen
excessive. However, I personally don't care too much about 32-bit platforms, so... Acked-by: Martin K. Petersen martin.peter...@oracle.com -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord

Re: [SCSI REGRESSION] 3.10.2 or 3.10.3: arcmsr failure at bootup / early userspace transition

2013-07-29 Thread Martin K. Petersen
Nick Controller Nick Driver Version 1.20.00.15 2010/08/05 Nick [...] Interesting. Please provide the output of: # sg_inq /dev/sdd # sg_vpd /dev/sdd # sg_vpd -p ai /dev/sdd -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line unsubscribe linux-scsi

Re: [SCSI REGRESSION] 3.10.2 or 3.10.3: arcmsr failure at bootup / early userspace transition

2013-07-29 Thread Martin K. Petersen
Bernd == Bernd Schubert bernd.schub...@fastmail.fm writes: Bernd I tested this patch with ARC-1260 and F/W V1.49, no issues. It could be due to the firmware version discrepancy. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line unsubscribe

Re: Kernel 3.10.3 reset SuperSpeed USB device number 2 using xhci_hcd

2013-07-29 Thread Martin K. Petersen
the following instead? -- Martin K. Petersen Oracle Linux Engineering SCSI: Don't attempt to send extended INQUIRY command if skip_vpd_pages is set If a device has the skip_vpd_pages flag set we should simply fail the scsi_get_vpd_page() call. Signed-off-by: Martin K. Petersen

Re: Kernel 3.10.3 reset SuperSpeed USB device number 2 using xhci_hcd

2013-07-29 Thread Martin K. Petersen
Alan == Alan Stern st...@rowland.harvard.edu writes: Alan In the case of these bug reports, the scsi_report_opcode() call Alan returns -EINVAL. Oh, right. Because I actually do an explicit SCSI version check in scsi_report_opcode(). That's OK, then... -- Martin K. Petersen Oracle Linux

Re: [SCSI REGRESSION] 3.10.2 or 3.10.3: arcmsr failure at bootup / early userspace transition

2013-07-29 Thread Martin K. Petersen
as the sg commands are concerned... -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [SCSI REGRESSION] 3.10.2 or 3.10.3: arcmsr failure at bootup / early userspace transition

2013-07-29 Thread Martin K. Petersen
to find a good blacklist trigger. And that's tricky given that Areca allows you manually specify the SCSI model string for each volume... -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord

Re: Kernel 3.10.3 reset SuperSpeed USB device number 2 using xhci_hcd

2013-07-30 Thread Martin K. Petersen
in the stable Alan kernels as soon as possible. James? [PATCH] SCSI: Don't attempt to send extended INQUIRY command if skip_vpd_pages is set If a device has the skip_vpd_pages flag set we should simply fail the scsi_get_vpd_page() call. Signed-off-by: Martin K. Petersen martin.peter...@oracle.com

Re: [SCSI REGRESSION] 3.10.2 or 3.10.3: arcmsr failure at bootup / early userspace transition

2013-07-30 Thread Martin K. Petersen
skip_vpd_pages for the ATA models. Under the assumption that the SAS controllers actually feature the ATA Information VPD... -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord...@vger.kernel.org More

Re: [SCSI REGRESSION] 3.10.2 or 3.10.3: arcmsr failure at bootup / early userspace transition

2013-07-30 Thread Martin K. Petersen
that tomorrow, I just need the system as it is till Bernd tomorrow noon. That would be a great data point. I don't have any Areca boards. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord

Re: [SCSI REGRESSION] 3.10.2 or 3.10.3: arcmsr failure at bootup / early userspace transition

2013-07-30 Thread Martin K. Petersen
. The controller firmware in this case. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] scsi disk: Use its own buffer for the vpd request

2013-08-01 Thread Martin K. Petersen
for you? Do we get an appropriate error back when we try to issue WRITE SAME 10/16? If so, I'm OK with this fix. And thanks for looking into this! -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message

Re: Toshiba USB disk stopped working in 3.10.3

2013-08-05 Thread Martin K. Petersen
://marc.info/?l=linux-scsim=137536767805820w=2 -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: State of big-endian for MegaRAID SAS driver

2013-08-14 Thread Martin K. Petersen
interest? -- Martin K. Petersen Oracle Linux Engineering commit 906b6af65cde77a13641a476b55879424bfaae24 Author: Martin K. Petersen martin.peter...@oracle.com Date: Sat Aug 10 17:55:58 2013 -0400 megaraid_sas: Big endian support This driver only worked on a little endian

Re: State of big-endian for MegaRAID SAS driver

2013-08-14 Thread Martin K. Petersen
Martin == Martin K Petersen martin.peter...@oracle.com writes: And against upstream... -- Martin K. Petersen Oracle Linux Engineering commit 6d6db0df277b46ea538be5c70e89347436a8a114 Author: Martin K. Petersen martin.peter...@oracle.com Date: Sat Aug 10 17:55:58 2013 -0400

Re: State of big-endian for MegaRAID SAS driver

2013-08-14 Thread Martin K. Petersen
) etc. was mostly to annotate the endian-sensitive parameters in case somebody changes them in the future. -- Martin K. Petersen Oracle Linux Engineering diff --git a/drivers/scsi/megaraid/megaraid_sas_base.c b/drivers/scsi/megaraid/megaraid_sas_base.c index 7bf9c5c..154e9e1 100644 @@ -1170,7

Re: Incorrect LBA Returned from scsi_get_lba() and blk_rq_pos() (Possible DIF Impact)

2013-08-14 Thread Martin K. Petersen
! -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: State of big-endian for MegaRAID SAS driver

2013-08-15 Thread Martin K. Petersen
systems. But I didn't want to clutter the initial submission. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo

Re: [PATCH 2/2] TARGET/sbc,loopback: Adjust command data length in case pi exists on the wire

2014-06-02 Thread Martin K. Petersen
: + data_len += (data_len 12) * 8; + break; + default: + data_len += + (data_len ilog2(sc-device-sector_size)) * 8; + } -- Martin K. Petersen

Re: [PATCH v2 4/6] sd: use READ_16 or WRITE_16 when transfer length is greater than 0xffff

2014-06-02 Thread Martin K. Petersen
Akinobu == Akinobu Mita akinobu.m...@gmail.com writes: Akinobu This change makes the scsi disk driver handle the requests Akinobu whose transfer length is greater than 0x with READ_16 or Akinobu WRITE_16. Reviewed-by: Martin K. Petersen martin.peter...@oracle.com -- Martin K. Petersen

Re: [PATCH v2 5/6] scsi: increase upper limit for max_sectors

2014-06-02 Thread Martin K. Petersen
, so that SCSI lower Akinobu level drivers can specify more than 0x. Reviewed-by: Martin K. Petersen martin.peter...@oracle.com -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord

Re: [PATCH v2 6/6] scsi_debug: allow huge transfer length for read/write commands

2014-06-02 Thread Martin K. Petersen
not changing defaults for any of the HBA ASICs I'm OK with it. But I would like us to be very cautious about going above 0x blocks in general. I have seen several devices that misbehave if you do. Or garble any blocks beyond 0x. Reviewed-by: Martin K. Petersen martin.peter...@oracle.com

Re: [PATCH v2 1/6] block: fix BLKSECTGET ioctl when max_sectors is greater than USHRT_MAX

2014-06-02 Thread Martin K. Petersen
In such case, USHRT_MAX is more preferable than the lower 16 Akinobu bits of max_sectors. Reviewed-by: Martin K. Petersen martin.peter...@oracle.com -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message

[PATCH] sd: Limit transfer length

2014-06-02 Thread Martin K. Petersen
the max_hw_sectors queue limit. Signed-off-by: Martin K. Petersen martin.peter...@oracle.com diff --git a/drivers/scsi/sd.c b/drivers/scsi/sd.c index 321faf603035..56018f37518d 100644 --- a/drivers/scsi/sd.c +++ b/drivers/scsi/sd.c @@ -2228,7 +2228,11 @@ got_data: } } - sdp

Re: [PATCH 5/6] [SCSI] Look up and store NAA if VPD page 0x83 is present

2014-06-02 Thread Martin K. Petersen
VPD data so we don't have to do lookups for every copy command. Signed-off-by: Martin K. Petersen martin.peter...@oracle.com Reviewed-by: Nicholas Bellinger n...@linux-iscsi.org diff --git a/drivers/scsi/scsi.c b/drivers/scsi/scsi.c index 88d46fe6bf98..190dca4a8494 100644 --- a/drivers/scsi

Re: [PATCH 1/2] libiscsi, iser: Adjust data_length to include protection information

2014-06-03 Thread Martin K. Petersen
-facing DIX transfer length may be different. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] sd: Limit transfer length

2014-06-03 Thread Martin K. Petersen
in slave_configure(). Ew! If they muck with the limit they should be updating host-max_sectors accordingly. But I agree we should play it safe in sd. Updated patch below... -- Martin K. Petersen Oracle Linux Engineering [SCSI] sd: Limit transfer length Until now the per-command transfer length has

Re: [PATCH] [SCSI] Fix T10-DIF-TYPE3 get_tag handler for multi-sector bios

2014-06-03 Thread Martin K. Petersen
-by: Martin K. Petersen martin.peter...@oracle.com -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v1 1/3] scsi_cmnd: Introduce scsi_transfer_length helper

2014-06-10 Thread Martin K. Petersen
Or == Or Gerlitz or.gerl...@gmail.com writes: Or Just to make sure, by 3.16 you also mean 3.15.y, right? Yes. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord...@vger.kernel.org More

Re: [PATCH v1 3/3] TARGET/sbc,loopback: Adjust command data length in case pi exists on the wire

2014-06-11 Thread Martin K. Petersen
of recalculating the transport's cmd-data_length nab from values within the CDB w/ prot=1. nab MKP, WDYT..? My general feeling is that once sbc on the target sees {rd,wr}protect 0 we're in the territory where you should start separating data and PI internally. -- Martin K. Petersen Oracle Linux

Re: [PATCH v2 1/3] scsi_cmnd: Introduce scsi_transfer_length helper

2014-06-11 Thread Martin K. Petersen
transfer length from the scsi command data Sagi length and protection attributes. Looks good! -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord...@vger.kernel.org More majordomo info at http

Re: [PATCH 03/14] block: Deprecate integrity tagging functions

2014-06-11 Thread Martin K. Petersen
Christoph == Christoph Hellwig h...@infradead.org writes: Deprecate the tagging functions. Christoph This patch doesn't just deprecate them but outright removes Christoph them. Fixed. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line

Re: [PATCH 02/14] block: Replace bi_integrity with bi_special

2014-06-11 Thread Martin K. Petersen
; }; That's the way Jens has done it in struct request. I think I like that better and it doesn't send the same up-for-grabs signal that a void pointer might. Jens: Any preference? -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line unsubscribe

Re: [PATCH 05/14] block: Deprecate the use of the term sector in the context of block integrity

2014-06-11 Thread Martin K. Petersen
Christoph == Christoph Hellwig h...@infradead.org writes: Christoph On Wed, May 28, 2014 at 11:28:39PM -0400, Martin K. Petersen wrote: The protection interval is not necessarily tied to the logical block size of a block device. Stop using the terms sector and sectors. Christoph This does

Re: [PATCH 09/14] block: Relocate integrity flags

2014-06-11 Thread Martin K. Petersen
Christoph == Christoph Hellwig h...@infradead.org writes: Christoph On Wed, May 28, 2014 at 11:28:43PM -0400, Martin K. Petersen wrote: Move flags affecting the integrity code out of the bio bi_flags and into the block integrity payload. Christoph It seems like bip is guaranteed to be non

Re: [PATCH 10/14] block: Integrity checksum flag

2014-06-11 Thread Martin K. Petersen
to convert it to IP checksum. Another example is qualification tooling that needs to be able to write a block with bad PI out to storage. In that case we also have to tell the HBA to ignore checking the PI and that it shouldn't attempt a checksum conversion. -- Martin K. Petersen Oracle

Re: [PATCH 12/14] block: Add specific data integrity errors

2014-06-11 Thread Martin K. Petersen
, split and stacked. After talking to nab about his needs for target I figured it was better to just define new error codes and handle them like Hannes did for the extended SCSI errors. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line unsubscribe

Re: [PATCH 13/14] lib: Add T10 Protection Information functions

2014-06-11 Thread Martin K. Petersen
/. Fine by me. Jens? -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: sd_setup_discard_cmnd: BUG: unable to handle kernel NULL pointer dereference at (null)

2014-06-19 Thread Martin K. Petersen
we received a request with no bio. Does this happen with later kernels? -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org

Re: sd_setup_discard_cmnd: BUG: unable to handle kernel NULL pointer dereference at (null)

2014-06-20 Thread Martin K. Petersen
remove REQ_DISCARD from that helper for now. It's also a good idea to disable discard and write same on the client side when you set up the request queue: blk_queue_max_discard_sectors(q, 0); blk_queue_max_write_same_sectors(q, 0); -- Martin K. Petersen Oracle Linux Engineering

Re: sd_setup_discard_cmnd: BUG: unable to handle kernel NULL pointer dereference at (null)

2014-06-23 Thread Martin K. Petersen
bios. Lars linux upstream DRBD also does blk_queue_max_write_same_sectors(q, Lars 0) and blk_queue_max_discard_sectors(q, DRBD_MAX_DISCARD_SECTORS) Great! -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body

Re: [PATCH v2 1/3] scsi_cmnd: Introduce scsi_transfer_length helper

2014-06-23 Thread Martin K. Petersen
Mike == Mike Christie micha...@cs.wisc.edu writes: + unsigned int xfer_len = blk_rq_bytes(scmd-request); Mike Can you do bidi and dif/dix? Nope. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body

Re: [PATCH v2 1/3] scsi_cmnd: Introduce scsi_transfer_length helper

2014-06-24 Thread Martin K. Petersen
-by: Mike Christie micha...@cs.wisc.edu Signed-off-by: Martin K. Petersen martin.peter...@oracle.com diff --git a/include/scsi/scsi_cmnd.h b/include/scsi/scsi_cmnd.h index 42ed789ebafc..e0ae71098144 100644 --- a/include/scsi/scsi_cmnd.h +++ b/include/scsi/scsi_cmnd.h @@ -318,7 +318,7 @@ static inline

Re: [PATCH v2 1/3] scsi_cmnd: Introduce scsi_transfer_length helper

2014-06-24 Thread Martin K. Petersen
on the context the wrapper is called in. I think iscsi is the only place where there's a distinction thanks to bidi. Looks like there are several places where that's done. In that case I wonder if we should have explicit scsi_in_transfer_length() and scsi_out_transfer_length() wrappers? -- Martin K. Petersen

Re: [PATCH v2 1/3] scsi_cmnd: Introduce scsi_transfer_length helper

2014-06-24 Thread Martin K. Petersen
Mike == Mike Christie micha...@cs.wisc.edu writes: Mike It would be nice to just have one function to call and it just do Mike the right thing for the drivers. But what is the right thing when there are buffers for both directions? -- Martin K. Petersen Oracle Linux Engineering

Re: sd_setup_discard_cmnd: BUG: unable to handle kernel NULL pointer dereference at (null)

2014-06-24 Thread Martin K. Petersen
into that if there is a need. Do different clients share that context? I.e. does a synchronous discard block other clients from accessing the drbd server? -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord

Re: [PATCH v2 1/3] scsi_cmnd: Introduce scsi_transfer_length helper

2014-06-25 Thread Martin K. Petersen
a scsi_data_buffer to Christoph scsi_transfer_length(), and let the caller use Christoph scsi_in/scsi_out to find the right one. I'm perfectly OK with that approach. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line unsubscribe linux-scsi

Re: [PATCH 08/14] block: Add a disk flag to block integrity profile

2014-06-25 Thread Martin K. Petersen
Christoph == Christoph Hellwig h...@infradead.org writes: Christoph On Wed, Jun 11, 2014 at 09:30:34PM -0400, Martin K. Petersen wrote: /sys/block/foo/integrity/disk_is_formatted_with_pi /sys/block/foo/integrity/disk_is_integrity_capable /sys/block/foo/integrity/disk_supports_storing_pi

Re: sd_setup_discard_cmnd: BUG: unable to handle kernel NULL pointer dereference at (null)

2014-06-25 Thread Martin K. Petersen
to Lars worker threads. I'd prefer to have an async submit path. OK, I'll chew on it. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord...@vger.kernel.org More majordomo info at http

Re: [PATCH 1/4] megaraid_sas: Fix reset_mutex leak

2014-06-25 Thread Martin K. Petersen
adam == adam radford aradf...@gmail.com writes: Reviewed-by: Martin K. Petersen martin.peter...@oracle.com -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord...@vger.kernel.org More

Re: [PATCH 2/4] megaraid_sas: Remove unused variables in megasas_instance

2014-06-25 Thread Martin K. Petersen
adam == adam radford aradf...@gmail.com writes: Reviewed-by: Martin K. Petersen martin.peter...@oracle.com -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord...@vger.kernel.org More

Re: [PATCH 4/4] megaraid_sas: Version and Changelog update

2014-06-25 Thread Martin K. Petersen
-by: Martin K. Petersen martin.peter...@oracle.com -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 3/4] megaraid_sas: Fix LD/VF affiliation parsing

2014-06-25 Thread Martin K. Petersen
adam == adam radford aradf...@gmail.com writes: Adam, Looks like all callers of megasas_get_ld_vf_affiliation() set initial to 0. So you can drop a bunch of code and that'll also take care of one indentation level. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from

Re: [PATCH] cleanup switch in scsi_adjust_queue_depth()

2014-06-25 Thread Martin K. Petersen
) Doug Signed-off-by: Douglas Gilbert dgilb...@interlog.com I agree that the original version is a bit misleading. Reviewed-by: Martin K. Petersen martin.peter...@oracle.com -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line unsubscribe linux-scsi

Re: [PATCH] sg: limit maximum cdb size to 252 bytes

2014-06-25 Thread Martin K. Petersen
Signed-off-by: Douglas Gilbert dgilb...@interlog.com Reviewed-by: Martin K. Petersen martin.peter...@oracle.com -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord...@vger.kernel.org More

Re: [PATCH RESEND] [SCSI] bfa: Fix undefined bit shift on big-endian architectures with 32-bit DMA address

2014-06-25 Thread Martin K. Petersen
Christoph == Christoph Hellwig h...@infradead.org writes: Christoph Looks good, Reviewed-by: Christoph Hellwig h...@lst.de Christoph Can I get another review, too please? Reviewed-by: Martin K. Petersen martin.peter...@oracle.com -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH RESEND] [SCSI] aic94xx: Remove broken fallback for missing 'Ctrl-A' user settings

2014-06-25 Thread Martin K. Petersen
not populate the sas_addr. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: scsi-mq V2

2014-06-30 Thread Martin K. Petersen
K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 4/8] Drivers: scsi: storvsc: Filter WRITE_SAME_16

2014-07-11 Thread Martin K. Petersen
what does the storsvc report as its thin provisioning capabilities? -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org

Re: [PATCH v2 1/3] scsi_cmnd: Introduce scsi_transfer_length helper

2014-07-13 Thread Martin K. Petersen
this up in my integrity patch set since we already have the flag to determine whether to transfer PI or not. I'll get those patches out today. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord

Re: [PATCH 4/8] Drivers: scsi: storvsc: Filter WRITE_SAME_16

2014-07-13 Thread Martin K. Petersen
page inquiries on devices that are known to support them. Reported-by: KY Srinivasan k...@microsoft.com Signed-off-by: Martin K. Petersen martin.peter...@oracle.com diff --git a/drivers/scsi/scsi_scan.c b/drivers/scsi/scsi_scan.c index 4a6e4ba5a400..a5b1a224628a 100644 --- a/drivers/scsi/scsi_scan.c

Re: [PATCH 01/10] scsi: move the nr_phys_segments assert into scsi_init_io

2014-07-13 Thread Martin K. Petersen
Christoph == Christoph Hellwig h...@lst.de writes: Christoph scsi_init_io should only be called for requests that transfer Christoph data, so move the assert that a request has segments from the Christoph callers into scsi_init_io. Reviewed-by: Martin K. Petersen martin.peter...@oracle.com

Re: [PATCH 02/10] scsi: restructure command initialization for TYPE_FS requests

2014-07-13 Thread Martin K. Petersen
Christoph and zero out the CDB, and just leave the call to scsi_init_io Christoph to the ULDs. Reviewed-by: Martin K. Petersen martin.peter...@oracle.com -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message

Re: [PATCH 03/10] scsi: set sc_data_direction in common code

2014-07-13 Thread Martin K. Petersen
Christoph == Christoph Hellwig h...@lst.de writes: Could have a slightly more verbose patch description. Otherwise OK. Reviewed-by: Martin K. Petersen martin.peter...@oracle.com -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line unsubscribe

Re: [PATCH 04/10] sd: don't use scsi_setup_blk_pc_cmnd for flush requests

2014-07-13 Thread Martin K. Petersen
good. Christoph Also rename scsi_setup_flush_cmnd to sd_setup_flush_cmnd for Christoph consistency. Been wanting to do that for ages... Reviewed-by: Martin K. Petersen martin.peter...@oracle.com -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line

Re: [PATCH 05/10] sd: don't use scsi_setup_blk_pc_cmnd for write same requests

2014-07-13 Thread Martin K. Petersen
. Reviewed-by: Martin K. Petersen martin.peter...@oracle.com -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo

Re: [PATCH 06/10] sd: don't use scsi_setup_blk_pc_cmnd for discard requests

2014-07-13 Thread Martin K. Petersen
by * scsi_init_io() we set __data_len to the size of the area to be * discarded on disk. This allows us to report completion on the full * amount of blocks described by the request. */ Reviewed-by: Martin K. Petersen martin.peter...@oracle.com -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH 08/10] sd: retry discard commands

2014-07-13 Thread Martin K. Petersen
Christoph == Christoph Hellwig h...@lst.de writes: Christoph Currently cmd-allowed is initialized from rq-retries for Christoph discard commands, but retries is always 0 for non-BLOCK_PC Christoph requests. Set it to the standard number of retries instead. Reviewed-by: Martin K. Petersen

Re: [PATCH 07/10] sd: retry write same commands

2014-07-13 Thread Martin K. Petersen
Christoph == Christoph Hellwig h...@lst.de writes: Christoph Currently cmd-allowed is initialized from rq-retries for Christoph write same commands, but retries is always 0 for non-BLOCK_PC Christoph requests. Set it to the standard number of retries instead. Reviewed-by: Martin K. Petersen

Re: [PATCH 09/10] sd: split sd_init_command

2014-07-13 Thread Martin K. Petersen
Christoph == Christoph Hellwig h...@lst.de writes: Christoph Factor out a function to initialize regular read/write Christoph commands and leave sd_init_command as a simple dispatcher to Christoph the different prepare routines. Reviewed-by: Martin K. Petersen martin.peter...@oracle.com

Re: [PATCH 10/10] scsi: mark scsi_setup_blk_pc_cmnd static

2014-07-13 Thread Martin K. Petersen
Christoph == Christoph Hellwig h...@lst.de writes: Reviewed-by: Martin K. Petersen martin.peter...@oracle.com -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord...@vger.kernel.org More

Re: [RESEND][PATCH 01/10][SCSI]mpt2sas: Added driver module parameter max_msix_vectors

2014-07-13 Thread Martin K. Petersen
of Sreekanth MSI-X vectors supported by the HBA, the number of CPU cores Sreekanth and the value set to max_msix_vectors module parameters. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord

Re: [RESEND][PATCH 01/10][SCSI]mpt2sas: Added driver module parameter max_msix_vectors

2014-07-13 Thread Martin K. Petersen
of Sreekanth MSI-X vectors supported by the HBA, the number of CPU cores Sreekanth and the value set to max_msix_vectors module parameters. Reviewed-by: Martin K. Petersen martin.peter...@oracle.com -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line

Re: [RESEND][PATCH 02/10][SCSI]mpt2sas: MPI2 Rev Y (2.00.17) and Rev Z (2.00.18) specifications

2014-07-13 Thread Martin K. Petersen
Tool to send a Sreekanthstring to IOC's Console using different console types (eg: SreekanthUART serial terminal or Ethernet terminal). Sreekanth The copyright in the mpi files is updated for year 2014 Reviewed-by: Martin K. Petersen martin.peter...@oracle.com -- Martin K. Petersen

  1   2   3   4   5   6   7   8   9   10   >