Re: [PATCH 01/21] lpfc: Fix opps when ExpressLane is enabled

James Smart writes: > From: Dick Kennedy > > Null pointer dereference in lpfc_sli4_fof_intr_handler > > The driver does not set up cq->assoc_qp for sli4_hba->oas_cq > > Initialize cq->assoc_qp before accessing it > > Signed-off-by: Dick Kennedy

aac_convert_sgraw2() masks -ENOMEM

Hey, today, I have run smatch and it reports, that aac_convert_sgraw2() returns -1 instead of -ENOMEM on kmalloc(). This is easy to fix, but nobody tests what aac_convert_sgraw2() returns in aac_build_sgraw2() Since commit 0b4334473d48 ("[SCSI] aacraid: SCSI dma mapping failure case handling"),

[PATCH] scsi: aacraid: error: testing array offset 'bus' after use

Fix possible indexing array of bound for >hba_map[bus][cid], where bus and cid boundary check happens later. Fixes: 0d643ff3c353 ("scsi: aacraid: use aac_tmf_callback for reset fib") Signed-off-by: Nikola Pajkovsky <npajkov...@suse.cz> --- drivers/scsi/a

[PATCH 3/3] scsi: aacraid: report -ENOMEM to upper layer from aac_convert_sgraw2()

aac_convert_sgraw2() kmalloc memory and return -1 on error, which should be -ENOMEM. However, nobody is checking return value, so with this change, -ENOMEM is propagated to upper layer. Signed-off-by: Nikola Pajkovsky <npajkov...@suse.cz> --- drivers/scsi/aacraid/aachba.c | 10 +++---

[PATCH 1/3] scsi: aacraid: fix indentation errors

fix stupid indent error, no rocket science here. Signed-off-by: Nikola Pajkovsky <npajkov...@suse.cz> --- drivers/scsi/aacraid/comminit.c | 6 +++--- drivers/scsi/aacraid/linit.c| 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/scsi/aacraid/comminit.c b/d

[PATCH 2/3] scsi: aacraid: get rid of one level of indentation

other code has changed. Signed-off-by: Nikola Pajkovsky <npajkov...@suse.cz> --- drivers/scsi/aacraid/aachba.c | 267 +- 1 file changed, 131 insertions(+), 136 deletions(-) diff --git a/drivers/scsi/aacraid/aachba.c b/drivers/scsi/aacraid/aa

Re: [PATCH v2 22/30] scsi: aacraid: Merge adapter setup with resolve luns

Raghava Aditya Renukunta writes: > The device hotplug events are processed only after retrieving the updated > lun information from the fw. Does not make sense to keep them separate. > > Merge both the hotplug handling and safw adapter setup code into

Re: [PATCH v2 22/30] scsi: aacraid: Merge adapter setup with resolve luns

Raghava Aditya Renukunta <raghavaaditya.renuku...@microsemi.com> writes: > Hi Nikola, > >> -Original Message----- >> From: Nikola Pajkovsky [mailto:npajkov...@suse.cz] >> Sent: Wednesday, January 3, 2018 2:02 AM >> To: Raghava Aditya Renukunta >> <