On 12/7/18 8:20 PM, Martin K. Petersen wrote:
>
> Jens,
>
> This went in through your tree. Can you please pick this fix up?
Yep, applied, thanks Dan.
--
Jens Axboe
James,
> Update lpfc to revision 12.0.0.9
>
> This patch contains lpfc bug fixes
Applied to 4.21/scsi-queue, thanks!
--
Martin K. Petersen Oracle Linux Engineering
Dan,
> If "interface" is NULL then we can't release it and trying to will
> only lead to an Oops.
Applied to 4.20/scsi-fixes, thanks!
--
Martin K. Petersen Oracle Linux Engineering
Himanshu,
> This reverts commit db186382af21e926e90df19499475f2552192b77.
>
> This commit introduced regression with FCP discovery so revert it back
> to fix discovery for FCP luns
Applied to 4.20/scsi-fixes.
--
Martin K. Petersen Oracle Linux Engineering
Jens,
This went in through your tree. Can you please pick this fix up?
> On Thu, Nov 29, 2018 at 01:37:10PM +0300, Dan Carpenter wrote:
>> Smatch generates a warning:
>>
>> drivers/scsi/scsi_lib.c:1656 scsi_mq_done() warn: test_bit() takes a bit
>> number
>>
>> The problem is that
Hi Brace,
In this patch series, do you have fixed and verified the timeout issue?
https://patchwork.kernel.org/patch/10637797/
Thanks,
- Alex
Don Brace 于2018年12月8日周六 上午6:28写道：
>
> These patches are based on Linus's tree
>
> The changes are:
>
> -
Steffen,
> One new recovery fix, which is not urgent, for an old bug. It's
> sufficient to apply it on top of the previously sent 23 zfcp updates
> for the v4.21 merge window
Applied to 4.21/scsi-queue, thanks!
--
Martin K. Petersen Oracle Linux Engineering
David,
> This patch-set allows for the modification of the T10 Vendor
> Identification string returned in the SCSI INQUIRY response, via the
> target/core/$backstore/$name/wwn/vendor_id ConfigFS path.
Applied to 4.21/scsi-queue, thank you!
--
Martin K. Petersen Oracle Linux Engineering
Bart,
> Nesting in __qla2x00_abort_all_cmds() is way too deep. Reduce the
> nesting level by introducing a helper function. This patch does not
> change any functionality.
Applied to 4.21/scsi-queue. Thank you.
--
Martin K. Petersen Oracle Linux Engineering
Varun,
> flush_scheduled_work() is not required as csio_hw_exit_workers() calls
> cancel_work_sync() for hw->evtq_work.
Applied to 4.21/scsi-queue, thanks!
--
Martin K. Petersen Oracle Linux Engineering
Steffen,
> Introduce separate zfcp module parameters to individually select
> support for: DIF which should work (zfcp.dif, which used to be
> DIF+DIX, disabled) or DIX+DIF which can cause trouble (zfcp.dix, new,
> disabled).
Applied to 4.21/scsi-queue.
--
Martin K. Petersen Oracle
Avri,
> By spec, the ufs sense data is 18 bytes long.
Applied to 4.21/scsi-queue, thanks!
--
Martin K. Petersen Oracle Linux Engineering
Reviewed-by: Gerry Morong
Reviewed-by: Dave Carroll
Signed-off-by: Don Brace
---
drivers/scsi/smartpqi/smartpqi_init.c |6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/scsi/smartpqi/smartpqi_init.c
b/drivers/scsi/smartpqi/smartpqi_init.c
index
Reviewed-by: Scott Benesh
Reviewed-by: Mahesh Rajashekhara
Reviewed-by: Scott Teel
Reviewed-by: Dave Carroll
Reviewed-by: Kevin Barnett
Signed-off-by: Don Brace
---
drivers/scsi/smartpqi/smartpqi.h | 89 +
drivers/scsi/smartpqi/smartpqi_init.c | 131
From: Kevin Barnett
Problem:
The Linux kernel takes a logical volume offline after a LUN reset.
This is generally accompanied by this message in the dmesg output:
Device offlined - not ready after error recovery
Root Cause:
The root cause is a "quirk" in the timeout handling in the Linux
SCSI
The PCI_IRQ_AFFINITY flag prevents customers from
changing the smp_affinity and smp_affinity_list entries.
Add a module parameter to allow this flag to be turned
off.
Reviewed-by: Scott Teel
Reviewed-by: Murthy Bhat
Reviewed-by: Mahesh Rajashekhara
Reviewed-by: Dave Carroll
Reviewed-by:
From: Dave Carroll
Reviewed-by: Murthy Bhat
Reviewed-by: Mahesh Rajashekhara
Reviewed-by: Scott Teel
Reviewed-by: Kevin Barnett
Signed-off-by: Dave Carroll
Signed-off-by: Don Brace
---
drivers/scsi/smartpqi/smartpqi_init.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff
From: Dave Carroll
- fix race condition when a unit is deleted after an RLL,
and before we have gotten the LV_STATUS page of the unit.
- In this case we will get a standard inquiry, rather than
the desired page. This will result in a unit presented
which no longer exists.
- If we
From: Murthy Bhat
- fix a formatting issue.
Reviewed-by: Mahesh Rajashekhara
Reviewed-by: Scott Teel
Reviewed-by: Dave Carroll
Reviewed-by: Kevin Barnett
Signed-off-by: Murthy Bhat
Signed-off-by: Don Brace
---
drivers/scsi/smartpqi/smartpqi_init.c |7 ++-
1 file changed, 6
From: Mahesh Rajashekhara
- wait on all outstanding I/O to complete before the device is removed.
- check for null device pointers in IO entry/completion functions.
Reviewed-by: Scott Teel
Reviewed-by: Murthy Bhat
Reviewed-by: Dave Carroll
Reviewed-by: Kevin Barnett
Signed-off-by: Mahesh
From: Sagar Biradar
- set pci_dev->dev to 0 only if the node is NO_NUMA_NODE.
If not, do not reset the value but retain it.
Reviewed-by: Murthy Bhat
Reviewed-by: Mahesh Rajashekhara
Reviewed-by: Dave Carroll
Reviewed-by: Scott Teel
Reviewed-by: Kevin Barnett
Signed-off-by: Sagar Biradar
From: Ajish Koshy
Reviewed-by: Murthy Bhat
Reviewed-by: Mahesh Rajashekhara
Reviewed-by: Dave Carroll
Reviewed-by: Scott Teel
Reviewed-by: Kevin Barnett
Signed-off-by: Ajish Koshy
Signed-off-by: Don Brace
---
drivers/scsi/smartpqi/smartpqi_init.c | 59 -
From: Ajish Koshy
Reviewed-by: Murthy Bhat
Reviewed-by: Mahesh Rajashekhara
Reviewed-by: Dave Carroll
Reviewed-by: Scott Teel
Reviewed-by: Kevin Barnett
Signed-off-by: Ajish Koshy
Signed-off-by: Don Brace
---
drivers/scsi/smartpqi/smartpqi_init.c | 24
1 file
From: Dave Carroll
- set allow_restart option during scsi_device init.
This allows the kernel to send a START/STOP Unit command
to the drive if it encounters a 4/2 check condition in sense data.
Reviewed-by: Murthy Bhat
Reviewed-by: Mahesh Rajashekhara
Reviewed-by: Kevin Barnett
From: Mahesh Rajashekhara
Reviewed-by: Ajish Koshy
Reviewed-by: Murthy Bhat
Reviewed-by: Justin Lindley
Reviewed-by: Scott Benesh
Reviewed-by: Dave Carroll
Reviewed-by: Scott Teel
Reviewed-by: Kevin Barnett
Signed-off-by: Mahesh Rajashekhara
Signed-off-by: Don Brace
---
From: Dave Carroll
- add sysfs device attributes, unique_id, lunid
and path_info.
Reviewed-by: Scott Teel
Reviewed-by: Kevin Barnett
Signed-off-by: Dave Carroll
Signed-off-by: Don Brace
---
drivers/scsi/smartpqi/smartpqi.h |3
drivers/scsi/smartpqi/smartpqi_init.c | 232
From: Murthy Bhat
Reviewed-by: Scott Benesh
Reviewed-by: Mahesh Rajashekhara
Reviewed-by: Dave Carroll
Reviewed-by: Scott Teel
Reviewed-by: Kevin Barnett
Signed-off-by: Murthy Bhat
Signed-off-by: Don Brace
---
drivers/scsi/smartpqi/smartpqi_init.c |8
1 file changed, 8
From: Mahesh Rajashekhara
Reviewed-by: Scott Benesh
Reviewed-by: Ajish Koshy
Reviewed-by: Murthy Bhat
Reviewed-by: Mahesh Rajashekhara
Reviewed-by: Dave Carroll
Reviewed-by: Scott Teel
Reviewed-by: Kevin Barnett
Signed-off-by: Mahesh Rajashekhara
Signed-off-by: Don Brace
---
From: Kevin Barnett
Add support for new IUs and parsing of the Firmware Features
section of the PQI Config Table to implement the
"handshake" between the driver and firmware to communicate
firmware features supported and enabled by the driver.
Reviewed-by: Ajish Koshy
Reviewed-by: Mahesh
These patches are based on Linus's tree
The changes are:
- smartpqi-add-support-for-PQI-Config-Table-handshake
. add support for get/set controller features.
- smartpqi-add-retries-for-device-resets
. re-attempt device reset.
- smartpqi-add-no_write_same-for-logical-volumes
. turn off
From: Dave Carroll
- allow update the luns for PTRAID devices.
Reviewed-by: Ajish Koshy
Reviewed-by: Murthy Bhat
Reviewed-by: Mahesh Rajashekhara
Reviewed-by: Justin Lindley
Reviewed-by: Scott Teel
Reviewed-by: Kevin Barnett
Signed-off-by: Dave Carroll
Signed-off-by: Don Brace
---
From: Dave Carroll
During slave_alloc, for logical volumes include no_write_same into
the scsi_device structure. This will insure that WRITE_SAME will not
be used for LD's.
Reviewed-by: Ajish Koshy
Reviewed-by: Murthy Bhat
Reviewed-by: Mahesh Rajashekhara
Reviewed-by: Justin Lindley
From: Dave Carroll
cleanup the common code which creates a raid path request
for the controller LUNID and sends it synchronously, into a
common routine;
Reviewed-by: Murthy Bhat
Reviewed-by: Mahesh Rajashekhara
Reviewed-by: Scott Teel
Reviewed-by: Kevin Barnett
Signed-off-by: Dave Carroll
Note that independent of what we do in the Linux iSCSI initiator
this is a network DOS, so we'll have to fix it.
On Wed, Dec 05, 2018 at 12:09:40PM -0800, Lee Duncan wrote:
> I recently found what I believe is a bug, and I'd appreciate feedback
> on if that is correct, and if so how to proceed.
>
Hi Hannes,
Commit bbc0f8bd88ab ("scsi: libfc: Add WARN_ON() when deleting rports")
added a warning whose intent was to check whether the rport was still
linked into the peer list. It doesn't work as intended and I
consistently see messages like the following:
[ 66.157471] host1: rport
Urgently need money? We can help you!
Are you by the current situation in trouble or threatens you in trouble?
In this way, we give you the ability to take a new development.
As a rich person I feel obliged to assist people who are struggling to give
them a chance. Everyone deserved a second
Update driver version from 27.100.00.00 to 27.101.00.00.
Signed-off-by: Suganath Prabu
---
drivers/scsi/mpt3sas/mpt3sas_base.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/scsi/mpt3sas/mpt3sas_base.h
b/drivers/scsi/mpt3sas/mpt3sas_base.h
index
Use ioc->base_readl to restrict the readl retries to only
Aero controllers.
Signed-off-by: Suganath Prabu
---
drivers/scsi/mpt3sas/mpt3sas_base.c | 39 +++--
1 file changed, 20 insertions(+), 19 deletions(-)
diff --git a/drivers/scsi/mpt3sas/mpt3sas_base.c
Adding flag "is_aero_ioc" to differentiate aero based controllers
from other gen35 controllers.
Signed-off-by: Suganath Prabu
---
drivers/scsi/mpt3sas/mpt3sas_base.h | 1 +
drivers/scsi/mpt3sas/mpt3sas_scsih.c | 14 --
2 files changed, 9 insertions(+), 6 deletions(-)
diff --git
Sometimes Aero controllers appears to be returning bad data (0)
for doorbell register read and if retries are performed immediately
after the bad read, they return good data.
Workaround is added to retry read from doorbell registers
for maximum three times if driver get the zero.
Added functions
Problem statement:
Sometimes aero controllers appears to be returning bad data (0)
for doorbell register read and if retries are performed immediately
after the bad read, they return good data.
Fix:
In below four patches added workaround to retry read operation from
controller doorbell registers
This reverts commit db186382af21e926e90df19499475f2552192b77.
This commit introduced regression with FCP discovery so revert
it back to fix discovery for FCP luns
Cc:
Signed-off-by: Himanshu Madhani
---
Hi Martin,
This patch has introduced regression for LUN discovery with FC.
Please apply
On Thu, 6 Dec 2018, Christoph Hellwig wrote:
> This function is a huge mess with duplicated error handling. Split out
> a few useful helpers and use goto labels to untangle the error handling
> and no-data ioctl handling.
>
> Signed-off-by: Christoph Hellwig
> ---
> drivers/scsi/gdth.c |
Would be nice to be pointed to the correct place to report major
regressions, if not here.
Note that the same error occurs:
* on 4.18.19
* on 4.19.8-rc1
* with the latest firmware (16.00.01)
* on a number of other peoples' powerpc64/power9 hardware.
Note that both 4.18.X and 4.19.Y will,
Hey everybody,
I'm the arch lead for Gentoo Linux on alpha (yes, the arch still
exists). Starting with 4.20-rc*, I get SCSI reset loops shortly
after boot:
aboot: starting kernel boot/vmlinuz-4.20.0-rc3 with arguments ro root=/dev/sda2
console=ttyS0 loglevel=6
[0.00] Linux version
https://bugzilla.kernel.org/show_bug.cgi?id=199435
--- Comment #27 from Gaetan Trellu (gaetan.tre...@incloudus.com) ---
By compiling the hpsa kernel module from SourceForge on Ubuntu 16.04 with
kernel 4.4 solved the issue for us.
Steps:
# apt-get install dkms build-essential
# tar xjvf
On 06/12/2018 17:50, Johannes Thumshirn wrote:
> Why not calling dma_alloc_coherent() directly instead of using the
> pci_alloc_consistent() wrapper?
Ah should've read the whole series
--
Johannes ThumshirnSUSE Labs Filesystems
jthumsh...@suse.de
On 06/12/2018 16:57, Christoph Hellwig wrote:
> Out of the three callers once insists on the scratch buffer, and the
> others are fine with a new allocation. Switch those two to juse use
> pci_alloc_consistent directly, and open code the scratch buffer
> allocation in the remaining one. This
Complements
v2.6.35 commit 64deb6efdc55
("[SCSI] zfcp: Use status_read_buf_num provided by FCP channel")
which replaced the hardcoded 16 with a variable value
Also complements already existing fixups for above commit
v2.6.35 commit 8d88cf3f3b9a
("[SCSI] zfcp: Update status read mempool")
v3.10
Suppose adapter (open) recovery is between opened QDIO queues and before
(the end of) initial posting of status read buffers (SRBs). This time
window can be seconds long due to FSF_PROT_HOST_CONNECTION_INITIALIZING
causing by design looping with exponential increase sleeps in the function
James, Martin,
One new recovery fix, which is not urgent, for an old bug.
It's sufficient to apply it on top of the previously sent
23 zfcp updates for the v4.21 merge window
[https://www.spinics.net/lists/linux-scsi/msg125211.html].
The 2 new patches apply to Martin's 4.21/scsi-queue
and to
This code has been under a never defined ifdef since the beginning
of time (or at least history), and has just bitrotted. Nuke it.
Signed-off-by: Christoph Hellwig
---
drivers/scsi/gdth.c | 151
1 file changed, 12 insertions(+), 139 deletions(-)
The non-PCI code has bitrotted for quite a while and will just oops
on load because it passes a NULL pointer to the PCI DMA routines.
Lets kill it for good - if someone really wants to use one of these
cards I'll help mentoring them to write a proper driver glue.
Signed-off-by: Christoph Hellwig
Out of the three callers once insists on the scratch buffer, and the
others are fine with a new allocation. Switch those two to juse use
pci_alloc_consistent directly, and open code the scratch buffer
allocation in the remaining one. This avoids a case where we might
be doing a memory allocation
gdth_show_info currently allocs and frees a dma buffer four times,
which isn't very efficient. Reuse a single allocation instead.
Signed-off-by: Christoph Hellwig
---
drivers/scsi/gdth_proc.c | 20 +---
1 file changed, 5 insertions(+), 15 deletions(-)
diff --git
This function is a huge mess with duplicated error handling. Split out
a few useful helpers and use goto labels to untangle the error handling
and no-data ioctl handling.
Signed-off-by: Christoph Hellwig
---
drivers/scsi/gdth.c | 244 +++-
1 file
Switch from the legacy PCI DMA API to the generic DMA API. Also switch
to dma_map_single from pci_map_page in one case where this makes the code
simpler.
Signed-off-by: Christoph Hellwig
---
drivers/scsi/gdth.c | 59 +++-
drivers/scsi/gdth_proc.c | 4
This code can't be built into the kernel without editing the source
file and is not generall useful.
Signed-off-by: Christoph Hellwig
---
drivers/scsi/gdth.c | 18 --
drivers/scsi/gdth_proc.c | 8
2 files changed, 26 deletions(-)
diff --git a/drivers/scsi/gdth.c
This can't ever be compiled into the kernel, so remove it.
Signed-off-by: Christoph Hellwig
---
drivers/scsi/gdth_ioctl.h | 89 ---
drivers/scsi/gdth_proc.c | 18
2 files changed, 107 deletions(-)
diff --git a/drivers/scsi/gdth_ioctl.h
Remove never compile in support for sending debug traces straight to
the serial port using direct port access.
Signed-off-by: Christoph Hellwig
---
drivers/scsi/gdth.c | 70 -
1 file changed, 70 deletions(-)
diff --git a/drivers/scsi/gdth.c
This code has been under the never defined GDTH_RTC ifdef forever,
nuke it.
Signed-off-by: Christoph Hellwig
---
drivers/scsi/gdth.c | 32
1 file changed, 32 deletions(-)
diff --git a/drivers/scsi/gdth.c b/drivers/scsi/gdth.c
index e8121b80233c..63d704301875
Cleans up various oddities found during a code audit, and drops the
legacy ISA support which hasn't had a chance to actually work for a
long time.
On 23/10/2018 06:35, Can Guo wrote:
> From: Dov Levenglick
>
> Enables core reset support. Add full initialization of the PHY and the
> controller before initializing UFS PHY and during link recovery.
>
> Signed-off-by: Dov Levenglick
> Signed-off-by: Amit Nischal
> Signed-off-by: Subhash
David,
> Indeed, the comment should refer to page 0x83.
> @Martin: all patches in this series have now been reviewed+acked. Can
> you fix the above comment (s/0x80/0x83) if/when you merge, or
>should I resend the series with this fixed?
I'll fix it up.
--
Martin K. Petersen
On Thu, 6 Dec 2018 15:25:42 +0300, Roman Bolshakov wrote:
> > /*
> > + * STANDARD and VPD page 0x80 T10 Vendor Identification
>
> Perhaps you meant 0x83 (Device Identification VPD page, T10 vendor ID
> based designator). INQUIRY page 0x80 is Unit Serial Number.
Indeed, the comment should
On Wed, Dec 05, 2018 at 01:18:35PM +0100, David Disseldorp wrote:
> In preparation for supporting user provided vendor strings, add an extra
> byte to the vendor, model and revision arrays in struct t10_wwn. This
> ensures that the full INQUIRY data can be carried in the arrays along
> with a
On Wed, Dec 05, 2018 at 01:18:36PM +0100, David Disseldorp wrote:
> The vendor_id attribute will allow for the modification of the T10
> Vendor Identification string returned in inquiry responses. Its value
> can be viewed and modified via the ConfigFS path at:
>
Hi,
在 2018/12/6 20:04, John Garry 写道:
On 06/12/2018 04:17, Martin K. Petersen wrote:
+
Bart,
Had you considered to use lower_32_bits() instead of "0x"?
That would to avoid that reviewers have to count the 'f'-s to verify
correctness of t10_pi_ref_tag().
I hadn't. I guess I tend
On 05/12/2018 08:01, Vivek Gautam wrote:
> On Tue, Oct 23, 2018 at 10:07 AM Can Guo wrote:
>>
>> This patch series adds support for UFS QMP PHY on SDM845 and the
>> compatible string for it. This patch series depends on the current
>> proposed QMP V3 USB3 UNI PHY support for sdm845 driver [1],
On 06/12/2018 04:17, Martin K. Petersen wrote:
+
Bart,
Had you considered to use lower_32_bits() instead of "0x"?
That would to avoid that reviewers have to count the 'f'-s to verify
correctness of t10_pi_ref_tag().
I hadn't. I guess I tend to think of lower_32_bits() as something
Dne 6.12.2018 v 11:34 Maurizio Lombardi napsal(a):
> This is what I see when a cd burn operation completes:
>
This is the complete blktrace log:
11,034 0.81759 11653 D W 63488 (2a 00 00 03 3c 29 00 00
1f 00 ..) [wodim]
11,034 0.81759 11653 D
Hi Jens,
Dne 20.6.2018 v 16:09 Jens Axboe napsal(a):
> On 6/20/18 5:52 AM, Maurizio Lombardi wrote:
>> Hi Jens,
>>
>> Dne 23.5.2018 v 16:42 Jens Axboe napsal(a):
>>> On 5/23/18 3:19 AM, Maurizio Lombardi wrote:
Dne 22.5.2018 v 16:47 Jens Axboe napsal(a):
> It's been many years,
Bart,
> Had you considered to use lower_32_bits() instead of "0x"?
> That would to avoid that reviewers have to count the 'f'-s to verify
> correctness of t10_pi_ref_tag().
I hadn't. I guess I tend to think of lower_32_bits() as something you do
to pointers, not to block numbers.
--
I recently found what I believe is a bug, and I'd appreciate feedback
on if that is correct, and if so how to proceed.
BACKGROUND
Recently Christoph Hellwig sent an email to driver maintainers for
drivers that set ".use_clustering" to DISABLE_CLUSTERING in their SCSI
Host templates, asking if
On 11/21/18 1:41 AM, Christoph Hellwig wrote:
> Hi all,
>
> you in the To list maintain or wrote SCSI drivers that set the
> DISABLE_CLUSTERING flag, which basically disable merges of any
> bio segments. We already have the actual max_segment size limit
> to say which length a segment should
On 12/5/18 6:04 AM, Martin K. Petersen wrote:
Since the return value of this function is 'u32', can the ' &
0x' be left out?
Absolutely, and I almost zapped it. However, I decided to leave it to
emphasize the point that the reference tag is truncated to a 32-bit
value. To me, this is
Hi Bart,
> Since the return value of this function is 'u32', can the ' &
> 0x' be left out?
Absolutely, and I almost zapped it. However, I decided to leave it to
emphasize the point that the reference tag is truncated to a 32-bit
value. To me, this is more obvious than having to
The vendor_id attribute will allow for the modification of the T10
Vendor Identification string returned in inquiry responses. Its value
can be viewed and modified via the ConfigFS path at:
target/core/$backstore/$name/wwn/vendor_id
"LIO-ORG" remains the default value, which is set when the
Initialise the t10_wwn vendor, model and revision defaults when a
device is allocated instead of when it's enabled. This ensures that
custom vendor or model strings set prior to enablement are not later
overwritten with default values.
The TRANSPORT_FLAG_PASSTHROUGH conditional can be dropped for
In preparation for supporting user provided vendor strings, add an extra
byte to the vendor, model and revision arrays in struct t10_wwn. This
ensures that the full INQUIRY data can be carried in the arrays along
with a null-terminator.
Change a number of array readers and writers so that they
spc5r17.pdf specifies:
4.3.1 ASCII data field requirements
ASCII data fields shall contain only ASCII printable characters (i.e.,
code values 20h to 7Eh) and may be terminated with one or more ASCII
null (00h) characters.
ASCII data fields described as being left-aligned shall have any
This patch-set allows for the modification of the T10 Vendor
Identification string returned in the SCSI INQUIRY response, via the
target/core/$backstore/$name/wwn/vendor_id ConfigFS path.
Changes since v6:
- PATCH 2/5
+ fill pscsi inquiry data using proper sd->inquiry pointer names
+ dump
On 12/4/18 6:31 PM, Martin K. Petersen wrote:
Commit ddd0bc756983 ("block: move ref_tag calculation func to the block
layer") moved ref tag calculation from SCSI to a library function. However,
this change broke returning the correct ref tag for devices operating in
DIF mode since these do not
238.144.170.101106.119.122.156
¿ª ¸÷ Àà ÔöÖµ Ë°Õý ¹æ Õæ ƱQQ:2211261333 ÁÖ ³Ì£º13632225663(΢ÐÅͬºÅ)
Commit ddd0bc756983 ("block: move ref_tag calculation func to the block
layer") moved ref tag calculation from SCSI to a library function. However,
this change broke returning the correct ref tag for devices operating in
DIF mode since these do not have an associated block integrity profile.
This
UBSAN: Undefined behaviour in drivers/scsi/megaraid/megaraid_sas_fp.c:117:32
index 255 is out of range for type 'MR_LD_SPAN_MAP [1]'
This commit 51087a8617fe (megaraid_sas : Extended VD support) defined those,
struct MR_FW_RAID_MAP {
u8 ldTgtIdToLd[MAX_RAIDMAP_LOGICAL_DRIVES+\
On Tue, 2018-12-04 at 16:26 +0300, Roman Bolshakov wrote:
> wrt PATCH 5 in the series. Should we allow to set vendor_id for for
> pscsi?
I think we should allow that.
Bart.
On Tue, 4 Dec 2018 15:13:51 +0300, Roman Bolshakov wrote:
> > + /* Assume ASCII encoding. Strip any newline added from userspace. */
> > + BUILD_BUG_ON(sizeof(dev->t10_wwn.vendor) != INQUIRY_VENDOR_LEN + 1);
> > + strlcpy(dev->t10_wwn.vendor, strstrip(buf),
> > +
On Tue, 4 Dec 2018 16:26:59 +0300, Roman Bolshakov wrote:
> wrt PATCH 5 in the series. Should we allow to set vendor_id for for
> pscsi? target_transport_configure sets t10_wwn fields for pscsi, but but
> an attempt to set vendor_id will overwrite the value recieved from
> scsi_device.
I
On Tue, Dec 04, 2018 at 03:13:51PM +0300, Roman Bolshakov wrote:
> On Tue, Dec 04, 2018 at 11:12:36AM +0100, David Disseldorp wrote:
> > The vendor_id attribute will allow for the modification of the T10
> > Vendor Identification string returned in inquiry responses. Its value
> > can be viewed
On Tue, Dec 04, 2018 at 11:12:38AM +0100, David Disseldorp wrote:
> Initialise the t10_wwn vendor, model and revision defaults when a
> device is allocated instead of when it's enabled. This ensures that
> custom vendor or model strings set prior to enablement are not later
> overwritten with
On Tue, Dec 04, 2018 at 11:12:37AM +0100, David Disseldorp wrote:
> Use the value stored in t10_wwn.vendor, which defaults to "LIO-ORG", but
> can be reconfigured via the vendor_id ConfigFS attribute.
>
> Signed-off-by: David Disseldorp
> Reviewed-by: Bryant G. Ly
> Reviewed-by: Lee Duncan
>
On Tue, Dec 04, 2018 at 11:12:36AM +0100, David Disseldorp wrote:
> The vendor_id attribute will allow for the modification of the T10
> Vendor Identification string returned in inquiry responses. Its value
> can be viewed and modified via the ConfigFS path at:
>
On Sat, Dec 01, 2018 at 12:34:20AM +0100, David Disseldorp wrote:
> In preparation for supporting user provided vendor strings, add an extra
> byte to the vendor, model and revision arrays in struct t10_wwn. This
> ensures that the full INQUIRY data can be carried in the arrays along
> with a
In preparation for supporting user provided vendor strings, add an extra
byte to the vendor, model and revision arrays in struct t10_wwn. This
ensures that the full INQUIRY data can be carried in the arrays along
with a null-terminator.
Change a number of array readers and writers so that they
The vendor_id attribute will allow for the modification of the T10
Vendor Identification string returned in inquiry responses. Its value
can be viewed and modified via the ConfigFS path at:
target/core/$backstore/$name/wwn/vendor_id
"LIO-ORG" remains the default value, which is set when the
spc5r17.pdf specifies:
4.3.1 ASCII data field requirements
ASCII data fields shall contain only ASCII printable characters (i.e.,
code values 20h to 7Eh) and may be terminated with one or more ASCII
null (00h) characters.
ASCII data fields described as being left-aligned shall have any
Use the value stored in t10_wwn.vendor, which defaults to "LIO-ORG", but
can be reconfigured via the vendor_id ConfigFS attribute.
Signed-off-by: David Disseldorp
Reviewed-by: Bryant G. Ly
Reviewed-by: Lee Duncan
Reviewed-by: Hannes Reinecke
---
drivers/target/target_core_spc.c | 8 +---
Initialise the t10_wwn vendor, model and revision defaults when a
device is allocated instead of when it's enabled. This ensures that
custom vendor or model strings set prior to enablement are not later
overwritten with default values.
The TRANSPORT_FLAG_PASSTHROUGH conditional can be dropped for
This patch-set allows for the modification of the T10 Vendor
Identification string returned in the SCSI INQUIRY response, via the
target/core/$backstore/$name/wwn/vendor_id ConfigFS path.
Changes since v5:
- remove unnecessary TRANSPORT_FLAG_PASSTHROUGH conditional from t10_wwn
ID defaults
1 - 100 of 70914 matches
Mail list logo
