Re: [PATCH] qla2xxx: fixup incorrect usage of host_byte

2019-10-18 Thread Martin K. Petersen


Hannes,

> DRIVER_ERROR is a a driver byte setting, not a host byte.  The qla2xxx
> driver should rather return DID_ERROR here to be in line with the
> other drivers.

Applied to 5.4/scsi-fixes, thanks!

-- 
Martin K. Petersen  Oracle Linux Engineering


[PATCH] qla2xxx: fixup incorrect usage of host_byte

2019-10-18 Thread Hannes Reinecke
DRIVER_ERROR is a a driver byte setting, not a host byte.
The qla2xxx driver should rather return DID_ERROR here to be
in line with the other drivers.

Signed-off-by: Hannes Reinecke 
---
 drivers/scsi/qla2xxx/qla_bsg.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/scsi/qla2xxx/qla_bsg.c b/drivers/scsi/qla2xxx/qla_bsg.c
index 28d587a89ba6..99f0a1a08143 100644
--- a/drivers/scsi/qla2xxx/qla_bsg.c
+++ b/drivers/scsi/qla2xxx/qla_bsg.c
@@ -253,7 +253,7 @@ qla2x00_process_els(struct bsg_job *bsg_job)
srb_t *sp;
const char *type;
int req_sg_cnt, rsp_sg_cnt;
-   int rval =  (DRIVER_ERROR << 16);
+   int rval =  (DID_ERROR << 16);
uint16_t nextlid = 0;
 
if (bsg_request->msgcode == FC_BSG_RPT_ELS) {
@@ -432,7 +432,7 @@ qla2x00_process_ct(struct bsg_job *bsg_job)
struct Scsi_Host *host = fc_bsg_to_shost(bsg_job);
scsi_qla_host_t *vha = shost_priv(host);
struct qla_hw_data *ha = vha->hw;
-   int rval = (DRIVER_ERROR << 16);
+   int rval = (DID_ERROR << 16);
int req_sg_cnt, rsp_sg_cnt;
uint16_t loop_id;
struct fc_port *fcport;
@@ -1950,7 +1950,7 @@ qlafx00_mgmt_cmd(struct bsg_job *bsg_job)
struct Scsi_Host *host = fc_bsg_to_shost(bsg_job);
scsi_qla_host_t *vha = shost_priv(host);
struct qla_hw_data *ha = vha->hw;
-   int rval = (DRIVER_ERROR << 16);
+   int rval = (DID_ERROR << 16);
struct qla_mt_iocb_rqst_fx00 *piocb_rqst;
srb_t *sp;
int req_sg_cnt = 0, rsp_sg_cnt = 0;
-- 
2.16.4