Re: [PATCH 05/10] sd: don't use scsi_setup_blk_pc_cmnd for write same requests

2014-07-17 Thread Christoph Hellwig
Can I get a second review in addition to the one from Martin for this one? This is the last blocker for merging the series and pushing an updated branch out! -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord...@vger.kernel.org More

Re: [PATCH 05/10] sd: don't use scsi_setup_blk_pc_cmnd for write same requests

2014-07-13 Thread Martin K. Petersen
Christoph == Christoph Hellwig h...@lst.de writes: Christoph Simplify handling of write same requests by setting up the Christoph command directly instead of initializing request fields and Christoph then calling scsi_setup_blk_pc_cmnd to propagate the Christoph information into the command.

Re: [PATCH 05/10] sd: don't use scsi_setup_blk_pc_cmnd for write same requests

2014-07-11 Thread Hannes Reinecke
On 06/29/2014 03:34 PM, Christoph Hellwig wrote: Simplify handling of write same requests by setting up the command directly instead of initializing request fields and then calling scsi_setup_blk_pc_cmnd to propagate the information into the command. Signed-off-by: Christoph Hellwig h...@lst.de

Re: [PATCH 05/10] sd: don't use scsi_setup_blk_pc_cmnd for write same requests

2014-07-11 Thread Christoph Hellwig
-rq-__data_len = sdp-sector_size; +rq-__data_len = sdp-sector_size; +ret = scsi_init_io(cmd, GFP_ATOMIC); +rq-__data_len = nr_bytes; return ret; } Hmm? __data_len is the amount of data written _on the target_. Do we actually care about it? And if so, why didn't it

[PATCH 05/10] sd: don't use scsi_setup_blk_pc_cmnd for write same requests

2014-06-29 Thread Christoph Hellwig
Simplify handling of write same requests by setting up the command directly instead of initializing request fields and then calling scsi_setup_blk_pc_cmnd to propagate the information into the command. Signed-off-by: Christoph Hellwig h...@lst.de --- drivers/scsi/sd.c | 44