Re: [PATCH 5/6] hpsa: do not print errors for unsupported report luns format

2017-08-09 Thread Hannes Reinecke
On 08/09/2017 03:46 PM, Christoph Hellwig wrote: > I don't like the misnamed supported flag. Either we should always ignore > the errors, or key it off a specific flag for newer firmware. > Well, there is no such hardware flag; there are several features implemented across the board. Hence we

Re: [PATCH 5/6] hpsa: do not print errors for unsupported report luns format

2017-08-09 Thread Christoph Hellwig
I don't like the misnamed supported flag. Either we should always ignore the errors, or key it off a specific flag for newer firmware.

[PATCH 5/6] hpsa: do not print errors for unsupported report luns format

2017-08-08 Thread Hannes Reinecke
Older/Unsupported controllers might not support the 'extended' report luns format, but as they are unsupported we don't need to print out an error here. Signed-off-by: Hannes Reinecke --- drivers/scsi/hpsa.c | 21 - 1 file changed, 12 insertions(+), 9