Re: [PATCH v8 6/7] sd: Implement support for ZBC devices

2016-10-19 Thread Jeff Moyer
Shaun Tancheff writes: > On Tue, Oct 18, 2016 at 11:58 AM, Jeff Moyer wrote: >> Damien Le Moal writes: >> >>> + if (!is_power_of_2(zone_blocks)) { >>> + if (sdkp->first_scan) >>> +

Re: [PATCH v8 6/7] sd: Implement support for ZBC devices

2016-10-19 Thread Jeff Moyer
"Martin K. Petersen" writes: >> "Jeff" == Jeff Moyer writes: > > Jeff, > > Jeff> Are power of 2 zone sizes required by the standard? I see why > Jeff> you've done this, but I wonder if we're artificially limiting the > Jeff> implementation,

Re: [PATCH v8 6/7] sd: Implement support for ZBC devices

2016-10-18 Thread Martin K. Petersen
> "Damien" == Damien Le Moal writes: Damien> Implement ZBC support functions to setup zoned disks, both Damien> host-managed and host-aware models. Only zoned disks that Damien> satisfy the following conditions are supported: Damien> 1) All zones are the same size,

Re: [PATCH v8 6/7] sd: Implement support for ZBC devices

2016-10-18 Thread Martin K. Petersen
> "Jeff" == Jeff Moyer writes: Jeff, Jeff> Are power of 2 zone sizes required by the standard? I see why Jeff> you've done this, but I wonder if we're artificially limiting the Jeff> implementation, and whether there will be valid devices on the Jeff> market that simply

Re: [PATCH v8 6/7] sd: Implement support for ZBC devices

2016-10-18 Thread Shaun Tancheff
On Tue, Oct 18, 2016 at 11:58 AM, Jeff Moyer wrote: > Damien Le Moal writes: > >> + if (!is_power_of_2(zone_blocks)) { >> + if (sdkp->first_scan) >> + sd_printk(KERN_NOTICE, sdkp, >> +

Re: [PATCH v8 6/7] sd: Implement support for ZBC devices

2016-10-18 Thread Jeff Moyer
Damien Le Moal writes: > + if (!is_power_of_2(zone_blocks)) { > + if (sdkp->first_scan) > + sd_printk(KERN_NOTICE, sdkp, > + "Devices with non power of 2 zone " > + "size are

[PATCH v8 6/7] sd: Implement support for ZBC devices

2016-10-18 Thread Damien Le Moal
From: Hannes Reinecke Implement ZBC support functions to setup zoned disks, both host-managed and host-aware models. Only zoned disks that satisfy the following conditions are supported: 1) All zones are the same size, with the exception of an eventual last smaller runt zone. 2)