Re: [PATCH v2] scsi: mpt3sas: fix oops in error handlers after shutdown/unload

2018-02-15 Thread Mauricio Faria de Oliveira
Hi Sreekanth, On 02/15/2018 03:48 AM, Sreekanth Reddy wrote: During the shutdown time, I don't want the outstanding IOs to timeout due to disabling of interrupts and go the TM path. So I wanted to clear out all the Outstanding IOs in the shutdown path itself instead of clearing them in TM path.

RE: [PATCH v2] scsi: mpt3sas: fix oops in error handlers after shutdown/unload

2018-02-14 Thread Sreekanth Reddy
05 PM To: Sreekanth Reddy; linux-scsi@vger.kernel.org; bart.vanass...@wdc.com Cc: Sathya Prakash Veerichetty; Chaitra Basappa; Suganath Prabu Subramani; j...@linux.vnet.ibm.com; martin.peter...@oracle.com; dougm...@linux.vnet.ibm.com Subject: Re: [PATCH v2] scsi: mpt3sas: fix oops in error handlers

Re: [PATCH v2] scsi: mpt3sas: fix oops in error handlers after shutdown/unload

2018-02-14 Thread Mauricio Faria de Oliveira
Hi Sreenkanth, Thanks for reviewing. On 02/12/2018 04:28 AM, Sreekanth Reddy wrote: Instead of returning the scmd with DID_NO_CONNECT in TM path, can we wait for some time (10 seconds) in shutdown/unload path for the outstanding commands to complete and even then [if] the scmds are outstanding

RE: [PATCH v2] scsi: mpt3sas: fix oops in error handlers after shutdown/unload

2018-02-11 Thread Sreekanth Reddy
Mauricio, Instead of returning the scmd with DID_NO_CONNECT in TM path, can we wait for some time (10 seconds) in shutdown/unload path for the outstanding commands to complete and even then the scmds are outstanding then return all the outstanding scmds with DID_NO_CONNECT in the shutdown/unload p

Re: [PATCH v2] scsi: mpt3sas: fix oops in error handlers after shutdown/unload

2018-02-09 Thread Martin K. Petersen
> This patch adds checks for 'ioc->remove_host' in the SCSI error > handlers, so not to access pointers/resources potentially freed > in the PCI shutdown/module unload path. The error handlers may > be invoked after shutdown/unload, depending on other components. Broadcom folks: Please review!