Re: [PATCH] Avoid that ATA error handling hangs

2018-02-22 Thread Natanael Copa
On Thu, 22 Feb 2018 03:53:19 + Bart Van Assche wrote: > On Thu, 2018-02-22 at 02:23 +, Damien Le Moal wrote: > > On Wed, 2018-02-21 at 09:23 -0800, Bart Van Assche wrote: > > > [ ... ] > > This does not compile. > > This patch depends on another patch that

Re: [PATCH] Avoid that ATA error handling hangs

2018-02-21 Thread Damien Le Moal
On 2/22/18 14:08, Damien Le Moal wrote: > Bart, > > On 2/22/18 12:53, Bart Van Assche wrote: >> On Thu, 2018-02-22 at 02:23 +, Damien Le Moal wrote: >>> On Wed, 2018-02-21 at 09:23 -0800, Bart Van Assche wrote: [ ... ] >>> This does not compile. >> >> This patch depends on another

Re: [PATCH] Avoid that ATA error handling hangs

2018-02-21 Thread Damien Le Moal
Bart, On 2/22/18 12:53, Bart Van Assche wrote: > On Thu, 2018-02-22 at 02:23 +, Damien Le Moal wrote: >> On Wed, 2018-02-21 at 09:23 -0800, Bart Van Assche wrote: >>> [ ... ] >> This does not compile. > > This patch depends on another patch that is not yet in Martin's tree. See also >

Re: [PATCH] Avoid that ATA error handling hangs

2018-02-21 Thread Damien Le Moal
Bart, On 2/22/18 13:39, Bart Van Assche wrote: > On Thu, 2018-02-22 at 04:39 +, Bart Van Assche wrote: >> On Thu, 2018-02-22 at 04:19 +, Damien Le Moal wrote: >>> It looks OK to me, at least if CONFIG_DEBUG_OBJECTS_RCU_HEAD is turned >>> off since the init_rcu_head() and

Re: [PATCH] Avoid that ATA error handling hangs

2018-02-21 Thread Bart Van Assche
On Thu, 2018-02-22 at 04:39 +, Bart Van Assche wrote: > On Thu, 2018-02-22 at 04:19 +, Damien Le Moal wrote: > > It looks OK to me, at least if CONFIG_DEBUG_OBJECTS_RCU_HEAD is turned > > off since the init_rcu_head() and destroy_rcu_head() functions only care > > about that. > > > > With

Re: [PATCH] Avoid that ATA error handling hangs

2018-02-21 Thread Bart Van Assche
On Thu, 2018-02-22 at 04:19 +, Damien Le Moal wrote: > It looks OK to me, at least if CONFIG_DEBUG_OBJECTS_RCU_HEAD is turned > off since the init_rcu_head() and destroy_rcu_head() functions only care > about that. > > With rcu head debug turned on, I am not so sure. The object debug code >

Re: [PATCH] Avoid that ATA error handling hangs

2018-02-21 Thread Damien Le Moal
Martin, On 2/22/18 13:06, Martin K. Petersen wrote: > > Bart, > >> This patch depends on another patch that is not yet in Martin's >> tree. > > Nobody reviewed it. Same goes for your queuecommand tweak :/ > > I'm pretty picky about getting at least one other person than me to look > over core

Re: [PATCH] Avoid that ATA error handling hangs

2018-02-21 Thread Martin K. Petersen
Bart, > This patch depends on another patch that is not yet in Martin's > tree. Nobody reviewed it. Same goes for your queuecommand tweak :/ I'm pretty picky about getting at least one other person than me to look over core changes. Reviewers: Fame and fortune awaits! -- Martin K. Petersen

Re: [PATCH] Avoid that ATA error handling hangs

2018-02-21 Thread Bart Van Assche
On Thu, 2018-02-22 at 02:23 +, Damien Le Moal wrote: > On Wed, 2018-02-21 at 09:23 -0800, Bart Van Assche wrote: > > [ ... ] > This does not compile. This patch depends on another patch that is not yet in Martin's tree. See also https://marc.info/?l=linux-scsi=151675130615597. I should have

Re: [PATCH] Avoid that ATA error handling hangs

2018-02-21 Thread Damien Le Moal
Bart, On Wed, 2018-02-21 at 09:23 -0800, Bart Van Assche wrote: > Avoid that the recently introduced call_rcu() call in the SCSI core > causes the RCU core to complain about double call_rcu() calls. > > Reported-by: Natanael Copa > Reported-by: Damien Le Moal