Re: [PATCH] drivers: message: fusion: Simplify rounding

2014-08-19 Thread Christoph Hellwig
On Tue, Jul 01, 2014 at 02:56:20PM +0200, Rasmus Villemoes wrote: Rounding up to a multiple of 4 should be done using the ALIGN macro. As a bonus, this also makes the generated code smaller. In GetIocFacts(), sz is assigned to a few lines below without being read in the meantime, so it is ok

Re: [PATCH] drivers: message: fusion: Simplify rounding

2014-08-06 Thread Rasmus Villemoes
Joe Lawrence joe.lawre...@stratus.com writes: On Tue, 1 Jul 2014, Rasmus Villemoes wrote: Rounding up to a multiple of 4 should be done using the ALIGN macro. As a bonus, this also makes the generated code smaller. In GetIocFacts(), sz is assigned to a few lines below without being read

Re: [PATCH] drivers: message: fusion: Simplify rounding

2014-07-03 Thread Joe Lawrence
ALIGN is certainly more readable to me. Reviewed-by: Joe Lawrence joe.lawre...@stratus.com -- Joe On Tue, 1 Jul 2014, Rasmus Villemoes wrote: Rounding up to a multiple of 4 should be done using the ALIGN macro. As a bonus, this also makes the generated code smaller. In GetIocFacts(), sz