Re: [PATCH] scsi: eata: drop VLA in reorder()

2018-03-13 Thread Salvatore Mesoraca
2018-03-13 10:05 GMT+01:00 Christoph Hellwig : > On Mon, Mar 12, 2018 at 10:35:36PM -0400, Martin K. Petersen wrote: >> No objections to Salvatore's patch but I have a slight affinity for >> retiring unused code over patching it. So unless there are objections... > > Lets kill

Re: [PATCH] scsi: eata: drop VLA in reorder()

2018-03-13 Thread Christoph Hellwig
On Mon, Mar 12, 2018 at 10:35:36PM -0400, Martin K. Petersen wrote: > No objections to Salvatore's patch but I have a slight affinity for > retiring unused code over patching it. So unless there are objections... Lets kill it. And the not DMA capable eata_pio driver with it for good riddance. >

Re: [PATCH] scsi: eata: drop VLA in reorder()

2018-03-12 Thread Martin K. Petersen
Linus, > That said, I wonder if the solution to this particular driver is > "delete it". Because the hardware is truly ancient and nobody sane > would use it any more. I'm not aware of anybody actively using these anymore. They are mid-nineties vintage with an M68K processor onboard. I ran a

Re: [PATCH] scsi: eata: drop VLA in reorder()

2018-03-12 Thread Arthur Marsh
Linus Torvalds wrote on 13/03/18 05:15: On Sun, Mar 11, 2018 at 8:08 PM, Tobin C. Harding wrote: I think we are going to see a recurring theme here. MAX_MAILBOXES==64 so this patch adds 1536 bytes to the stack on a 64 bit machine or 768 bytes on a 32 bit machine.

Re: [PATCH] scsi: eata: drop VLA in reorder()

2018-03-12 Thread Linus Torvalds
On Sun, Mar 11, 2018 at 8:08 PM, Tobin C. Harding wrote: > > I think we are going to see a recurring theme here. MAX_MAILBOXES==64 > so this patch adds 1536 bytes to the stack on a 64 bit machine or 768 > bytes on a 32 bit machine. Yeah, that's a bit excessive. It probably

Re: [PATCH] scsi: eata: drop VLA in reorder()

2018-03-12 Thread Salvatore Mesoraca
2018-03-12 4:08 GMT+01:00 Tobin C. Harding : > Adding kernel newbies to CC because I pose a few noob questions :) > Adding Linus to CC because I quoted him. > > On Sun, Mar 11, 2018 at 10:06:58PM +0100, Salvatore Mesoraca wrote: >> n_ready will always be less than or equal to

Re: [PATCH] scsi: eata: drop VLA in reorder()

2018-03-12 Thread valdis . kletnieks
On Mon, 12 Mar 2018 14:08:34 +1100, "Tobin C. Harding" said: > removal patch that 768 was a lot of stack space. That comment did, > however say 'deep in some transfer call chain'. I don't know what a > 'transfer call chain' (the transfer bit) is but is there some heuristic > we can use to know

Re: [PATCH] scsi: eata: drop VLA in reorder()

2018-03-11 Thread Tobin C. Harding
Adding kernel newbies to CC because I pose a few noob questions :) Adding Linus to CC because I quoted him. On Sun, Mar 11, 2018 at 10:06:58PM +0100, Salvatore Mesoraca wrote: > n_ready will always be less than or equal to MAX_MAILBOXES. > So we avoid a VLA[1] and use fixed-length arrays instead.