Re: [PATCH 3/4] hpsa: remove coalescing settings for ioaccel2

[Martin K. Petersen]

> "Don" == Don Brace  writes:

Don,

Don> Wondering what has happened to this patch?

According to my notes, there were some concerns with the series that did
not get addressed. And only patch 3 actually got a reviewed-by tag. I
suggest you repost the series.

-- 
Martin K. Petersen  Oracle Linux Engineering
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

RE: [PATCH 3/4] hpsa: remove coalescing settings for ioaccel2

[Don Brace]

> -Original Message-
> From: Hannes Reinecke [mailto:h...@suse.de]
> Sent: Thursday, October 27, 2016 4:04 AM
> To: Don Brace <don.br...@microsemi.com>; j...@linux.vnet.ibm.com; John
> Hall <john.h...@microsemi.com>; Kevin Barnett
> <kevin.barn...@microsemi.com>; Mahesh Rajashekhara
> <mahesh.rajashekh...@microsemi.com>; h...@infradead.org; Scott Teel
> <scott.t...@microsemi.com>; Viswas G <viswa...@microsemi.com>; Justin
> Lindley <justin.lind...@microsemi.com>; Scott Benesh
> <scott.ben...@microsemi.com>; elli...@hpe.com; posw...@suse.com
> Cc: linux-scsi@vger.kernel.org
> Subject: Re: [PATCH 3/4] hpsa: remove coalescing settings for ioaccel2
> 
> EXTERNAL EMAIL
> 
> 
> On 10/27/2016 12:21 AM, Don Brace wrote:
> > - Setting coalescing has a significant negative
> >   impact on low queue-depth performance.
> > - Does not help high queue-depth performance.
> >
> > Reviewed-by: Scott Benesh <scott.ben...@microsemi.com>
> > Reviewed-by: Scott Teel <scott.t...@microsemi.com>
> > Reviewed-by: Kevin Barnett <kevin.barn...@microsemi.com>
> > Signed-off-by: Don Brace <don.br...@microsemi.com>
> > ---
> >  drivers/scsi/hpsa.c |8 ++--
> >  1 file changed, 2 insertions(+), 6 deletions(-)
> >
> > diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c
> > index 9fb739c..810c300 100644
> > --- a/drivers/scsi/hpsa.c
> > +++ b/drivers/scsi/hpsa.c
> > @@ -9277,13 +9277,9 @@ static int hpsa_enter_performant_mode(struct
> ctlr_info *h, u32 trans_support)
> >   access = SA5_ioaccel_mode1_access;
> >   writel(10, >cfgtable->HostWrite.CoalIntDelay);
> >   writel(4, >cfgtable->HostWrite.CoalIntCount);
> > - } else {
> > - if (trans_support & CFGTBL_Trans_io_accel2) {
> > + } else
> > + if (trans_support & CFGTBL_Trans_io_accel2)
> >   access = SA5_ioaccel_mode2_access;
> > - writel(10, >cfgtable->HostWrite.CoalIntDelay);
> > - writel(4, >cfgtable->HostWrite.CoalIntCount);
> > - }
> > - }
> >   writel(CFGTBL_ChangeReq, h->vaddr + SA5_DOORBELL);
> >   if (hpsa_wait_for_mode_change_ack(h)) {
> >   dev_err(>pdev->dev,
> >
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
> > the body of a message to majord...@vger.kernel.org
> > More majordomo info at  http://vger.kernel.org/majordomo-info.html
> >
> Reviewed-by: Hannes Reinecke <h...@suse.com>
> 
> Cheers,
> 
> Hannes
> --
> Dr. Hannes ReineckeTeamlead Storage & Networking
> h...@suse.de   +49 911 74053 688
> SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
> GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton
> HRB 21284 (AG Nürnberg)

Wondering what has happened to this patch?

Thanks,
Don Brace

ESC - Smart Storage
Microsemi Corporation

Re: [PATCH 3/4] hpsa: remove coalescing settings for ioaccel2

[Hannes Reinecke]

On 10/27/2016 12:21 AM, Don Brace wrote:
> - Setting coalescing has a significant negative
>   impact on low queue-depth performance.
> - Does not help high queue-depth performance.
> 
> Reviewed-by: Scott Benesh 
> Reviewed-by: Scott Teel 
> Reviewed-by: Kevin Barnett 
> Signed-off-by: Don Brace 
> ---
>  drivers/scsi/hpsa.c |8 ++--
>  1 file changed, 2 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c
> index 9fb739c..810c300 100644
> --- a/drivers/scsi/hpsa.c
> +++ b/drivers/scsi/hpsa.c
> @@ -9277,13 +9277,9 @@ static int hpsa_enter_performant_mode(struct ctlr_info 
> *h, u32 trans_support)
>   access = SA5_ioaccel_mode1_access;
>   writel(10, >cfgtable->HostWrite.CoalIntDelay);
>   writel(4, >cfgtable->HostWrite.CoalIntCount);
> - } else {
> - if (trans_support & CFGTBL_Trans_io_accel2) {
> + } else
> + if (trans_support & CFGTBL_Trans_io_accel2)
>   access = SA5_ioaccel_mode2_access;
> - writel(10, >cfgtable->HostWrite.CoalIntDelay);
> - writel(4, >cfgtable->HostWrite.CoalIntCount);
> - }
> - }
>   writel(CFGTBL_ChangeReq, h->vaddr + SA5_DOORBELL);
>   if (hpsa_wait_for_mode_change_ack(h)) {
>   dev_err(>pdev->dev,
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
> the body of a message to majord...@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 
Reviewed-by: Hannes Reinecke 

Cheers,

Hannes
-- 
Dr. Hannes ReineckeTeamlead Storage & Networking
h...@suse.de   +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton
HRB 21284 (AG Nürnberg)
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html