Re: [PATCH 4/7] megaraid_sas: Send SYNCHRONIZE_CACHE command to firmware

2016-10-26 Thread Martin K. Petersen
> "ching" == 黃清隆 writes: ching, ching> Yes. Passing SYNCHRONIZE_CACHE command to firmware is safe for ching> all Areca Raid controllers, even the oldest. I applied your patch to 4.9/scsi-fixes. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe

Re: [PATCH 4/7] megaraid_sas: Send SYNCHRONIZE_CACHE command to firmware

2016-10-24 Thread Martin K. Petersen
> "Tomas" == Tomas Henzl writes: >> SCSI command checking in queuecommand function of arcmsr can be >> removed safely. Now driver can pass all scsi command to controller >> firmware. Tomas> Is this (passing the SYNCHRONIZE_CACHE command to firmware) safe Tomas> for all

Re: [PATCH 4/7] megaraid_sas: Send SYNCHRONIZE_CACHE command to firmware

2016-10-21 Thread Tomas Henzl
er; Hannes Reinecke; Sumit >> Saxena; linux-scsi@vger.kernel.org; martin.peter...@oracle.com; Christoph >> Hellwig; Martin K. Petersen; Jeff Moyer; Gris Ge; Ewan Milne; Jens Axboe; >> Raghava Aditya Renukunta >> Subject: Re: [PATCH 4/7] megaraid_sas: Send SYNCHRONIZE_CACHE >&g

RE: [PATCH 4/7] megaraid_sas: Send SYNCHRONIZE_CACHE command to firmware

2016-10-19 Thread Raghava Aditya Renukunta
cle.com; Christoph > Hellwig; Martin K. Petersen; Jeff Moyer; Gris Ge; Ewan Milne; Jens Axboe; > Raghava Aditya Renukunta > Subject: Re: [PATCH 4/7] megaraid_sas: Send SYNCHRONIZE_CACHE > command to firmware > > EXTERNAL EMAIL > > > On 19.10.2016 11:50, Ching Hu

Re: [PATCH 4/7] megaraid_sas: Send SYNCHRONIZE_CACHE command to firmware

2016-10-19 Thread Tomas Henzl
PM >>>>> To: Ric Wheeler; Hannes Reinecke; Sumit Saxena; >>>>> linux-scsi@vger.kernel.org >>>>> Cc: martin.peter...@oracle.com; the...@redhat.com; >>>>> kashyap.de...@broadcom.com; Christoph Hellwig; Martin K. Petersen; >>>>>

Re: [PATCH 4/7] megaraid_sas: Send SYNCHRONIZE_CACHE command to firmware

2016-10-19 Thread Ching Huang
From: James Bottomley [mailto:j...@linux.vnet.ibm.com] > >>> Sent: Monday, October 17, 2016 10:50 PM > >>> To: Ric Wheeler; Hannes Reinecke; Sumit Saxena; > >>> linux-scsi@vger.kernel.org > >>> Cc: martin.peter...@oracle.com; the...@redhat.com; > &g

RE: [PATCH 4/7] megaraid_sas: Send SYNCHRONIZE_CACHE command to firmware

2016-10-18 Thread Sumit Saxena
h Hellwig; >Martin >K. Petersen; Jeff Moyer; Gris Ge; Ewan Milne; Jens Axboe >Subject: Re: [PATCH 4/7] megaraid_sas: Send SYNCHRONIZE_CACHE command to >firmware > >On Mon, 2016-10-17 at 23:06 +0530, Kashyap Desai wrote: >> > -Original Message- >> >

Re: [PATCH 4/7] megaraid_sas: Send SYNCHRONIZE_CACHE command to firmware

2016-10-18 Thread Tomas Henzl
m; Christoph Hellwig; Martin K. Petersen; >>> Jeff >>> Moyer; Gris Ge; Ewan Milne; Jens Axboe >>> Subject: Re: [PATCH 4/7] megaraid_sas: Send SYNCHRONIZE_CACHE >>> command >>> to firmware >>> >>> On Mon, 2016-10-17 at 12:27 -0400,

RE: [PATCH 4/7] megaraid_sas: Send SYNCHRONIZE_CACHE command to firmware

2016-10-18 Thread Sumit Saxena
er 17, 2016 6:44 PM >>>> To: Sumit Saxena; linux-scsi@vger.kernel.org >>>> Cc: martin.peter...@oracle.com; j...@linux.vnet.ibm.com; >>>> kashyap.de...@broadcom.com >>>> Subject: Re: [PATCH 4/7] megaraid_sas: Send SYNCHRONIZE_CACHE >>>> c

Re: [PATCH 4/7] megaraid_sas: Send SYNCHRONIZE_CACHE command to firmware

2016-10-18 Thread Ric Wheeler
; kashyap.de...@broadcom.com Subject: Re: [PATCH 4/7] megaraid_sas: Send SYNCHRONIZE_CACHE command to firmware On 17.10.2016 12:24, Sumit Saxena wrote: megaraid_sas driver returns SYNCHRONIZE_CACHE command back to SCSI layer without sending it to firmware as firmware takes care of flushing cache

Re: [PATCH 4/7] megaraid_sas: Send SYNCHRONIZE_CACHE command to firmware

2016-10-17 Thread James Bottomley
ernel.org > > Cc: martin.peter...@oracle.com; the...@redhat.com; > > kashyap.de...@broadcom.com; Christoph Hellwig; Martin K. Petersen; > > Jeff > > Moyer; Gris Ge; Ewan Milne; Jens Axboe > > Subject: Re: [PATCH 4/7] megaraid_sas: Send SYNCHRONIZE_CACHE > > comma

RE: [PATCH 4/7] megaraid_sas: Send SYNCHRONIZE_CACHE command to firmware

2016-10-17 Thread Kashyap Desai
com.com; Christoph Hellwig; Martin K. Petersen; Jeff > Moyer; Gris Ge; Ewan Milne; Jens Axboe > Subject: Re: [PATCH 4/7] megaraid_sas: Send SYNCHRONIZE_CACHE command > to firmware > > On Mon, 2016-10-17 at 12:27 -0400, Ric Wheeler wrote: > > On 10/17/2016 12:20 PM, James Bottomle

Re: [PATCH 4/7] megaraid_sas: Send SYNCHRONIZE_CACHE command to firmware

2016-10-17 Thread Ric Wheeler
On 10/17/2016 01:19 PM, James Bottomley wrote: That's not what I get from the change log. What it says to me is > >that the caches are currently firmware managed. Barring firmware > >bugs, that means that we currently don't have any integrity issues. > >Your understanding (or the change log)

Re: [PATCH 4/7] megaraid_sas: Send SYNCHRONIZE_CACHE command to firmware

2016-10-17 Thread James Bottomley
On Mon, 2016-10-17 at 12:27 -0400, Ric Wheeler wrote: > On 10/17/2016 12:20 PM, James Bottomley wrote: > > On Mon, 2016-10-17 at 09:01 -0400, Ric Wheeler wrote: > > > On 10/17/2016 07:34 AM, Hannes Reinecke wrote: > > > > On 10/17/2016 12:24 PM, Sumit Saxena wrote: > > > > > megaraid_sas driver

Re: [PATCH 4/7] megaraid_sas: Send SYNCHRONIZE_CACHE command to firmware

2016-10-17 Thread Ric Wheeler
On 10/17/2016 12:20 PM, James Bottomley wrote: We really need to have some ways to validate that our IO stack is >properly and safely configured. > >I would love to see a couple of things: > >* having T10 & T13 report the existence of a volatile write cache - >this is different than WCE set,

Re: [PATCH 4/7] megaraid_sas: Send SYNCHRONIZE_CACHE command to firmware

2016-10-17 Thread Ric Wheeler
On 10/17/2016 12:20 PM, James Bottomley wrote: On Mon, 2016-10-17 at 09:01 -0400, Ric Wheeler wrote: On 10/17/2016 07:34 AM, Hannes Reinecke wrote: On 10/17/2016 12:24 PM, Sumit Saxena wrote: megaraid_sas driver returns SYNCHRONIZE_CACHE command back to SCSI layer without sending it to

Re: [PATCH 4/7] megaraid_sas: Send SYNCHRONIZE_CACHE command to firmware

2016-10-17 Thread Ewan D. Milne
On Mon, 2016-10-17 at 12:08 -0400, Ric Wheeler wrote: > On 10/17/2016 11:55 AM, Christoph Hellwig wrote: > > On Mon, Oct 17, 2016 at 09:01:29AM -0400, Ric Wheeler wrote: > >> This must go in - without this fix, there is no data integrity for any > >> file system. > > megaraid always had odd ideas

Re: [PATCH 4/7] megaraid_sas: Send SYNCHRONIZE_CACHE command to firmware

2016-10-17 Thread James Bottomley
On Mon, 2016-10-17 at 09:01 -0400, Ric Wheeler wrote: > On 10/17/2016 07:34 AM, Hannes Reinecke wrote: > > On 10/17/2016 12:24 PM, Sumit Saxena wrote: > > > megaraid_sas driver returns SYNCHRONIZE_CACHE command back to > > > SCSI layer without sending it to firmware as firmware takes care > > >

Re: [PATCH 4/7] megaraid_sas: Send SYNCHRONIZE_CACHE command to firmware

2016-10-17 Thread Ric Wheeler
On 10/17/2016 11:55 AM, Christoph Hellwig wrote: On Mon, Oct 17, 2016 at 09:01:29AM -0400, Ric Wheeler wrote: This must go in - without this fix, there is no data integrity for any file system. megaraid always had odd ideas on cache flushing, and this might be a opportunity to write down all

Re: [PATCH 4/7] megaraid_sas: Send SYNCHRONIZE_CACHE command to firmware

2016-10-17 Thread Christoph Hellwig
On Mon, Oct 17, 2016 at 09:01:29AM -0400, Ric Wheeler wrote: > This must go in - without this fix, there is no data integrity for any file > system. megaraid always had odd ideas on cache flushing, and this might be a opportunity to write down all the assumptions and document them. > In effect,

RE: [PATCH 4/7] megaraid_sas: Send SYNCHRONIZE_CACHE command to firmware

2016-10-17 Thread Sumit Saxena
org >>> Cc: martin.peter...@oracle.com; j...@linux.vnet.ibm.com; >>> kashyap.de...@broadcom.com >>> Subject: Re: [PATCH 4/7] megaraid_sas: Send SYNCHRONIZE_CACHE >command >>> to firmware >>> >>> On 17.10.2016 12:24, Sumit Saxena wrote: >>>

Re: [PATCH 4/7] megaraid_sas: Send SYNCHRONIZE_CACHE command to firmware

2016-10-17 Thread Tomas Henzl
>> kashyap.de...@broadcom.com >> Subject: Re: [PATCH 4/7] megaraid_sas: Send SYNCHRONIZE_CACHE command to >> firmware >> >> On 17.10.2016 12:24, Sumit Saxena wrote: >>> megaraid_sas driver returns SYNCHRONIZE_CACHE command back to SCSI >>> l

RE: [PATCH 4/7] megaraid_sas: Send SYNCHRONIZE_CACHE command to firmware

2016-10-17 Thread Sumit Saxena
com.com; Christoph Hellwig; Martin K. Petersen; Jeff >Moyer; Gris Ge; Ewan Milne; Jens Axboe >Subject: Re: [PATCH 4/7] megaraid_sas: Send SYNCHRONIZE_CACHE command to >firmware > >On 10/17/2016 07:34 AM, Hannes Reinecke wrote: >> On 10/17/2016 12:24 PM, Sumit Saxena

RE: [PATCH 4/7] megaraid_sas: Send SYNCHRONIZE_CACHE command to firmware

2016-10-17 Thread Sumit Saxena
>-Original Message- >From: Tomas Henzl [mailto:the...@redhat.com] >Sent: Monday, October 17, 2016 6:44 PM >To: Sumit Saxena; linux-scsi@vger.kernel.org >Cc: martin.peter...@oracle.com; j...@linux.vnet.ibm.com; >kashyap.de...@broadcom.com >Subject: Re: [PATCH 4/

Re: [PATCH 4/7] megaraid_sas: Send SYNCHRONIZE_CACHE command to firmware

2016-10-17 Thread Tomas Henzl
On 17.10.2016 12:24, Sumit Saxena wrote: > megaraid_sas driver returns SYNCHRONIZE_CACHE command back to SCSI layer > without sending it to firmware as firmware takes care of flushing cache. > This patch will change the driver behavior wrt SYNCHRONIZE_CACHE handling. > If underlying firmware has

Re: [PATCH 4/7] megaraid_sas: Send SYNCHRONIZE_CACHE command to firmware

2016-10-17 Thread Ric Wheeler
On 10/17/2016 07:34 AM, Hannes Reinecke wrote: On 10/17/2016 12:24 PM, Sumit Saxena wrote: megaraid_sas driver returns SYNCHRONIZE_CACHE command back to SCSI layer without sending it to firmware as firmware takes care of flushing cache. This patch will change the driver behavior wrt

RE: [PATCH 4/7] megaraid_sas: Send SYNCHRONIZE_CACHE command to firmware

2016-10-17 Thread Sumit Saxena
bject: Re: [PATCH 4/7] megaraid_sas: Send SYNCHRONIZE_CACHE command to >firmware > >On 10/17/2016 12:24 PM, Sumit Saxena wrote: >> megaraid_sas driver returns SYNCHRONIZE_CACHE command back to SCSI >> layer without sending it to firmware as firmware takes care of flushing cache. >>

Re: [PATCH 4/7] megaraid_sas: Send SYNCHRONIZE_CACHE command to firmware

2016-10-17 Thread Hannes Reinecke
On 10/17/2016 12:24 PM, Sumit Saxena wrote: > megaraid_sas driver returns SYNCHRONIZE_CACHE command back to SCSI layer > without sending it to firmware as firmware takes care of flushing cache. > This patch will change the driver behavior wrt SYNCHRONIZE_CACHE handling. > If underlying firmware