Re: [PATCH V4 10/16] block: mq-deadline: Add zoned block device data

2017-09-24 Thread Damien Le Moal
On 9/24/17 17:14, Christoph Hellwig wrote: >> + >> +struct request_queue *q; > > Do you really need the queue backpointer? At least as far as this > patch is concerned we could just pass the queue on to > deadline_enable_zones_wlock and be fine. And in general we should > always passing the

Re: [PATCH V4 10/16] block: mq-deadline: Add zoned block device data

2017-09-24 Thread Christoph Hellwig
> + > + struct request_queue *q; Do you really need the queue backpointer? At least as far as this patch is concerned we could just pass the queue on to deadline_enable_zones_wlock and be fine. And in general we should always passing the q, as we can trivial go from queue to deadline_data