Re: [PATCH v3] m68k/amiga - Amiga Zorro NCR53C9x boards: new zorro_esp.c

On Fri, 16 Mar 2018, Michael Schmitz wrote: > Hi Finn, Geert, > > In the interest of making minimal changes between the Mac and Amiga > versions, I'd leave the macros as they are, and add a comment to the > macro definitions stating that both addr and fifo are local-scope > variables in the

Re: [PATCH v3] m68k/amiga - Amiga Zorro NCR53C9x boards: new zorro_esp.c

Hi Michael, On Fri, Mar 16, 2018 at 8:26 AM, Michael Schmitz wrote: > In the interest of making minimal changes between the Mac and Amiga > versions, I'd leave the macros as they are, and add a comment to the > macro definitions stating that both addr and fifo are

Re: [PATCH v3] m68k/amiga - Amiga Zorro NCR53C9x boards: new zorro_esp.c

Hi Finn, Geert, In the interest of making minimal changes between the Mac and Amiga versions, I'd leave the macros as they are, and add a comment to the macro definitions stating that both addr and fifo are local-scope variables in the only scope the macro is used in, to address reviewer's

Re: [PATCH v3] m68k/amiga - Amiga Zorro NCR53C9x boards: new zorro_esp.c

On Wed, 14 Mar 2018, Michael Schmitz wrote: > > > > Please pass "addr" and "fifo" as macro parameters, too, so it's easier > > for the reviewer to notice they are used. > > Yes, I can do that (meaning Finn would need to make the same change to > keep our versions in sync). Personally, I

Re: [PATCH v3] m68k/amiga - Amiga Zorro NCR53C9x boards: new zorro_esp.c

Hi Geert, Am 14.03.2018 um 21:30 schrieb Geert Uytterhoeven: > Hi Michael, > > On Wed, Mar 14, 2018 at 9:23 AM, Michael Schmitz wrote: >> thanks for the review - largely uncontroversial except for the volatile... > > The presence of volatile in drivers is always

Re: [PATCH v3] m68k/amiga - Amiga Zorro NCR53C9x boards: new zorro_esp.c

Hi Tuomas, oddly enough, it does. How embarrassing... Hope I got the names of the boards right this time. Thanks for spotting this! Cheers, Michael Am 14.03.2018 um 20:13 schrieb Vainikka Tuomas: > The config description lists 53c700 devices, not ESP devices? > > -Tuomas >

Re: [PATCH v3] m68k/amiga - Amiga Zorro NCR53C9x boards: new zorro_esp.c

Hi Michael, On Wed, Mar 14, 2018 at 9:23 AM, Michael Schmitz wrote: > thanks for the review - largely uncontroversial except for the volatile... The presence of volatile in drivers is always considered controversial ;-) > Am 14.03.2018 um 20:49 schrieb Geert Uytterhoeven:

Re: [PATCH v3] m68k/amiga - Amiga Zorro NCR53C9x boards: new zorro_esp.c

Hi Geert, thanks for the review - largely uncontroversial except for the volatile... Am 14.03.2018 um 20:49 schrieb Geert Uytterhoeven: >> +/* Blizzard 1230 DMA interface */ >> + >> +struct blz1230_dma_registers { >> + volatile unsigned char dma_addr;/* DMA address [0x]

Re: [PATCH v3] m68k/amiga - Amiga Zorro NCR53C9x boards: new zorro_esp.c

Hi Michael, On Mon, Mar 12, 2018 at 8:26 AM, Michael Schmitz wrote: > From: Michael Schmitz > > New combined SCSI driver for all ESP based Zorro SCSI boards for > m68k Amiga. > > Code largely based on board specific parts of the old drivers (blz1230.c,

Re: [PATCH v3] m68k/amiga - Amiga Zorro NCR53C9x boards: new zorro_esp.c

The config description lists 53c700 devices, not ESP devices? -Tuomas From: linux-m68k-ow...@vger.kernel.org on behalf of Michael Schmitz Sent: 12 March 2018 09:26:40 To: linux-scsi@vger.kernel.org

Re: [PATCH v3] m68k/amiga - Amiga Zorro NCR53C9x boards: new zorro_esp.c

> > I forgot to add your Reviewed-by tag - will do that for the next > version, OK? Sure. Geert's tag may be harder to bag though :-) --

Re: [PATCH v3] m68k/amiga - Amiga Zorro NCR53C9x boards: new zorro_esp.c

Hi Finn, Am 12.03.2018 um 22:04 schrieb Finn Thain: >> +if (addr == esp->command_block_dma) >> +addr = (u32) esp->command_block; > > Since you've removed the alternative branch and phys_to_virt(), I suggest > you do this at function invocation... (see below) Keeps it together

Re: [PATCH v3] m68k/amiga - Amiga Zorro NCR53C9x boards: new zorro_esp.c

On Mon, 12 Mar 2018, Michael Schmitz wrote: > diff --git a/drivers/scsi/zorro_esp.c b/drivers/scsi/zorro_esp.c > new file mode 100644 > index 000..47053d1 > --- /dev/null > +++ b/drivers/scsi/zorro_esp.c > @@ -0,0 +1,1136 @@ > +// SPDX-License-Identifier: GPL-2.0 > +/* zorro_esp.c: ESP