Re: [PATCH v5 02/11] scsi: ufs: sysfs: device descriptor

[Jaegeuk Kim]

On 02/12, Stanislav Nijnikov wrote:
> 
> 
> > -Original Message-
> > From: Jaegeuk Kim [mailto:jaeg...@kernel.org]
> > Sent: Monday, February 12, 2018 3:08 AM
> > To: Stanislav Nijnikov <stanislav.nijni...@wdc.com>
> > Cc: linux-scsi@vger.kernel.org; linux-ker...@vger.kernel.org;
> > gre...@linuxfoundation.org; Alex Lemberg <alex.lemb...@wdc.com>
> > Subject: Re: [PATCH v5 02/11] scsi: ufs: sysfs: device descriptor
> > 
> > On 02/06, Stanislav Nijnikov wrote:
> > > This patch introduces a sysfs group entry for the UFS device
> > > descriptor parameters. The group adds "device_descriptor" folder under
> > > the UFS driver sysfs entry (/sys/bus/platform/drivers/ufshcd/*). The
> > > parameters are shown as hexadecimal numbers. The full information
> > > about the parameters could be found at UFS specifications 2.1.
> > >
> > > Signed-off-by: Stanislav Nijnikov <stanislav.nijni...@wdc.com>
> > > ---
> > >  Documentation/ABI/testing/sysfs-driver-ufs | 223
> > +
> > >  drivers/scsi/ufs/ufs-sysfs.c   | 116 +++
> > >  drivers/scsi/ufs/ufs.h |   8 ++
> > >  drivers/scsi/ufs/ufshcd.c  |  12 +-
> > >  drivers/scsi/ufs/ufshcd.h  |   6 +
> > >  5 files changed, 359 insertions(+), 6 deletions(-)  create mode
> > > 100644 Documentation/ABI/testing/sysfs-driver-ufs
> > >
> > > diff --git a/Documentation/ABI/testing/sysfs-driver-ufs
> > > b/Documentation/ABI/testing/sysfs-driver-ufs
> > > new file mode 100644
> > > index 000..8da7b84
> > > --- /dev/null
> > > +++ b/Documentation/ABI/testing/sysfs-driver-ufs
> > > @@ -0,0 +1,223 @@
> > > +What:
> > /sys/bus/platform/drivers/ufshcd/*/device_descriptor/device_type
> > > +Date:February 2018
> > > +Contact: Stanislav Nijnikov <stanislav.nijni...@wdc.com>
> > > +Description: This file shows the device type. This is one of the UFS
> > > + device descriptor parameters. The full information about
> > > + the descriptor could be found at UFS specifications 2.1.
> > > + The file is read only.
> > > +
> > > +What:
> > /sys/bus/platform/drivers/ufshcd/*/device_descriptor/device_class
> > > +Date:February 2018
> > > +Contact: Stanislav Nijnikov <stanislav.nijni...@wdc.com>
> > > +Description: This file shows the device class. This is one of the UFS
> > > + device descriptor parameters. The full information about
> > > + the descriptor could be found at UFS specifications 2.1.
> > > + The file is read only.
> > > +
> > > +What:
> > /sys/bus/platform/drivers/ufshcd/*/device_descriptor/device_sub_
> > class
> > > +Date:February 2018
> > > +Contact: Stanislav Nijnikov <stanislav.nijni...@wdc.com>
> > > +Description: This file shows the UFS storage subclass. This is one of
> > > + the UFS device descriptor parameters. The full information
> > > + about the descriptor could be found at UFS specifications 2.1.
> > > + The file is read only.
> > > +
> > > +What:
> > /sys/bus/platform/drivers/ufshcd/*/device_descriptor/protocol
> > > +Date:February 2018
> > > +Contact: Stanislav Nijnikov <stanislav.nijni...@wdc.com>
> > > +Description: This file shows the protocol supported by an UFS device.
> > > + This is one of the UFS device descriptor parameters.
> > > + The full information about the descriptor could be found
> > > + at UFS specifications 2.1.
> > > + The file is read only.
> > > +
> > > +What:
> > /sys/bus/platform/drivers/ufshcd/*/device_descriptor/number_of_
> > luns
> > > +Date:February 2018
> > > +Contact: Stanislav Nijnikov <stanislav.nijni...@wdc.com>
> > > +Description: This file shows number of logical units. This is one of
> > > + the UFS device descriptor parameters. The full information
> > > + about the descriptor could be found at UFS specifications 2.1.
> > > + The file is read only.
> > > +
> > > +What:
> > /sys/bus/platform/drivers/ufshcd/*/device_descriptor/number_of_
> > wluns
> > > +Date:February 2018
> > > +Contact: Stanislav Nijnikov <stani

RE: [PATCH v5 02/11] scsi: ufs: sysfs: device descriptor

[Stanislav Nijnikov]

> -Original Message-
> From: Jaegeuk Kim [mailto:jaeg...@kernel.org]
> Sent: Monday, February 12, 2018 3:08 AM
> To: Stanislav Nijnikov <stanislav.nijni...@wdc.com>
> Cc: linux-scsi@vger.kernel.org; linux-ker...@vger.kernel.org;
> gre...@linuxfoundation.org; Alex Lemberg <alex.lemb...@wdc.com>
> Subject: Re: [PATCH v5 02/11] scsi: ufs: sysfs: device descriptor
> 
> On 02/06, Stanislav Nijnikov wrote:
> > This patch introduces a sysfs group entry for the UFS device
> > descriptor parameters. The group adds "device_descriptor" folder under
> > the UFS driver sysfs entry (/sys/bus/platform/drivers/ufshcd/*). The
> > parameters are shown as hexadecimal numbers. The full information
> > about the parameters could be found at UFS specifications 2.1.
> >
> > Signed-off-by: Stanislav Nijnikov <stanislav.nijni...@wdc.com>
> > ---
> >  Documentation/ABI/testing/sysfs-driver-ufs | 223
> +
> >  drivers/scsi/ufs/ufs-sysfs.c   | 116 +++
> >  drivers/scsi/ufs/ufs.h |   8 ++
> >  drivers/scsi/ufs/ufshcd.c  |  12 +-
> >  drivers/scsi/ufs/ufshcd.h  |   6 +
> >  5 files changed, 359 insertions(+), 6 deletions(-)  create mode
> > 100644 Documentation/ABI/testing/sysfs-driver-ufs
> >
> > diff --git a/Documentation/ABI/testing/sysfs-driver-ufs
> > b/Documentation/ABI/testing/sysfs-driver-ufs
> > new file mode 100644
> > index 000..8da7b84
> > --- /dev/null
> > +++ b/Documentation/ABI/testing/sysfs-driver-ufs
> > @@ -0,0 +1,223 @@
> > +What:
>   /sys/bus/platform/drivers/ufshcd/*/device_descriptor/device_type
> > +Date:  February 2018
> > +Contact:   Stanislav Nijnikov <stanislav.nijni...@wdc.com>
> > +Description:   This file shows the device type. This is one of the UFS
> > +   device descriptor parameters. The full information about
> > +   the descriptor could be found at UFS specifications 2.1.
> > +   The file is read only.
> > +
> > +What:
>   /sys/bus/platform/drivers/ufshcd/*/device_descriptor/device_class
> > +Date:  February 2018
> > +Contact:   Stanislav Nijnikov <stanislav.nijni...@wdc.com>
> > +Description:   This file shows the device class. This is one of the UFS
> > +   device descriptor parameters. The full information about
> > +   the descriptor could be found at UFS specifications 2.1.
> > +   The file is read only.
> > +
> > +What:
>   /sys/bus/platform/drivers/ufshcd/*/device_descriptor/device_sub_
> class
> > +Date:  February 2018
> > +Contact:   Stanislav Nijnikov <stanislav.nijni...@wdc.com>
> > +Description:   This file shows the UFS storage subclass. This is one of
> > +   the UFS device descriptor parameters. The full information
> > +   about the descriptor could be found at UFS specifications 2.1.
> > +   The file is read only.
> > +
> > +What:
>   /sys/bus/platform/drivers/ufshcd/*/device_descriptor/protocol
> > +Date:  February 2018
> > +Contact:   Stanislav Nijnikov <stanislav.nijni...@wdc.com>
> > +Description:   This file shows the protocol supported by an UFS device.
> > +   This is one of the UFS device descriptor parameters.
> > +   The full information about the descriptor could be found
> > +   at UFS specifications 2.1.
> > +   The file is read only.
> > +
> > +What:
>   /sys/bus/platform/drivers/ufshcd/*/device_descriptor/number_of_
> luns
> > +Date:  February 2018
> > +Contact:   Stanislav Nijnikov <stanislav.nijni...@wdc.com>
> > +Description:   This file shows number of logical units. This is one of
> > +   the UFS device descriptor parameters. The full information
> > +   about the descriptor could be found at UFS specifications 2.1.
> > +   The file is read only.
> > +
> > +What:
>   /sys/bus/platform/drivers/ufshcd/*/device_descriptor/number_of_
> wluns
> > +Date:  February 2018
> > +Contact:   Stanislav Nijnikov <stanislav.nijni...@wdc.com>
> > +Description:   This file shows number of well known logical units.
> > +   This is one of the UFS device descriptor parameters.
> > +   The full information about the descriptor could be found
> > +   at UFS specifications 2.1.
> > +   The file is read only.
> > +
> > +What:
>   /sys/b

Re: [PATCH v5 02/11] scsi: ufs: sysfs: device descriptor

[Jaegeuk Kim]

On 02/06, Stanislav Nijnikov wrote:
> This patch introduces a sysfs group entry for the UFS device descriptor
> parameters. The group adds "device_descriptor" folder under the UFS driver
> sysfs entry (/sys/bus/platform/drivers/ufshcd/*). The parameters are shown
> as hexadecimal numbers. The full information about the parameters could be
> found at UFS specifications 2.1.
> 
> Signed-off-by: Stanislav Nijnikov 
> ---
>  Documentation/ABI/testing/sysfs-driver-ufs | 223 
> +
>  drivers/scsi/ufs/ufs-sysfs.c   | 116 +++
>  drivers/scsi/ufs/ufs.h |   8 ++
>  drivers/scsi/ufs/ufshcd.c  |  12 +-
>  drivers/scsi/ufs/ufshcd.h  |   6 +
>  5 files changed, 359 insertions(+), 6 deletions(-)
>  create mode 100644 Documentation/ABI/testing/sysfs-driver-ufs
> 
> diff --git a/Documentation/ABI/testing/sysfs-driver-ufs 
> b/Documentation/ABI/testing/sysfs-driver-ufs
> new file mode 100644
> index 000..8da7b84
> --- /dev/null
> +++ b/Documentation/ABI/testing/sysfs-driver-ufs
> @@ -0,0 +1,223 @@
> +What:
> /sys/bus/platform/drivers/ufshcd/*/device_descriptor/device_type
> +Date:February 2018
> +Contact: Stanislav Nijnikov 
> +Description: This file shows the device type. This is one of the UFS
> + device descriptor parameters. The full information about
> + the descriptor could be found at UFS specifications 2.1.
> + The file is read only.
> +
> +What:
> /sys/bus/platform/drivers/ufshcd/*/device_descriptor/device_class
> +Date:February 2018
> +Contact: Stanislav Nijnikov 
> +Description: This file shows the device class. This is one of the UFS
> + device descriptor parameters. The full information about
> + the descriptor could be found at UFS specifications 2.1.
> + The file is read only.
> +
> +What:
> /sys/bus/platform/drivers/ufshcd/*/device_descriptor/device_sub_class
> +Date:February 2018
> +Contact: Stanislav Nijnikov 
> +Description: This file shows the UFS storage subclass. This is one of
> + the UFS device descriptor parameters. The full information
> + about the descriptor could be found at UFS specifications 2.1.
> + The file is read only.
> +
> +What:
> /sys/bus/platform/drivers/ufshcd/*/device_descriptor/protocol
> +Date:February 2018
> +Contact: Stanislav Nijnikov 
> +Description: This file shows the protocol supported by an UFS device.
> + This is one of the UFS device descriptor parameters.
> + The full information about the descriptor could be found
> + at UFS specifications 2.1.
> + The file is read only.
> +
> +What:
> /sys/bus/platform/drivers/ufshcd/*/device_descriptor/number_of_luns
> +Date:February 2018
> +Contact: Stanislav Nijnikov 
> +Description: This file shows number of logical units. This is one of
> + the UFS device descriptor parameters. The full information
> + about the descriptor could be found at UFS specifications 2.1.
> + The file is read only.
> +
> +What:
> /sys/bus/platform/drivers/ufshcd/*/device_descriptor/number_of_wluns
> +Date:February 2018
> +Contact: Stanislav Nijnikov 
> +Description: This file shows number of well known logical units.
> + This is one of the UFS device descriptor parameters.
> + The full information about the descriptor could be found
> + at UFS specifications 2.1.
> + The file is read only.
> +
> +What:
> /sys/bus/platform/drivers/ufshcd/*/device_descriptor/boot_enable
> +Date:February 2018
> +Contact: Stanislav Nijnikov 
> +Description: This file shows value that indicates whether the device is
> + enabled for boot. This is one of the UFS device descriptor
> + parameters. The full information about the descriptor could
> + be found at UFS specifications 2.1.
> + The file is read only.
> +
> +What:
> /sys/bus/platform/drivers/ufshcd/*/device_descriptor/descriptor_access_enable
> +Date:February 2018
> +Contact: Stanislav Nijnikov 
> +Description: This file shows value that indicates whether the device
> + descriptor could be read after partial initialization phase
> + of the boot sequence. This is one of the UFS device descriptor
> + parameters. The full information about the descriptor could
> +