Re: [Xen-devel] [PATCH V2 2/4] Introduce xen-scsifront module

2014-08-01 Thread Christoph Hellwig
On Wed, Jul 30, 2014 at 06:53:59AM +0200, Juergen Gross wrote: Hmm, I looked into scsi_add_device(). It seems as if the caller can't distinguish between a new created and an already existing device. Am I missing something? That's right. If you need that I still think it's better to add a

Re: [Xen-devel] [PATCH V2 2/4] Introduce xen-scsifront module

2014-08-01 Thread Juergen Gross
On 08/01/2014 02:08 PM, Christoph Hellwig wrote: On Wed, Jul 30, 2014 at 06:53:59AM +0200, Juergen Gross wrote: Hmm, I looked into scsi_add_device(). It seems as if the caller can't distinguish between a new created and an already existing device. Am I missing something? That's right. If you

Re: [Xen-devel] [PATCH V2 2/4] Introduce xen-scsifront module

2014-08-01 Thread Christoph Hellwig
On Fri, Aug 01, 2014 at 03:06:04PM +0200, Juergen Gross wrote: That's right. If you need that I still think it's better to add a variant of scsi_add_device helping you with that. I'm open to that solution. Do you have preferences how to do it (IOW: can you give me a hint)? I thought

Re: [Xen-devel] [PATCH V2 2/4] Introduce xen-scsifront module

2014-07-29 Thread Juergen Gross
On 07/29/2014 03:53 PM, Christoph Hellwig wrote: + * Patched to support 2TB drives + * 2010, Samuel Kvasnica, IMS Nanofabrication AG + */ This doesn't really belong into the top of the file comment and should be moved to the patch description. Okay. + +#include linux/version.h not

Re: [Xen-devel] [PATCH V2 2/4] Introduce xen-scsifront module

2014-07-29 Thread Juergen Gross
On 07/29/2014 04:57 PM, Juergen Gross wrote: On 07/29/2014 03:53 PM, Christoph Hellwig wrote: +switch (op) { +case VSCSIFRONT_OP_ADD_LUN: +if (device_state == XenbusStateInitialised) { +sdev = scsi_device_lookup(info-host, chn, tgt, +